- 02 Jun, 2020 40 commits
-
-
Thiemo Nagel authored
This reverts commit 6cb8f1ee. Reason for revert: Could this be causing BookmarkBarViewTest22.CloseSourceBrowserDuringDrag failures? [0602/000817.871182:ERROR:test_launcher.cc(1041)] no test result for BookmarkBarViewTest22.CloseSourceBrowserDuringDrag [ RUN ] BookmarkBarViewTest22.CloseSourceBrowserDuringDrag X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 25 (X_SendEvent) Resource id in failed request: 0x600010 Serial number of failed request: 560 Current serial number in output stream: 563 [144/291] BookmarkBarViewTest22.CloseSourceBrowserDuringDrag (159 ms) https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests https://chromium-swarm.appspot.com/task?id=4c8cabe25bd9e510#BookmarkBarViewTest22.CloseSourceBrowserDuringDrag,WebViewFocusInteractiveTest.Focus_FocusEvent Original change's description: > [ozone/x11] Moved the DnD handling from X11WindowOzone to X11Window. > > This CL is the first step that prepares us to get rid of DWTHX11. > > As we proceed with that, at some point we will have to throw off the > DesktopDragDropClientAuraX11 because it is used by DWTHX11, and migrate > DnD to DDDCOzone. As the latter will be used on both Ozone and > non-Ozone, it needs the X11window to handle DnD. > > Hence this change. I move the DnD-related code from X11WindowOzone into > X11Window. > > Change-Id: I682c794d9cfab4b7ad6b6a9b89331526f31d227a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213578 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#774026} TBR=thomasanderson@chromium.org,msisov@igalia.com,adunaev@igalia.com Change-Id: I2d5147265dab2e820bcb5467530df280f0bf1823 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223945Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774063}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/db5db9a0afbe..255926129b10 2020-06-02 patrick.brosset@microsoft.com Introducing a general UI interaction test for the Network panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5e718f75fd63505303e228d73deaaab6105df497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226464Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774062}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a5d0662b82d0..e246638c18ca 2020-06-02 fancl@chromium.org Use bug_id and project in AlertGroup instead of alert If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1090225 Tbr: wenbinzhang@google.com Change-Id: Ib75382ecf028bae22c1aaadb4b4d1dce72180605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226466Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id19328132035b613bf80c61df784182b6e76162e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226463Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3288b2d9. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia201abbe95ab31794f22e11576f9d0c5b43f466a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774059}
-
Johann authored
run_blink_wptserve.py has no way of knowing which gen/ directory to serve files from. Document this fact. R=qyearsley@chromium.org Change-Id: Ia5caef49b7333e695665ca921790c4dedb30ac22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217275 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#774058}
-
Thiemo Nagel authored
This reverts commit 40342cdf. Reason for revert: It seems the CL has introduced high levels of flakiness in BackForwardCacheBrowserTest.DoesNotCachePaymentManager See e.g.: https://chromium-swarm.appspot.com/task?id=4c8c1a19978bfe10 Mac10.10 Tests has failed six times: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests?limit=200 Original change's description: > [bfcache] Blocklist documents/frames using PaymentManager > > As a note - this patch jumps from 47 to 49 in WebSchedulerTrackedFeature so as to prevent merge conflicts with the patch here: > https://chromium-review.googlesource.com/c/chromium/src/+/2212934 > > Some background on why we sometimes need to disable bfcache: > https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 > > Change-Id: I884e7b5262938c453cea7e1792b505c3a55447bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225355 > Commit-Queue: Harkiran Bolaria <hbolaria@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773982} TBR=nasko@chromium.org,haraken@chromium.org,altimin@chromium.org,hbolaria@google.com Change-Id: Id7b7cdaaed0815addf65795cb664d33520e6d841 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223943Reviewed-by:
-
Ravjit Singh Uppal authored
Bug: 1073883 Change-Id: I64bd8568ca8e9ab904f2159a3c69b99c13688a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218041 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774056}
-
Alex Rudenko authored
This reverts commit 176ec212. Reason for revert: the overlay seems broken on master, I'd like to revert to see if the merge caused it Original change's description: > [DevTools]: Remove highlight tool and use new resources from DevTools > > This CL removes inspect_tool_highlight.html and replaces it with > resources produced by DevTools[1], where the implementation has been > moved to in a separate CL[2]. > > [1]: https://goo.gle/devtools-overlay-reuse > [2]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192892 > > Bug: 1078267 > Change-Id: I95d3faef98470e13430ed251cf135e59269358d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194865 > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774030} TBR=thakis@chromium.org,gbiv@chromium.org,petermarshall@chromium.org,jochen@chromium.org,blundell@google.com,mathias@chromium.org,alexrudenko@chromium.org Change-Id: I8b5b97d040e15b80441295ebe96e5b408f73bb72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225718Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774055}
-
Yoshifumi Inoue authored
This patch changes "directionality-after-undo-replace.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ib3b187db88c54a79ba44023f1e2b1c655534232f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226323 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfe5e4df6de2..e714d17672f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: I43b6d055a1c31654590022b8b7070186c2c4eb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226396Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774053}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b9f640ad..588bee56 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I66fd2e37b17c74308468c7275c2545d182996801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226436Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774052}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: I12c279457aa360cbb0cd9ea53a4ae54db4d4d051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226003 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#774051}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591012454-0e17033bf0adb2d9001d6af97cdfcbf8391457fc.profdata to chrome-win32-master-1591070241-638ab9c3267df589aa252b26b8cbbae9d2449ff5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5e160f21adfbcc27ecf6ed64c0c2d5ca1f6c7d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226055Reviewed-by:
-
Mansi Awasthi authored
This change adds struct PP_PrivateAccessibilityChoiceFieldInfo to PP_PrivateAccessibilityFormFieldInfo to transfer accessibility related PDF choice field data from the plugin process to the mimehandler process. Made the same changes to the C++ versions of these structs and added the appropriate conversion code. Bug: 1030242 Change-Id: I7aa6fd612de051d9e6b22e84e60c964d24685242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214734 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774049} -
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f15982ebebb2..0cc27fb68c0e 2020-06-02 cepheus@frii.com Update news for header location change and recommendation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ibe52a3b681d19754e812d8510e63ac18b120132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226401Reviewed-by:
-
Daniel Cheng authored
Processes that directly allocate shared memory need to know about this flag; otherwise, they will use the wrong allocation strategy and potentially encounter OOM failures. Most processes are sandboxed by default on Linux, so shared memory creation is brokered through the browser process, which already knows about this flag; however, any processes which aren't sandboxed will have this problem. The unsupported --no-sandbox flag compounds this issue, since all renderer processes begin allocating shared memory directly as well. If /dev/shm is limited in size (often the case in containerized environments), then the renderer will start encountering OOM crashes when shared memory creation fails due to the size constraints. Fixed: 1085829 Change-Id: I5f321ba5f91360b72524614e1e91e0e5d805d4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220891Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774047}
-
Giovanni Ortuño Urquidi authored
See associated bugs for more information. TBR=bsazonov@chromium.org Bug: 1090216,1014213 Change-Id: Ibf0fc1689bc7b3226af7c9159a5694e343f54666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224955Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#774046}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab74e294602d..db5db9a0afbe 2020-06-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4f1ef0878b1878e4e99a585f89c51b6cc377655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226400Reviewed-by:
-
sauski authored
CL adds the SQLite database backend implementation to support recording first-party contexts in which client-side storage APIs are accessed. The database is not currently instanstiated or accessible from production code. Bug: 1083384 Change-Id: I0fa83b09c11c988364957ef58d25b51eae0a16ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218072Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#774044}
-
phweiss authored
Windows are considered one "logical window" if they are created with the same |shelf_group_id| and |logical_window_id|. The consequence: only one window per logical window is shown in the shelf, the alt-tab menu, and the desk mini view. The use case are windows across multiple screen, which are not possible in Chrome OS. So the app creates one window per screen and marks them as one logical window. This is done by the |ArcAppWindowInfo|, which stores the IDs mentioned above. It is setting the |HideInDeskMiniView| property, the |HideInOverview| property and the new |HideInShelf| property on a window. The AppWindowLauncherItemController pays attention to the HideInShelf property and will not use hidden windows as |last_active_window|s, nor return them via |GetAppMenuItems|. When a window closes, it might have been the visible window of a logical window, so the |AppServiceAppWindowArcTracker| checks this and tells a different app of the same logical window to become visible. browser_tests --gtest_filter=ArcAppLauncherBrowserTest.LogicalWindow Test: Bug: b/148875131 Change-Id: Ide57ac8dbc77137d4678763bdc88806f3937c0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207316Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Philipp Weiß <phweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#774043}
-
Maksim Sisov authored
Previously, we assumed that if we are waiting for f0, f1 and f2 feedbacks and we get f2, the f0 and f1 are failed (because of destroyed buffer or anything like that). However, there is one case we missed - f2 can be discarded by the Wayland server, but f0 and f1 still can be valid and come later. Thus, pass discarded bool variable to OnPresentation if the feedback was discarded. Bug: 1087839 Change-Id: I1f60c282d4871b7aedbae901f8a79b76727e2a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218779 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#774042}
-
Ken Rockot authored
This prevents the bindings generator from re-assigning a message's ID to a scrambled value whenever the message definition in mojom has an explicit ordinal declared (i.e. @N notation). As an added measure of stability, this also adds the requirement that interfaces marked [Stable] MUST assign explicit ordinals to all methods. Fixed: 1089230 Change-Id: Iaa6eff350f7ecee31feb54b19349c9caa4b2a2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225327 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774041}
-
Luciano Pacheco authored
Change the padding in the dialog, font-size and color for the title, change the spacing above and below the input/password. The new spacing required additional 10px (up to 170px) for the dialog window height. This changes the style without guarding with a feature flag because this basically changes the spacing and color slightly, this dialog was mostly adhering to the new style and Zip Archiver doesn't have other UIs that would require consistent look. Bug: 992827 Change-Id: If9b5ba465ef95e3d1567cc0c87a2b3a780771676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226320Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#774040}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e5288a5ef2a..3a5de9aae13c 2020-06-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I5252184623941f6afe55a8b21443e2ae7b173361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226399Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I99856b3f70ed21a8bd1b618dd877d41b6b83f3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220419Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#774038}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ica7227a1db1abe186c26cc0ce97ade56e92ec274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226397Reviewed-by:
-
Gang Wu authored
This is a reland of 91eda9e8 Original change's description: > Fix image search from search activity > > SearchActivity did not handle image search data since image search need > post data, so the fix is add the post data into intent to pass to chrome. > > Bug: 1078773 > Change-Id: I04efdad0bba315508e0b05d3d9e444d8c1a5d955 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187191 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772335} Bug: 1078773 Change-Id: I86f1fbab1cc27a66ceb5ad8ac987179b8f5e8e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220150Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774036}
-
Chris Hall authored
- Migrating IsDefault method - Migrating HasPopup method - Inverting control flow for NativeRoleIgnoringAria Written collaboratively with Aboxhall and Meredithl. Change-Id: Ic516fecf0f9e9d010e033ec46c8bd09df7869983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186874Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774035}
-
Fergal Daly authored
Adds a frame_tree() accessor to RenderFrameHostImpl. Adds an accessor for NavigationControllerImpl to FrameTree. Using both of these, remove a lot of chained accesses in code. Change-Id: Ic195217e249eb41744a0d7fd8f77340ab708ce07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212185 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774034}
-
Giovanni Ortuño Urquidi authored
This reverts commit e00873cb. Reason for revert: Causing a lot of SafeBrowsingBlockingPageDelayedWarningBrowserTest tests to fail: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/63042 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878647092646084928/+/steps/browser_tests/0/logs/Deterministic_failure:_SafeBrowsingBlockingPageWithDelayedWarningsBrowserTest__x2f_SafeBrowsingBlockingPageDelayedWarningBrowserTest.KeyPress_ESCAndCharacterKey_WarningShown__x2f_1__status_CRASH_/0 Original change's description: > [SB Delayed Warnings] Allow non-character keys such as Escape > > Users may sometimes press non character keys such as ESC when on a > webpage (e.g. to close popups or other prompts). This CL ignores > these cases and does not undelay the warning. > > Bug: 1057157 > Change-Id: I4cfc2c621e4c0a84f46fdaa8f800e6843ed6b4b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361 > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773833} TBR=meacer@chromium.org,vakh@chromium.org Change-Id: I660f1e2b2b05472df75fbe34600672d53594e95e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225682Reviewed-by:
-
David Bokan authored
This ensures scroll-related unit tests in this file run with both unification enabled and disabled. Bug: 1086625 Change-Id: Ic64d466ff8b93bb208aa676be4c1188d58964186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222141 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774032}
-
Nick Diego Yamane authored
This is a reland of 5930a9fd Original change's description: > ozone/wayland: Fix data objects initialization and ownership > > DataDevice-related wrappers initialization and ownership, for both > standard and GTK's primary selection, are quite confusing and spread > over different parts of the backend code. This CL fixes and simplifies > it by: > > - Moving {WaylandData,GtkPrimarySelection}Device ownership to their > respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns > WaylandDataDevice singleton; > > - Fix WaylandClipboard initialization whether the compositor happens to > advertise GtkPrimarySelectionDeviceManager after wl_seat and > wl_data_device_manager; > > - Use dependency injection to provide DataSources with the correct > DataDevice instance at their construction time; > > - Clean up WaylandConnection by getting rid of the multiple (and almost > unused) data device getters from it as well as removing unneeded header > includes. > > Bug: 896640 > Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#773235} Bug: 896640 Change-Id: I52ec359c5339847674ab0ab8f89a96c15ededf59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225502 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#774031}
-
Alex Rudenko authored
This CL removes inspect_tool_highlight.html and replaces it with resources produced by DevTools[1], where the implementation has been moved to in a separate CL[2]. [1]: https://goo.gle/devtools-overlay-reuse [2]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192892 Bug: 1078267 Change-Id: I95d3faef98470e13430ed251cf135e59269358d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194865 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d39b8afc47a1..f15982ebebb2 2020-06-02 dj2@everburning.com Remove install to the SPIRV/ folder. (#2256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I534dee9c82879fae34149a6c6c06fa48c15aaa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226054Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "click-before-and-after-table.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I675249309b62567be60c15854624c3eede648b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226105 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774028}
-
Johann authored
Change-Id: Ic5d84ea643161a33ed724c2576d75f4171413386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225680 Commit-Queue: Johann Koenig <johannkoenig@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774027}
-
Alexander Dunaev authored
This CL is the first step that prepares us to get rid of DWTHX11. As we proceed with that, at some point we will have to throw off the DesktopDragDropClientAuraX11 because it is used by DWTHX11, and migrate DnD to DDDCOzone. As the latter will be used on both Ozone and non-Ozone, it needs the X11window to handle DnD. Hence this change. I move the DnD-related code from X11WindowOzone into X11Window. Change-Id: I682c794d9cfab4b7ad6b6a9b89331526f31d227a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213578Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#774026}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591055861-2c929ca1d8463b09aee877402f62f07b9528b0a1.profdata to chrome-mac-master-1591070241-ce04e1e2e870e385b3dffbd254a1f6cdfc41d3e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4d9fa6154b0310e7b10b8d7bf62d820413301dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226052Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8eeff5ccf3a3..6e5288a5ef2a 2020-06-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c70c5e32 to 0fa61969 (402 revisions) 2020-06-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 471c120ac92a to 11dd7183c4d2 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: Ia4325268b10d2babced73888075ec74165806b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226050Reviewed-by:
-
