- 27 Apr, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4799d13aa0fb..ce903c4c1357 Created with: gclient setdep -r src-internal@ce903c4c1357 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I4fec89dae2f200c3f75c4c309f971edc5ecae4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586719Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654718}
-
Fergus Dall authored
Currently, spinners appear in the shelf on all profiles and will only go away if the app window opens when you are on the profile that owns that window (currently, this is always the primary profile). This CL changes this behaviour so that spinners are associated with a profile and hidden when other profiles are active, and are closed at the right time. Bug: 846213 Change-Id: Iaf9447eed491d956831b8f5b30a95cd7d6f5b288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504667Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#654717}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8bceb48c2222..ae6ebf06c7e8 git log 8bceb48c2222..ae6ebf06c7e8 --date=short --no-merges --format='%ad %ae %s' 2019-04-27 thestig@chromium.org Fix CFXJSE_FormCalcContext::Substr() behavior. 2019-04-27 thestig@chromium.org Beef up CFXJSE_FormCalcContextEmbedderTest.Substr Created with: gclient setdep -r src/third_party/pdfium@ae6ebf06c7e8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956985 TBR=dsinclair@chromium.org Change-Id: I7a2403f3fbf4afa1f917717f19c4f195b244f025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654716}
-
Ryan Hamilton authored
Change-Id: Ic8db4fbaaf01bc24351753c87562e015cc59f825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586320 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#654715}
-
Mounir Lamouri authored
Bug: 951548 Change-Id: Ice27c1c114f9bb3e93f5516fb964a78f8d43a637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585293 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#654714}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6130f7f5dc8..4799d13aa0fb Created with: gclient setdep -r src-internal@4799d13aa0fb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: Ie3f8dfee0f72dea41b87e3671ea225ba7ed07873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585334Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: Iba8178164ddfb99e4d2ee6236e6d4cb6418890d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585537 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#654712}
-
Jazz Xu authored
Touchless context menu implementation. Implemented fullscreen, mute, download, and captions. Tests will be in follow CL. Bug: 942156 Change-Id: Ifeae091aa0c35cfe989483d230df3bf28bbe23ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585957Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#654711}
-
Darwin Huang authored
Remove unused arguments, to make blink and mojo more "thin" and readable. https://cs.chromium.org/chromium/src/third_party/blink/public/mojom/clipboard/clipboard.mojom?l=62 Bug: 956291 Change-Id: I62a14b7fd3cb35f566a31d3fd5ac43995724534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582305Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654710}
-
Sujie Zhu authored
Use the supported_card_bin_range from GDFSC to filter the migratable credit cards for checkout flow. Will abandon the migartion if no supported card left. Will only show the supported card in the main dialog. Bug: 954367 Change-Id: Ic35ca24e5d3d5c018a2f114d59ea587f255d9971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582448 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#654709}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ibf4b69cefd21c91b941d7810f9a92621df332781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586662Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#654708}
-
Rakib M. Hasan authored
This CL adds validations for test expectations files. One validation makes sure that all test expectations patterns in the file are for existing tests. Another validation makes sure that there are no collisions between expectations in the file. This CL also creates a namespace for the pixel test generator methods Bug: chromium:948891 Bug: chromium:698902 Change-Id: I80c3120113b09d11f4a79db449f73149605b38f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586475Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#654707}
-
Elly Fong-Jones authored
We're planning to remove this flag for reasons thestig will end up documenting :). Bug: None Change-Id: If1cc4dae41ab2ae13778c87aecf4fd8932c66a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586254 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#654706}
-
Yann Dago authored
Unmanaged browser: http://screen/iSGQc3jemSh Managed browser(no extension, no reporting): http://screen/mBhBmNFFZdm Local reporting: http://screen/J3TuQiOLKRt Cloud reporting: http://screen/BPDRCMM7vJP No Reporting: http://screen/UBDpXm8wgKs Unknown/incognito domain: http://screen/4gLqBq7xrpi Dark mode: http://screen/n64k5C6cWfn Bug: 956561 Change-Id: I7cb4501edce48950e43534616de4caaf716ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584884Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#654705}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3610ded5e409..a32d6303a613 git log 3610ded5e409..a32d6303a613 --date=short --no-merges --format='%ad %ae %s' 2019-04-27 chrisforbes@google.com Support more more formats for input attachments Created with: gclient setdep -r src/third_party/swiftshader@a32d6303a613 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I96cfe0b32b0d1100daa4abaf9aa952983d8c3777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585332Reviewed-by:
-
Dan Beam authored
$i18n{} is used across many other web UI pages in Chrom{e,ium} and is recommended by styleguide/web/web.md. In this case, its also more efficient as it only need make 1 pass in total over the contents of local_ntp.html (current code makes 8). R=kristipark@chromium.org BUG=none Change-Id: Ie839d12322ab4baca8445eeba1a8a47c76d22e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586695 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#654703}
-
Ben Chan authored
The shill.Device.SetCarrier API only works on the modems supported by cromo and it is being deprecated along with cromo. This CL removes all usage of the shill.Device.SetCarrier API from Chrome. Bug: 954634 Change-Id: I9114650783f9c3f848c4012db718ca4caa8f1803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586460Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654702}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/43a1c0f10f28..d31f86fa34ef $ git log 43a1c0f10..d31f86fa3 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 dschinazi Add presubmit to force use of QUIC_LOG 2019-04-26 vasilvv Make SimpleRandom faster by using Chacha20 as underlying primitive. 2019-04-26 dschinazi Fixup use of gunit and gmock in QUIC 2019-04-26 fayang gfe-relnote: In QUIC, adjust cwnd when doing bandwidth resumption in BBR. Protected by gfe2_reloadable_flag_quic_fix_bbr_cwnd_in_bandwidth_resumption. 2019-04-26 danzh gfe-relnote: n/a(code not in use) a few changes to improve SimpleLinkedHashMap's portability. 2019-04-25 dschinazi Make QUIC EXPECT and ASSERT test macros reject comparison of unsigned integers Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I2232f1fc7b19184f3af31e04f592c62c27952935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586549 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
David Bokan authored
NonFastScrollableRegions are set on the FrameView's scrolling contents layer in order to let the compositor know about scrollers that aren't composited or need forwarding events to the main thread for some reason. This logic breaks when a non-composited subscroller is placed inside the root scroller. The root scroller is always composited and it becomes the layout/outer viewport in the compositor. This means we never actually check the frame view's scrolling layer for NFSRs since we stop walking up the scroll tree once we've scrolled the viewport. This CL fixes the issue by setting the regions on the root scroller's scrolling contents layer, rather than the FrameView's. GetScrollableArea on the root FrameView will return a RootFrameViewport which returns the layout viewport's scrolling layer. Bug: 954496 Change-Id: Ic6ee4273fe7d34a97c60c48f00d0ba4892295953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580219Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654700}
-
Chris Harrelson authored
DidBeginMainFrame can cause mutations to layer state, and the commit needs to be complete before doing so. Bug: 939342 Change-Id: I078a78879394f999cebe05a2804ac05617a31cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584498 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#654699}
-
John Rummell authored
Also adds a test to verify the behavior. BUG=957138 TEST=new base_unittest passes Change-Id: Ida1d0801f457e96dbf1d2ed299966a50aec05442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586220 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
rbpotter authored
Remove new/ folder, since the old UI code has been deleted, and move all contents to a new ui/ folder or the data/ folder, as appropriate. Bug: 888272 Change-Id: I57e7df9e96a12fce112d18a70c58889587fb6e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586265Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#654697}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6841244fb6c0..c6130f7f5dc8 Created with: gclient setdep -r src-internal@c6130f7f5dc8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I79ac08fe959d178a639b2e0b4a18027b9a64f357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586192Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f691fbb59c7..1ad7a07212b2 git log 6f691fbb59c7..1ad7a07212b2 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 jonahr@google.com Clean up unexpected passed/failed test behavior for generate_stats Created with: gclient setdep -r src/third_party/angle@1ad7a07212b2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I15ebacc6a43a0833d64e8235a8a1254be5256cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586245Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3349fb0195ff..e178c0586cd6 git log 3349fb0195ff..e178c0586cd6 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e178c0586cd6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I0f3b0522a4474dca262f6b4b91a52546271b0b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585331Reviewed-by:
-
John Budorick authored
Bug: 861983 Change-Id: I4265612b47bff2799a63cda4cc5c28952446a7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586469 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#654693}
-
Mounir Lamouri authored
Bug: 952090 Change-Id: I0abea411b1dfb60b5d4c6a37b9cd571d70fffa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585347Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#654692}
-
PKH authored
This CL splits the webapk_java GN template into two targets: 1) webapk_java - Contains most of the source files of the old webapk_java template - Does not depend on compiled_in_runtime_library_java - shell_apk_javatests depends on webapk_java 2) webapk_with_service_java - depends on webapk_java and compiled_in_runtime_library_java BUG=817263 Change-Id: If234e939fc3ba5119dd9290256fab3a34c80b2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585114 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654691}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f5c8936c463e..3610ded5e409 git log f5c8936c463e..3610ded5e409 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 chrisforbes@google.com Adjust input attachment index when indexing into array of input descriptors Created with: gclient setdep -r src/third_party/swiftshader@3610ded5e409 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I31ed519038dadcb83b4b9fa650d9a35e970489c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586190Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5fb2ca3384f7..8bceb48c2222 git log 5fb2ca3384f7..8bceb48c2222 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 thestig@chromium.org Fix some nits in CFXJSE_FormCalcContext. Created with: gclient setdep -r src/third_party/pdfium@8bceb48c2222 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic327f49bfda5eb9f492a0cbce6216907e92f8da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586189Reviewed-by:
-
Nigel Tao authored
This commit is part 1 of 2, being a refactor with no change in behavior. There is an existing observer leak (an AddObserver call with no matching RemoveObserver call), but this commit keeps that leak. A follow-up commit will fix the leak. TBR=seantopping@chromium.org Change-Id: I73e9087540949c29bb76d6526362b5448452e182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585403 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#654688}
-
Nate Chapin authored
This centralizes as much of the same-document navigation logic as possible on DocumentLoader. This CL almost moves a helper, FrameLoader::LoadInSameDocument, and renames it to DocumentLoader::CommitSameDocumentNavigationInternal Change-Id: I4492160a4ac8b86cd41a3dd55dabf0aeed3c8d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580323 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654687}
-
Mason Freed authored
From profiling and Pinpoint tests, a decent percentage of PushPaintArtifactToCompositor() CPU time (possibly up to ~30%) is spent reallocating Vector<> objects. Specifically in two places: the chunks_ vector in PaintChunker, and the pending_layers vector in PaintArtifactCompositor. Previous to this CL, on each frame, both vectors were constructed from scratch, grown up to their final size (with many reallocations along the way), used, and then destroyed. This CL tries to reduce a bit of that overhead by keeping the vectors around, at their prior-frame capacity. This CL re-uses the pending_layers vector. The PaintChunker CL is at [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1586578 Bug: 954961 Change-Id: I496259f06835989d2e25b7ce1eb73ef2ab9cc788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585330 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e095532eff2..6837707f8009 git log 0e095532eff2..6837707f8009 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 dschuff@chromium.org Fix emscripten_releases directory name to match git repo name Created with: gclient setdep -r src/third_party/depot_tools@6837707f8009 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I62760e16a5abe1673e0b93580a7fc6fd451d0271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586188Reviewed-by:
-
Alexei Svitkine authored
Android.ResourceBundle.LoadLocaleFailure: Shows no data, removing in this CL. Since there was never any data logged for it, I'm removing it entirely from histograms.xml. UMA.LogUpload.Canceled.CellularConstraint: Still interesting, bumping expiry date, will also add monitoring. Variations.SeedProcessingTime: Still interesting, bumping expiry date, will also add monitoring. UMA.UnsentLogs.Dropped: Still interesting and there's active plans to do work on background uploads on Android, which may move this, so bumping expiry date. Bug: 948327, 948331, 948329, 945552, 914342 Change-Id: Iee2452969b5d3052b043235edf106d5dd0791589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586415Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I26559ac3c7769845120341ab83181ea0dc4fc211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586471 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#654683}
-
Pavel Yatsuk authored
Touchless context menus should include icons for individual items. To support this I added a method to TouchlessContextMenuManager to map from item id to resource id of corresponding item. I've also added following VectorDrawable resources: - ic_remove_circle_outline_24dp - ic_help_outline_24dp Here are screenshots: - screen/pyyNGb0jLpX - screen/GDwXF9z7mvr BUG=937445 R=dewittj@chromium.org Change-Id: Ic46f4335f8a219bc6d2cc389b62457a9042415d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586261 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#654682}
-
Chris Lu authored
Calls FindInPageManager::StopFinding() if the Find in Page feature flag is turned on. Bug: 919685 Change-Id: I310c15d46049c24642bf6d0d25e4fb4a36711409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579025 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#654681}
-
Joe DeBlasio authored
This is a reland of ff13eb07 with a minor tweak to prevent a flaky test. Original change's description: > Update CCT to hide origin if requested by security interstitial. > > This CL modifies the behavior of CCTs such that they hide the > origin of a page and page info button if there is an active security > interstitial that requests it. This brings the behavior in line with > that of desktop and mobile. > > Bug: 939601 > Change-Id: I6c46cb4918871b9d2a760a72bee742fc7867e1b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570415 > Reviewed-by: Jay Harris <harrisjay@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653038} Bug: 939601 Change-Id: I9fd61d7689bcec23723ee2d7ecd6520ae2c201da TBR: harrisjay@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579915 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#654680}
-
Elly Fong-Jones authored
ccameron is going to be tackling this :) Bug: 716231 Change-Id: I56f04c4c8be9744eb0f8b4defc6dcd11cd3ec1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586274 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#654679}
-
