- 13 Jul, 2018 19 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/66447ba64fcc..8495de1eb482 git log 66447ba64fcc..8495de1eb482 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 dtu@chromium.org [pinpoint] Fix: Use new results path for performance_webview_test_suite. 2018-07-12 dtu@chromium.org [pinpoint] Use old isolate target for jobs before OBBS migration. 2018-07-12 benjhayden@chromium.org Add /api/timeseries2 Created with: gclient setdep -r src/third_party/catapult@8495de1eb482 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862654 TBR=sullivan@chromium.org Change-Id: Ifb6b94cad8056d5d2b668fe3acde70ea8d00fbeb Reviewed-on: https://chromium-review.googlesource.com/1135218Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574796}
-
Ian Kilpatrick authored
This removes the layout-tree fixup which kept leading abs-pos & floats in an inline context in a block context. This makes an additional 8 tests pass which needed this fix. The failures in the patch broadly fall into these buckets. 1) Paint invalidation changes. Now that the floats are within the line boxes, and the paint invaldation is different. This was likely hiding other issues, and we'll need to investigate these. 2) Three crashes which I believe might be fixed by Christian's pending min/max fix. 3) One selection and one editing failure. 4) Static position of abs-pos and text alignment failures. (this was hiding a larger bug). 5) A few other random failures. The rebaselines are from new layout-tree dumps, and/or "simple" (i.e. just name changes) within the paint invalidation dumps. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib5cc99219d31cb11ef18c8f10f7f4e9e0fea8db6 Bug: 734554 Reviewed-on: https://chromium-review.googlesource.com/1132541 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#574795}
-
Zhiheng Vincent Li authored
There is a flashing page when transiting from one cast app to another cast app or when stopping a cast app. It is caused by redrawing the webcontent view when destroying the WebContents. Bug: internal b/79172781 b/79694573 Test: manually tested on Jasper Change-Id: Ib445301a1f0d2a79cdf5a7dd2652a0666c570f06 Reviewed-on: https://chromium-review.googlesource.com/1132622Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#574794}
-
Christian Biesinger authored
When we are sized to shrink-to-fit, we can use the cached preferred logical width when we have one; this patch implements that. It also changes ComputeInlineSizeForFragment to take a Node, which simplifies several callers. While writing this CL, I discovered a missing check for IsParallelWritingMode in ComputeMinAndMaxContentContribution; that change is conceptually unrelated to this CL but without it 20 tests fail. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id793856d86b12bd46fd7e1bab42541520c7ea031 Reviewed-on: https://chromium-review.googlesource.com/1128195 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#574793}
-
Moe Ahmadi authored
__gCrWeb.fill.setInputElementValue gives the input element focus prior to setting its value and restores the focus to the previously focused element afterwards. When a suggestion is selected, the previously focused element can be <body> which leads to focus events on the body with no useful form activity information to be sent to the WebStateObservers. This CL adds a |hasUserGesture| parameter to the FormActivityParams so that the observers can detect and avoid acting on such events. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I67f993dd2e7737f3a37f479df4ade1932e94666d Reviewed-on: https://chromium-review.googlesource.com/1126480 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574792}
-
xlou authored
Missed some in CL: crrev.com/c/1128325. Since the UI displays Pages Per Sheet for the N-up setting, and there was a review comment previously to rename it to pages_per_sheet, so I am renaming the variable name here. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: Ie605699d64a3ad1fcf2f943378e08065048183e5 Reviewed-on: https://chromium-review.googlesource.com/1135895Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shirleen Lou <xlou@chromium.org> Cr-Commit-Position: refs/heads/master@{#574791}
-
Kim Paulhamus authored
Tbr: tkent@chromium.org Bug: 863067 Change-Id: I913685da055480d9cddea105808a16fd7e70facd Reviewed-on: https://chromium-review.googlesource.com/1135982Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574790}
-
Xu Xing authored
BUG=857217 Change-Id: I328529cc444ddcadad83eeb4b9aa5ff445844912 Reviewed-on: https://chromium-review.googlesource.com/1125518Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#574789}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed5e651e. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21191 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: I8cbb857220afec37734ab39cca07d888d7d3c941 Reviewed-on: https://chromium-review.googlesource.com/1135754 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574788}
-
Marc-Antoine Ruel authored
This is a reland of 3bcc71d8 Now code search should be fine. Original change's description: > Add luci-go tool to be fetched via CIPD > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > need to be updated. > > Change analyze to not ignore changes to isolate. > > R=tandrii@chromium.org > > Bug: 851596 > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > Reviewed-on: https://chromium-review.googlesource.com/1097623 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569688} Bug: 851596 Change-Id: Icd227efde182ff844e93dbb692124c1297ab0d7c Reviewed-on: https://chromium-review.googlesource.com/1135791Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574787}
-
siyua authored
This is the 2nd CL wiring things up with changes in AutofillClient and BrowserCommands. There will be one following CL on unit-test and metrics. Previous CL: 1128569. For project details, please refer to design doc go/ib-paradise. This project is to offer users an option to upload chrome local credit cards to Google Pay server. This bubble UI is the entry point of the entire flow. It should be anchored to a credit card icon in the location bar and be shown from it. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a53f54fda97157cd0d0e7a8fe500728b4733515 Reviewed-on: https://chromium-review.googlesource.com/1134193 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574786}
-
Pavel Feldman authored
This includes transition from \n to \0 message separation. Change-Id: I9bcd5690dc848a6d4206d051443be2082d747824 Reviewed-on: https://chromium-review.googlesource.com/1135939Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#574785}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94919f78e1bc..d8df8c35a463 git log 94919f78e1bc..d8df8c35a463 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 hnakashima@chromium.org Fix mark not saved if there are no other changes in the same object. Created with: gclient setdep -r src/third_party/pdfium@d8df8c35a463 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I484bd07bb84691a0abb347821832fae20de8c029 Reviewed-on: https://chromium-review.googlesource.com/1135222Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574784}
-
Artur Khachatryan authored
Disabling failing tests on Waterfall for Android build bot for Chrome Beta and Stable. Bug: chromedriver:2503 Change-Id: I75e625d8dd027109c6fd6cd2143d58342c271318 Reviewed-on: https://chromium-review.googlesource.com/1135972Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#574783}
-
Robert Ma authored
The fallback path for the Retina port in blinkpy is adjusted to 10.13 accordingly. And tests are rebaselined. To keep the CL simple, mac10.12_retina-blink-rel isn't renamed to 10.13 yet. It needs to be renamed later on both src and build sides. Bug: 863070 Change-Id: Ia1ae7f643e3bffaaa4b8ea133b20b8e8ec06ba5a Reviewed-on: https://chromium-review.googlesource.com/1135707 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#574782}
-
Sandra Sun authored
This patch initializes the rect_ field in SnapContainerData in copy constructor and move constructor. Fixing a snapping issue in the composited pages. We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded test suite so that they are tested with the composited cases. snap-at-user-scroll-end-manual-automation.js calls mouseClickInTarget() of pointerevent_common_input.js. That method invokes programmatic scrolls. The test was written before programmatic scroll snapping was implemented so it worked at that time. However, with programmatic scroll snapping implemented, it will always snap in mouseClickIntarget() and cannot test whether the user scroll snaps. This patch adds a parameter shouldScrollToTarget to mouseClickInTarget to avoid invoking programmatic scrolls in the test. This patch also checks nullptr for layout_box in ScrollManager::SnapAtGestureScrollEnd() to fix a crash. Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e Reviewed-on: https://chromium-review.googlesource.com/1132386 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#574781}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca73efa2232f..27998f763495 git log ca73efa2232f..27998f763495 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 dgarrett@google.com cbuildbot_launch/InitSdk: Remove DepotToolsEnsureBootstrap. Created with: gclient setdep -r src/third_party/chromite@27998f763495 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2656770fe4d004aa28076691390936561aeb9de0 Reviewed-on: https://chromium-review.googlesource.com/1135616Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574780}
-
Thomas Guilbert authored
This CL adds MediaStatus and MediaStatusObserver, which are based off of media_router.mojom.MediaStatus. Deduplicating the MediaStatus interface from the one in the media_router namespace will be covered in crbug.com/820277 Bug: 790766 Change-Id: I7a72bb942cb303483d3abb143318269524990f9a Reviewed-on: https://chromium-review.googlesource.com/1134357 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574779}
-
Yue Li authored
Bug: b/110219351 Test: Manual Test Change-Id: If0499953843c05288eb8d32f3e7927f9901ac8a7 Reviewed-on: https://chromium-review.googlesource.com/1134395Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#574778}
-
- 12 Jul, 2018 21 commits
-
-
Matt Falkenhagen authored
FID is becoming a trusted page load metric. Bug: 862895 Change-Id: Ib434d2f2e203a986c29928909af32427aa0c30c7 Reviewed-on: https://chromium-review.googlesource.com/1134641Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#574777}
-
Kenichi Ishibashi authored
When S13nServiceWorker is enabled requests/responses directly go from page to service worker and we don't go through the XSDB check. As [1] noted, we wouldn't need to check responses because checking responses would be redundant. This CL make rossSiteDocumentBlockingServiceWorkerTest.NoNetwork to be skipped as the test wouldn't be needed when S13nServiceWorker is enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/879348/12/content/browser/loader/cross_site_document_resource_handler.cc#587 Bug: 861644 Change-Id: Id64063995f341733fc8f39c3620c083ab07d0c94 Reviewed-on: https://chromium-review.googlesource.com/1134636 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#574776}
-
Kenneth Russell authored
This reverts commit 840dc0a7. Revert "RC: Use Chrome usage time since hidden to decide if tab can be proactively discarded." This reverts commit 3c279f29. Revert "RC: Move parts of TabManager::PerformStateTransitions() into helper methods." This reverts commit 79fba743. These three CLs stack on top of each other and the first one ( 840dc0a7 , https://chromium-review.googlesource.com/1133593 ) seems to have introduced assertion failures and crashes per http://crbug.com/863243 . Tbr: fdoray@chromium.org Tbr: sky@chromium.org Bug: 775644, 863243 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I7f02f28de26a8c531e6eebe847120f45b133fd7d Reviewed-on: https://chromium-review.googlesource.com/1135969Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#574775}
-
dpapad authored
This was throwing a runtime error when the unified-consent flag was enabled. Bug: 860854 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6e521b813ca160e5434ac066e47f73ecf61b7ba1 Reviewed-on: https://chromium-review.googlesource.com/1134515Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574774}
-
Ryan Hansberry authored
This provides a simple wrapper around MultiDeviceSetup service, allowing it to easily be stubbed out in tests. R=khorimoto@chromium.org Bug: 824568 Change-Id: If3279d6e4e03ff2b60307aeb70d4f6ef91620b63 Reviewed-on: https://chromium-review.googlesource.com/1135654 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574773}
-
Yue Li authored
Bug: b/111262834 Test: Manual Test Change-Id: Ifce7bd2e2a7be2d927301519b8e8375a326dd896 Reviewed-on: https://chromium-review.googlesource.com/1135912 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574772}
-
Christopher Cameron authored
For translucent windows, don't do any CATransaction synchronization until after the first frame has been received. This allows us to avoid blocking the UI thread when entering the first keystrokes in the omnibox. While in the neighborhood, delete the dead code for using alpha to make windows appear atomically. Bug: 712268 Change-Id: I71cab1c1c598adc34542b6990d8f9112eda8be4f Reviewed-on: https://chromium-review.googlesource.com/1135891 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574771}
-
Morten Stenshorne authored
One known problem if we switch engines elsewhere, is that LayoutNG and legacy layout don't cooperate on margin collapsing. This causes one test regression. The force-legacy-on-contenteditable mechanism doesn't always work as it should. A bug has been reported. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I019f9028f6a1a51c923c9649c6add12034aa692f Reviewed-on: https://chromium-review.googlesource.com/1127027Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#574770}
-
Kenichi Ishibashi authored
Remove WebContents parameter as it isn't used. Change-Id: I1e0069612b422498598f190cd4fdf21d05804e83 Reviewed-on: https://chromium-review.googlesource.com/1133603Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574769}
-
Justin Novosad authored
The fix prevents compositor frames from being pushed by OffscreenCanvas whenever the push is unwarranted. Spurious pushes cause flickering due to preserveDrawingBuffer=false behaviour. BUG=863085 Change-Id: I24c8b4d27e6a07b41e8e0ae030d1ec626674b8d0 Reviewed-on: https://chromium-review.googlesource.com/1135520Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574768}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6aa2190f70a8..94919f78e1bc git log 6aa2190f70a8..94919f78e1bc --date=short --no-merges --format='%ad %ae %s' 2018-07-12 thestig@chromium.org Move CJS_Field private methods into an anonymous namespace. 2018-07-12 thestig@chromium.org Remove parameter to CJS_Field::GetFormFields(). 2018-07-12 thestig@chromium.org Add CJS_Field::GetFirstFormField(). 2018-07-12 hnakashima@chromium.org Create API to set and get blob values from a mark dict. 2018-07-12 thestig@chromium.org Add more helper functions to check field types in CJS_Field. 2018-07-12 thestig@chromium.org Add a IsCheckBoxOrRadioButton() helper for CJS_Field. 2018-07-12 thestig@chromium.org Use pdfium::Optional in CJS_Return. 2018-07-12 thestig@chromium.org Rename 'ori' to 'backdrop' in rendering code. Created with: gclient setdep -r src/third_party/pdfium@94919f78e1bc The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia1700215bfc02ab131428fa83463cb3d46be38cb Reviewed-on: https://chromium-review.googlesource.com/1135617Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574767}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I729ae81845f289f2bf562c44cc37726b90417f9d Reviewed-on: https://chromium-review.googlesource.com/1134717Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#574766}
-
Zhongyi Shi authored
Spin up a migrate back to default network to bring the network back to the default network. Change-Id: I48d72420b79297de83e350937cb4eb05e97fdb38 Reviewed-on: https://chromium-review.googlesource.com/1134444 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#574765}
-
Kim Paulhamus authored
Was formerly disabled on Mac. Tbr: tkent@chromium.org Bug: 862716 Change-Id: I56fa0b3c738189c9b5e89e2fbedb4655c8ca789f Reviewed-on: https://chromium-review.googlesource.com/1135762Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574764}
-
Kim Paulhamus authored
- css3/filters/filter-repaint-composited-fallback-crash.html - virtual/gpu-rasterization/images/color-profile-mask-image-svg.html Tbr: tkent@chromium.org Bug: 860706 Change-Id: Iaedb2f2960eb8ed975562db4d0d0e05dfbdc4cfb Reviewed-on: https://chromium-review.googlesource.com/1135815 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574763}
-
Kyle Milka authored
Hide the Google Photos and Chrome backgrounds options when offline. Bug: 856722 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4e915c16f40e6961f929b3a69eb3497238eb9185 Reviewed-on: https://chromium-review.googlesource.com/1121347 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#574762}
-
Nico Weber authored
src/ side Bug: 863167 Change-Id: Id7070aab7e1da278a0329b086564b2b9cf9357d3 Reviewed-on: https://chromium-review.googlesource.com/1135556 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#574761}
-
erikchen authored
The logic has never been correctly hooked up for MacViews. This CL uses ChromeCommandDispatcherDelegate to explicitly invoke FocusManager::ProcessAccelerator. This gives Views toolkit an opportunity to process hotkeys, regardless of focused view. This CL removes the restriction that chrome/browser/ui/cocoa cannot depend on ui/views, since chrome/browser/ui/cocoa can already depend on chrome/browser/ui/views. Bug: 848341 Change-Id: Ibf356768b28da4b2ea0c4834635c6a47f7562cc8 Reviewed-on: https://chromium-review.googlesource.com/1134200Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574760}
-
Emil A Eklund authored
Add support for shaping latin-1 without first up-converting to UTF-16 in HarfBuzzShaper and to the LayoutNG text layout & line breaking pipeline. This allow for moderate improvements in memory usage and performance for latin-1 content, espeically for subsequent layouts as text up-convertion is avoided therefore allowing script segmentation to be avoided as well. Notably the layout/line-layout-repeat-append performance test gets twice as fast with this change. Other layout perf tests improve very slightly. Increases performance of the ShapingLineBreakerPerfTest::ShapeLatinText micro benchmark by about 5x. From 200 runs/s to 1000 runs/s on a T430s. Legacy layout retains the UTF-16 up-conversion logic and isn't affected. Bug: 636993, 693704 Test: perf_tests/layout/line-layout-repeat-append.html Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7fdb9ab228b61b22e9ef39cdfb8de6c360e83e3f Reviewed-on: https://chromium-review.googlesource.com/1132270 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#574759}
-
Nico Weber authored
Bug: none Change-Id: Idd235e2a2786950e0da9d228b9d321f85a14fe9e Reviewed-on: https://chromium-review.googlesource.com/1135295Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574758}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b138f742b74..8a2e331aa718 git log 2b138f742b74..8a2e331aa718 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 ehmaldonado@chromium.org Collect metrics for 'git nav-downstream' Created with: gclient setdep -r src/third_party/depot_tools@8a2e331aa718 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386 TBR=agable@chromium.org Change-Id: I6b05c998dde183f9b072d17a3b194f2e398730df Reviewed-on: https://chromium-review.googlesource.com/1135217Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574757}
-