- 19 Aug, 2020 30 commits
-
-
Joel Hockey authored
Multiple tests were creating and deleting the same file path, which looks like it lead to the flakes when tests run simultaneously. Now using scoped dirs for each test. Bug: 1117356 Change-Id: I4d949f5dfe735ea084f1a09f2b2f282eb7b1b004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362355 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#799424}
-
Gang Wu authored
This CL add icons for overflow menu, the icon will be in front of each menu item. Icons defined in main_menu.xml, and AppMenuPropertiesDelegate will decide show them or not. And then AppMenuAdapter will choose layout depending on AppMenuPropertiesDelegate#shouldMenuItemStartWithIcon. Bug:1114440 Change-Id: I160020cb2210053ce904af185c059af25b168580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335389 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#799423}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/560b983ff5a9..fb33bb85a9f7 2020-08-18 brgoddar@microsoft.com Performance: Fix perf issue with Event Log If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112663 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib219661dae063202feb8df5b884fb5b4a188074e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799422}
-
John Z Wu authored
Allow client to display a "Suggest password..." suggestion to the user. Upon tapping this suggestion, trigger delegate method asking the user to accept the suggested password. Bug: 1022906 Change-Id: I5a7264eb4efaab3c6bfcafe0a35d82f5eead6e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316847 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799421}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9aed03dcb02f..b54c82ed3948 2020-08-18 enga@chromium.org Support depth-only/stencil-only COPY_SRC on OpenGL 2020-08-18 cwallez@chromium.org Metal: Remove usage of MTLTextureUsagePixelFormatView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I23a46acee92ef6202695c3cf6a1dd18f9640b2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363305Reviewed-by:
-
Erik Jensen authored
The asynchronous writing code assumes that pointers to the data stay valid when ownership in transferred via std::move. However, due to the small-string optimization, that is not the case for std::string with less than 23 bytes of data. This CL switches to using std::vector, which is guaranteed by the standard to maintain iterator validity when moved. Bug: 1116785 Change-Id: Ib099eccad2e304ab33ae3d35cb15bd873ca7da18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359189Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799419}
-
Peter Kasting authored
* Avoid restating type * Clarify computations * Follow style guide declaration order * Simplify * FromSecondsD(samples / samples_per_sec) is more unit-correct than FromSeconds(samples) / samples_per_sec * Make definition order match declaration order * Use more appropriate TimeDelta conversion accessors * Don't handle DCHECK failure * Avoid double-negative Bug: none Change-Id: Iedf42e24412bf1b11f3f56cec5f7a818454ab340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359004 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799418}
-
Sky Malice authored
TBR: boliu@chromium.org Bug: 1117289 Change-Id: I0350cdaa7cf498ba0a40a6e6641f2f0a66f9ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359376 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799417}
-
Sky Malice authored
TBR: wychen@chromium.org Bug: 1118181 Change-Id: I0d932c32a3ae8219f6842dd9c8ce07702b3c6dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363565Reviewed-by:
-
Russ Hamilton authored
Change-Id: Idd9f8996b430df63f44273c07e6a4ad993aad38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359558Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#799415}
-
rbpotter authored
Bug: 1000989 Change-Id: I8bf967219ae6fb20446bb2d096be49f4a3765be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360697Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799414}
-
Wan-Teh Chang authored
I completed an audit of the grid image code in libavif. See bug 1114916. Change-Id: Ifb2d4859bff5fc5647095b04e3bdb4db88a31ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354777Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#799413}
-
Kenichi Ishibashi authored
This test depends on in-memory representations of service worker registrations and versions. Move the test from service_worker_storage_unittest.cc to service_worker_registry_unittest.cc so that the storage_unittest.cc can be moved to the Storage Service directory. This CL also modifies ServiceWorkerStorage::StoreRegistrationData so that it can LazyInitialize() when uninitialized. This allows the test to eliminate explicit LazyInitialize() call. Bug: 1055677 Change-Id: I2425d9aa964c37191df355f1c5c67ed250cb1f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361382Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799412}
-
Haiyang Pan authored
This reverts commit c3907c3e. Reason for revert: Observed multiple test failures in chrome_pulic_test_apk on android builders, since the following builds: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/973 * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1894 * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2437 Original change's description: > Migrate remaining chrome/android native_java_unittest to javatests > > native_java_unittests are going away, so these tests need to be migrated > to javatests. > > Bug: 1103344 > Change-Id: I49a99d1cc1e3170d4af01af8e1a75e9b09249fc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353391 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799264} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Ia64e53afde3d7fdeecb1a4500c74bf6e0ad69ffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363925Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#799411}
-
Miguel Casas authored
ToT VaapiWrapper uses |va_buffers_| for internal Vpp uses and also for external VEA/JEA use. This CL starts refactoring these VABufferIDs lifetime, by splitting the Vpp VABufferID out of |va_buffers_| and into a ScopedID |va_buffer_for_vpp_|. Bug: b:162962069 Change-Id: Ic54d0d26f5d17ea49fe896cf7ca5e1c931d07e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352522 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799410}
-
Brandon Wylie authored
This property is captured implicitly by other events. When reparenting, this property isn't captured properly. Adding an explicit event for this to ensure it is. Bug: 1076798 Change-Id: I1e5fa720627128a13e3969abc0a891b37d846936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293160 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#799409}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4a82aaabbdd..573931528077 2020-08-18 jmadill@chromium.org Auto-gen more Overlay code. 2020-08-18 jmadill@chromium.org Clean up Overlay code duplication. 2020-08-18 jmadill@chromium.org Vulkan: Clean up ImageLayout enum. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I533bb3e858398874b6c3b0e3e90efc9ab864f9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363793Reviewed-by:
-
Lily Chen authored
This fixes a crash caused by failure of a consistency check on the Reporting endpoints present in an endpoint group, triggered by receiving malformed Report-To headers (or multiple Report-To headers in one response). Upon parsing a Reporting group from a newly received header, if an equivalent group already exists in the cache, any preexisting endpoints with URLs that are not present in the newly parsed group are removed, i.e. a new header should overwrite the equivalent group set by a previous header. The problem occurs when there are multiple equivalent groups with disjoint endpoint URLs present in the same header (or multple headers on the same response). We should treat these headers as if a single group were specified, containing the combined set of URLs. However, we were deleting preexisting but no-longer-present endpoints multiple times, once for each duplicate group listed. The (malformed) header would effectively overwrite previous parts of itself, causing a consistency check failure. This is fixed by removing old endpoints only after the entire header has been processed. Bug: 1116529 Change-Id: I1bf5d57db2acf9f90a9d1cb63a5b1b79d9145fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357468 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#799407}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d0f7dea2a59..0795384a7997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I33e6e011455a92bc4a8ba165135ac88ac31838b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363446Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d0f7dea2a59..0795384a7997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3266d7e79c26347701cf5adc1c73aeebcb76666e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363645Reviewed-by:
-
Dan Sanders authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/d2dd36c03501..45b753b2d1 $ git log d2dd36c03..45b753b2d --date=short --no-merges --format='%ad %ae %s' 2020-08-17 sandersd@chromium.org Always use av_realloc() for ogg_stream |buf|. 2020-08-14 sandersd@chromium.org README.chromium file 2020-08-14 sandersd@chromium.org Chromium patches file 2020-08-14 sandersd@chromium.org GN Configuration 2020-08-01 lance.lmwang@gmail.com avcodec/libsvtav1: remove unneeded svt_av1_enc_deinit_handle() (...) 2020-04-16 josh.brewster libavcodec/libx264: fix reference frame computation based on level 2020-04-20 barryjzhao lavf/mp3enc: fix ID3v1 year metadata setting issue 2020-04-26 lance.lmwang avformat/dashenc: use av_reallocp_array() 2020-04-26 lance.lmwang avformat/dashenc: use local variable and avoid calculate duration multiple times 2020-04-26 lance.lmwang avformat/dashenc: cosmetics Created with: roll-dep src/third_party/ffmpeg Bug: 1105118, 1117613 Change-Id: Ife0e3dca60640e88a2b3f508fbfc6fe8d9308be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359167 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
Kartik Hegde authored
Tests whether a firewall is blocking HTTP port 80. TEST=unit_tests --gtest_filter=HttpFirewallRoutineTest.* BUG=chromium:956783 Change-Id: I9e847e433417dd2f2cca551041d7bf4ab5ad032e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303464 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799403}
-
Yoichi Osato authored
This CL is a follow up of the histogram: crrev.com/c/2255925 Bug: 688906 Change-Id: Ic81f629a8074708f2ea6240cf09036318ac97e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354125 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799402}
-
Klaus Weidner authored
If entering WebXR mode using DOM Overlay when we're already in fullscreen mode, and if we have a remote ancestor frame that's in another process, the ancestor frame didn't get set to transparent since fullscreen_controller ignores changes to fullscreen options. As a workaround, exit fullscreen mode in this case before proceeding with the session request. Bug: 1101193 Change-Id: I36b9918717abf6c5d462b7c78d545ae53fc5391e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358493Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#799401}
-
Brandon Maslen authored
The Storage Access API is enabled in Edge but is still disabled by default in Chromium. This change updates the expiration of the about:flags entry to allow for continued use for a few more milestones. Bug: 989663 Change-Id: I8072fd21606c152fb1106a8e1aebe2fb3e78c054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363642Reviewed-by:
Nicolas Arciniega <niarci@microsoft.com> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799400}
-
Yue Li authored
Bug: b/164287576 Test: Run QuickAnswersControllerTest.* in ash_unittests Change-Id: Id59933ae2535cc485c2515d8e8971b2b85752e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355492 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799399}
-
Alan Screen authored
Move the printing::ColorModel enum to print.mojom for using it in Mojo interfaces. This is in preparation for mojoifying PrintBackend class. Bug: 809738 Change-Id: Ibe3f4a47c807a8d4af28fb72f3667aa7a2163cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355083Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799398}
-
Sky Malice authored
This reverts commit b27232d7. Reason for revert: Test failures, see crbug.com/1117676 Original change's description: > [PwdCheckAndroid] Add redirect to Google Password Check on quota limit > > This CL adds the logic to redirect the user to the Google Password > Check on quota limit error. The redirect is called through > PasswordCheckBridge to avoid dependencies on chrome_java. > > IDS_PASSWORD_CHECK_STATUS_MESSAGE_ERROR_QUOTA_LIMIT_ACCOUNT_CHECK.png > https://storage.cloud.google.com/chromium-translation-screenshots/c4546cf199aa6314ead807fa1fc0e1ed8b779a83 > > Bug: 1092444 > Change-Id: I374ad088c305d299fea00f412f27dd6ab3d0e9b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362023 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Eleonora Rocchi <erocchi@google.com> > Cr-Commit-Position: refs/heads/master@{#799117} TBR=fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com Change-Id: I38a6779f2a9a278317ab5ce2be2edb0742e34f34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363444Reviewed-by:
-
Eric Roman authored
This also moves udp_socket_test_util.cc into the test/ subdirectory, in order to satisfy existing DEPS rules. Bug: 1083278 Change-Id: I45fd4ceb8b46e0464ff0cd2a41a897efa294f64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360125Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799396}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/e1e5e502ea64..abf77f1b3891 $ git log e1e5e502e..abf77f1b3 --date=short --no-merges --format='%ad %ae %s' 2020-08-18 wub Internal QUICHE change 2020-08-18 fayang Add a stable enum for QuicFrameType for logging purpose. 2020-08-17 renjietang In QUIC, change OnOneRttKeysAvailable() to OnTlsHandshakeFinished(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iebc4860945ebbc443c531172a1cc234463c4568d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363807 Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799395}
-
- 18 Aug, 2020 10 commits
-
-
Tommy Li authored
This CL refactors ZeroSuggestProvider::TypeOfResultToRun to take an AutocompleteInput as a parameter instead of just the current page URL. We need this because differentiating the on-focus vs. on-clobber ZeroSuggest modes requires access to AutocompleteInput::focus_type(). This CL also makes the method 'static', for three reasons: 1. The function is more easily testable when it only depends on its parameters, rather than any state in the member variables. 2. The member variables store data that's also in the |input| parameter, and I didn't want to introduce ambiguity as to which is used. 3. We plan to split MostVisited into its own provider, and we will want to share some logic from TypeOfResultToRun. Making this method static is a step towards that future. For reviewability, this CL actually has no functional changes, and just moves things around. The followup CL will actually add the on-clobber vs. on-focus logic to TypeOfResultToRun. Bug: 1106096 Change-Id: I69c8f2f08a182796be9ce1c66611fe6788a6158a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360562Reviewed-by:Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799394}
-
Steven Bennetts authored
This is in preparation for adding UI to allow users to set a custom DHCP hostname. Currently the policy code is always setting the hostname, even if kDeviceHostnameTemplate is not set by policy, which overrides any other custom set hostname. Bug: 1103272 Change-Id: Ia99ee58c59ae1f38e8fe10ed693997dead861c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320991 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799393}
-
Sammie Quon authored
Original thought the dark ripple was for the dark background. Test: manual Bug: 1117203 Change-Id: I3221271f8bb1d1d32a8832c75a46c0b8f726426e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363997Reviewed-by:
-
John Palmer authored
Should be 8px, old number worked out to 16px BUG=1117379 Change-Id: Ic6cef89a6c9b93fab24b538f13d6c07fa4f06647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362062 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799391}
-
David Bokan authored
As part of splitting out input from LayerTreeHostImpl I found some issues in tests that use FakeLayerTreeHost. This class also initializes a FakeLayerTreeHostImpl which is used in some tests. However, some tests also call InitializeSingleThreaded to use the FakeLayerTreeHost with a Proxy. Initializing a Proxy will call LayerTreeHost::CreateLayerTreeHostImpl which currently creates a (real) LayerTreeHostImpl that's owned by the Proxy. These tests are incorrectly running with multiple LTHI objects. This CL overrides CreateLayerTreeHostImpl in the fake so that this method creates a fake Impl object. We also avoid manually creating a fake Impl inside the FakeLayerTreeHost and instead rely on the call to CreateLayerTreeHostImpl to store a pointer to the fake impl. For tests that don't use a Proxy, we now manually call a new CreateFakeLayerTreeHostImpl method that does the same thing and the FakeLayerTreeHost takes ownership of the Impl instead. Bug: 915926 Change-Id: I63202e1717d2eab026688d69c8d0ef75939c7c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363247Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799390}
-
Miguel Casas authored
ToT VaapiWrapper has a simple report-to-uma callback that clients have to implement and that usually just points to "error happened" in either the normal or the Vpp VaapiWrapper. This CL changes that: - VaapiWrapper provides a function for this: ReportVaapiErrorToUMA(). - Clients bind their histogram (eg. Media.VaapiVideoDecoder.VAAPIError) to that new ReportVaapiErrorToUMA() method. - A new VaapiFunctions enumeration (with a matching UMA enum) is added to vaapi_wrapper.cc to identify which concrete vaBla() function failed, and is logged to UMA. This forces ToT UMA histograms (and associated enums) to be marked as obsolete, namely: -Media.VAJDA.DecoderFailure -Media.VAJDA.VppFailure -Media.VAJDAWorker.DecoderFailure -Media.VAJEA.VppFailure -Media.VAVDA.DecoderFailure -Media.VAVEA.EncoderFailure New ones are landed instead (with associated VaapiFunctions enum): -Media.VaapiImageDecodeAcceleratorWorker.VAAPIError -Media.VaapiJpegEncodeAccelerator.VAAPIError -Media.VaapiJpegEncodeAccelerator.VAAPIVppError -Media.VaapiMjpegDecodeAccelerator.VAAPIError -Media.VaapiMjpegDecodeAccelerator.VAAPIVppError -Media.VaapiVideoDecodeAccelerator.VAAPIError -Media.VaapiVideoDecoder.VAAPIError -Media.VaapiVideoEncodeAccelerator.VAAPIError -Media.VaapiVideoEncodeAccelerator.VAAPIVppError This CL also adds two new boolean histograms for VaapiVideoDecoder, who had none. Bug: b:162962069 Change-Id: I561e48183f61de86247598fea4f3b10cd590c2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339787 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799389}
-
Becca Hughes authored
For normal images contentAttributes are optional in the spec but the converter requires them. This makes them optional. Change-Id: I4073de51009e6e7802667b2d79a7ad485d939978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363477 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#799388}
-
Evan Stade authored
Bug: 1110930 Change-Id: I20914d3f88ad98944e0f5525421bc666cc79eb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363696Reviewed-by:
-
James Cook authored
Add support for image, list, and progress notifications. This involves serializing the RichNotificationData structure. Move some existing crosapi::Bitmap serialization code into a shared utility file. Add deserialization to SkBitmap. For now the image format is hard-coded. crbug.com/1116652 tracks more flexible image serialization. Add unit tests for both ash side and lacros side. Bug: 1113889 Test: unit_tests, manual with Notifications Galore chrome app Change-Id: I27b1c74f828751f35d845e625052386530de9722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357749 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799386}
-
Daniel Cheng authored
The current browser-side navigation code can ask the renderer to commit a MIME type that it cannot handle. When this happens, the renderer simply ignores the commit request, tripping the CHECKs added in https://crrev.com/796508. For now, allow these commits to silently fail and not commit a new document... Bug: 999255, 1115912, 1117282 Change-Id: I435831058db8e059b0389a8e2262f6bd72e875fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360602 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#799385}
-
