- 30 Jun, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic4e73dd90a476fee76673e6ff5c9985bde43087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784118}
-
Wei-Yin Chen (陳威尹) authored
Bug: 925965 Change-Id: Ieba151adfdfcf5b2419ba9396766426ea943703f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274973 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#784117}
-
Li Lin authored
Quick Answer result is cached when getting it from the server. The result type is then used for logging purpose. Currently, the result doesn't get reset when user select a new text. If users perform actions before the result came back from the server, the cached result type is used for logging. This CL reset the result when user select a new text and trigger QuickAnswers. Bug: b/160244136 Test: Manual test Change-Id: I526684755b7876aa0b6df12513ead9284a5454c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276513Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784116}
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: If620bd17399f0e20c6a2e37b09209dcfbbe6078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159949Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784115}
-
Dylan Cutler authored
This reverts the manual instrumentation done in: https://chromium-review.googlesource.com/c/chromium/src/+/2186997 In favor of bindings-based instrumentation introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2245048 Bug: 973801 Change-Id: I0b562c6326689bd084f8a217aa805fa3495fae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267421Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#784114}
-
Becca Hughes authored
Fix the bug by checking we have not reached the end before accessing. BUG=1095560 Change-Id: I309237562ddd5058c3b3b99d58a03c526cf49b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276511 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784113}
-
Francois Doray authored
OneCopyRasterBufferProvider::Playback() acquires the GpuChannelHost, which is also acquired from high priority tasks. It should not run at background thread priority because that can cause priority inversions, as shown by Slow Reports (see the bug). A follow-up CL https://crrev.com/c/2157659 adds a DCHECK to ensure that the GpuChannelHost lock does not cause other priority inversions than the one fixed in this CL. Bug: 1072756 Change-Id: I3cd7bd9a67e15c0079db35aeab3d1805e2b61835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240141 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784112}
-
Steven Bingler authored
Increase the expiry date to M90. Bug: 1072566 Change-Id: Ic6da0060ec9717bc4733e86141abfe7a5842dcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275465Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784111}
-
Philip Rogers authored
Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, dirtying TestRunner state for the next test. A navigation to about:blank is done after every test. This patch resets the TestRunner state after the navigation to about:blank, when we are sure no test javascript can change TestRunner state. This fixes a class of flaky bugs. This behavior happened with video-overlay-scroll.html which would set a custom layout dump (setCustomTextOutput) in a fullscreenchange event handler. This event handler was not removed at the end of the test (this will be fixed in a followup), and would run a second time, after the custom text output setting was reset. This caused later tests to run with custom text output from video-overlay-scroll.html. With this patch, video-scrolled-iframe.html is no longer flaky. Code in WebFrameTestProxy::BeginNavigation to intercept navigations relied on TestRunner::PolicyDelegateEnabled being reset before it ran. This patch now skips WebFrameTestProxy::BeginNavigation when the test is not running. Bug: 1048597 Change-Id: I888f7cc2ae91d7d3cfdd143a7573f62cb052c1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275348Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784110}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/584a47eb..df954ac3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16a4e1093dcb4fe8968b434729059a93a6b809b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275463Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784109}
-
Parastoo Geranmayeh authored
This reverts commit 1c1df774. Reason for revert: the first revert didn't stop the failures, this isn't the culprit. Original change's description: > [Sheriff] Revert "[WebLayer] Reuse Chrome's InfoBarWrapper.java" > > This reverts commit b7a33c21. > > Reason for revert: possibly causing crbug/1100914 > > Original change's description: > > [WebLayer] Reuse Chrome's InfoBarWrapper.java > > > > This CL eliminates //weblayer's copy of chrome's InfoBarWrapper.java in > > favor of directly using the latter now that it has been componentized. > > There were no substantive changes introduced in //weblayer and no > > behavioral changes. > > > > Bug: 1099169 > > Change-Id: Ie9cc819f17ce30bb66085cb05040ce11696725ec > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270554 > > Commit-Queue: Colin Blundell <blundell@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#783894} > > TBR=blundell@chromium.org,cduvall@chromium.org > > Change-Id: I5f0fbec56bae167ccfb54ca9d9fd4b5f3fdf25ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1099169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276312 > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#783980} TBR=blundell@chromium.org,parastoog@google.com,cduvall@chromium.org Change-Id: I31c5c69c74083bf07c60b5573ac4bf2b3ff1d637 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276518Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#784108}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593518062-9a8bcf79d9703750826ab2cdd2c19e0799442665.profdata to chrome-mac-master-1593539505-1242fb6afac1e074d04c68b7772a687abe4506af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I98e085aed20d7d3beaf2f52cde25b15ef0afed24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784107}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0144ebea. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/encoding skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I4f986f386122b15b24ab0e30324ee82a1b605f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275102Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784106}
-
Hazem Ashmawy authored
If the Dev UI is the WebView provider, we only show "WebView package", and "WebView version". If the Dev UI is not the system WebView provider, show "DevTools package", "DevTools version", "WebView package" and "WebView version." This should help triage bugs filed for the different WebView error message. Fixed: 1075747 Test: Manually change WebView provider to and from one package and verify correct info is shown Test: Manually verify correct text is copied when items are long pressed Change-Id: I33b8b7bbe96274ae9b5006ed1ce8e2cd1880661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266905 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784105}
-
Ben Pastene authored
They're all failing due to a problem with the virtual keyboard. This disables them until a fix is in-place. Bug: 1100710 Change-Id: I25974dc1b6ac3cd8055ed2cd01e5c5912b581067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276491Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#784104}
-
Nate Fischer authored
This captures all the requirements to be a valid WebView provider, including mapping common device configurations to the WebView providers they support. This also simplifies the related parts of the build guide. Fixed: 1083512 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I05b7966ab84363fda105ccbc3f3477e2fb7f76f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271009Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784103}
-
Lily Chen authored
Bug: None Change-Id: I8700e681e8c24c3d6ce434cda6fc5242b3bfa5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276224Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#784102}
-
Lily Chen authored
Bug: None Change-Id: I27274f5c1e8e4ccc32b7ccaa3d2600ca086ea77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276240Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#784101}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Iaa91fc42cdb74cf38f6edae3b72d4e535e52ceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276234 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784100}
-
Lei Zhang authored
Use base::bits::IsPowerOfTwo() and base::bits::Align(), instead of manually doing bitwise operations. Fix some lint errors along the way. Change-Id: Ib0ce4ca5bdba6ddc6368623f2105808bccdacd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253564Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#784099}
-
John Williams authored
Bug: 1095222, b/159069899 Change-Id: I387ffe8c9f560a2dbe5fd72dad3f2cbe21620692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271165 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#784098}
-
Xianzhu Wang authored
This fixes a regression caused by crrev.com/c/2183198. We should move the effect's clip to the outer synthetic effects for backdrop effects only. For non-backdrop effect we don't move effect up into the synthetic effect and can share the synthetic effect with other effects, so we should not move up the clip. Bug: 1099234 Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/162e2b2eb46e..2e50e757e3e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com,parastoog@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058102 Tbr: davidbienvenu@google.com,parastoog@google.com Change-Id: I0eee12566cbe4e5063a37cac02351e53ef9143f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276341Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784096}
-
Daniel Hosseinian authored
If a new print composite request is introduced before PrepareForDocumentToPdf() is completed for an old composite request, the result status is |mojom::PrintCompositor::Status::kCompositingFailure|. Ignore that result if the failure is from an old request. Bug: 1100825 Change-Id: Iead7dc19ada9290732640e0e561f3b08dd2e3b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276492Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#784095}
-
inglorion authored
This is not a functional change. The list existed before, but the new name more clearly describes its purpose. Bug: 1099035 Change-Id: I6dd8435df37c4d55e6e4254fe8be7516a55ea7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275356 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#784094}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d912aa91339c..9056401df001 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I1d744b18657609fb7e4ef1ec25a25148b2936cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784093}
-
Francois Doray authored
The new task category is for tasks that must not be scheduled when there are foreground tasks to run, but shouldn't run at background thread priority. Tasks that acquire resources shared with foreground work (example: a lock) should not run at background thread priority, because there is a risk that they will hold these resources for a long time, causing a priority inversion. The new task category is used in https://crrev.com/c/2240141 to fix a priority inversion that is observed via Slow Reports. Bug: 1072756 Change-Id: Ie42feb48cc167303712e5adbdfeec11ec2e312c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158939Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#784092}
-
Qijiang Fan authored
For Python3 compatibility. $ python3 ./mojo/public/tools/bindings/mojom_bindings_generator.py precompile Traceback (most recent call last): File "./mojo/public/tools/bindings/mojom_bindings_generator.py", line 390, in <module> sys.exit(main()) File "./mojo/public/tools/bindings/mojom_bindings_generator.py", line 385, in main return args.func(args, remaining_args) File "./mojo/public/tools/bindings/mojom_bindings_generator.py", line 256, in _Precompile generator_modules = LoadGenerators(",".join(_BUILTIN_GENERATORS.keys())) File "./mojo/public/tools/bindings/mojom_bindings_generator.py", line 72, in LoadGenerators "generators.%s" % _BUILTIN_GENERATORS[language]) File "/usr/lib/python3.7/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1006, in _gcd_import File "<frozen importlib._bootstrap>", line 983, in _find_and_load File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 677, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 728, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/ssd2/chromium/src/mojo/public/tools/bindings/generators/mojom_mojolpm_generator.py", line 7, in <module> from mojom_cpp_generator import _NameFormatter as CppNameFormatter ModuleNotFoundError: No module named 'mojom_cpp_generator' Bug: 941669 Change-Id: Id54c3d212852ef68f34a83ef1160aa3d0e97d0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273504 Auto-Submit: Qijiang Fan <fqj@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#784091}
-
Bo authored
This reverts commit 1dd99e49. Reason for revert: It just moves the crash to later Original change's description: > android: Catch exception in broken OS implementations > > Some bad OS implementation throw null pointer exception here. Just catch > and ignore it. > > Bug: 1092978 > Change-Id: Ia465e6198645c2ff0e5c30b0e3c45eccf6f0508b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238451 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776700} TBR=boliu@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1092978 Change-Id: Ica8ae5fbe0e463473b4a3da9ecfca06743d0ae32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276238Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784090}
-
danakj authored
In order to add a WebTestShellPlatformDelegate override for other platforms, I need to add one for each web test build configuration to avoid messy defines in the header. That would also need an Android version even though we don't run web tests there. So in this CL we group all the web test files/deps together in the BUILD.gn and do not include them on android. This allows us to avoid adding a WebTestShellPlatformDelegate implementation for the platform. Moves the MockClientHintsControllerDelegate class up from web_test/ to the content/test/ directory, as it is shared test code between content_browsertests and web tests. We also move its dependent mock_client_hints_utils.{h,cc} helpers with it to content/test/. This removes the 2 dependencies from content_browsertests on web test code via content shell, now that the web test code will not be present on Android, but content_browsertests are. R=avi@chromium.org Change-Id: I7f40fc67f4a6c993dd7eccac0da5bc7482806fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270800 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784089}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0452c2e8370..64b2c2e83ae6 2020-06-30 brgoddar@microsoft.com Grid: Add telemetry to track Grid settings changes 2020-06-30 sigurds@chromium.org Fix stylelint-config-standard issues in data_grid/dataGrid.css 2020-06-30 petermarshall@chromium.org Revert "(e2e test) Port console last result test" 2020-06-30 sigurds@chromium.org [cleanup] Make it clear that DataGrid.createCell creates an HTMLElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1083142,chromium:1099603 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16f884bb099180f8831b8588369ca6e8b30bc10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784088}
-
Dmitry Torokhov authored
This adds the Chrome D-Bus interface that will allow querying set of permissions (Microphone, Camera, etc) that are available to the VM. Current implementation returns the same set of permissions for all VMs of given kind (Plugin VM, Crostini VM) and only Plugin VMs are actually hooked up. Bug: 1071872,1016193 Test: dbus-send --system --type=method_call --print-reply --dest=org.chromium.VmPermissionService /org/chromium/VmPermissionService org.chromium.VmPermissionServiceInterface... .... Change-Id: I972e8a8b467773f473ab0152444fc1b4533c8631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253119 Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784087}
-
Stefan Zager authored
It's not clear why InCompositingMode() would be out of sync with the allocation of the root graphics layer, even when the iframe is throttled; but the CHECK was being hit. BUG=1092673 Change-Id: I709f0958db7fb9e2c8fb315abac01c56aa0bded0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274674Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#784086}
-
Shengfa Lin authored
Changed bind to bind repeating when calling metric state manager Format cast_metrics_service_client.cc Disable base::Bind/base::Callback for //chromecst/metrics Bug: 1007650 Change-Id: I29e5c53888943fa6da8a587909c853c25f107ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274095Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#784085}
-
Leonard Grey authored
Only this class and related files are renamed. The enterprise policy is https://crbug.com/1095226. The pref name is going to need some kind of migration, so I will defer that for now. Bug: 1097287 Change-Id: I27f1e6f6cf77fb77698d74ae382433a7e6a68f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267646Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#784084}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I373b73928b84b42cf75fb5fb85245d7a7bf70802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275354Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#784083}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If2c0fcb5f9d6c0fc6b4e07f55eee385527004922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784082}
-
Xing Liu authored
Only informs the new observer added in SimpleDownloadManagerCoordinator. Or all observers will get multiple random OnDownloadsInitialized(). TBR=dtrainor@chromium.org, qinmin@chromium.org Bug: 1099891 Change-Id: I90a31ba276813bf0ca9320ac9d9cf193f2a9ceaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269119Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b5d9bdb51608..237a776bc179 2020-06-30 aninditaghosh@google.com Add Python binary and library configuarations to BUILD.extras If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I73938cef0d559a220aa56f07a4f62116cad1695c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276339Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784080}
-
Gavin Williams authored
Move the logic for checking if the current destination is a local Chrome OS printer to the destination_select. Then pass that variable to the destination dropdown. Bug: 1059607 Change-Id: I75b48dbfedd235bb085cc426f214fcf13ea3e60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273763 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784079}
-