GitLab

In this CL, when the mouse click on the main button or the delete button
is canceled, the menu selection is refreshed by:
(1) Select the menu item hovered by mouse if any; otherwise,
(2) Select the root menu item to cancel the selection on a child item.

Bug: 1165999
Change-Id: I86bebc2b1dc08665a98da366a6a6bdb9fab532d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625798Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843103}

Bug: 1101837
Change-Id: I21f981c1b5c154ca68d3e310653a9485d7e903ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617847
Commit-Queue: James Cook <jamescook@chromium.org>
Owners-Override: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843102}

With use_thin_lto, needs_stack_alignment is false, so `defines`
wasn't, uh, defined when adding PREFIX to it.

Bug: none
Change-Id: I08ddd80386fce17bfd5b135b6a075d7f3bd0cf12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626774
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843101}

The previous fix http://crrev/c/2562059 isn't very correct:
1) It introduced menu flickering because the icons could be set after
   the menu is already showing.
2) Even after a pre-warming, the second #loadDrawableAsync() call could
   still be slow, so the icons doesn't show sometimes.
3) An internal Android framework change made the situation worse that
   sometimes the menu item won't send the intent. Because the menu item
   can change its icon from null to an actual drawable, but the
   framework code made the assumption that the menu item won't change.

This fix moves the icon loading work to the same background task for
the smart text classification task, after we get the classification
result. In this way we could have a deterministic
icon loading result while not violating the strict mode rule.

Fixed: 1129211
Change-Id: I7c35d8221bf57bd8ed68295f797d5bd6871dbae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626461Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843100}

This will call WebMeasureMemory randomly after a page load, and discard
the results, to check for crashes. It is controlled by an experiment
feature ("StressTestWebMeasureMemory") that will only be enabled for
some Canary users.

Also removes some unused headers from performance_manager_lifetime.cc.

Bug: 1085129
Change-Id: I32f24d4bf35032dea26b672a4fa899c5bf182cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627360Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843099}

Bug: 1081222
Change-Id: Ifc710417bd6a26b72de1168f06820fab1df7d127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612951
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843098}

RequestType is a new enum in the permissions package that is not
burdened by UMA backwards-compatibility like PermissionRequestType is.
PermissionRequestType is renamed to RequestTypeForUma and is now only
used inside permission_uma_util.h/cc (and related tests). RequestType
also replaces most usages of ContentSettingsType within the permission
package. Prompt icons are now fetched statically via the RequestType.

RequestType will eventually also represent combined requests (for
example, camera and microphone together) but this will be done in a
future patch.

Bug: 1110905
Change-Id: I8a1141488a5b500e796d8baa1fde02a93b8b4169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569656
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Auto-Submit: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843097}

When the children appended, the height of <select> popup must be changed.

Therefore, Add a condition for calling the function.

Bug: 753001
Change-Id: If20fae2d1d578839ef3b6d6405c8400198968464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603763Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Cr-Commit-Position: refs/heads/master@{#843096}

This CL adds code to read the DM token from ConnectorsService instead
of policy::GetDMToken so that the correct token (profile vs browser) can
be obtained depending on the value of the scope pref.

Bug: 1163992
Change-Id: I772199d08bb5e5a99c582453106fe2ec0365f1f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615779Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843095}

Change-Id: Ia362147eee429f4000db067914e755dadc6b014a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627687Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843094}

All of chrome's mb_configs should have been swapped over to using
'builder_groups'.

V8's and WebRTC's copies of mb.py still have references to 'masters':
https://chromium.googlesource.com/v8/v8/+/master/tools/mb/mb.py
https://webrtc.googlesource.com/src/+/master/tools_webrtc/mb/mb.py

So updating those are left as a follow-up for the relevant project
owners.

Bug: 1117773
Change-Id: Ic58469c050cac77d834c63f4a2b6478c377d9411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622751Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843093}

Prior to this CL, a scan for instant tethering networks is performed
every time the PHoneHub UI bubble opens. Now, a scan for tether
networks only occurs the first time the user opens PhoneHub when its
enabled during their session.

Fixed: 1164517
Bug: 1106937
Change-Id: I281fb88bafdc375391e0596052b327657ee71c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621982
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843092}

This CL change the behaviour when editing a the omnibox to not stop the
load of the page when typing in the omnibox.

Bug: 818649, 1159147
Change-Id: If4e71aee5a8ad5367122058630a54039399d7040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627490
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843091}

We would like to only include ANGLE library in Android canary build.
Archive this by use use_static_angle when chrome version is 90. I will
land it on the 89 branch date.

Bug: 1161513
Change-Id: I445a2b5a38cbfc585f277ac538031d8c0c2fa611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613150
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843090}

This reverts commit 13fc65a6.

Reason for revert: broke build (https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/105660) due to a mid-air collision with https://chromium-review.googlesource.com/c/chromium/src/+/2589206

Original change's description:
> Origin-keyed agent clusters: rename in Blink and plumbing
>
> 942aca88 performed the minimal updates
> to the implementation to shift from "origin isolation" to "origin-keyed
> agent clusters" for the web-observable API surface. This followup also
> renames much of our internal implementation references to the concept.
>
> Specifically, it takes care of all the Blink-side infrastructure
> supporting the window.originAgentCluster getter, as well as
> document.domain restrictions. This includes all the navigation-params
> plumbing to get the value from the browser process into the renderer
> process.
>
> This does not yet tackle any renaming for code that is entirely within
> the browser process.
>
> The only observable effect of this is changing the console warning
> message for document.domain to mention "origin-keyed" instead of
> "origin-isolated".
>
> Bug: 1158853
> Change-Id: I8feb507eee17db53e58b70e4ee5820c555ba962f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617583
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Domenic Denicola <domenic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#843082}

TBR=creis@chromium.org,kinuko@chromium.org,domenic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ic0bc0bbcf6ba4b8f3c920a34356e3cb8cfca823e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1158853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625916Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843089}

This reverts commit 55f04b52.

Reason for revert: 🤠 Seems this CL is causing compiling error here, looking to revert. Details: https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/95820/overview



Original change's description:
> Copy attributes of old DocumentLoader on javascript: URL & XSLT commits
>
> When javascript: URL evaluates into a string, or XSLT document change
> happens, we will commit a new document but won't notify the browser of
> the change of documents, as no URL/origin change happens, essentially
> treating it as just a content update within the previously committed
> document.
>
> However, we actually create a new DocumentLoader and Document for the
> commit, and not all attributes of the old document are actually carried
> over to the new document. This CL copies most attributes from the
> previous document through DocumentLoader::CreateParamsToClone(), to
> ensure future navigations within the new document won't result in
> confusion in the browser. Some examples of things that are now copied to
> the new document: HistoryItem, http_method, http_status_code,
> devtools_navigation_token (so XSLT document transformations show up
> on devtools), etc.
>
> Bug: 1151954, 1048106
> Change-Id: Iefd620c7c3896f2f1ae2fdcc60404361363124eb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589206
> Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#843047}

TBR=dcheng@chromium.org,creis@chromium.org,japhet@chromium.org,rakina@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Id3ca501b35c039300d8b3155fd09709a26dc425b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1151954
Bug: 1048106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626099Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843088}

The interested data type list will be sent on each change. Before this
CL, if sending of interested data types was just enabled, then the new
field containing the list wouldn't have been sent to the server after
the next browser startup.

Bug: 1155030
Change-Id: I50ffb01b8592432128f3929abd554d874023d47e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598908
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843087}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6cbcce5b..5f223d7f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6c2ca51b7361135ba190163d6db4c73e1aa2c42e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627139Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843086}

This CL refactors the CheckClientDownloadRequestBase into two separate
classes. The CheckClientDownloadRequestBase is responsible for request
logic, such as checking the allowlist and networking operations, while
the DownloadRequestMaker is responsible for assembling the actual
request proto.

Bug: 1165815

Change-Id: Iaaa43ddf65a9c808f2d50bb86800c9667f5e5d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623708Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843085}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bcd6b5c3ff8a..c593077f725b

2021-01-13 morlovich@chromium.org Device emulation: re-apply changes after edit
2021-01-13 jacktfranklin@chromium.org Migrate String#compareTo to utilities
2021-01-13 jacktfranklin@chromium.org Use custom CSS property rather than string interpolation
2021-01-13 tvanderlippe@chromium.org Inline and remove peekLast()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1050549,chromium:1158834,chromium:1166108
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6dc9151ac3d80547b117a75de4e83ca4698c8877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627616Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843084}

Sets up gpu.fyi's "Android FYI Release (Pixel 4)" and its manual-only
trybot mirror "gpu-fyi-try-android-r-pixel-4-32".

Bug: 1165876
Change-Id: Iaa4c39eda29f1ad9813c945a0aacc00a546e52af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625827
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843083}

942aca88 performed the minimal updates
to the implementation to shift from "origin isolation" to "origin-keyed
agent clusters" for the web-observable API surface. This followup also
renames much of our internal implementation references to the concept.

Specifically, it takes care of all the Blink-side infrastructure
supporting the window.originAgentCluster getter, as well as
document.domain restrictions. This includes all the navigation-params
plumbing to get the value from the browser process into the renderer
process.

This does not yet tackle any renaming for code that is entirely within
the browser process.

The only observable effect of this is changing the console warning
message for document.domain to mention "origin-keyed" instead of
"origin-isolated".

Bug: 1158853
Change-Id: I8feb507eee17db53e58b70e4ee5820c555ba962f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617583Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843082}

In general, I don't have enough expertise in this code to be able to do
meaningful OWNERS reviews for substantive changes to the implementation,
and I redirect such changes to mark@. However, thanks to my refactoring
of the IPC to Mojo I seem to still be the person with the second-most
knowledge of this code on the team :P. This CL adds comments to the
OWNERS file to make my expertise here explicit.

Change-Id: I262d4da3c1abb2ebbc2c2c6b1d0f1425d4cd3674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617925Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843081}

Underlying problem that lead to the earlier revert fixed in:

https://chromium-review.googlesource.com/c/chromium/src/+/2614365




Bug: 389359
Change-Id: I0c688430e8a1df0f2af6711d58e883f2cd179fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625290Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843080}

Fix unnecessary blink of ripple effect seen at back arrow in Wi-Fi
details screen. This was caused because both settings_subpage and
internet_detail_page were focusing their own UI elements, causing
a flickering. This is solved by setting the settingId param in the url
so then settings_subpage does not attempt to focus its back button.

Fixes: 1150806
Change-Id: I9cc1a50188b76f32fb7b7ac2f2f489b197c963df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625330Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gordon Seto <gordonseto@google.com>
Cr-Commit-Position: refs/heads/master@{#843079}

This CL is part of a migration of all interactions with the Libassistant
3rd party library to a mojom service. Currently Libassistant is invoked
directly from the browser thread.

This specific CL focuses on the audio input, aka the microphone.
Libassistant needs to open the microphone both for hotword detection
and for listening to actual user queries (for example
'ok google; set a timer for 5 minutes').

The idea behind the mojom interface is that we tell Libassistant
    - What audio devices to use.
    - When it is allowed to open the microphone (for example we don't
      want Libassistant listening if the lid of the device is closed).

We also want to keep creating the |AudioStreamFactory| instances on the
browser thread, so this mojom API contains a delegate to allow our
service to request a |AudioStreamFactory| from the Browser thread.

Bug: b/171748795
Test: N/A
Change-Id: I3b75d9424e78fe5af8793395e25485168bc3c999
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600332
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843078}

The following tests appear to be flaky on android-10-arm64-rel:
WebXrVrPermissionTest#testPermissionPersistsAfterReload__CustomTabActivity
WebXrVrPermissionTest#testPermissionPersistsAfterReload__WebappActivity

BUG=1166223
TBR=bsheedy@chromium.org

Change-Id: I6ea1649e7a1f90b274b6b82941a7e6c8982bf747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627399Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843077}

Stable rollout is targeting M88 now, update ending milestone to match.

Change-Id: Iec905a97847df21bbaa8d19b22051643d79919d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624152
Auto-Submit: Matt Mueller <mattm@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843076}

We don't support synchronously exiting fullscreen when fullscreen
is entered. The code currently CHECKs in the native side. This
patch throws an exception in hopes of better identifying why
the java side is synchronously exiting. It doesn't seem the
embedder has a synchronous path that exits, but perhaps it's
because of a config change/retain issue?

BUG=1142101
TEST=none

Change-Id: Ia41dd9018c210a0b300223329a650cb0651030b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626191Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843075}

Replace two methods in AshTestBase as a first step.

Bug: None
Change-Id: I9826897319b19b967d5f07d6ac9ef22f280570e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609588
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843074}

NetworkChangeNotifier was mis-reporting the failure status as
ZX_ERR_INVALID_ARGS.  Move the failure logging into the
GetExistingInterfaces() call so that the status can be logged properly.

Bug: 1165716
Bug: b/177088778
Change-Id: I2e0db22ee27b93d1c5b3d199c6286d9898c2adf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623012
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843073}

According to Stability.iOS.UTE.MobileSessionAppWillTerminateWasReceived
UMA it's not uncommon to have a UTE after appWillTerminate callback.

Bug: None
Change-Id: I20b9e581b8dadb11d2b3e8b7f1c770f5ae1df650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627049
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843072}

This is no longer needed.

Bug: 1090417,1159182
Change-Id: I4c0fc0e8a2b63f4b4b2fd8403b362b0d94998400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613486
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843071}

When aria-labelledby is used, any element directly pointed to with a
value should not contribute a value to the name.

However, when the value is is part of an element that is deeper in a
subtree, and the element is contributing via recursion, then the value
can contribute to the name.

Bug: 1159567
Change-Id: Idcf89b012896377d41c8689e61b4b7833f9322e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605481
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843070}

Roll Chrome Win32 PGO profile from chrome-win32-master-1610528340-b101588b91e5587ca53d6a4d812cdea4439c3876.profdata to chrome-win32-master-1610538373-fd44620c77870a58d7cfe6c95cdad1d7eb2cbcb8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia161a3d341a5d166bc657e53cf3860bbf07ebb64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627560Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843069}

Adds "Profile.Guest.SigninTransferred.Lifetime" and
"Profile.Guest.BlankState.Lifetime" for comparison of Guest
profile lifetime when its initialized by a signed in token and when it
starts from blank state.

Bug: 1157764
Change-Id: Iea3a8cce12bddd8fed19b9a1c01c7c8c4c68dd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623009Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843068}

This CL makes window.open() fail in prerendered pages and return a null
object like other restriction cases (e.g., window.open() in sandboxed
iframes). This doesn't cancel prerendering.

Bug: 1158252
Change-Id: I49fa64c8653fab898076eb91ace3c8386c7cf3f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589060
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843067}

Defers item validity checks for Android file until connection to ARC
file system service is ready. Without this, there was a race condition
between holding space service and ARC initialization, where item
validity checks were performed before the backing file system was ready.

Also, given that ARC is only initialized for primary profiles, makes
holding space file system delegate ignore Android files in non-primary
profile - they are kept in the persistent storage, but are kept out of
the holding space model.

BUG=1165890

Change-Id: I1d93289ce176c2c396b6925ca0f5b5ab8414816d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625453Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843066}

We suspect that in rare cases some clients trigger some kind of loop
failures when Reshape fails, generates context loss, but after
reinitialization it fails again.

This CL adds CHECK for this case to crash and get more info from crash
reports.

Similar logic that was implemented in SkiaOutputDeviceGL earlier in
https://crrev.com/c/2416749

Change-Id: Ifa1dca0ee19423f5ba532644ec45cd373e712b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626771
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843065}

When navigating to #foo, the element with id="foo" is scrolled into view
and is focused if focusable. This patch makes it receive the caret too,
in case caret browsing is enabled.

Bug: 1011934

TEST=editing/caret/caret-browsing-fragment-anchor.html

Change-Id: I044e6b48545426afdb0c5ee766d4ee3a218aa95b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463308
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843064}