- 08 Sep, 2020 40 commits
-
-
Alice Wang authored
This CL removes all ChromeActivity usage in AccountPickerDelegate. Bug: 1125068 Change-Id: Ib2afc7f5d8ab1ebe8138e96aff41cdd1c1c8dea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398129Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804921}
-
Peter Boström authored
This removes ButtonListener from BubbleDialogModelHost and adds Button::PressedCallback versions of MdTextButton and LabelButton constructors to support it. Bug: 772945, 1106422 Change-Id: I5a6fc50a714e6ac6701af588d5a428ea291bd008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398321 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804920}
-
Ella Ge authored
When switch on/off dark theme, WebApk splash screen is shown again since browser is initialized again and SplashController#onPreInflationStartup is called. The splash screen is not hidden because the web page is not reloaded. This CL makes the splash screen also hide when the Tab's re-attached to window (intractability state to True), and is not loading. It only hides when TabCreationMode is RESTORED so the real splash screen on webapk launch won't be affected. Bug: 1111880 Change-Id: I4df9490d3dccc375db03ef9b639e8fee74d952e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391387 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804919}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::ShapeText()| not to reuse |ShapeResult| for text with CSS property "letter-spacing" because we modify |ShapeResult| directly to apply letter spacing. Thus, letter- spacing is applied more than once on reused portion of |ShapeResult|. This is reland of original commit. There are two changes to fix revert resones: 1. Size of ShapeResult is increased => reduce bit size of |num_glyphs_|[1] 2. Newly added member is not initialized in copy constructor[2] [1] http://crrev.com/c/2390615 [2] http://crrev.com/c/2392577 Bug: 1124446, 1124740 Change-Id: Ifef96781528b03944be752303b1ce1edca5ff92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397105 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804918}
-
Julian Pastarmov authored
The current logic simply returned UNKNOWN for all cases that were not a dm disk or we had trouble learning what is the uuid of that disk. With this change anything that is not a dm disk will return that encryption is disabled. It also now checks the result of the stat command and returns UNKNOWN if it fails as this prevents us from doing the further interrogation. BUG=1125634 TEST=unit_tests:EnterpriseReportingPrivateGetDeviceInfoTest.GetDeviceInfo Change-Id: I83e3b825f1033e14c3819d5adbe35fc0ee1be1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396377 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804917}
-
Kushagra Sinha authored
|GoogleServiceAuthError::State::USER_NOT_SIGNED_UP| is now thrown iff |OAuth2AccessTokenManager::Delegate::HasRefreshToken| is |false|. Update the documentation for |GoogleServiceAuthError::State::USER_NOT_SIGNED_UP| to reflect this. Change-Id: I5f5f4ea9d6706254092074f0ec48b9c4fdde6c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386798Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#804916}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d7e4614b548c..e9eaf5ce5d81 2020-09-08 tvanderlippe@chromium.org [globals] self.UI.dockController 2020-09-08 alexrudenko@chromium.org Move inspector_overlay to the top level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320,chromium:1100925 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80d0b9d3d0da2dacf031ca6c0760fe157fe852a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804915}
-
Maksim Sisov authored
This is a reland of 7138b785 WaylandPopup didn't allow empty bounds. Fixed by https://crrev.com/c/2397695 Original change's description: > ozone/wayland: Fix drop down menus for touch events. > > In case of touch events, we may not find currently focused windows > as menu windows might be created on touch up events. Thus, > GetCurrentFocusedWindow returns nullptr. > > To fix that, use a concept of a currently active window. That is, > Wayland sets a window to "active" state if it has had a focus. > There can be only one focused window at a time. > > Thus, if there is no a focused window, use currently active window > as a parent. That's the best effort one could make to find a parent > window for a newly created non-toplevel window. At some point, > it might be worth reconsidering the design and make aura always pass > parent widgets for new windows if applicable. > > Bug: 1123521 > Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#804674} Bug: 1123521 Change-Id: I62c6b254bc2e931bc93ac4609290518138aa19b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397715 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#804914}
-
Maksim Sisov authored
After https://crrev.com/c/2385279 landed, the factory stopped creating WaylandToplevelWindow instead of WaylandPopup for requests that asked for kPopup windows (which is correct). However, some tests may pass bounds with the size parameter set to 0, 0. That resulted in closing of WaylandPopups and tests crashed. Thus, to fix this problem, readjust bounds when shell popup is created. Bug: 1125924 Change-Id: Icd7179e8f5ab1d9c2e96fee3dbb167e67b9e753d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397695 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804913}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dc1b9762731e..6a6e311d81dd 2020-09-08 johnkslang@users.noreply.github.com Merge pull request #2388 from Tobski/rq-initialization-error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I1a5248157bd441f1bdc5dbf4fab9f723cec5d5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398318Reviewed-by:
-
Jose Dapena Paz authored
Fix this build error using libstdc++: ../../printing/print_settings_conversion.h:24:22: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type 24 | PRINTING_EXPORT std::unique_ptr<PrintSettings> PrintSettingsFromJobSettings( | ^~~~~~~~~~ ../../printing/print_settings_conversion.h:9:1: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’? Bug: 957519 Change-Id: I3d23fb277ba5c600109c115e5de48a08c6e401be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394163Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#804911}
-
Owen Min authored
This reverts commit 85ae69b0. Reason for revert: crbug.com/1126038 Compile error on Linux Chrome: https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/15196 Original change's description: > Add new class ColorTrackingIconView to deduplicate subclasses. > > Upon investigating the associated bug, I noticed that there are a few > subclasses of ImageView that exist solely to override OnThemeChanged. > Since I also needed a subclass like this to fix the bug, I decided to > make a utility class to eliminate this ad-hoc subclassing, in the style > of ColorTrackingVectorImageButton (in image_button_factory.cc). > > Bug: 1125510 > Change-Id: I975a9b6a4676bb6b2a454172f211f406934d7869 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397737 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804901} TBR=tapted@chromium.org,bsep@chromium.org Change-Id: I958b5f7c04434b680f58fb0d0e0e46a8529a6abb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1125510, 1126038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398778Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6f29c57c715c..c107c7e93630 2020-09-08 andrewbb@google.com Ran tools/run_ftrace_proto_gen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I21c279a29065aaa34c6ccd350c33ebae9fa96742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398316Reviewed-by:
-
Owen Min authored
Using 'future_on' instead of 'future' flag for the following policies: CrostiniArcAdbSideloadingAllowed CrostiniExportImportUIAllowed DeviceCrostiniArcAdbSideloadingAllowed Except the DeviceCrostiniArcAdbSideloadingAllowed, all policies will be filtered out in Beta and Stable. The follwing policies are actually launched, removing the future flag for them. CrostiniAnsiblePlaybook FloatingAccessibilityMenuEnabled VirtualKeyboardFeatures PluginVmDataCollectionAllowed BYPASS_POLICY_COMPATIBILITY_CHECK=Four policies are launched few milestones ago without removing the future flag. Bug: 1117637 Change-Id: I89304cc1b613a10fba1853267d6d31ed674597ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391615Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804908}
-
Frédéric Wang authored
This CL adds a web platform test to check that MathML content inside a content-editable div is still correctly laid out. It is inspired from the similar tests mathml/relations/html5-tree/integration-point-4.html and mathml/relations/css-styling/multi-column-layout.html for SVG embedding and fragmentation respectively. Currently, this test passes with EditingNG enabled. Bug: 6606, 1125133, 707656 Change-Id: I1bac091ca02608891e2d36e34c0a8190c40506be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398481 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804907}
-
Paula Vidas authored
This CL makes DeviceInfoSyncService an observer for FCM token and interested data types, so that it can send updated device info when they change. Bug: 1102336 Change-Id: I3fe00cbef6eb57fd7ccff35c047fa74053e4fcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397578 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804906}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51932f610c36..0485634fe3f9 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 25d277579d1e to ccab4cc42372 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ic8124b58b79e82dfab4b23795182ac1a60a7d635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398315Reviewed-by:
-
cfredric authored
Change-Id: I1ad064b9da87821b578d9f183a7a78ba8da5929a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393056 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804904}
-
Wez authored
Flakes are observed under Fuchsia, Linux ASAN, Linux MSAN and ChromeOS bots, so disable the tests for Fuchsia & ChromeOS, and all ASAN and MSAN configurations. TBR=sunnyps Bug: 1045521 Change-Id: Ib8d1f33d433e6be6d3be1183af0e5ecd3edb5fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398678Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#804903}
-
sauski authored
Bug: 1125970 Change-Id: I4ab51c22d84ee64564a3a28144e35d1216b76c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398131Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#804902}
-
Bret Sepulveda authored
Upon investigating the associated bug, I noticed that there are a few subclasses of ImageView that exist solely to override OnThemeChanged. Since I also needed a subclass like this to fix the bug, I decided to make a utility class to eliminate this ad-hoc subclassing, in the style of ColorTrackingVectorImageButton (in image_button_factory.cc). Bug: 1125510 Change-Id: I975a9b6a4676bb6b2a454172f211f406934d7869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397737 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#804901}
-
Stephen McGruer authored
The WPT importer is blocked by the rename of a bunch of tests that are in the disable-layout-ng file. Add entries for the new location to unblock the importer; the old locations will be cleaned up by a follow-up CL after the import lands. TBR=lpz@chromium.org Bug: 1126004 Change-Id: I7911c022c78b3ee18f5f44509b42a896b4aa2142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398399Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804900}
-
Matthias Körber authored
Change-Id: Ied46d737413cfb5fcd1eae5995c2bea8c1be50d4 Bug: 978014, 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282752 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#804899}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/91fd72f9456b..d7e4614b548c 2020-09-08 petermarshall@chromium.org Avoid layout shift when rendering pie charts 2020-09-08 sigurds@chromium.org Don't override background of tabbed-pane-header-tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1122511,chromium:1125940 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I30587e321c26163897a4f2d4d0b495bbc5dd5490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398311Reviewed-by:
-
Santiago Aboy Solanes authored
This is done to set up a reverse Finch trial of V8's --turbo-direct-heap-access. As a note, it is is dependent of V8's flag --local-heaps. Bug: 1125606, v8:7790 Change-Id: Ieede59881b3ef3c762ba0679dccf1b95cc05c1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396137Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#804897}
-
Anders Hartvoll Ruud authored
Change-Id: Ida10f6a7f6a4583dddc6e51bf6874d664cb138af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372284 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#804896}
-
Andy Paicu authored
On iOS the HCSM is only used for cookies and one boolean for blocking popups both of which are irrelevant to the migration logic so this is effectively a no-op, even with the change in ios/chrome/browser/content_settings/host_content_settings_map_factory.cc Bug: 1090670 Change-Id: Ia472fcea9b0cb0523db5ea7909aabd2de4ce114a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362809 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#804895}
-
Arthur Hemery authored
This test verifies that the candidate SiteInstance is not used for a cross origin redirect, that would lead to have a SiteInstance hosting a crossOriginIsolated page with an incorrect top level origin as initially registered. Bug: 1107814 Change-Id: If52fef13528ca8d2f8dcf8af04b6510462072f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396379 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804894}
-
Vasilii Sukhanov authored
testing config. Bug: 1049200 Change-Id: I11515fd5626565be57ab75f834825d93a952e9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396218Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804893}
-
Kent Tamura authored
- It has a circular dependency with modules/worklet:worklet. The dependency is safe because these targets are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: Id77e8c276ff74e6802e6ce7b2323cead37e6862b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397475 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804892}
-
Patrick To authored
If the xr-spatial-tracking feature policy is disabled, throw a SecurityError on makeXRCompatible. This is to prevent an unnecessary restart of the GPU process. The WebXR spec isn't clear on the behavior when the xrCompatible flag is set when requesting a context. In this scenario, this change simply sets the flag to false without throwing an exception. The WebXR spec has also been updated to specify that an InvalidStateError should be thrown if there are no devices available. The kNotCompatible enum is split into specific reasons for why we can't be XR compatible to be able to throw the corresponding exception. A subsequent change will add a blink feature for multi-GPU and add corresponding tests Bug: 1124024 Change-Id: I5207ed56d838d76eedf2287f0bd6e1fffd2c5b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388902Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804891}
-
Mohamed Amir Yosef authored
Column "preferred" has been deprecated and replaced with "date_last_used" in M81. It has been left around though for a grace period to give users enough time to migrate the old values. The column is now dropped completely in M87. For users who will upgrade Chrome from 80 directly to M87, they lose their preferences for which credentials to be filled by default where multiple credentials exists per website. Since we are dropping a column, old Chrome binaries won't be able to read the current database schema anymore. Those users who use an old binary with the current database, will lose access to password manager. This should be aligned with go/cbe-downgrade-snapshot Bug: 997670 Change-Id: I6be32dfc9f17d5e165ebc236f55f95accb88c397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396119 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804890}
-
Anqing Zhao authored
We did some refactoring for Chrome app Kiosk. UsbStickUpdateAppNoNetwork case can pass stably in local now. Please let me re-enable it and keep monitoring. Bug: 1021492 Change-Id: Icfeaf4ca83de0f0b71208588b25775a73802ab50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396126Reviewed-by:
-
Rakina Zata Amni authored
For better readability of metrics Change-Id: Ibaeaf6adf59a90774e2d05b2eacf122f4840ae29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397516 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804888}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69e45dc92bd0..7f6cd0ad669b 2020-09-08 jleconte@google.com Adapt ChromePerf code to retrieve WebRTC git hash for bisection. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1123318 Tbr: rmhasan@google.com Change-Id: If12ecd4fc8d518a3593055437435f58355bf4935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398289Reviewed-by:
-
Benoit Lize authored
PartitionRoot precomputes constants that are needed in the hot path, to save branches. These constants are the same across all PartitionRoots, and they could be known at compile-time. This CL precomputes these at compile time, which saves ~1kiB per PartitionRoot, and should improve cache locality, as we have multiple partitions in use at any point. Bug: 998048 Change-Id: I36ff92b8df684c7788a1ffee7cfb160d3e4cc98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375248 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804886}
-
Wei Lee authored
Also, since shenghao@ is not in camera team now, change the owner to me. Bug: 1125686, 1125688 Test: None Change-Id: I6947dc960282b502d05202558ee9842a853df22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397515 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Disable cookie deletion button in new PageInfo UI when deletion is restricted for supervised users. Bug: 1077766 Change-Id: Iabb07fb686b761a1a3a9ca8b9c3d0f2be95f499c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396122 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#804884}
-
Frédéric Wang authored
This CL adds a web platform test to check that MathML content inside a multi-column list is still correctly laid out. It is copied from the similar relations/html5-tree/integration-point-4.html test for MathML inside SVG foreignObject. These two tests are failing because legacy layout is currently forced in the subtree containing MathML. They should pass when this issue is fixed and would crash if the legacy check mentioned on issue 1125133 is removed before this actually happens. Bug: 6606, 1125133, 829028 Change-Id: I4b060c445e551f32f1884e1676e6b48f8f5e09a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397718Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#804883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e46a2aea1478..c0ee2b2ab51b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: I6556d1e60ce28e42cf3cb2b754706b81d0b8b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397668Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804882}
-
