GitLab

This change replaces RenderThreadImpl calls in WebMediaPlayerImpl with
calls on the WebMediaPlayerParams passed into the constructor. This
removes another content/ depencency so that this code can be moved to
media/blink.

The EncryptedMediaSupport creation was moved to RenderThreadImpl and
passed via WebMediaPlayerParams to avoid linking problems that would
occur if WebMediaPlayerImpl was in media/blink.

BUG=408338

Review URL: https://codereview.chromium.org/517003002

Cr-Commit-Position: refs/heads/master@{#292741}

BUG=NONE

Review URL: https://codereview.chromium.org/519143002

Cr-Commit-Position: refs/heads/master@{#292740}

BUG=409119
TEST=Tested on Linux and Windows.

Review URL: https://codereview.chromium.org/516103004

Cr-Commit-Position: refs/heads/master@{#292739}

BUG=None
Test=None, internal cleanup.

Review URL: https://codereview.chromium.org/522563005

Cr-Commit-Position: refs/heads/master@{#292738}

R=byungchul@chromium.org,lcwu@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/517213005

Cr-Commit-Position: refs/heads/master@{#292737}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/521943002

Cr-Commit-Position: refs/heads/master@{#292736}

This is to figure out which link in RAF is broken to cause flakiness.

My current guess is the compositor scheduler issue, and these logs can confirm.

BUG=393331
TEST=bots
R=kbr@chromium.org
TBR=brianderson@chromium.org

Review URL: https://codereview.chromium.org/516663004

Cr-Commit-Position: refs/heads/master@{#292735}

This adds a browser type 'android-webview-shell' for the test
shell activity (AndroidWebView.apk), which is different from the existing
'android-webview' target that uses the device's system WebView for
testing.

Review URL: https://codereview.chromium.org/517573004

Cr-Commit-Position: refs/heads/master@{#292734}

A switch RENDERER_WAIT_FOR_JAVA_DEBUGGER is newly added to block
ChildProcessMain thread of ChildProcessService until a Java debugger is
attached.

BUG=378975

Review URL: https://codereview.chromium.org/511683003

Cr-Commit-Position: refs/heads/master@{#292733}

- Always shown during the gesture
- not showning in minimized state
- HomeCardView::SetState is no longer used. Remove it.

BUG=408825
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/521493002

Cr-Commit-Position: refs/heads/master@{#292732}

Use registry virtualization so that stale data on the test machines
don't interfere with the tests.

BUG=375739

Review URL: https://codereview.chromium.org/521703002

Cr-Commit-Position: refs/heads/master@{#292731}

Review URL: https://codereview.chromium.org/517403002

Cr-Commit-Position: refs/heads/master@{#292730}

It used to crash in nativeSetUploadData instead.

BUG=409151

Review URL: https://codereview.chromium.org/526503002

Cr-Commit-Position: refs/heads/master@{#292729}

Revert of android: Use hw acceleration in android_webview_shell (patchset #9 id:160001 of https://codereview.chromium.org/414503004/)

Reason for revert:
clang

Original issue's description:
> android: Use hw acceleration in android_webview_shell
>
> This creates a (GL)SurfaceView overlay on top of the shell
> container view which runs its own thread for rendering.
> It calls into the native draw functor through a small
> dynamic library (drawgl.so).
>
> NOTRY=True
>
> Committed: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438

TBR=boliu@chromium.org,mkosiba@chromium.org,hush@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/524933002

Cr-Commit-Position: refs/heads/master@{#292728}

Revert of Keep a copy of page id in RenderViewHost. (patchset #2 id:20001 of https://codereview.chromium.org/517813002/)

Reason for revert:
Crash data is coming in from the 39.0.2140.0 canary.  I'll revert this so that it doesn't continue reporting crashes over the long weekend.

(Sadly, the crashes so far appear to be in the browser process and not the renderer process, meaning we don't have a solid explanation yet.)

Original issue's description:
> Keep a copy of page id in RenderViewHost.
>
> This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.
>
> BUG=407376
> TEST=this may crash for a few people
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ab752e59a10a2a4c322ee7f6dbbb16a4fdb467e0

TBR=avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407376

Review URL: https://codereview.chromium.org/526493004

Cr-Commit-Position: refs/heads/master@{#292727}

This add methods to compositor_util.cc to compute the number of
raster threads to be used in the renderer process. Then this number
is passed to the renderer process explicitly instead of just forwarding
a command line flag blindly.

If the renderer will use more than one thread, chrome://gpu will report
that "Multiple Raster Threads" is enabled, otherwise it shows disabled.
If the --num-raster-threads command line argument is used to force more
than one thread, then it will show Force enabled.

There is no change in behaviour with this patch, it still uses one thread
unless forced otherwise on the command line.

BUG=237669

Review URL: https://codereview.chromium.org/519923002

Cr-Commit-Position: refs/heads/master@{#292726}

getnameinfo has a slightly different signature on bionic.

TEST=./build_tools/build_sdk.py --bionic

Review URL: https://codereview.chromium.org/523043004

Cr-Commit-Position: refs/heads/master@{#292725}

This line can't be reached because it's already guarded by a check to IsAutofillable().

Also, change a method signature to take a const ref.

BUG=none

Review URL: https://codereview.chromium.org/512993002

Cr-Commit-Position: refs/heads/master@{#292724}

WebView passes the correct viewport and transform for tile
priority in both hardware and resourceless software draws. As
a result, PictureLayerImpl does not need to treat
resourceless software draws differently.

BUG=398587

Review URL: https://codereview.chromium.org/517893002

Cr-Commit-Position: refs/heads/master@{#292723}

Revert of Landing Recent QUIC Changes. (patchset #1 id:1 of https://codereview.chromium.org/515303003/)

Reason for revert:
Reverting to see if it fixes the following issue. Crash rate has gone up by 10 times.

BUG=409191

Original issue's description:
> Landing Recent QUIC Changes.
>
> Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.
>
> Merge internal change: 74239145
> https://codereview.chromium.org/509203003/
>
>
> Remove PacketType from QUIC because the QUEUED type is not used and the
> other types can be reduced to a bool.
>
> Merge internal change: 74148481
> https://codereview.chromium.org/515003003/
>
>
> Don't send a QUIC SCUP message until after handshake confirmed.
>
> A server config update was occasionally being sent before the crypto
> handshake was complete, causing the client to close the connection.
>
> Merge internal change: 74132773
> https://codereview.chromium.org/516713002/
>
>
> Change TransmissionInfo's all_transmissions SequenceNumberSet* to
> default to NULL, and only be present if there are multiple transmissions.
>
> Estimated to save ~2% of CPU.
>
> Merge internal change: 74076012
> https://codereview.chromium.org/509073004/
>
>
> Log the quic version for internal server tracing.
> Not used in production.
>
> Merge internal change: 74069715
> https://codereview.chromium.org/514043002/
>
>
> Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
> deque.
>
> Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
> on tools/quic/end_to_end_test.cc.
>
> Merge internal change: 74054196
> https://codereview.chromium.org/514033002/
>
>
> Unit test for empty packet closes QUIC connection bug.
>
> Merge internal change: 74041239
> https://codereview.chromium.org/495423011/
>
>
> Log the QUIC transmission type in QUIC internal server trace visitor.
> Not used in production.
>
> Merge internal change: 73895739
> https://codereview.chromium.org/514023002/
>
>
> Not used in production. Log whether a QUIC packet sent was a crypto
> packet or not for internal server side tracing.
>
> Merge internal change: 73894063
> https://codereview.chromium.org/515003002/
>
>
> Fix a QUIC bug in which PING frames were not being ACK'd.
>
> Merge internal change: 73837644
> https://codereview.chromium.org/512933005/
>
> R=rch@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949

TBR=rch@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/523813003

Cr-Commit-Position: refs/heads/master@{#292722}

scale_factor was not used at all.
scroll_offset was not being used correctly. This CL now grabs the scroll offset from the CompositorFrameMetadata in RenderWidgetHostView.

BUG=none
TBR=kenrb@chromium.org for code deletion in view_messages.h + browser_plugin_messages.h

Review URL: https://codereview.chromium.org/525523003

Cr-Commit-Position: refs/heads/master@{#292721}

Refactors the migration tests to no longer reuse the same
StatusChangeChecker.

Splits the previous MigrationChecker into two separate classes:
MigrationWaiter and MigrationWatcher.  The waiter is long-lived
and observes migrations.  The waiter exists only while we're
waiting for a migration to complete.

BUG=97780, 95742

Review URL: https://codereview.chromium.org/490643004

Cr-Commit-Position: refs/heads/master@{#292720}

BUG=395240
TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/420663003

Cr-Commit-Position: refs/heads/master@{#292719}

This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).

NOTRY=True

Review URL: https://codereview.chromium.org/414503004

Cr-Commit-Position: refs/heads/master@{#292718}

The coded size should always be rounded up to multiples of 16 pixels to accomodate
alignment requirements of HW encoders, while the visible size reflects the actual
content size.

Update video capture messages to pass visible rect from browser to renderer process.

BUG=402501
TEST=verify that non-multiple-of-16-pixel capture works and no black border is shown
R=dalecurtis@chromium.org, hclam@chromium.org, palmer@chromium.org

Review URL: https://codereview.chromium.org/500653003

Cr-Commit-Position: refs/heads/master@{#292717}

- Rename to tools/resources/list_unused_grit_header.py.
- Handle structures of type "FOO_{LEFT,RIGHT,TOP}".
- Add ability to scan files and folders.

NOTRY=true

Review URL: https://codereview.chromium.org/524743002

Cr-Commit-Position: refs/heads/master@{#292716}

The problem is that some locales (Hindi) or platforms (Linux) have a
bigger base font size for the default font (crbug.com/405994). If this
is the case, we should decrease the font size to the one we expect,
so that the font fits in the button correctly.

Just adjusting the baseline is not always enough, as the new avatar
button has a fixed size, and the text might not fit correctly
regardless of the baseline adjustments.

Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMRHc5WTBxZWNrRm8&usp=sharing

BUG=403466
TEST=Start Chrome with --enable-new-avatar-menu on Linux, or with --enable-new-avatar-menu and --lang-hi on Windows. The avatar button text should fit nicely in the button.

Review URL: https://codereview.chromium.org/470053004

Cr-Commit-Position: refs/heads/master@{#292715}

Everything seems to run fine locally.

BUG=270920

Review URL: https://codereview.chromium.org/513543007

Cr-Commit-Position: refs/heads/master@{#292714}

Allow special characters such as spaces in filenames.

Also includes some general cleanup, and documentation.

Review URL: https://codereview.chromium.org/15854004

Cr-Commit-Position: refs/heads/master@{#292713}

BUG=none
TEST=compile
TBR=dnicoara
NOTRY=true

Review URL: https://codereview.chromium.org/518303002

Cr-Commit-Position: refs/heads/master@{#292712}

https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/519933002

Cr-Commit-Position: refs/heads/master@{#292711}

Override the main() function from libppapi_stub, and rather than
simply failing when PPAPI is missing, assume that we are running
in sel_ldr and jump directly to the user's main function.

As a nice side effect this removes the needs to SEL_LDR=1 builds.

Review URL: https://codereview.chromium.org/412083002

Cr-Commit-Position: refs/heads/master@{#292710}

BUG=NONE
TEST=manually
NOTRY=true

Review URL: https://codereview.chromium.org/519903002

Cr-Commit-Position: refs/heads/master@{#292709}

NOTRY=True

Review URL: https://codereview.chromium.org/521453003

Cr-Commit-Position: refs/heads/master@{#292708}

Revert of Disable BrowserTest.InterstitialCloseTab which is flaky. (patchset #1 id:1 of https://codereview.chromium.org/424143003/)

Reason for revert:
This should be fixed by r288895

Original issue's description:
> Disable BrowserTest.InterstitialCloseTab which is flaky.
>
> BUG=393218
> TBR=mattm@chromium.org
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286225

TBR=mattm@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393218

Review URL: https://codereview.chromium.org/523733003

Cr-Commit-Position: refs/heads/master@{#292707}

This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.

BUG=404066

Review URL: https://codereview.chromium.org/480453002

Cr-Commit-Position: refs/heads/master@{#292706}

pa_stream_flush() returns a pa_operation object on success, so we must unref it by calling pa_operation_unref() to avoid memory leaks.

BUG=238493

Review URL: https://codereview.chromium.org/520613003

Cr-Commit-Position: refs/heads/master@{#292705}

This component handles the protocol between Chrome and an associated phone for
the Easy Unlock and Easy Sign-in features.

The system is currently implemented as a Chrome packaged app, and this is the
first step in migrating this functionality to native code. We will gradually
reimplement the system and switch from the app to this component once the
refactoring is complete.

BUG=385719

Review URL: https://codereview.chromium.org/505373004

Cr-Commit-Position: refs/heads/master@{#292704}

BUG=
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2f985cb

Committed: https://chromium.googlesource.com/chromium/src/+/26bbbb9

Review URL: https://codereview.chromium.org/516683002

Cr-Commit-Position: refs/heads/master@{#292703}

This CL also makes ApplicationRunnerChromium use MessagePumpMojo by default

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/506353002

Cr-Commit-Position: refs/heads/master@{#292702}