- 12 Oct, 2018 40 commits
-
-
Gauthier Ambard authored
This CL changes the header of the "Articles for you" section of the NTP to have a better support for the "accessibility" categories of preferred content size chosen by the user. Bug: 893524 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee Reviewed-on: https://chromium-review.googlesource.com/c/1273522 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599145}
-
Gauthier Ambard authored
This CL adds Dynamic Type to the cell displayed when the NTP's articles section is empty. Bug: 893527 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be Reviewed-on: https://chromium-review.googlesource.com/c/1273536 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599144}
-
Florent Castelli authored
This reverts commit aa6c62dc. Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402 Original change's description: > Move InstallAttributes to chromeos/settings > > Necessary for moving CrosSettings to chromeos/settings, so it > can eventually be used by Mustash. > > The following changes were necessary: > 1. Move install_attributes{.h, .cc} and unit_test.cc > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn > (destination) > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h, > which is included by install_attributes.h > > 4. Unfortunately, that same dependency lead to a circular dependency. > I was able to avoid that by separating out a "common_constants" rule in > components/policy/core/common, so that chromeos/settings only depends on > that, and not on all of components/policy. So I had to change > components/policy/core/common/BUILD.gn > and I removed an unnecessary include from > components/policy/core/common/cloud/cloud_policy_constants.cc > > 5. Update #include directives for install_attributes to point to new > location. This is the other 22 files, all with diffs of +1 -1. > > Bug: 446937 > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288 > Reviewed-on: https://chromium-review.googlesource.com/c/1264757 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: A Olsen <olsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599140} TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org Change-Id: I50c58b55830961d97834d86a76088dc50eff672d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 446937 Reviewed-on: https://chromium-review.googlesource.com/c/1278748Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599143}
-
Fergal Daly authored
This is the new syntax agreed for partmap. Bug: 805271 Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2 Reviewed-on: https://chromium-review.googlesource.com/c/1278566 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#599142}
-
Alexander Alekseev authored
Bug: 894280 Change-Id: I0d478790d35323008a0622404ebde6983fea06ae Reviewed-on: https://chromium-review.googlesource.com/c/1278211 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599141}
-
A Olsen authored
Necessary for moving CrosSettings to chromeos/settings, so it can eventually be used by Mustash. The following changes were necessary: 1. Move install_attributes{.h, .cc} and unit_test.cc 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn (destination) 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h, which is included by install_attributes.h 4. Unfortunately, that same dependency lead to a circular dependency. I was able to avoid that by separating out a "common_constants" rule in components/policy/core/common, so that chromeos/settings only depends on that, and not on all of components/policy. So I had to change components/policy/core/common/BUILD.gn and I removed an unnecessary include from components/policy/core/common/cloud/cloud_policy_constants.cc 5. Update #include directives for install_attributes to point to new location. This is the other 22 files, all with diffs of +1 -1. Bug: 446937 Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288 Reviewed-on: https://chromium-review.googlesource.com/c/1264757Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599140}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fb7986d8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02 Reviewed-on: https://chromium-review.googlesource.com/c/1278059 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599139}
-
Roman Sorokin authored
Otherwise install attributes are not loaded on the linux Chrome OS build. TEST=manual Bug: 848615, 729596 Change-Id: I445b2b337b707822459c076058610f49f02767ab Reviewed-on: https://chromium-review.googlesource.com/c/1264643 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#599138}
-
Alexander Alekseev authored
Bug: 852553 Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525 Reviewed-on: https://chromium-review.googlesource.com/c/1250136 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599137}
-
Luciano Pacheco authored
Change DirectoryModel to "unwrap" VolumeEntry when it's selected via file list. This fixes the issue where after selecting a VolumeEntry any operation in the private API would fail because it wouldn't be able to send a VolumeEntry to private API, because it requires a real Entry. This fixes the user issue of trying to rename and always getting "Use shorter name" error, even with a short name. Update FakeEntry to be an implementation of FilesAppDirEntry, since all users were using as directory, also update some functions to typing to use FilesAppDirEntry instead of FakeEntry which is more correct. Test: browser_tests --gtest_filter="*/myFilesFolderRename" Bug: 889636 Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad Reviewed-on: https://chromium-review.googlesource.com/c/1276067Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599136}
-
Alexandre Courbot authored
libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make it return 0 planes for single-plane multiplanar formats. We obviously cannot have a multiplanar format with 0 planes, so add a workaround at the fake-ioctl level. Implement it as a case-switch for future-proofing against other workarounds we will likely have to add. Also add a few recommendations in v4l2_device.cc against the temptation to spare some memory by using an appropriately-sized array of v4l2_planes: it turns out libv4l2 also likes to write above the number of passed planes, and using anything shorter than VIDEO_MAX_PLANES will result in memory corruption DCHECKS being raised. BUG=893661 TEST=Checked that VDA unittest was passing on both hana and nyan_big. Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225 Reviewed-on: https://chromium-review.googlesource.com/c/1275727 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599135}
-
Jochen Eisinger authored
Depending on the sync / sign-in state. BUG=890925 R=tangltom@chromium.org, msarda@chromium.org Change-Id: I784f13a4981250f851df770d111a13969a6892a6 Reviewed-on: https://chromium-review.googlesource.com/c/1273521 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#599134}
-
Yuta Kitamura authored
This CL moves the most of implementation for Thread in Platform to Thread, so the Platform would contain less implementation (ideally, Platform should be a pure interface to embedders). Previously the global state of threads was stored in Platform, and this CL moves it to Thread. Now the thread-local storage for Blink threads and the main and compositor thread objects are stored as the global variable in thread.cc. This way, the threads state is completely separated from Platform. Old threading functions in Platform are deprecated now, and they will be migrated to Thread ones later. Due to those changes, some test utilities need to be updated. As the state of threads is not stored in Platform, the tests that need to override their main thread have to do that by themselves. To facilitate this, two new utility classes, ScopedMainThreadOverrider and ScopedSchedulerOverrider, are introduced, and TestingPlatform- SupportWithCustomScheduler is removed in favor of the new utilities. Bug: 826203 Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058 Reviewed-on: https://chromium-review.googlesource.com/c/1273115 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#599133}
-
Eliot Courtney authored
This CL introduces a new BoundsChangeAnimationType for ClientControlledState which will animate the window bounds for a specified duration. Bug: b/115291749 Bug: 841886 Test: Tested with local PIP prototype - applies animation. Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881 Reviewed-on: https://chromium-review.googlesource.com/c/1218385 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#599132}
-
Gauthier Ambard authored
This view was used in the old ReadingList implementation. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874 Reviewed-on: https://chromium-review.googlesource.com/c/1276966Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599131}
-
Alexander Alekseev authored
Bug: 852553 Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae Reviewed-on: https://chromium-review.googlesource.com/c/1249496Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#599130}
-
Amos Lim authored
Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl. Unify C++ template files to cc.tmpl Bug: 894684 Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a Reviewed-on: https://chromium-review.googlesource.com/c/1278567Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#599129}
-
Joel Hockey authored
Shown when crostini and flag crostini-files are enabled. Links to chrome://settings/crostini/crostiniShared. Record UMA for clicks. Bug: 878324 Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020 Reviewed-on: https://chromium-review.googlesource.com/c/1277130 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22 Created with: gclient setdep -r src-internal@7781cb9daa22 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e Reviewed-on: https://chromium-review.googlesource.com/c/1278303Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599127}
-
momohatt authored
Spec requires that during the update of service workers, request headers for fetching main scripts should include "Service-Worker" field, while that for fetching importScripts() resources should not. This patch adds WPT tests to validate this behavior. Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f Reviewed-on: https://chromium-review.googlesource.com/c/1267297 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599126}
-
Noel Gordon authored
Now we have the QuickView <webview> infra to detect the 'loaded' state of the <webview> content, add a <file-safe-media> audio test, and also check the <webview> renders its content on a transparent black body. This test exposed an issue in Blink node code. When the modal <dialog> is calling showModal(), its flat tree distribution can be out-of-date, causing a DCHECK crash when testing if the Quick View <dialog> element contains sibling <iframe id="command-dispatcher"> [1]. Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires that its node arguments have up-to-date flat tree distribution. Ensure the <dialog>'s flat tree distribution is up-of-date _before_ trying to propagate the "inert" bit into sub-frames. Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html [1] Known crash reports already exist: issue 789094 issue 804047. test: browser_tests --gtest_filter="QuickView*openQuickViewAudio" Bug: 891150, 789094, 804047 Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961 Reviewed-on: https://chromium-review.googlesource.com/c/1264138 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599125}
-
John Z Wu authored
Namely, it is OK to call it multiple times. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a Reviewed-on: https://chromium-review.googlesource.com/c/1278061Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#599124}
-
Henrik Grunell authored
This reverts commit dfeab488. Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091 Original change's description: > [Video Capture, Test] Make tests requiring real webcam fail if it's not found > > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and > add checking whether webcam is found or not. > Accordingly, exclude such test cases from test suites for devices that have no > camera. > > Bug: 893494 > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado) > and it failed. > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado) > and it passed. > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin) > and it passed. > > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7 > Reviewed-on: https://chromium-review.googlesource.com/c/1276407 > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599097} TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893494 Reviewed-on: https://chromium-review.googlesource.com/c/1278272Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#599123}
-
Jochen Eisinger authored
Instead, require an email to opensource-licensing@ again until we figured out the new process. R=jam@chromium.org Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c Reviewed-on: https://chromium-review.googlesource.com/c/1275846Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599122}
-
yiyix authored
Bug: 879379 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1277953Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#599121}
-
Maksim Sisov authored
This CL fixes a fullscreen state changes before the surface is activated. That is, Wayland may ignore fullscreen changes before the surface is activated. Thus, store a pending state, and once the surface is activated, trigger the change. Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a Bug: 843018 Reviewed-on: https://chromium-review.googlesource.com/c/1275885Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#599120}
-
Christopher Cameron authored
Fix a few places where we would dereference a BridgedNativeWidgetImpl which is null when out-of-process. This doesn't guarantee correct behavior, but avoids a crash. Make WebContentsNSViewBridge::Show resize the web contents view and also all of its children. Bug: 859152 Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342 Reviewed-on: https://chromium-review.googlesource.com/c/1278533Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#599119}
-
Trent Apted authored
atomicops.h uses `volatile` which inhibits some compiler optimisations without contributing to threading correctness. Define AtomicFlag::IsSet() in the header, rather than out-of-line. Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver in base_perftests are up to 70% greater. Bug: 891536 Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d Reviewed-on: https://chromium-review.googlesource.com/c/1278425 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#599118}
-
Sam McNally authored
Bug: 891197 Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113 Reviewed-on: https://chromium-review.googlesource.com/c/1277133Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599117}
-
Alexandre Courbot authored
The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that makes it fail if the number of planes of the passed v4l2_buffer does not exactly match the number of planes of the currently set format. This CL implements a workaround by first running a VIDIOC_G_FMT ioctl in AllocateBuffers(), and then passing the returned number of planes to the buffer constructor so the correct value can be passed to VIDIOC_QUERYBUF. And since we have this value, we also use it in VIDIOC_DQBUF. BUG=893661 TEST=Checked that VDA unittest was passing on hana (Tegra devices have another bug that is fixed in the next CL). Change-Id: I830334de1cf322302fd476ac5535313ebc65900d Reviewed-on: https://chromium-review.googlesource.com/c/1275726 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#599116}
-
Trent Apted authored
These functions are currently in file_manager/file_manager/common/js/unittest_util.js which has a lot of files-app specific stuff that media apps shouldn't depend on. - Move MockAPIEvent to the only unittest (in gallery) that uses it. - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js - Updates the remaining handcrafted foo_unittest.html files in the files app * combination sed-script and manual edit. Bug: 879035 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1 Reviewed-on: https://chromium-review.googlesource.com/c/1275545 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599115}
-
Yuki Yamada authored
This CL renames some ambiguous name of scope and context in JSBasedEventListener::handleEvent(). Split from another one: https://chromium-review.googlesource.com/c/chromium/src/+/1270300 Bug: 872138 Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608 Reviewed-on: https://chromium-review.googlesource.com/c/1277135Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#599114}
-
rajendrant authored
This CL does a bunch of steps to make the servicification easy to do. 1. Removes the usage of ServiceName in data_use_measurement 2. Refactors the data use update to metrics service to not take service name and instead send if the data use is from metrics component. 3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(), ChromeDataUseMeasurement is introduced that does the posting to UI thread (from io_thread.cc). This helps in servicification since there won't be thread hop. This also helps when CDUA classes are removed, and ChromeDataUseMeasurement can be there without dependency. Bug: 808498 Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48 Reviewed-on: https://chromium-review.googlesource.com/c/1272256 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599113}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s' 2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error. 2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS 2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock Created with: gclient setdep -r src/third_party/chromite@e2727ef6f5dc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453 Reviewed-on: https://chromium-review.googlesource.com/c/1278301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599112}
-
Patti authored
This reverts commit 86da6573. Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 Findit found culprit 598844 with 75% confidence, so reverting this to try and fix. Original change's description: > [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering. > > * The service shouldn't unregister from the topics, when handler > the Handler is unregistering from topic (as stated in the documentation > for for UnregisterHandler). > * Sync shouldn't unregister on browser shutdown > > Bug: 801985, 876274 > Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76 > Reviewed-on: https://chromium-review.googlesource.com/c/1196522 > Commit-Queue: Tatiana Gornak <melandory@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598844} TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org Change-Id: I70fa87c3476925814408665644acb23c3c1f1614 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801985, 876274, 894715 Reviewed-on: https://chromium-review.googlesource.com/c/1278273Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599111}
-
Yuki Yamada authored
This is the bug fixing for previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1253317 v8::HandleScope was not named. Bug: 894069 Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533 Reviewed-on: https://chromium-review.googlesource.com/c/1278548 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#599110}
-
Jinsuk Kim authored
TabWebContentsObserver is TabWebContentsUserData which is created for the first active WebContents for a given Tab, and finally destroyed together with the Tab. There was a bug creating multiple instances of the observer for every new active WebContents. This left an instance for old WebContents undestroyed, and caused a reported bug for already nulled out WebContents references while handling an event that should not have been triggered. This CL makes sure there will be a single TabWebContentsObserver for Tab. Bug: 894353 Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312 Reviewed-on: https://chromium-review.googlesource.com/c/1278426Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#599109}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8f4bc41c4231..a54daf162fac git log 8f4bc41c4231..a54daf162fac --date=short --no-merges --format='%ad %ae %s' 2018-10-11 benwright@webrtc.org Reland "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h" 2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d052f4b..37b6d53f (598839:598967) Created with: gclient setdep -r src/third_party/webrtc@a54daf162fac The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3d22153c1dd390398aa7dda8a0f8a00d032fc627 Reviewed-on: https://chromium-review.googlesource.com/c/1278298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599108}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f Created with: gclient setdep -r src-internal@aebffd21b13f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe Reviewed-on: https://chromium-review.googlesource.com/c/1278300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599107}
-
Kunihiko Sakamoto authored
This fixes a bug where Resource Timing for prefetched Signed Exchange had negative duration value. Bug: 803774 Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8 Reviewed-on: https://chromium-review.googlesource.com/c/1278546Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599106}
-