- 28 May, 2019 40 commits
-
-
Kush Sinha authored
If an online login through Gaia is forced at the Chrome OS login screen, we should be able to debug the reason behind it. Fix this by adding logs for the case when an online login is forced. Bug: 964691 Change-Id: I31db5ed4e280108bf5234c1e9ecd89fcee2ecba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617448Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663827}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33d3be2b8bdb..0210991491ea Created with: gclient setdep -r src-internal@0210991491ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Idc5d9b691f309f45e79c20b128b54ab3d4bf852f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631145Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663826}
-
Nina Satragno authored
Call AuthenticatorEnvironment::DisableVirtualAuthenticator() when RenderFrameHostImpl is destroyed. This prevents leaking memory if the virtual environment is enabled for a frame host that is later destroyed, and prevents an indirect use-after-free when a new render frame host is assigned to the same memory position as a previous one. This bug was discovered by findit: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWNmNDAzZjliMzcxMGVjYTVkYmM1YjJiY2U5MmYyYTY1YzdiN2M1Mgw Bug: 967032 Change-Id: Iae241c72904be46526bcaf1aa533749e66a34d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629069Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#663825}
-
Lukasz Anforowicz authored
This CL adds CORB coverage for: 1) text/event-stream, application/x-www-form-urlencoded, based on the code review discussion in a previous CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1604244/4/services/network/cross_origin_read_blocking.cc#227 2) application/gzip, which wasn't mentioned explicitly in the CR discussion above, but which is ranked #212 in the spreadsheet mentioned in https://github.com/whatwg/fetch/issues/860#issuecomment-457330454 and therefore probably should have been included in r659671 together with x-gzip (ranked #54) and zip (ranked #71). Bug: 802836 Change-Id: I8c10f900110a2cb471437a19425bfd5e38aed2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628809Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#663824}
-
Lucas Tenório authored
Bug: 943242 Change-Id: I5674869d925a8345cb314020f76a71bfd20f9d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628827Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#663823}
-
Dominic Battre authored
A bunch of interactive_ui_tests from AutofillInteractiveTests.* are flakily timing out on the win7 builders. This CL enables pixel outputs. Hopefully that reveals why the tests time out. Bug: 967588 Change-Id: Icc6296fbb324fe0e2920807afa6a6ceea121b691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632330 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663822}
-
Jacob DeWitt authored
There are slightly different code paths to handle the disconnect for immersive and non-immersive sessions. There can only be one immersive session, but there can be multiple non-immersive sessions and they all use the same magic window provider as their data provider. Bug: 937906 Change-Id: I71f05fa2d854c2654744e818d407e4b94a2fd95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628269Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#663821}
-
Yves Arrouye authored
Bug: chromium:947743 Test: unit tests Change-Id: I3041651936dea5e6080f0a1fb15f80b5c65b361d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631896 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#663820}
-
Friedrich Horschig authored
The address controller will be asked to provide addresses only once when it is initialized. After that, it needs to push any changes made to profiles whenever they change. For that purpose, observe the PersonalDataManager as soon as it was used for the first time. Bug: 967380 Change-Id: Ia6b1ad02edce92b31e5d4951f06ae8933be3fed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631594 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#663819}
-
Rune Lillesveen authored
A more robust way of making sure the features are set back to its original state for other tests. Change-Id: I4187c7eba820006736c8f49bc8ac85aaa359dc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632189Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#663818}
-
tzik authored
CookieStore on workers uses the default task runner to handle the async IPC completion, which is deprecated. This CL updates the IPC endpoint set up to use per-frame task runner for finer priority control. Bug: 961186 Change-Id: I45db9728d1315b31d0b570578bff34fe6be9cdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626923 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663817}
-
Natalie Chouinard authored
The Protected Content menu should always be visible now. Remove checks that are no longer necessary now that we've ended JB support. Bug: 923477 Change-Id: If9ef76e1399dbc754f31dbd9ceb23447b4cfcc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628995Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#663816}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I98b470753bd88c50a616bc4454fc1585083c6ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629691 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#663815}
-
Caroline Rising authored
No change is being made to functionality. TabRendererData currently gets the visible url, this change updates the variable name to reflect this. Bug: 910739 Change-Id: I7a0bf0e07dc05b5a6f42c20da04c64fe614bc2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632554 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#663814}
-
jonross authored
We recently updated four Chrome GPU bots to 16.04, in order to debug a bad Vulkan state. We pinned linux_nvidia_quadro_p400_experimental to this in: https://chromium-review.googlesource.com/c/chromium/src/+/1626338 However some angle_perftests and angle_end2end_tests crash with this configuration. We suspect that 16.04 is not a good choice for these bots. We have plans in crbug.com/966502 to update the bots to 19.04. In the interim I am pinning this configuration back on 14.04 which was working Bug: 967039 Change-Id: I749cd57a8d5907de40f9db968201633af22017c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631638Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#663813}
-
Scott Violet authored
It's unused. BUG=none TEST=none Change-Id: I4314c2f987b1511254a7cdddbe2ae7cecd23431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632301Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663812}
-
Bill Orr authored
\\?\VIRTUAL_DIGITIZER was detected as a gamepad on some machines. Bug: 961774 Change-Id: If16d122572ba1aec5f6978b10a69b3b0f9049511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628333 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#663811}
-
Shimi Zhang authored
My fix aosp/943625 didn't make the new release, it only reached dev repo, we need to disable this test until next release. Bug: 967173 Test: android_webview/tools/run_cts.py -f=android.webkit.cts.WebViewTest#testGetContentHeight --cts-release O, test didn't run. Test: android_webview/tools/run_cts.py -f=android.webkit.cts.WebViewTest#testGetContentHeight --cts-release N, test didn't run. Change-Id: Iff6be933a264361ca430e6b9ba70430bbaa1602c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631897Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#663810}
-
Kevin Bailey authored
This CL only adds a flag for a previously added feature: group suggestions by search vs URL. Bug: 966462 Change-Id: I37d956baadad1a2bb5ea9968f4959933c0c61b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631299 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#663809}
-
Victor Hugo Vianna Silva authored
Instead of taking a pointer as an argument and returning whether the fetch was successful, we can just return the pointer directly, yielding nullptr in case of failure. Change-Id: I9710b832a6e51eb5112a62af81d54906d5c1cc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626000 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#663808}
-
Xing Liu authored
This CL adds the owner file in the java code directory. Bug: 930968 Change-Id: I2537cf0b38d460036b2a794d4f090b29e9696cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628941Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#663807}
-
Jose Leal Chapa authored
Devtools: Add performance histogram to track how long it takes for remote modules to be loaded from the devtools frontend. Change-Id: Icc4249a00e04f008f8c1d1b5bda97a31333822e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610460Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Jose Leal <joselea@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663806}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9ab520e24bb9..07fc398ca8d7 git log 9ab520e24bb9..07fc398ca8d7 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 13f6824c..9809faf8 (663612:663719) 2019-05-28 terelius@webrtc.org Fix text logging of ALR detector experiment settings. 2019-05-28 srte@webrtc.org Cleanup of CongestionWindowDownlinkDelay trial. Created with: gclient setdep -r src/third_party/webrtc@07fc398ca8d7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide1841ffca498a9789afaed0895ef921cd2aab45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663805}
-
James Cook authored
We're not running ash out-of-process, so this doesn't need to be an IPC interface. Continue the pattern of SessionController / SessionControllerClient. Add a public interface and SystemTray::Get() in //ash/public/cpp, with the backing private impl inside //ash. Use that public interface to set the client instance. Move locale information to //ash/public/interfaces/locale.mojom. That can be converted to a C++ enum later if we want. TBR=msw@chromium.org Bug: 958219 Test: existing browser_tests Change-Id: I41eb23273d88aceb6de1fa6cff141df8c526ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625838 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#663804}
-
Bill Orr authored
If a user is tricked into holding down enter before requesting a session, and letting it up after the dialog shows, the consent dialog will be quickly dismissed and consent given without the user really intending. This change sets focus to the deny button so the malicious page won't be able to trick users into giving consent through key-jacking. Bug: 965631 Change-Id: Iad4ce135a4933f56bbf629a649e8f3876be2b2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626683 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/68951d2c..604b5dab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id60b174b0a01356f8141261ea1c207dd11a2c2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632611Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663802}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/176b214f91bc..53146121b8ab git log 176b214f91bc..53146121b8ab --date=short --no-merges --format='%ad %ae %s' 2019-05-28 herb@google.com Call bulk advances in SkPDFMakeCIDGlyphWidthsArray 2019-05-28 robertphillips@google.com Use sk_memset* in GrFillBufferWithColor 2019-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms feba95f66c08..ca5b4470be98 (1 commits) 2019-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 5b8149aaf52b..feba95f66c08 (1 commits) Created with: gclient setdep -r src/third_party/skia@53146121b8ab The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I4fa6f0bb2a87f385cfa9e929ff8af041afc1e5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631134Reviewed-by:
-
Morten Stenshorne authored
The constraint space has several resolution sizes, depending on what we're to resolve. There's "available size", "percentage resolution size" (and "replaced percentage resolution size"), and even "percentage resolution inline-size for parent writing mode". The latter is used when resolving percentage based margins and padding. This works when staying within LayoutNG, but when we need to enter legacy layout for some child, we convert all those values into something that legacy layout understands, and dumb down the number of values to basically 3 (plus two optional values); see BoxLayoutExtraInput. Avoid setting an indefinite containing block inline-size, since we use this value to resolve percentage padding and margins. The test included only *crashed* without this fix (it rendered correctly if DCHECKs were bypassed), but I figured it would be useful to have a test for correct rendering in this case as well. Bug: 966795 Change-Id: Ia2a2ede55a257b41dc38236a8bb0ff689e75a310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631370 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663800}
-
Emily Stark authored
For converting HTTP auth to committed interstitials, we'll need to be able to access the AuthChallengeInfo in the navigation stack, to pass from there into the interstitial itself. The interstitial needs this information to insert credentials into the auth cache when the user enters them. In contrast, today the auth challenge info is stored with the request itself, and the request hangs around waiting for the user to enter credentials which are then put into the cache. With committed interstitials, the request completes while the auth prompt is shown, so the interstitial code will keep track of the AuthChallengeInfo for inserting into the cache, instead of the request itself. This CL plumbs the AuthChallengeInfo from HttpResponseInfo out of URLRequest to ResourceResponse. Subsequent CLs will plumb it through the navigation code into the committed interstitial code. (Specifically: NavigationHandle will have an auth_challenge_info() getter similar to its ssl_info() getter, and a NavigationThrottle will create a LoginHandler to show the login prompt and hang on to the AuthChallengeInfo from the NavigationHandle.) Bug: 963310 Change-Id: I2c79e50b29c9a598efa074d4554424408286886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625831 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#663799}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I4cfaba445e9492b99fb1fb2cbcb4d0980447c109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630814Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#663798}
-
Yi Su authored
This CL moves RequiresContentFilterBlockingWorkaround function into wk_web_view_util so that it can be shared by CRWWKNavigationHandler and CRWWebController. Bug: 956511 Change-Id: I011413d885233d02daaf6ce7c0ea3c9ff197afe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631416Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663797}
-
Georges Winkenbach authored
1. Search + Fn + F3 should trigger zoom window. 2. With keyboard setting treat-top-row-keys-as-function-keys, Search + <function key> should trigger corresponding action. Updated event-rewriter unit tests. Bug: 966894 Test: Build and deploy chrome on device, manually check top-row keys. Change-Id: Ied7b2267cf0fbdfbf46484585a32b488a4406a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626490 Commit-Queue: Georges Winkenbach <gwink@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#663796}
-
Jarryd authored
This change alters how per host quota is calculated. Specifically, there is a case where users have low disk space availability where the quota is based off available disk space. This change ignores that branch of logic for users that have the StaticHostQuota Finch study enabled. The study is disabled by default, but will be enabled for 100% of users, starting with Dev/Canary and moving up the channels to Stable. Keeping this behind a Finch study allows us to disable this change with a single line change to Finch. Bug: 965710 Change-Id: Icd5ed59c1c592ccd9554395427f6707210376271 Signed-off-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625744Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
-
kylechar authored
Merge CompositorOverlayCandidateValidator class into OverlayCandidateValidator. The inheritance hierarchy was a relic of historical code structure and not really necessary anymore. Also rename CompositorOverlayCandidateValidator<Platform> classes to shorten names. Bug: 963597 Change-Id: I0f242f069e3bfc540f57b0add3b2be9a00f495bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629290Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#663794}
-
Caleb Raitto authored
This library is supposed to be excluded from LSAN, but somehow we're still seeing leaks from this library [1]. Fix this by excluding the path to the library in third_party. Leave the existing entry in case it's somehow catching other libfontconfig leaks. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914727183139935872/+/steps/browser_tests__with_patch_/0/logs/Deterministic_failure:_PDFExtensionInternalLinkClickTest.CtrlLeft__status_CRASH_/0 Bug:961017 Change-Id: I8869755987ff595e9df634dc3d997f0eb136cf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614437 Commit-Queue: Alexander Potapenko <glider@chromium.org> Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#663793}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 2 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::QueryURL thus removing a naked "new" and the use of base::Unretained and base::Owned to pass the value to both callbacks - change QueryURLCallback to be invoked with a QueryURLResult instead of three values thus allowing to remove an helper function - change HistoryBackend::QueryURL to return the result by value instead of via an out parameter - add move and copy assignment operator to QueryURLResult Bug: 812523, 714018 Change-Id: I7907802824c7c51b6d1457b522e519bae6a9ad2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631377 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663792}
-
Tatiana Buldina authored
Bug: chromedriver:1231 Change-Id: I4be96e0105cc6e854a7ef01ad9d0dc4dd965ec6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627552Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#663791}
-
Mohamed Amir Yosef authored
Bug: 967713 Change-Id: I0fb0800c6d4fc3b114556f0ec70450a46eb18157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632230 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/51e9e5659a55..7e01e4e0d6b7 git log 51e9e5659a55..7e01e4e0d6b7 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 capn@google.com Support images with linear tiling for transfers Created with: gclient setdep -r src/third_party/swiftshader@7e01e4e0d6b7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/119620767,chromium:b/132437008 TBR=swiftshader-team+autoroll@google.com Change-Id: Ia42166a4e193c1f3bf87d37e7713c3fe111a54c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631133Reviewed-by:
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=georgesak@chromium.org Bug: 887407 Change-Id: I12017f988c1ec4c04ce0ce3a52725bc6b9b62240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632258 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663788}
-
