- 11 Mar, 2020 40 commits
-
-
Kevin Babbitt authored
AXPlatformNodeDelegate::GetFocus() returns the node within the called node's subtree that currently has focus. When an element in web content has focus, and a delegate in Views is asked for focus, that delegate can only reach as far as the web content root. Calling GetFocus() again on the web content root ensures that the platform API returns the currently focused node. Bug: 928811 Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#749386}
-
Robbie McElrath authored
This CL makes WebLayer delete ALL of its data during startup if it detects that it was downgraded to a lower major release since the previous launch. The previous version is maintained in a SharedPreference. Bug: 1043217 Change-Id: I12c90d6705be4563a2e3bf07712f96a1136d96c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052601 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#749385}
-
Hazem Ashmawy authored
This shows WebView Developer UI launcher icon for beta channels for all build variants including standalone WebView, Trichrome and Monochrome. It also make the check to show/hide the icon for Monochrome less frequent by listening to Activity#STARTED instead of RESUMED. Fixed: 1060405 Test: Build beta channels of Trichrome, standalone WebView and see the icon Test: Build beta Monochrome and select it as WebView provider and see the icon Change-Id: I9cb5c57bdf9b8488523caaa6fe8a98a0d46adb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096959 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749384}
-
dpapad authored
Bug: None Change-Id: I68574edf3f94422f9dc87edb9a31fc29b163483f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099027 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749383}
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: Ide133ebd853491aa53b2009bad7fb3208e6b6349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097943Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749382}
-
Pavel Yatsuk authored
This CL moves InfoBarInteractionHandler, InfoBarLayout, InfoBarCompactLayout and related resources to chrome/browser/ui/messages BUG=1056346 R=mdjones@chromium.org Change-Id: Id1000a4d5cfbb7c4e04c3f70284470f728bc0283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088183 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#749381}
-
Henrique Nakashima authored
Also allow any "*InstrumentationTest.java" to depend on chrome/android even if in a module. Bug: 1053463 Change-Id: Idfac74521187a4d8ee923732cbaf8e6bee108b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080579Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#749380}
-
Aaron Leventhal authored
Fixes an apparent coding error to now mirror AXNodeObject::AddChildren(), where the owned children correctly get a parent. Note: the duplication between the 2 methods is disturbing, and the code should be refactored to be less repetitive. Bug: None Change-Id: Ib6bbc20680cdfb017e417de073640742fa15349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092909Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749379}
-
dalyk authored
The automatic mode radio button description is broken into two lines. The privacy policy line and custom text field are left-aligned with the dropdown menu. This cl also adds accessibility labels. Bug: 1040145 Change-Id: I4b1d62f91c87e328f5869e2e77740127a9fd196f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087703Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#749378}
-
Sergey Ulanov authored
Moved common code to helper function to reduce code duplication. Change-Id: I5a9eb369e70e2fcf3ef520004089ece479935654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092950 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53effe844c9a..d52eddaad2fb git log 53effe844c9a..d52eddaad2fb --date=short --first-parent --format='%ad %ae %s' 2020-03-11 ehmaldonado@google.com scm: Fix bug when checking for valid revision and add tests. Created with: gclient setdep -r src/third_party/depot_tools@d52eddaad2fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie812cec6962eccf20282ccd7ba20e3bf40d44b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097842Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749376}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7004f998c7ba..71d8ec363794 git log 7004f998c7ba..71d8ec363794 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rmhasan@google.com [Telemetry] Add general debug and release tags for desktop browsers Created with: gclient setdep -r src/third_party/catapult@71d8ec363794 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045339 Tbr: eseckler@google.com Change-Id: Iabcdb9d3f58eb496101f080b1c8e4419e864b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749375}
-
Jimmy Gong authored
- If a scheme is unspecified, we will default with ipps. - If that fails then we will fallback with ipp with port 631. Bug: 1045651 Test: end to end manual Change-Id: Id25cc700340913c6f3df6a7e508c2341d6913cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086687 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#749374}
-
Ken Rockot authored
This moves Python library code out of mojo/public/tools/bindings/pylib/ and into mojo/public/tools/mojom/. Note that duplicate nested mojom/ directory name is intentional: the repository will be named "mojom" and the top-level directory will contain documentation and scripts, as well as other subdirectories. The "mojom" subdirectory is then the home of the parser's Python modules. This is all in preparation to mirror mojo/public/tools/mojom/ in a read-only repository. Bug: 1060467 Change-Id: I33c32f2c6b402b227408f8e5f1fc8c40be4dd3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098849 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#749373}
-
Jonathan Ross authored
When running with SkiaRenderer on Windows, this test is flaking. TBR=kylechar@chromium.org skia_renderer_gl_blink_web_tests Test: media/video-controls-visibility-multimodal-mouse-after-touch.html Bug: 1060773 Change-Id: Ib276b749f6f61248a8f5811880e1429005422005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099303Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#749372}
-
Nate Chapin authored
This actually changes the structure, so that LocalDOMWindow inherits ExecutionContext, rather than Document. I left as much logic as I could on Document, and had LocalDOMWindow call in to it. A few things needed to move for consistency, and I moved anything where the Document override of a ExecutionContext function was only called through the ExecutionContext interface. Added null-checks and updated code to final format where it was necessary to keep tests passing, otherwise left transitional code/helpers intact. Updated many unit tests that needed an ExecutionContext to use DummyPageHolder instead of just a standalone Document. Bug: 1029822 Change-Id: I8e8a477b5f58569cef5d6fb44ca02299ea3a80d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092560Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#749371}
-
Saman Sami authored
If the first LocalSurfaceId provided by the parent has a child sequence number greater than 1, we should use that number. This is a speculative fix for https://crbug.com/1051625 Bug: 1051625,1043109 Change-Id: I8b5fb86d42aa6e087e64c9e86a1de703e0b74723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092417 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#749370}
-
Tricia Crichton authored
When request origin is specified, verify that it is localhost or an explicitly whitelisted ip address. This protects against cross-domain attacks and header spoofing. Bug: 1045787 Change-Id: I65336d77e29ed0dec775bf4db40f0a274c03bcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090305 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749369}
-
Alison Maher authored
Add fragmentation support for fieldset legends. Unit tests added to NGFieldsetLayoutAlgorithmTest. The following work remains in order for legend fragmentation to be considered complete and will be addressed in follow-up changes: 1. Making sure the fieldset border starts at the correct offset during fragmentation when a legend is added. 2. Web tests will need to be added to test #1, as well as other potential fragmentation scenarios. 3. Get fragmentation working in the case of a large border and small legend, and add a unit test for this. 4. Refactor to reduce the amount of code in the Layout() function. 5. Handle fieldset content with a negative margin border start correctly. Bug: 875235 Change-Id: Idf1947af4ca9b26892bc6fc76e72cc1bbec4afa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090762 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#749368}
-
Jonathan Ross authored
When ramping up SkiaRenderer + Vulkan coverage on Android we saw a high rate of flakes around FeatureList startup. We disabled all tests that saw this. No other test has demonstrated this flake since, and a lot of development of SkiaRenderer and Vulkan has occurred since. We are re-enabling these, but will re-disable if new reproductions show up. This affects the GPU FYI bot: 'Android FYI SkiaRenderer Vulkan (Pixel 2)' TBR=backer@chromium.org TEST= NavigationBrowserTest.HistoryBackCancelPendingNavigationUserGesture/1 SitePerProcessBrowserTest.* TextFragmentAnchorBrowserTest.DisabledOnScriptNavigation/0 vulkan_content_browsertests Bug: 1012372 Change-Id: I4b6add8cec0eb4072000e09515916b928856676c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097153Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#749367}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72abb04e33fa..f5c744d6f172 Created with: gclient setdep -r src-internal@f5c744d6f172 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041473,chromium:937821 Tbr: jbudorick@google.com Change-Id: I8e78ca78294c19d9d6ca1bcd84bfbcb95a66928b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093107Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749366}
-
Peter Wen authored
Removes duplicate entries in the sources list for feed. Fix errorprone warnings about wrong argument order in assertEquals. Tbr: mkwst@chromium.org for trivial reordering of args to assertEquals. Bug: None Change-Id: I971385ec599e48c57284acc7bc6eba04cabb8f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099102Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749365}
-
Chris Cunningham authored
Adds predictors for non-network rebuffer (NNR) and consecutive "bad windows" with high counts of dropped frames. The predictions will be compared against configurable thresholds for determining smooth=true/false for a given MediaDecodingConfiguration. Bug: 1049339 Change-Id: Ia80a9cdc887c070f8156b58a0da64d02318fda40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021950 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#749364}
-
Mitsuru Oshima authored
Next step: * Consolidate string grd file into single shortcut_viewer_strings.grd * Remove NewWindowDelegate::ShowKeyboardShortcutViewer and open it directly. * Remove KSV_EXPORT TBR=thakis@chromium.org Bug: 1046624 Change-Id: I86f8aecea09d67d3f1e5ee6234c5c6792bb87063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094760Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#749363}
-
Lukasz Anforowicz authored
This CL takes //content/public/common/context_menu_params.h and splits it into: 1. //content/public/common/*untrustworthy*_context_menu_params.h which contains: - UntrustworthyContextMenuParams - CustomContextMenuContext (type of a field under UntrustworthyContextMenuParams) 2. //content/public/*browser*/context_menu_params.h which contains: - ContextMenuParams Bug: 534561 Tbr: avi@chromium.org Tbr: michaelbai@chromium.org Tbr: tapted@chromium.org Tbr: reillyg@chromium.org Tbr: hidehiko@chromium.org Tbr: shaktisahu@chromium.org Tbr: jinsukkim@chromium.org Tbr: jochen@chromium.org Tbr: mcnee@chromium.org Tbr: knollr@chromium.org Change-Id: Ie6cd124327a423604e33970e099723dedfb8d1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097468 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749362}
-
Patrick Monette authored
The comment was reworded to reduce repetitions and now references worker nodes. Bug: 993029 Change-Id: Id854cbfa86fc8367e98a5057cd002f9c034f67e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094712 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#749361}
-
Moe Ahmadi authored
Change-Id: I9ea3144f0eb659c8b4bd64be364d056267e6d606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099103 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749360}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cbf7f5178da6..066e6a62edcc git log cbf7f5178da6..066e6a62edcc --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com Platform: Add IP Address Fields to InterfaceInfo Created with: gclient setdep -r src/third_party/openscreen/src@066e6a62edcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5b9c96ea6b323c5d26917de414353d4946da1833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749359}
-
Jan Wilken Dörrie authored
This change adds a TOO_MANY_PASSWORDS_AND_QUOTA_LIMIT case to the PasswordCheckState enum. This distinction is relevant for users that are unable to use the online Password Checkup to check the passwords saved in their Google account. Bug: 1047726 Change-Id: If8b28c7db8cd9eb10e0de9e1291f3a97627db9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098682 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749358}
-
Piotr Bialecki authored
Invisible input sources should not cause their hit test results to be surfaced to the application. Change-Id: Id6aff539db20981d78d57098b2f0335ca352319b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098852 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#749357}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I291af7ef2ac95083b0f1e4b59e39b7006b7a4ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095199Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#749356}
-
Donn Denman authored
Converts the server-debug setting used for CoCa integration debugging from a single value to a mixin so we can include that at any level of integration. Also adds support for the exact-search bit as a CoCa integration mixin due to lack of support for the additional parameter needed to support this critical feature correctly. The need for this is covered in issue 1060669. BUG=1060669, 1059004, 956277, 985518 Change-Id: I53d5a9acf114e1b84f8821ddf05283eabcd1c30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098489 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749355}
-
Arthur Eubanks authored
Pointers are only guaranteed to be castable to an integer of at least the same size. gperf currently generates something like {(int)(long)&(foo), bar}, Replace it with {static_cast<int>(reinterpret_cast<uintptr_t>(&(foo)), bar}, Bug: 1059231 Change-Id: Ic68a92f8239ec0d51485f17ac5ada91b7617636e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098763Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#749354}
-
Christian Dullweber authored
Screenshot: https://crbug.com/1060118#c9 Bug: 1060118 Change-Id: Ia645b0e54bb959fba678c8acf8c451f7f51c147a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096765Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#749353}
-
Matt Jones authored
The CompositorViewRezsiser has been replaced by ApplicationViewportInsetSupplier, this patch replaces the password utility's usage of it. Bug=1048183 Change-Id: I83b56da97495e78fb0a47d12f3073912a1e7f786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033375 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#749352}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 63d2d5bd. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 2594f643 "Fix timeout in update-and-send-events-replacment.html" f9c54ec3 "Support getAnimations() for ShadowRoot" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2b522541f29488295be46821cf97c9bf312ebc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098502Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749351}
-
Jonathan Ross authored
On Linux ATI GPU conformance/more/functions/bindBuffer.html has an occasional GPU crash. Marking as RetryOnFailure to address its flaky nature until root cause can be deteremined. TBR=ynovikov@chromium.org TEST=conformance/more/functions/bindBuffer.html webgl_conformance_gl_passthrough_tests Bug: 1060632 Change-Id: If3483e5edc7c81d352fa708253d16269bee50d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097841Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#749350}
-
Brian Sheedy authored
Switches uses of PrintResult in blink_heap_unittests to PerfResultReporter and whitelists it for conversion to histograms before being uploaded to the perf dashboard. Bug: 923564 Change-Id: I5278ed703b2644eac7fbe7b547ed8dcc94eb8e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095926Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#749349}
-
Hailey Wang authored
Used to analyze traces uploaded via Slow Reports when draw intervals above the 99th percentile threshold are detected. Bug: 1055890 Change-Id: I64c97de8ffcd9d288f5c71a85bdd79789f704d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083431Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#749348}
-
Rouslan Solomakhin authored
Before this patch, both "abort" and "can make payment" shared a PaymentEventResultCallback type, which creates a lot of code churn when only one of the event types needs an update. This patch splits PaymentEventResultCallback into CanMakePaymentCallback and AbortCallback. After this patch, changing the parameters for "can make payment" callback will be easier. Bug: 1005076 Change-Id: I0df01a8a8b4551a16f1949d77ffd546df7ea5702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091646 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749347}
-