GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/be87f1c..75d0e9b

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/1137693005

Cr-Commit-Position: refs/heads/master@{#329607}

- ContinueSessionRestore() should ensure SESSION_RESTORE_PREPARING state.
  Otherwise, /MergeSession is not called after /ListAccount because it would
  not be considered as is_pre_merge;
- Cover SESSION_RESTORE_PREPARING state in connection change event;

BUG=487476

Review URL: https://codereview.chromium.org/1137253003

Cr-Commit-Position: refs/heads/master@{#329606}

This runs the full suite of tests with the AppListMixer field trial set
to both "default" and "Blended", for full coverage of both code paths.

Also, MixerTest.Basic now has different expectations in the "Blended"
case, because the mixing behaviour has (deliberately) changed.

BUG=487494

Review URL: https://codereview.chromium.org/1128683005

Cr-Commit-Position: refs/heads/master@{#329605}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/24dae38..be87f1c

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1126333004

Cr-Commit-Position: refs/heads/master@{#329604}

BUG=485955
NOTRY=true
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1137763003

Cr-Commit-Position: refs/heads/master@{#329603}

The goal is to remove all dependencies from test_runner on content

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1140863002

Cr-Commit-Position: refs/heads/master@{#329602}

Adds the "AppListMixer" Finch experiment, affecting the search result
ranking and mixing in the App Launcher. By default, the mixer behaves
exactly as before. With the "Blended" option, results are selected and
ordered more naturally according to their relevance to the query, rather
than in arbitrary groups ("apps, then omnibox, then webstore, then
people").

Specific changes under the "Blended" option:

- Replaced the per-group "boost" with a per-group "multiplier". Now,
  instead of stratifying results from each group, they are mixed
  together according to the relevance score assigned by the provider.
  Some groups have a multiplier to de-prioritize them (people results
  x0.85, webstore results x0.4). This means that relevance scores now
  need to be comparable between groups!

- Removed the 6-result limit from the mixer. It can now return an
  arbitrary number of results, which will later be truncated by the
  view. (This is necessary because the view now supports more than 6
  results, since all app results take up a single row.)

- The per-group limit is now a "soft" limit. If there aren't enough
  total results to fill a minimum quota of 6, we go back and get as many
  results as we can from each group.

- The omnibox group is no longer special. Previously, it had no limit,
  but would only provide more than 1 result if there was room. Now, it
  has a soft limit of 4, and behaves the same as other groups (can
  provide more results if necessary).

Can be enabled with --force-fieldtrials=AppListMixer/Blended.

BUG=487494,460451,422610,338418

Review URL: https://codereview.chromium.org/1113483002

Cr-Commit-Position: refs/heads/master@{#329601}

Cr-Commit-Position: refs/heads/master@{#329600}

The CL lets DriveUploader use batch request API. DriveUploader does asynchronous
preparation before calling API on service interface. To hold batch request
during the asynchronous preparation, the CL introduce refcounted hepler class,
which manages life time of batch request configurator.

BUG=451917
TEST=DriveUploaderTest

Review URL: https://codereview.chromium.org/1134633003

Cr-Commit-Position: refs/heads/master@{#329599}

BUG=378127
R=kalman@chromium.org,asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1137783005

Cr-Commit-Position: refs/heads/master@{#329598}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9fa4ee7..24dae38

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1130653005

Cr-Commit-Position: refs/heads/master@{#329597}

BUG=

Review URL: https://codereview.chromium.org/1134013004

Cr-Commit-Position: refs/heads/master@{#329596}

These tests are timing out.

TBR=oshima@chromium.org
BUG=487501

Review URL: https://codereview.chromium.org/1134043006

Cr-Commit-Position: refs/heads/master@{#329595}

Revert of Use cert config options in SSLServerSocketOpenSSL. (patchset #4 id:80001 of https://codereview.chromium.org/1138813003/)

Reason for revert:
It seems like this change has caused new leaks on Linux and ChromeOS.

First build it appeared: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/41241

Log output:
Memcheck:Leak
fun:calloc
fun:PORT_ZAlloc_Util
fun:ConvertToSID
fun:ServerSessionIDLookup
fun:ssl3_HandleClientHello
fun:ssl3_HandleHandshakeMessage
fun:ssl3_HandleHandshake
fun:ssl3_HandleRecord
fun:ssl3_GatherCompleteHandshake
fun:SSL_ForceHandshake
fun:_ZN3net18SSLServerSocketNSS11DoHandshakeEv
fun:_ZN3net18SSLServerSocketNSS15DoHandshakeLoopEi
fun:_ZN3net18SSLServerSocketNSS21OnHandshakeIOCompleteEi
fun:_ZN3net18SSLServerSocketNSS14OnRecvCompleteEi
fun:_ZN3net18SSLServerSocketNSS18BufferRecvCompleteEi

This might be tickling some bug in underlying libraries, or it might be a problem with the change itself.

You can reproduce the leak by running valgrind and running all the SSLServerSocket tests. I didn't narrow down which test.

See https://www.chromium.org/developers/how-tos/using-valgrind for more details on using valgrind.

Original issue's description:
> Use cipher suite config options in SSLServerSocketOpenSSL.
>
> Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites
> list and require_forward_secrecy flag from SSLConfig. Fixed
> SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL.
>
> BUG=481163
>
> Committed: https://crrev.com/d0eae58087e6f45088d6ef349d9ebaa2da450ea1
> Cr-Commit-Position: refs/heads/master@{#329528}

TBR=davidben@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481163

Review URL: https://codereview.chromium.org/1131573005

Cr-Commit-Position: refs/heads/master@{#329594}

BUG=483283

Review URL: https://codereview.chromium.org/1113683003

Cr-Commit-Position: refs/heads/master@{#329593}

BUG=457697

Review URL: https://codereview.chromium.org/1138163002

Cr-Commit-Position: refs/heads/master@{#329592}

This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel|
enum into a class of their own: |ConnectionSecurityHelper| in
//chrome/browser/ssl (since it is applying Chrome-specific security
policy to determine the security level of a page).

Later, we will use the new |ConnectionSecurityHelper| class to compute a
security level for a page to send to the DevTools Security
panel. Specifically, we need to be able to calculate the security level
for a given page, not just the WebContents for the active tab.

BUG=484392

Review URL: https://codereview.chromium.org/1123943002

Cr-Commit-Position: refs/heads/master@{#329591}

Removed the concept of max_results == 0 meaning "unlimited" in mixer
groups. Now, the omnibox group is specifically considered unlimited (and
all other groups have a defined maximum).

BUG=487494

Review URL: https://codereview.chromium.org/1139493004

Cr-Commit-Position: refs/heads/master@{#329590}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/69b829f..9fa4ee7

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1133663005

Cr-Commit-Position: refs/heads/master@{#329589}

Allow an Intent navigation even when a user types if a URL is server redirect and has an external protocol

BUG=487282

Review URL: https://codereview.chromium.org/1136443004

Cr-Commit-Position: refs/heads/master@{#329588}

TBR=oshima@chromium.org
BUG=487500

Review URL: https://codereview.chromium.org/1141693002

Cr-Commit-Position: refs/heads/master@{#329587}

These tests are consistently failing and have been for some time.

TBR=oshima@chromium.org
BUG=484910

Review URL: https://codereview.chromium.org/1138383002

Cr-Commit-Position: refs/heads/master@{#329586}

TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1136363002

Cr-Commit-Position: refs/heads/master@{#329585}

TBR=oshima@chromium.org
BUG=487492

Review URL: https://codereview.chromium.org/1140593004

Cr-Commit-Position: refs/heads/master@{#329584}

Review URL: https://codereview.chromium.org/1128313004

Cr-Commit-Position: refs/heads/master@{#329583}

TEST=Checked manually with a test server.
BUG=None

Review URL: https://codereview.chromium.org/1127273004

Cr-Commit-Position: refs/heads/master@{#329582}

This is for making type of file_to_install and file_display_name_ consistent.

BUG=486616

Review URL: https://codereview.chromium.org/1129103006

Cr-Commit-Position: refs/heads/master@{#329581}

This is necessary because it is one of the dependencies of the
'blink_tests' group that should be built.

BUG=483171
R=avi@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1131773004

Cr-Commit-Position: refs/heads/master@{#329580}

Previously this was called --linux-only which was a little
misleading since this flag is really used to detect when
it running via the hooks.

Review URL: https://codereview.chromium.org/1099003002

Cr-Commit-Position: refs/heads/master@{#329579}

BUG=449816

Review URL: https://codereview.chromium.org/1128683003

Cr-Commit-Position: refs/heads/master@{#329578}

BUG=485381

Review URL: https://codereview.chromium.org/1130113005

Cr-Commit-Position: refs/heads/master@{#329577}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/76a74c1..69b829f

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1138373003

Cr-Commit-Position: refs/heads/master@{#329576}

Cr-Commit-Position: refs/heads/master@{#329575}

This is used to rank apps and webstore results. This should not (really)
affect the relative ranking of any results, only the absolute scores
that they are assigned internally. However, this will be relevant in the
future when we start comparing scores of different types of results
against each other.

The algorithm (used to score app and webstore results) now has a
different tapering formula, designed to reach a higher score with fewer
keystrokes. Previously, it was based on the percentage of the full title
you had typed (which unfairly de-prioritized apps with long titles, such
as "Google Keep - notes and lists"). Now, it has an exponential curve,
so you get a reasonably high score with just a few letters matched, and
then it tapers off, approaching 1.0 as you type more letters.

BUG=422610

Review URL: https://codereview.chromium.org/1138193002

Cr-Commit-Position: refs/heads/master@{#329574}

BUG=486236
TEST=manually tested.

Review URL: https://codereview.chromium.org/1141563002

Cr-Commit-Position: refs/heads/master@{#329573}

There was no icon specified for the <paper-icon-button> for closing the WebUI. This adds the "close" icon for this <paper-icon-button>.

Review URL: https://codereview.chromium.org/1139663003

Cr-Commit-Position: refs/heads/master@{#329572}

The first is 1be16298:
"Clear the onMessage and onDisconnect listeners when their Extension Port is destroyed."
which was a fix to the original patch.

The second, original patch is 32b3a84b:
"Move the Extension Port implementation out of messaging.js into its own file port.js."

This is the key patch, which has caused no end of trouble. The goal was noble:
to fix the myriad of bugs which messaging has due to being written in JS not
C++. It appears that the moral of the story is: this is impossible, and the
hole we've dug in over the last 5 years cannot be recovered from (without a
complete rewrite, I suppose).

The last .5 of a patch was one of the tests added in
b9dca054 which will no longer pass.

BUG=486715,477323,475536
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1131043003

Cr-Commit-Position: refs/heads/master@{#329571}

BUG=485381
NOTRY=true

Review URL: https://codereview.chromium.org/1134553006

Cr-Commit-Position: refs/heads/master@{#329570}

BUG=485381

Review URL: https://codereview.chromium.org/1137103002

Cr-Commit-Position: refs/heads/master@{#329569}

BUG=485381

Review URL: https://codereview.chromium.org/1125343005

Cr-Commit-Position: refs/heads/master@{#329568}