- 22 Oct, 2020 40 commits
-
-
Ian Struiksma authored
This is a reland of 4e484a8f Disabled flaky test separately (crrev.com/c/2490849) so no change from original CL. Original change's description: > Give test hooks to allow autofill test to keep popup open > > On some test bots, mac dock or external values cause the browser to > make minor resizings of the frame. These are extraneous to our tests > so we would like to ignore those during tests. > > This CL provides a test hook by adding test access methods to > ChromeAutofillClient to make the autofill popup more > resistant to hiding from frame resizes, and then has AutofillUiTest > access that hook when running Interactive UI tests. > > This re-enables autofill interactive tests on mac bots. > > > Bug: 967588 > Change-Id: Id9e25988f0cf64f0aa0631a48d48eb982b116c34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473802 > Commit-Queue: Ian Struiksma <ianstruiksma@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818550} Bug: 967588 Change-Id: I605a05e69636e5dbbf7e240c882bf1406b1a3eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490868Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#819846}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Icda023abc2c5105c1796913cde5b94aaca7a4438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480627 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819845}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I944746422982223a5580db531c7bb3e6e94434fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819844}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c5f7774fc2a..f3ec9833e881 2020-10-22 jvanverth@google.com Fix storage class issues for push constant variables. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I1a76ecd737355f01fb8c4b028d5f8c0c29bbb319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491685Reviewed-by:
-
Ben Wagner authored
It is possible that a memory dump will be requested before the blink font manager is set. This can result in attempting to create a fallback font manager and ignoring the real one which may be set later. Avoid this situation by ensuring that the memory dump request does not implicitly cause a global FontCache to be created just to dump that it is empty. Bug: chromium:1140954 Cq-Include-Trybots: luci.chromium.try:win_chromium_dbg_ng Change-Id: If29d830c66f85552663384898fbf3d29fb6d67e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490503 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#819842}
-
Jan Wilken Dörrie authored
This change implements notifying the PasswordAutofillAgent about automated text changes to confirmation password fields if the user manually modifies a previously generated password. Bug: 1140499 Change-Id: Ia52e71819c608ee9aa9a574a4afbc7858c02ed23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489916Reviewed-by:
-
Fredrik Söderqvist authored
Introduces a new child-content-management class for use by LayoutSVGRoot and LayoutSVGContainer. Moves shared child management code from SVGLayoutSupport to it, namely: LayoutChildren(), HitTestChildren(), ComputeHasNonIsolatedBlendingDescendants() and ComputeContainerBoundingBoxes() Besides allowing nicer code-sharing (and thus depopulating SVGLayoutSupport) it also allows better handling of derived, and other, state relating to the collection of children. Change-Id: I009a9bcde670fa6f994a9195b08f2f58683b5370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489643Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#819840}
-
Brian Ho authored
SkiaRenderer uses the |are_contents_opaque| property to selectively enable alpha blending [1]. Without it, underlays will be entirely occluded by the "transparent" quad. This CL sets the |are_contents_opaque| property for quads replaced by underlays. Since this will be needed on all platforms that will use SkiaRenderer (e.g. ChromeOS and Cast), this CL moves the relevant logic up from DCLayerOverlayProcessor [2] into RenderPassInternal directly. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/skia_renderer.cc;l=1209;drc=1bcf9a08d9f39a91a37d025bb78c7877cfc525aa [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/dc_layer_overlay.cc;l=754;drc=36971a950ef4b6d8fe1a4e90382cca6eb2dfda37 Bug: 1114290 Change-Id: Ib7b8b389492457a6bbeb2fb913bd1706e04511ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354465 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819839}
-
Alex Turner authored
This is a reland of ed0b0d99 The UkmWorkerBrowserTests should now always have the identifiability study enabled, which was the cause of the previous failures. Original change's description: > Emit a UKM event on client connection to a ServiceWorker > > Whenever an execution context (whether a window or worker) becomes a > client of a service worker, the renderer will now inform the respective > ServiceWorkerContainerHost of the client's ukm::SourceId once it is > execution ready. This id will be passed to SWIdentifiabilityMetrics, a > new SWContextCoreObserver. This observer will them emit a UKM event > (Worker.ClientConnected) in order to associate the ServiceWorker's > ukm::SourceId with the client's. DedicatedWorkers' ukm::SourceIds are > not included as they exactly match that of their parent execution > context. > > This association is required both for attributing entropy consumption of > workers to sites, but will also help to gain insight into the cross- > connectivity between first-party contexts via shared and service > workers. Design doc (internal-only): > https://docs.google.com/document/d/1mx4-zI53cskB8j75Mis2q3rVrO8uHeJpwGuT8psbURA/edit?usp=sharing > > Bug: 1085645, 1134193 > Change-Id: I7d1728ebe15d162b980dd2e552622e4c4f91edc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321059 > Commit-Queue: Alex Turner <alexmt@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818555} Bug: 1085645 Bug: 1134193 Change-Id: I958c842277a91266b4f3f74a37ddfb1db67265b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485589Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819838}
-
Denis Kuznetsov authored
Discover app was replaced by Showoff app (crbug.com/1042109) without being launched. The only relevant part of Discover code is the PIN setup dialog during OOBE/First login UI that is kept for now. Fixed: 1110625 Bug: 1104120 Change-Id: I4df4edbbb0768996264c70735133ce63e9cc1912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487640Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819837}
-
Adithya Srinivasan authored
Throttle isn't safe browsing related and doesn't needed to be guarded by a safebrowsing flag check. Change-Id: Ie59c7a9c87141b378cecc5ba4befdb97d21a2ca2 Bug: 1141329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490168Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#819836}
-
Josh Nohle authored
Nearby Share optionally supports automatic switching from Bluetooth to WebRTC to improve transfer speeds. Because the WebRTC implementation is not yet functional, disable the automatic switching behind a flag. This flag will provide greater flexibility when debugging and also for the upcoming dogfood. Fixed: 1141072 Change-Id: Iec20a8ca68de7ad1c472b8597b54264c768f5b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487685Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#819835}
-
W. James MacLean authored
Bug: 975702 Change-Id: I5693cf8045d032395890ec0d39e3cfc6347770b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488040Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#819834}
-
Hiroki Nakagawa authored
As the first step to introduce the Prerender2, this CL adds some browser-side classes in content/browser/prerender/ and implements basic functionalities like prerendering with a new WebContents and swapping to the prerendered contents. All new implementations are behind a new `blink::features::kPrerender2` flag. These are not integrated in navigation code yet. <Details> See the design doc for details: https://docs.google.com/document/d/15N-HYdSnItZyDIqRFui5OVzYFcNwxtq7kYkKBx3J3xQ/edit?usp=sharing This CL... - adds the new `blink::features::kPrerender2` flag. - reuses the existing Blink-side implementation and mojo interfaces for the current prerender (no-state-prefetch). Implementations of the mojo interfaces are switched based on the feature flag in the browser interface binders. - adds content::PrerenderProcessor that implements blink::mojom::PrerenderProcessor and works as the browser-side entry point of prerendering. This is created per prerender request (see comments on the mojom interface for details) and owned by mojo::UniqueReceiverSet on the initiator RenderFrameHostImpl. When Start() on the processor is called from a renderer process, this instantiates a new PrerenderHost, and forwards the request to the host. - adds content::PrerenderHost that creates a new WebContents and starts prerendering with that. Then navigation code is expected to find this host from content::PrerenderHostRegistry and swap in the prerendered WebContents upon navigation. This is created per prerender request and owned by content::PrerenderHostRegistry. Note that creating a new WebContents is a tentative approach. This will by replaced by the MPArch later. - adds PrerenderHostRegistry that manages running prerender hosts. This is created and owned by StoragePartitionImpl. Note that once the MPArch is ready, this will be scoped to WebContents, not StoragePartitionImpl. Change-Id: I9d8e802f3c7778e971d159dd6b4300d35ecce9d1 Bug: 1132746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409473 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This is a reland of c2d62d36. This is safe to reland because it got reverted due to the issue that has been fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=1108676. Original change's description: > [Longtasks] Fix buffering before observer > > When we shipped longtasks with buffered flag, we forgot to remove a > check that would prevent longtask creation when there's no observer. > This CL fixes this and adds a test for this case. It also moves the > UseCounter to the observe() method. > > Bug: 1131385 > Change-Id: I2911b9ab044db7394bcf64f64b1e599959cbdc37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463594 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816664} Bug: 1131385 Change-Id: I8640abc566fc7eceaf44e80c04d23ca59182542d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491100Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819832}
-
Mihai Sardarescu authored
This CL attempts to simplify a bit the the call to enable sync from the native promos that are single account. Bug: 1140978 Change-Id: Ie085da9775a3c81b9457b077ef283ca0b4f77576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490107 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#819831}
-
W. James MacLean authored
At present ChildProcessSecurityPolicyImpl::SecurityState stores only a single BrowsingInstanceID (the lowest) even though its associated process may contain multiple BrowsingInstances. This may lead CanAccessDataForOrigin to consider the wrong BrowsingInstance when performing its checks for opt-in isolated origins. This CL converts SecurityState to track an ordered set of all the BrowsingInstanceIDs so that they can all be checked. CanAccessDataForOrigin is modified to return 'true' if *any* BrowsingInstance in the set would allow the access, otherwise it returns 'false', and logs the failure reasons for each of the BrowsingInstances. This CL also includes delayed cleanup of BrowsingInstance state from ChildProcessSecurityPolicy when BrowsingInstances are deleted. This avoids memory leaks but may pose a small risk of renderer kills. We will monitor the CanAccessDataForOrigin crash keys to see if such cases occur in practice. Bug: 1135539 Change-Id: Icb7d25a84601b378c0c495a19266cd013667136a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446370Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#819830}
-
Elizabeth Popova authored
AddressEditor.Purpose.AUTOFILL_ASSISTANT is defined but no longer used. Now autofill assistant uses AddressEditor.Purpose.PAYMENT_REQUEST, see [1]. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/user_data/AssistantCollectUserDataBinder.java;l=672 Change-Id: Idb67ca782c7c9f28d24e3bda722ac31d2f77a736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489994Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#819829}
-
W. James MacLean authored
Bug: 1092510 Change-Id: I0b7d7c4ea94f91767fd2a4e6c7c807bfc73a8fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490226Reviewed-by:
-
Matt Menke authored
LoadTimingBrowserTest.HTTP is flaking for unknown reasons. The only unusual thing it obviously does before it hangs is use the chunked handler in the SpawnedTestServer. We want to reduce usage of that test server, anyways, so this adds an equivalent handler to the EmbeddedTestServer. This CL also removes the legacy chunked handled from the SpawnedTestServer, and migrates the small number of consumers off of the SpawnedTestServer. Bug: 1138769 Change-Id: Ia63be2326349f2019a1052cc04e9a708f9a2f4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481702Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819827}
-
Ioana Pandele authored
Bug: 1141018 Change-Id: I44c9516636f5ab8c3610aa272b725329c2fe911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489912Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#819826}
-
Ben Mason authored
This reverts commit 54eea645. Reason for revert: Rejected by Play: crbug/1141430 Original change's description: > Reland "Enable isolated splits in canary" > > This is a reland of b9d174e5 > > This time component builds should be actually fixed with > http://crrev.com/c/2490668. > > Original change's description: > > Enable isolated splits in canary > > > > All known issues have been fixed so enabling this in canary to see if > > there are any major problems. > > > > Bug: 1126301 > > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819200} > > TBR=agrieve@chromium.org > > Bug: 1126301 > Change-Id: I71afd73c704deb6c7d65a76c6ea8a2b6f0b6fb57 > Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490871 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819681} TBR=agrieve@chromium.org,cduvall@chromium.org Change-Id: I99bddb7d0f1a370ce811f212159b04b98aa7ad49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126301 Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489998Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819825}
-
Jan Krcal authored
This CL introduces a timeout so that profile creation is not blocked on the lack of extended account info. This is useful when the request gets blocked by a firewall, etc. When this happens, the account email address is used as the name of the new profile instead of the account's given name. Bug: 1126913 Change-Id: I6e251caed78800ee075295f6677c7db3d7d44d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489911 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603346243-3f07f08fc669370b6060ed7693324b959ad870ad.profdata to chrome-linux-master-1603367983-f14ef1ec6eb1e2af5431460b8d6073dd67a6ea14.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e84091ec11695ae6eb78cc9a751e7fcdd68305a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491962Reviewed-by:
-
Camillo Bruni authored
Preparation for landing https://crrev.com/c/2487123 which changes the error location for failing module imports. Bug: v8:6513 Change-Id: I4ad7dc72782b9cb94bd4effbc447627f4944044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489993Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819822}
-
David Bienvenu authored
This is an attempt to fix oom crashes in SetRegValueWorkItem::DoImpl when the current registry value for keys it is trying to set are ginormous. When rollback is disabled, DoImpl doesn't need to read the current value, and thus hit OOM. Bug: 1106328 Change-Id: Id70bc05732ce7e1401d5fe706f81e1f9f1283087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488923Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819821}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c5210c268e2..ae7f748fc467 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115604,chromium:1138425 Tbr: beverloo@google.com Change-Id: Id3c363f03781eedb33a332941a5b6cf505ea0c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819820}
-
Matt Jones authored
This patch simplifies the SceneOverlay API by providing the LayerTitleCache to the LayoutManager and directly to the features that actually need it. Bug: 1070281 Change-Id: I564c4b8d91f2c5026e97163e4b4532421f08af4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480882Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819819}
-
Tanmoy Mollik authored
Remove unused class SyncOffPreference and the resource xml file that is only used in this class. Bug: 1139896 Change-Id: I0ce6ecf5203f8c682e4f965ffe66e57204dcf5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484450Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819818}
-
Monica Basta authored
This CL deletes 'signin_icons' and replaces all usage of 'signin:business' with 'cr:domain'. Change-Id: Ifa234f23af00f0d45e2b528ad4b1d37f3568f2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490045Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#819817}
-
Javier Ernesto Flores Robles authored
bug: 1138710 Change-Id: I9c1c787837d6c64e7ef88c66bf9070bb7d073547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477236Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#819816}
-
Reilly Grant authored
These tests were broken by User Activation v2 because they assumed that an activation is inherited by cross-origin child frames. The tests have been updated to use test_driver.click() in the iframe to create their own activation. Bug: 860713 Change-Id: I5b3d6d17d97098eaa1689e77f5fc112002f76795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491683 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819815}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ded46963acfa..4492cf287a23 2020-10-22 yangguo@chromium.org [ts] Type-check DOMStorageItemsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79edc4380cb34c8d5325e35e4443ea112a476642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491355Reviewed-by:
-
Palak Agarwal authored
Change-Id: I5b7ee18f7f497d787998bde8408d46987a45a6eb Bug: 1136714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463833 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#819813}
-
Matt Menke authored
Add NetworkIsolationKey to Network Error Logging policies. This CL modifies the NelPolicy struct representing a NEL policy, by replacing the origin field with a (NetworkIsolationKey, origin) tuple. The policies are stored in the NetworkErrorLoggingService map of policies by this new key, instead of just origin. Bug: 993805 TBR: msramek@chromium.org Change-Id: If5e8d61aec8cf6325e2cf707b12e5b5a79fb67a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485531 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#819812}
-
Tanmoy Mollik authored
The test failed because of 4 pixel mismatches on the corners of the rendered images. To the naked eye they look identical. Enabling the test as it might be golden render issue. This is a reland of 7201dc96 Original change's description: > [Android] Add render test for sync promo in MainSettings > > This cl adds a render test to check that sync promo is shown when the > user has signed in with without sync consent. > > Bug: 1105800 > Change-Id: I24bb2a78f84ebf39586fbe285bc7361ecba30cc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467878 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817018} Bug: 1105800 Change-Id: Iacdd454607f1f755c38f25531dd9a8bc8fd0dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484431Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This reverts commit b47e9c83. Reason for reland: Updated more .pydeps files. Original change's description: > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > This reverts commit 49fdeca1. > > Reason for revert: Breaking presubmit due to stale .pydeps file: > android_webview/tools/run_cts.pydeps > > Original change's description: > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > Bug: 1120190 > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819489} > > TBR=agrieve@chromium.org,bpastene@chromium.org > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1120190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819668} TBR=agrieve # reland Bug: 1120190 Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819810}
-
Danila Kuzmin authored
Bug: 1134822 Change-Id: I8fdae2162564b787a9d484b58cb687cf6c8d5b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470878Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#819809}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d74754378f09..1c7f0284516a 2020-10-22 lexa.knyazev@gmail.com Vulkan: Fix invalid clamping of ES3 clear stencil values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I70098b4bf6c9d9f42b4850528332331d99f0a4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491354Reviewed-by:
-
Josh Nohle authored
Before this CL, failed or cancelled send attempts resulted in duplicate share targets in the UI on the next send attempt. The root cause of this behavior was that the share target from the failed/cancelled attempt was overwritten in the endpoint-ID --> outgoing-share-target map during the second share attempt (using the same endpoint ID), and observers were not notified that the previous share target was removed. In this CL, we handle removal of outgoing share targets in a consistent way. The removal process is as follows: - The share target is removed from the |outgoing_share_target_map_|. - File payloads are released. - The share target info is removed from |outgoing_share_target_info_map_|. - Send-discovery observers are notified that a share target was lost. Fixed: 1133824 Change-Id: Ia5faf674ae50e86a1d813d4e2f58d770248c95b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491221Reviewed-by:
-
