- 11 May, 2018 31 commits
-
-
Timothy Loh authored
This reverts commit 4a7db45d. Reason for revert: DraggableButtonTest.ActsOnMouseDownIgnoredForCommandClick fails on Mac10.12 bot, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/12756 (test times out) Original change's description: > Mac: Don't trigger mouse down events on bookmark buttons if command key is down > > Currently, all clicks on a bookmark folder button trigger their action on > mouse down, so that the folder menu can open on mouse down as expected. > > This also includes command click, which, rather than opening the folder menu, > opens all the bookmarks in the folder as new tabs. This isn't desirable since: > - The expected behavior is that button clicks trigger on mouse up. > - Triggering this on mouse down interacts poorly with the nested run loop > created by the confirmation dialog we display when the folder has many links. > > This change causes the action to no longer fire on mouse down if the user > is command-clicking the folder button. > > Bug: 840387 > Change-Id: Ic1364160cf26f2f3ea6e67d7dd0d6cf5079082eb > Reviewed-on: https://chromium-review.googlesource.com/1053947 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557676} TBR=rsesek@chromium.org,lgrey@chromium.org Change-Id: Iafb3cc8af01be9ba50a5e944b44750c62ee1df84 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840387 Reviewed-on: https://chromium-review.googlesource.com/1055027Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557760}
-
Xing Liu authored
Chrome uses file URL to access file on disk. The path needs to be in a directory white list. This CL adds the external SD card directory to the white list, so file can be accessed through file URL. Also moves the core function getAllDownloadDirectories to PathUtils for easier access in native code. Bug: 838419,792775 Change-Id: If52202d6a62f89106b1e8533f8c1884b17cc9e0b Reviewed-on: https://chromium-review.googlesource.com/1050394 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#557759}
-
Kenneth Russell authored
This was a difficult bug to track down and is worth mentioning as a reason to prioritize stamping out flakiness on the waterfall. Bug: 840988 Change-Id: If2c56a80b02178ddc28efd44d73ec440a2aa2e0c Tbr: rjkroege@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054585Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557758}
-
Jinho Bang authored
The related spec was changed: https://github.com/w3c/payment-handler/pull/301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 Reviewed-on: https://chromium-review.googlesource.com/1045705Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#557757}
-
Scott Chen authored
Bug: 836117 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I933a083f489d24c5ba4ff65636906b36f80f66dd Reviewed-on: https://chromium-review.googlesource.com/1054706Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557756}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/959fc245a92a..6c6ea2dabfc8 $ git log 959fc245a..6c6ea2dab --date=short --no-merges --format='%ad %ae %s' 2018-05-10 bungeman Non-normal blur styles to work with non-a8. 2018-05-10 skcms-skia-autoroll Roll skia/third_party/skcms 5b9549a..28e8b32 (1 commits) 2018-05-10 fmalita Fix unchecked allocation in kImageFilter::Common::unflatten() 2018-05-10 egdaniel Revert "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter." 2018-05-10 brianosman Revert "Remove GrBackendObject and all related functions from Skia." 2018-05-10 mtklein Revert "strip down SkICC.cpp" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I62c06d06784d97df02150ac59ea14cf39c7e495e Reviewed-on: https://chromium-review.googlesource.com/1054828 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557755}
-
Lambros Lambrou authored
This fixes a warning on the official Linux builders. When building the remoting Debian package, don't strip output binaries in-place, as this confuses the build system into thinking that .stamp files are outdated. Instead, copy the binaries into the package staging area before running eu-strip on the copied binaries. Bug: 828970 Change-Id: I47f5ee43ecb3bf29bb7bc27844e2dd2dc171a190 Reviewed-on: https://chromium-review.googlesource.com/1054827Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557754}
-
David Black authored
Now using a mojom struct containing: - text - icon URL (optional) - action URL (optional) Icon URL will be used to fetch an icon for a suggestion chip view. Action URL, when specified, dictates a different action to be taken on suggestion tap/click. Handling of icon/action URLs will come in follow up CL. Bug: b:78236856 Change-Id: I04c489285250ccb395cfe54c465a696c8539f619 Reviewed-on: https://chromium-review.googlesource.com/1050906 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557753}
-
Qiyu Hu authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/930c8c9de139..ce8067becb65 $ git log 930c8c9de..ce8067bec --date=short --no-merges --format='%ad %ae %s' 2018-05-07 qiyuh Add new device kMTUProperty and remove deprecated kGattServicesProperty 2018-05-09 jkardatzke Add GetContainerSshKeys call to vm_concierge 2018-05-07 sonnysasaka bluetooth: Add constants for NewBlue 2018-05-04 jkardatzke Add D-Bus service constants for CrosDNS service. Created with: roll-dep src/third_party/cros_system_api Bug: b:78593133 Test: CQ will verify this Change-Id: I313188e899d4549d476335b35696339d881a4256 Reviewed-on: https://chromium-review.googlesource.com/1054621Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#557752}
-
Kenneth Russell authored
There isn't enough Win7 Nvidia GPU bot capacity to run everything on the waterfall and allow running manually triggered try jobs. This CL removes the debug configurations "Win7 FYI Debug (NVIDIA)" and "Win7 FYI x64 Debug (NVIDIA)" from chromium.gpu.fyi waterfall. This CL also increases the execution timeout for the remaining Win7 Nvidia GPU bots. Bug: 838895 Tbr: jbudorick@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia3934d51384de411dbd2e9106213833437b84780 Reviewed-on: https://chromium-review.googlesource.com/1053103 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557751}
-
Timothy Loh authored
This reverts commit 500de904. Reason for revert: Breaks linux-jumbo-rel compile as the patch adds a second definition for blink::Clipboard. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-jumbo-rel/1249 Original change's description: > Merge WebClipboardImpl and Pasteboard into Clipboard > > Bug: 775830 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I3da04418bac37e0e03b63df4a8d2407296948e77 > Reviewed-on: https://chromium-review.googlesource.com/1045492 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557739} TBR=dgozman@chromium.org,dcheng@chromium.org,haraken@chromium.org Change-Id: Iae8a29b556f55971515b66a943df7ef812cd44f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1055007Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557750}
-
https://chromium.googlesource.com/angle/angle.git/+log/6110763fec16..2fc0806f5595 $ git log 6110763fe..2fc0806f5 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 jmadill Micro-optimize uniform updates. 2018-05-09 lucferron Vulkan: Fix use-after-free with DynamicBuffer. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I167169f14b2e9c3de4b7cb2aa73206202faa4237 Reviewed-on: https://chromium-review.googlesource.com/1054807Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557749}
-
Ahmed Fakhry authored
A navigation entry may have not been committed yet for the page. We will exclude it from tablet mode web prefs overriding. BUG=841461 Change-Id: Ic5cf268edd42127ca6161f4663ec0efc29c64b96 Reviewed-on: https://chromium-review.googlesource.com/1054575Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#557748}
-
Kenneth Russell authored
Failures on all platforms: virtual/video-surface-layer/media/controls/modern/ tap-to-hide-controls.html Timeouts: fast/events/hr-timestamp/input-events.html Bug: 810437, 831720 Change-Id: I538493dc8a815e04effe5090ad432ad79fa477e8 Tbr: steimel@chromium.org Tbr: skyostil@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054849Reviewed-by:Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557747}
-
Kenneth Russell authored
Mark these two tests as failing: deqp/functional/gles3/shaderoperator/binary_operator_01.html deqp/functional/gles3/shaderoperator/unary_operator_01.html Bug: 756537 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I08a3d1b7ba3e240aec2347a92e8b52156780c510 Tbr: rjkroege@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054773Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557746}
-
Bence Béky authored
Validate response headers of an HTTP/2 pushed stream against the client request headers even if the response headers only arrive after the pushed stream has been claimed by a request. Cancel stream and retry request in HttpNetworkTransaction if headers do not match. Bug: 554220 Change-Id: I5e1a42583b941faef5529b50178fe00d8c864976 Reviewed-on: https://chromium-review.googlesource.com/1053429Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557745}
-
Zhiling Huang authored
Bug: 790520 Change-Id: I9612375c0c479e4b0219cd2c315e895c0185afe6 Reviewed-on: https://chromium-review.googlesource.com/1054208Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#557744}
-
Peter Boström authored
Adds circular inkdrops for the toolbar and pill-shaped ones for entries in the bookmarks bar for Refresh. This removes the recent move to 8dp squircles for Refresh and Touch and instead unifies them as rounded. Also tones down EMPHASIS_HIGH for non-touchable and non-refresh as they are not ready for rounded corners. Bug: chromium:822069, chromium:822072 Change-Id: Ie619f40834127ebfde59621a86fae42e7d8c4f23 Reviewed-on: https://chromium-review.googlesource.com/1053379 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#557743}
-
Tommy C. Li authored
Currently, the search providers all have static prepopulated favicon URLs. These can fall out of date. This CL updates the search providers' favicons as the user browses. Specifically, when the user actually lands on a URL matching the a search provider URL template, and we get a favicon that does not match the stored favicon URL, we update the stored favicon URL. Bug: 88243, 823535 Change-Id: I43f72ad449515d5a19e5ec4b32ca996b9d32eb11 Reviewed-on: https://chromium-review.googlesource.com/1048174 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557742}
-
Michael Giuffrida authored
This is a reland of 52e03fa8 Mac compile failure should be fixed with USE_AURA #ifdef around test. Original change's description: > AppShell: Suppress context menu in webviews > > AppShell doesn't support context menus, but still needs to provide a > WebViewGuestDelegate to handle the context menu. Otherwise, we reach a > NOTREACHED() in WebContentsViewChildFrame::ShowContextMenu(). > > Also removes a WebViewGuestDelegate function that is unused (see > https://codereview.chromium.org/2836973002). > > Bug: 820604 > Change-Id: I0760d397384908a490704f23388e11c4eef113a5 > Reviewed-on: https://chromium-review.googlesource.com/957596 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544136} Bug: 820604 Change-Id: Ib44c00f70a89f88b13f0ba934d725d10353bff86 Reviewed-on: https://chromium-review.googlesource.com/1053181Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557741}
-
Shakti Sahu authored
Transient downloads are meant not to show up in download home. However notifications must be shown during the download. This was broken recently due to a change which affected background fetch notifications to get lost. Restoring this behavior. Bug: 841344 Change-Id: I034b9761b0bd33275e23a298691b49e0db7f6d3f Reviewed-on: https://chromium-review.googlesource.com/1052891Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557740}
-
Dmitry Gozman authored
Bug: 775830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3da04418bac37e0e03b63df4a8d2407296948e77 Reviewed-on: https://chromium-review.googlesource.com/1045492 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557739}
-
Emil A Eklund authored
Refactor BoxPainterBase and BoxModelObjectPainter to supply flowbox size as parameter to PaintFillLayer instead of storing it as a private field. This will in turn help with code re-use between InlineFlowBoxPainter and the LayoutNG equivalent. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I342c51c87eb253e2d6420f2b11440b77c564f67d Reviewed-on: https://chromium-review.googlesource.com/1054133Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#557738}
-
Dan Beam authored
R=dpapad@chromium.org BUG=841000 Change-Id: I4b0c6ae08a6097df28aed3743fbe82f211c2e023 Reviewed-on: https://chromium-review.googlesource.com/1053425 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557737}
-
Sean Topping authored
Introduces an LRU cache for prelaunching renderers. This class creates a pool of prelaunched renderers for the N most recently closed pages. Bug: internal b/77879457 Test: cast_shell_unittests Change-Id: I0500f24b65377360d0c74ea390b476e1b879708a Reviewed-on: https://chromium-review.googlesource.com/1036730 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557736}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0aae1c1fc30a..3c311c15709b $ git log 0aae1c1fc..3c311c157 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 manojgupta cbuildbot: Disable unit tests in fuzzer builds. 2018-04-20 bmgordon build_stages: Use snapshot to clean up chroot. 2018-05-04 yunlian generic_stages: temporarily ignore all target prebuilts. 2018-05-08 guocb auto_updater: filter more directories when copy devserver to DUT Created with: roll-dep src/third_party/chromite BUG=chromium:841512,chromium:829665,chromium:730144,chromium:826418,chromium:840975,chromium:824580 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0abebd960beb44b1560aca995781fed1b91f453f Reviewed-on: https://chromium-review.googlesource.com/1054619 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557735}
-
Min Qin authored
This reverts commit 13077433. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Cancel parallel download request if server doesn't send partial response" > > This reverts commit 189d1033. > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > Original change's description: > > Cancel parallel download request if server doesn't send partial response > > > > If the server doesn't support partial responses, Chrome should cancel > > parallel download requests. > > These requests result in the wrong write offset and makes the file larger > > than the original > > > > BUG=838627 > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557252} > > TBR=qinmin@chromium.org,xingliu@chromium.org > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838627, 841666 > Reviewed-on: https://chromium-review.googlesource.com/1053470 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557489} TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627, 841666 Reviewed-on: https://chromium-review.googlesource.com/1054887Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557734}
-
Thomas Guilbert authored
The RemoteMediaPlayerWrapper's call to RMP.load() never completes, and all subsequent API calls fail. This is because messages from the CastDevice are not being properly routed back to RemoteMediaPlayer. This CL register the RemotingCastSession as a MessageReceivedCallback for the media namespace, and forwards those messages to the RemoteMediaPlayerWrapper. Bug: 790766 Change-Id: Ibb514b14d4559fd280c6bafac871781c7fb1ac99 Reviewed-on: https://chromium-review.googlesource.com/1044969Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#557733}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e877b1776a14..2191308678e4 $ git log e877b1776..219130867 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 jbudorick Revert "gclient: Get rid of parsed_url." 2018-05-10 ehmaldonado bot_update: Assert no syncing of refs/remotes/* Created with: roll-dep src/third_party/depot_tools BUG=chromium:841936,chromium:840445 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I52a88ffeda4b56309156e3fc377eebdbc3ae8138 Reviewed-on: https://chromium-review.googlesource.com/1054635Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557732}
-
Reid Kleckner authored
This reverts commit 7ebf529c. Reason for revert: Breaks many browser_tests in official builds. Google-internal official builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/84099 Failures are visible publicly here: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1489 Original change's description: > Revert "Revert "Disable Channel ID on all platforms except Android"" > > This reverts commit 3c79bfc0. > > In addition to the original CL bd3d1ea0, this includes a fix to the crash > when relaunching after changing about:flags. > > Bug: 841006 > Change-Id: I04c82074bb83da7ba5854b783862ec689d7a36e0 > Reviewed-on: https://chromium-review.googlesource.com/1050976 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Nick Harper <nharper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557307} TBR=boliu@chromium.org,rch@chromium.org,nharper@chromium.org,dschuyler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841006 Change-Id: I2900a883c01307f3c91bcd91698ef8487acfac44 Reviewed-on: https://chromium-review.googlesource.com/1054205Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557731}
-
Jialiu Lin authored
This is a reland of 3c6230c7 Previous revert is caused by merge conflict with another CL that happened to land around the same time. This reland is a simply a rebase of the original CL. Original change's description: > Refactor HashPasswordManager to accept multiple password hashes > > This CL doesn't change existing behavior, but only refactor > HashPasswordManager class such that it can keep track of multiple > password hashes. This CL introduces a new struct PasswordHashData to > replace SyncPassswordData. > > Migration from SyncPasswordData to PasswordHashData is in place so that > we'll not lose already captured sync password. IsSyncPasswordHashSaved > histogram enum is added to track this migration. SyncPasswordData > will be deprecated after the transition period. > > Bug: 830998 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 > > TBR=jochen@chromium.org > > Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 > Reviewed-on: https://chromium-review.googlesource.com/1036464 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557646} TBR=dvadym@chromium.org, jochen@chromium.org Bug: 830998 Change-Id: I195fbea0c53f2b3a2000e53b37f3eeaa33d5b846 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1054354Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#557730}
-
- 10 May, 2018 9 commits
-
-
Kyle Milka authored
Add the UI strings for NTP custom backgrounds, custom links, and fakebox. Bug: 837798, 839152, 837784 Change-Id: I8c605ec41923eced800579f8c15901caf93e93f4 Reviewed-on: https://chromium-review.googlesource.com/1052667Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557729}
-
dpapad authored
Also doing the same for kEasyUnlockLearnMoreUrl, which is only used in CrOS. Bug: 621723 Change-Id: Ieada2f363c886e9321016de45a2157a3d35ac1fb Reviewed-on: https://chromium-review.googlesource.com/1053155 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#557728}
-
Xiaohan Wang authored
Instead of having MojoMediaClient creating a RendererFactory, ask MojoMediaClient to create a Renderer directly. This helps us to eliminate the audio and video renderer sink from the interface, which isn't interesting to most Renderers hosted by MojoRendererService. This also helps to simplify how we pass |audio_device_id| into the Renderer directly (not having to go through the audio sink). Bug: 586211 Test: All existing tests pass. Change-Id: Ifcb0708a063da1958ccf495ef08ab8f98902617d Reviewed-on: https://chromium-review.googlesource.com/1053295Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557727}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/024615e9752d..959fc245a92a $ git log 024615e97..959fc245a --date=short --no-merges --format='%ad %ae %s' 2018-05-10 brianosman Add SkColorSpace::toProfile 2018-05-10 bsalomon Add GrContextThreadSafeProxy and remove most friends of GrContextThreadSafeProxy 2018-05-10 mtklein non-linear blending first steps Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I5fc690ffbb0c016a92b25ff07cd7e152c9d477d0 Reviewed-on: https://chromium-review.googlesource.com/1054550 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557726}
-
Ria Jiang authored
Viz hit-test doesn't need LocalSurfaceId in targeting/ transforming requests, HitTestQuery has that information; and we don't currently have a valid one in RenderWidgetHostViewGuest and RenderWidgetHostViewChildFrame in OOP-D. We could add it in RWHVG/ RWHVCF, but since we don't need it anyway, skip this validation for Viz hit-test. Bug: 840893 Change-Id: Ic9bbf9f29fc2016f9c838f781f8cf554c180d61e Reviewed-on: https://chromium-review.googlesource.com/1050440Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557725}
-
Tom Sepez authored
The ImageData might get destroyed while the paints are still pending. Typically, the paints are then cancelled thereafter so no harm comes from the dangling references, but this patch avoids creating them in the first place. The remaining changes are consequences of ProgressivePaint becoming non-POD, and converting to protected members. Also use scoped FPDF classes while we're at it. Bug: 838886 Change-Id: Ic933350ac9e981da58f1f841968dc89fb8518974 Reviewed-on: https://chromium-review.googlesource.com/1054502Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#557724}
-
Alexander Alekseev authored
Bug: 841974 Change-Id: Ie847933ad8090024a14807cc4db629a837266092 Reviewed-on: https://chromium-review.googlesource.com/1054638Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#557723}
-
Jinsuk Kim authored
Turns ContentVideoView/ContentVideoViewEmbedder public interfaces, and removes the corresponding DEPS exceptions. Bug: 617324 Change-Id: I2e1fdd5b48e6a11e204c3d145458a58561dc0fb8 Reviewed-on: https://chromium-review.googlesource.com/1043305Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#557722}
-
Esmael El-Moslimany authored
Bug: 840898 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5180a32f2453547d915ca5867190facc30e63e00 Reviewed-on: https://chromium-review.googlesource.com/1053115Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#557721}
-