- 25 Jan, 2018 40 commits
-
-
F#m authored
This patch adds a slider to adjust the size or zoom of a display from chrome display settings page. The slider is hidden behind a command line switch which can be toggled from the chrome experiments page. Adds a check on the API to ensure the values are not abused are always within reasonable bounds. Added tests for the same. This patch also updates the minimum allowed device scale factor for a display from 1.0f to 0.5f. Bug: 790723 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8027d144859d06a8e5a1a5b3bc7988b217edd851 Component: Display settings webui, chromeos switches, about flags Reviewed-on: https://chromium-review.googlesource.com/879111 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531968}
-
Roger Johannesson authored
SnapLayerToPhysicalPixelBoundary calculates the sub pixel offset that is needed for a layer to end up on a physical pixel boundary but it does not take into account that a layer can have a scaling transform applied to it. This showed up as a problem when https://chromium-review.googlesource.com/691338 landed since it made layers with scale transforms applied start triggering DCHECKs in CheckSnapped. The reason there was no problem before that CL is that ConvertPointToLayer used to return floored coordinates. This patch attempts to fix this problem by applying the transform scale to the offset vector, similar to how the device scale factor is applied. Bug: 805425 Change-Id: I401de72a465b83b00762a92ad2634ac2fc40dff5 Reviewed-on: https://chromium-review.googlesource.com/883782 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#531967}
-
F#m authored
With display zoom a wide range of device scale factors can now be set as for a given device. Sometimes a value can lead to a failure in the pixel snapping check. This patch increases the threshold for these checks. Bug: 790723 Change-Id: I21ae6711f608b9f6bc99efd47d0c8466f03722eb Component: Dip Util, Pixel Snapping, Reviewed-on: https://chromium-review.googlesource.com/884361 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#531966}
-
Christos Froussios authored
Change-Id: I41ee353dddff2aa5a72701503956894668d82f1c Reviewed-on: https://chromium-review.googlesource.com/873970 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#531965}
-
Malcolm White authored
Change-Id: I390b9983b624db7086cb5fb8adee43622434f3d4 Reviewed-on: https://chromium-review.googlesource.com/884483 Commit-Queue: Malcolm White <malcolmwhite@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531964}
-
Quinten Yearsley authored
Now webkit-patch rebaseline-server is removed in https://crrev.com/c/847641. layout-tests-server is likely also unused, and it would be good to reduce the surface area and quantity of code in webkitpy if possible. Bug: 704384 Change-Id: I518153ae01c36d1e34433dc38c5ebea9b87cc869 Reviewed-on: https://chromium-review.googlesource.com/883613Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#531963}
-
sangwoo.ko authored
We mustn't open it as bookmark. Bug: 791962 Change-Id: I65b51e8af76c4b31f83991a4f7d3f3f8c37f1a9f Reviewed-on: https://chromium-review.googlesource.com/882902Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531962}
-
Jiaquan He authored
With this change we won't need to pass SyncItem over IPC later. Bug: 733662 Change-Id: I4fa2e3743b8c8c36c98f74b9fb609750a2cfbe99 Reviewed-on: https://chromium-review.googlesource.com/885084Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#531961}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/2d8e432a9e50..aba14ff52bea $ git log 2d8e432a9..aba14ff52 --date=short --no-merges --format='%ad %ae %s' 2018-01-15 geofflang Add GLES1 conformance tests. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I861260ae89d16768549666d4760f02151e31c39d Reviewed-on: https://chromium-review.googlesource.com/887101Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531960}
-
Justin Donnelly authored
Support for ftp is deprecated so encouraging its use with a special-case fixup no longer makes sense. Bug: 798166 Change-Id: I8644164cf7229b435c1c452c74a33f26fb4543bb Reviewed-on: https://chromium-review.googlesource.com/875201 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531959}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bc21ae5..ee5d9a0c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I8ce852cb910f2127657d8cf4b137ce63c019eafc Reviewed-on: https://chromium-review.googlesource.com/886961Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531958}
-
Jonathan Backer authored
The autogenerated service side tests are sharded out. New extensions were added and those tests spilled over into a new shard 4. However, there was no driver for the 4th shard and these tests were never run. This CL does 2 things: (1) adds a simple driver so that any new autogen tests in the 4th shard will be run (2) disables the service side tests for the CHROMIUM extensions Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibb3fbb89a6fd648804559d3c7be2cb946db7f4ba Reviewed-on: https://chromium-review.googlesource.com/886648 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531957}
-
Matt Mueller authored
Enables AIA fetching and OCSP for CertVerifyProcNSS and CertVerifyProcBuiltin. Change-Id: I0d03e717855492707dc48441130731aeccd74074 Reviewed-on: https://chromium-review.googlesource.com/884721Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#531956}
-
Justin Carlson authored
Bug: 803953 Change-Id: I9a8f880d9dabef462b25dbc5876b0dd678cb9c60 Reviewed-on: https://chromium-review.googlesource.com/883977Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531955}
-
jdoerrie authored
This change fixes clang-tool to allow pointers in lambda init-captures. Prior to this change it erroneously triggered the auto raw pointer check. Bug: 804944 Change-Id: Ifc8811d80cefcc593383c21d7c086d3ba719975f Reviewed-on: https://chromium-review.googlesource.com/879181Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#531954}
-
Anita Woodruff authored
- All non-persistent notification events (onshow, onclick, and onclose) now go through Mojo when the NotificationsWithMojo blink feature flag is enabled. - Layout tests with mojo enabled that rely on non-persistent notification events now pass and are re-enabled. (Except for those relying on the Notification.close() path which still needs to be migrated to mojo). - Interactive ui tests with mojo enabled are simplified to wait for the show event rather than NotificationDisplayService mutation. BUG=796990 Change-Id: Id99cd7b936b2ef18fd4be270aa76e4732e137db9 Reviewed-on: https://chromium-review.googlesource.com/878744Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#531953}
-
Deepanjan Roy authored
We have UMA for Time to Interactive metric already. This CL adds an UKM. See https://goo.gl/TFw6xz for explanation of Time to Interactive. Bug: 631203 Change-Id: I4563602c7dddc30800dfed308682931ef8c30573 Reviewed-on: https://chromium-review.googlesource.com/881533Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531952}
-
Troy Hildebrandt authored
NewApi warnings were suppressed accidentally and an AssertionError constructor that requires API 19 was used. The NewApi warnings are back, so this fix avoids using the AssertionError, and throws the exceptions as they are. Since a couple calls that were being caught in a try/catch block before need to throw exceptions but can't from a Runnable, a waitForActivity method in ActivityUtils was added that takes a Callable<Void> was added. The original that takes a Runnable is just a wrapper around this new method so other tests are not affected. Bug: 805509,803484 Change-Id: I7960b2725b4fad1496fbfde7aafa8e2cf52ec686 Reviewed-on: https://chromium-review.googlesource.com/884362 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#531951}
-
Evan Stade authored
This is a more general fix for the CFI issues seen while updating tests to use NotificationDisplayServiceTester. While referencing |profile_| after shutdown would typically be sorta safe in this case, the CFI bot objects because it detects a cast on a destroyed object. The old solution, administered somewhat inconsistently, was to destroy the NotificationDisplayServiceTester before the profile. However this also has issues, because some code references the NotificationDisplayService during profile shutdown. Hence it is not safe for NDSTester to outlive its profile, and not safe not to outlive its profile. The solution is to allow it to outlive its profile but not reference the profile after it's been destroyed. TBR=rdevlin.cronin@chromium.org,atwilson@chromium.org Bug: 804231 Change-Id: I17f29befb18f0667b2f15ca2bb7554af1854b6d1 Reviewed-on: https://chromium-review.googlesource.com/883224Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#531950}
-
Theresa authored
BUG=803088 Change-Id: Idfdd6fa8f77a4d47a9ffcc9c807470cd23340ad2 Reviewed-on: https://chromium-review.googlesource.com/875146Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#531949}
-
Yoland Yan authored
Merge CronetTestCommon into CronetTestRule since there is no long need for sharing the implementation with other classes Bug: 711517 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ib5177155e3a818345c0038241f752af82843236c Reviewed-on: https://chromium-review.googlesource.com/881553 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531948}
-
Jonathan Backer authored
This uses the new raster specific command IDs and autogen of boilerplate handler code. All of the handlers are stubbed out with NOTIMPLEMENTED(). Compiles and links. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I791f1105d191197628273beaf0c6aa46c0c4b763 Reviewed-on: https://chromium-review.googlesource.com/884205 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#531947}
-
Miguel Casas-Sanchez authored
crrev.com/c/882081 landed a correction of the incoming VideoFrame colorspace [1,2], to have a MatrixID::RGB matrix. This was (and is) not needed and wrong, because we might lose container color space information, and in reality what we want is to tell VideoResourceUpdater to manipulate this resource as RGB, so this CL corrects this situation. [1] https://cs.chromium.org/chromium/src/media/video/gpu_memory_buffer_video_frame_pool.cc?sq=package:chromium&dr=CSs&l=451 [2] https://cs.chromium.org/chromium/src/media/video/gpu_memory_buffer_video_frame_pool.cc?sq=package:chromium&dr=CSs&l=462 Bug: 797347 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I3f22fdc82395ece5181cb2ce198ed2c838cf49a7 Reviewed-on: https://chromium-review.googlesource.com/885041Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#531946}
-
Ken Russell authored
This should help prevent the compiler from attempting to inline them. Bug: 805409 Change-Id: I282c12f09048fef3cb24b8c1b1d14c1a0ca705f0 Reviewed-on: https://chromium-review.googlesource.com/885901 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531945}
-
deejay authored
Aria-dropeffect and aria-grabbed are deprecated in aria 1.1. Those properties are expected to be replaced by a new feature in a future version of WAI-ARIA. After that we will re-implement them following new spec. For now, we do not deprecate them immediately for backward compatibility and just notify it by comments as "TODO". Bug: none Change-Id: I1701d2048158c209b9a09608c0904abc3bfb75d7 Reviewed-on: https://chromium-review.googlesource.com/867799Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531944}
-
Yoland Yan authored
Bug: 711517 Change-Id: I041ffd60657022e98196246bdff14f0e4d802f20 Reviewed-on: https://chromium-review.googlesource.com/882447Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531943}
-
Troy Hildebrandt authored
NewApi warnings were suppressed accidentally and an AssertionError constructor that requires API 19 was used. The NewApi warnings are back, so this fix avoids using the AssertionError, and throws the exceptions as they are. R=yusufo@chromium.org Bug: 805509,803484 Change-Id: I488c5f8de4351acac14874c7743a52ee0612c37c Reviewed-on: https://chromium-review.googlesource.com/884206 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#531942}
-
Emily Hanley authored
on mac 10.12 TBR=charliea@chromium.org NOTRY=true Bug: 805934 Change-Id: Ifc2da35f001c146e59836e32e60a168ea063ec66 Reviewed-on: https://chromium-review.googlesource.com/887221Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#531941}
-
Gauthier Ambard authored
This CL adds the side swipe capability to the Adaptive Toolbar. Bug: 803371 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie87d1955a81151f06bc5339c655746863b829b58 Reviewed-on: https://chromium-review.googlesource.com/881441 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#531940}
-
Wenzhao Zang authored
Clear focus for Cancel button only, because other types of buttons may still want to keep the focus after being pressed. (Although, currently no other buttons really need to keep the focus: they either trigger restart of Chrome, or the login/lock screen will explicitly request the focus.) Bug: 797752 Change-Id: Ib48969e61472c3e6ccda2a413d5ec3d719754ef4 Reviewed-on: https://chromium-review.googlesource.com/885624Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531939}
-
David Bokan authored
Additional test to chcanges landed in r531871 Bug: 804813 Change-Id: I9684318423e2e00ee20a4f5504e0420ecf8d080c Reviewed-on: https://chromium-review.googlesource.com/886561Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531938}
-
Jun Choi authored
AuthenticatorGetInfo, AuthenticatorGetNextAssertion, AuthenticatorReset, and AuthenticatorCancel commands in CTAP protocol are requests with empty parameter and are serialized to a single byte that represents command type. Add object construct to encapsulate/serialize requests with empty parameter. Bug: 799355 Change-Id: I05a876a17bfb3dc1c1ef21d830f330db503856f6 Reviewed-on: https://chromium-review.googlesource.com/851673 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#531937}
-
Lukasz Anforowicz authored
Bug: 804957 Change-Id: I2d2cccf2e77ad44305af1601e52c6ae80e062d7d Reviewed-on: https://chromium-review.googlesource.com/882450 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#531936}
-
Francois Doray authored
TBR=jochen@chromium.org Bug: 667892 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If125f2f33081fb39184ad13594f187e8ec165148 Reviewed-on: https://chromium-review.googlesource.com/883767Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#531935}
-
John Budorick authored
This reverts commit b2b018c5. Reason for revert: Breaking compilation on multiple Fuchsia bots: crbug.com/805844 (includes net_unittests.archive_manifest files) Original change's description: > Build Fuchsia packages for test and executable targets. > > All targets that use the test() or fuchsia_executable_runner rules > will produce Fuchsia packages, which contain the test executable and > their runtime dependencies. > > The packages are modules which can be deployed in an already-running > system, as opposed to the current scheme which bakes the files into > the system boot image. > > Deployment and support for dynamic libraries will be addressed > in followup CLs. > > This CL also: > * Fixes PathService logic for packaged invocations. > * Adds a new "build_manifest.py" GN helper script. > * Fixes the dependency graph for Fuchsia runner script generation > so that it accurately captures the real dependency ordering. > > > Bug: 796779 > Change-Id: I4e3a38e0075573b328ad98425cc493e28cff1ca4 > Reviewed-on: https://chromium-review.googlesource.com/841749 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531288} TBR=dcheng@chromium.org,wez@chromium.org,dpranke@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org Bug: 796779,805844 Change-Id: I451b714715b72a9a4b2f723a515a1f7c0dff7687 Reviewed-on: https://chromium-review.googlesource.com/886821 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#531934}
-
Peter E Conn authored
The Intent to open the Notifications Preferences screen included the FLAG_ACTIVITY_CLEAR_TASK flag. This means that if the screen were already present in the Task Stack, the entire stack would be cleared. This meant that when the user entered Chrome Settings, was linked to Android Settings (through the Notifications button) and then was linked back to Chrome Settings (through the "Additional Settings in the app" link), the whole Task Stack would be cleared. Pressing Back at this point would take the user to the home screen. The flag was originally set to prevent instability due to having Callbacks destined for the first Settings Activity arriving at the second Settings Activity and generally making a mess of things. I'm disabling the flag in the hope such instability has been fixed, and if not to generate some up to date crash reports. Bug: 803422, 707804 Change-Id: Id662fd7218e35739755e97fb42780ebd16b09346 Reviewed-on: https://chromium-review.googlesource.com/886844 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#531933}
-
Jun Choi authored
Added classes to encapsulate response data received from CTAP devices as specified by the CTAP protocol. https://fidoalliance.org/specs/fido-v2.0-rd-20170927/fido-client-to-authenticator-protocol-v2.0-rd-20170927.html#authenticatorMakeCredential Bug: 796782 Change-Id: If5a80846d565ab6a7919aa3236ff78e22b5209ae Reviewed-on: https://chromium-review.googlesource.com/850895 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#531932}
-
Manish Jethani authored
Since the selector index field in RuleData is only 13 bits, we can only support lookups in the range 0-8191. We must ignore any selectors outside this range. BUG=804179,632009 Change-Id: I11c0acfe27813d98f24f72fb7e50f13b326a0e84 Reviewed-on: https://chromium-review.googlesource.com/883702Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manish Jethani <m.jethani@eyeo.com> Cr-Commit-Position: refs/heads/master@{#531931}
-
jonross authored
I've updated the Viz FYI filter for content_browsertests to match the one used on the CQ. To account for renamed tests. TBR=kylechar@chromium.org Bug: 760181 Change-Id: I5c86a182c5240a324aaa7afa147f5373163b9930 Reviewed-on: https://chromium-review.googlesource.com/886659Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#531930}
-
Alexandros Frantzis authored
Update libsync to the latest upstream version. Also remove the previously added linux sync headers, since they are unused and out of date. Up to date kernel UAPI definitions (both for the legacy and modern sync file UAPI) are contained in sync/sync.h for code that may need them, but it's preferable to use the libsync API instead. that use libsync currently) Test: Build ozone/drm and media/capture (which are the only components Bug: None Change-Id: Iea55bc1342e558191ac4daa470a6e9a93a05b9ef Reviewed-on: https://chromium-review.googlesource.com/832484Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531929}
-