GitLab

BUG=None
R=mukai@chromium.org
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/323573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380782
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/316013006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275479 0039d316-1c4b-4281-b951-d872f2087c98

When the browser compositor does a SwapBuffers to its output surface,
take a lock on the compositor until that swap is displayed on the screen.
This prevents the renderer from running ahead of the browser.

If the renderer sends a new frame (it can send at most one), then track
this event, and request redraw as soon as the lock is released.

BUG=314190

Review URL: https://codereview.chromium.org/316103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361156

Review URL: https://codereview.chromium.org/250383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381742
TBR=tonyg@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/320013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275476 0039d316-1c4b-4281-b951-d872f2087c98

This adds the //ui/events/platform target and adds a dependency from //ui/gl

R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/317823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378785

Review URL: https://codereview.chromium.org/301193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341554
TEST=unittests, manual feedback send from debug chrome build
TBR=jochen for OWNERS

Review URL: https://codereview.chromium.org/296173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275472 0039d316-1c4b-4281-b951-d872f2087c98

It was using ProtocolHandlers, but it makes more sense for it
to use the new URLRequestInterceptor class.

BUG=146600

Review URL: https://codereview.chromium.org/300693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275470 0039d316-1c4b-4281-b951-d872f2087c98

There isn't a mechanism for doing partial swaps of a CAOpenGLLayer
on Mac.

BUG=314190

Review URL: https://codereview.chromium.org/316173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380378
TEST=Manual, see bug
R=erg
TBR=sadrul (For trivial change to ui/base/x/x11_util.h)

Review URL: https://codereview.chromium.org/317273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275468 0039d316-1c4b-4281-b951-d872f2087c98

Turns out no-one needs this.

BUG=359566

Review URL: https://codereview.chromium.org/315653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275467 0039d316-1c4b-4281-b951-d872f2087c98

Following https://chromiumcodereview.appspot.com/318673002/ blink will no
longer be setting cache headers, so the special case that skips over cache
headers is not needed anymore.

BUG=376025

Review URL: https://codereview.chromium.org/316883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275466 0039d316-1c4b-4281-b951-d872f2087c98

Depends on: blink:r174579

R=piman

Review URL: https://codereview.chromium.org/291333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275465 0039d316-1c4b-4281-b951-d872f2087c98

This splits out the Non-SFI case more explicitly when starting a NaCl module to
make the code easier to read. There isn't a whole lot of code in common between
the Non-SFI and SFI cases.

BUG=333950

Review URL: https://codereview.chromium.org/301993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275464 0039d316-1c4b-4281-b951-d872f2087c98

This just unbreaks things for now before I can make a better fix.

TBR=sky

BUG=381733

Review URL: https://codereview.chromium.org/322573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275462 0039d316-1c4b-4281-b951-d872f2087c98

This paves the way for having more than one platform-specific object,
which is necessary for the componentization of ozone.

The plumbing to build objects that depend on the platform is shared
using the PlatformObject<T> template.

Code that wants to build such an object need simply do

  scoped_ptr<MyPlatformSpecificType> my_platform_object =
      PlatformObject<MyPlatformSpecificType>::Create();

We have to generate a couple of source files to make this work:

  - a header file with an enumeration of platforms
  - a (per-component) source file with a static const list of
    constructors for each platform type

This converts the previous object (OzonePlatform) instantiation
to use PlatformObject<>. This should be functionally identical.

BUG=380884
TEST=build aura_builder with "use_ozone=1 chromeos=1", ran egltest
NOTRY=true

Review URL: https://codereview.chromium.org/313963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275206

Review URL: https://codereview.chromium.org/314603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275459 0039d316-1c4b-4281-b951-d872f2087c98

Previously, this benchmark required a separate profile generation step as wel
as arguments. This isn't a Telemetric way to write a benchmark. Now, if a
profile isn't given, it generates the correct profile for the benchmark.

BUG=

Review URL: https://codereview.chromium.org/317733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275458 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275457 0039d316-1c4b-4281-b951-d872f2087c98

To fix build error on Windows.

https://code.google.com/p/font-compression-reference/source/detail?r=6cef49677dc4c650ef6e3f56041e0a41803afa8c

Review URL: https://codereview.chromium.org/315393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275456 0039d316-1c4b-4281-b951-d872f2087c98

Most examples work with Chrome stable (currently M35), so don't require
apps to use a newer version of Chrome.

No examples need a later version of Chrome, but a few use features that
just made it to stable. In this case, we allow the minimum version to be
specified in example.dsc.

BUG=none
R=sbc@chromium.org, noelallen@chromium.org

Review URL: https://codereview.chromium.org/318823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275454 0039d316-1c4b-4281-b951-d872f2087c98

The WindowTreeHost and ContextFactory implementations are specific to
the view manager and should be moved there. No one else should be
using these directly. I'm also nuking launcher as it was temporary and
the only other place that was using this code.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/315223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275453 0039d316-1c4b-4281-b951-d872f2087c98

--disable-touch-editing can be used to disable touch text selection.

Originally landed as r274972, but reverted due to blink layout test
failures. Layout tests are fixed in r175595 (blink).

BUG=304872

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274972

Review URL: https://codereview.chromium.org/305423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275452 0039d316-1c4b-4281-b951-d872f2087c98

R=rsesek@chromium.org, rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/314133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339558

Review URL: https://codereview.chromium.org/319733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275449 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately, TSan doesn't handle operator(), neither does the PRESUBMIT script.
We're going to deprecate v1 soon, so it doesn't worth fixing.

TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/320593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275448 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Remove hardware menu button dragging support. (https://codereview.chromium.org/317083005/)

Reason for revert:
AppMenuHandler.hardwareMenuButtonUp is still used by clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572, hence this is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder to fail to compile with the following error:

../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572: cannot find symbol
symbol  : method hardwareMenuButtonUp()
location: class org.chromium.chrome.browser.appmenu.AppMenuHandler
                mAppMenuHandler.hardwareMenuButtonUp();

Original issue's description:
> [Android] Remove hardware menu button dragging support.
> 
> This code path was broken sometime within a year, and we don't think
> it's worth to support this more.
> 
> BUG=366154
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275395

TBR=aurimas@chromium.org,tedchoc@chromium.org,kkimlabs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366154

Review URL: https://codereview.chromium.org/317383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275441 0039d316-1c4b-4281-b951-d872f2087c98

We were adding an extra null into the string because FPDFLink_GetURL only gives the length without the null terminator.

BUG=pdfium:6
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/316233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275439 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275438 0039d316-1c4b-4281-b951-d872f2087c98

R=fischman@chromium.org

Review URL: https://codereview.chromium.org/311263013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275437 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add creation of v14 compatible resources to process_resources.py (https://codereview.chromium.org/321453002/)

Reason for revert:
This is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder (downstream) to fail with the following error message:

FAILED: cd ../../clank/native/framework; python ../../../build/android/gyp/process_resources.py --android-sdk /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//platforms/android-19 --android-sdk-tools /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//build-tools/19.0.0 --android-manifest ../../../clank/java/apps/deviceextras/AndroidManifest.xml --dependencies-res-dirs "" --extra-res-packages "" --extra-r-text-files "" --proguard-file ../../../out/Debug/device_extras_apk/proguard.txt --resource-dir ../../../clank/java/apps/deviceextras/res --res-v14-compatibility-dir ../../../out/Debug/device_extras_apk/res_v14_compatibility --crunch-output-dir ../../../out/Debug/device_extras_apk/res --R-dir ../../../out/Debug/device_extras_apk/gen --stamp ../../../out/Debug/device_extras_apk/codegen.stamp
Traceback (most recent call last):
  File "../../../build/android/gyp/process_resources.py", line 217, in <module>
    main()
  File "../../../build/android/gyp/process_resources.py", line 166, in main
    options.v14_verify_only)
  File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 335, in GenerateV14Resources
    ErrorIfStyleResourceExistsInDir(input_dir)
  File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 107, in ErrorIfStyleResourceExistsInDir
    '-v17 directory. Please refer to '
Exception: error: style file /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values/styles.xml should be under /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values-v17 directory. Please refer to http://crbug.com/243952 for the details.

I don't know resource loading well enough to tell if that's a legitimate issue or not; so for now reverting this to fix the build bots, and if it is a legitimate issue then ideally it could be fixed before relanding this?

Original issue's description:
> Add creation of v14 compatible resources to process_resources.py
> 
> There are a lot of steps in processing resources and preparing them for
> packaging. It will be easier if these are all done by the same script.
> 
> BUG=375431,359249
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275401

TBR=newt@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375431,359249

Review URL: https://codereview.chromium.org/314363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275436 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of effort for enabling Drive in open file dialog
of incognito windows. It enabled protocol handler for drive: scheme
in incognito profiles.

BUG=359418

Review URL: https://codereview.chromium.org/310613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275435 0039d316-1c4b-4281-b951-d872f2087c98

Since ExtensionRegistry provide canonical way, use  ExtensionRegistry instead.

BUG=374353
TEST=unit_tests

Review URL: https://codereview.chromium.org/298023009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275434 0039d316-1c4b-4281-b951-d872f2087c98

This affects only official Chrome builds.

BUG=374279

Review URL: https://codereview.chromium.org/318993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275433 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a support of opening multiple files to Video Player. Previously, the player can open only a single file.

This patch does:
* Remove file-tasks filter which removes VideoPlayer on opening a single file.
* Add left/right arrows which can switches to prev/next video.
  - Arrows are hidden when opening a single file.
  - Left (or right) arrow are hidden when playing the first (or last) file.

BUG=355545
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/313273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275432 0039d316-1c4b-4281-b951-d872f2087c98

Previously WorkspaceManager was used for this container which resulted in various
issues when login screen window was not full screen and was supposed to be resized
only by virtual keyboard container. Otherwise panels and shelf were taken into account
even though they are stacked below the lock container.

This CL improves previous fix
https://codereview.chromium.org/231123002

Disable this layout manager with --ash-disable-lock-layout-manager

Verified that existing out-of-box/login/multi-profiles login/lock* virtual keyboard
overscroll/non-overscroll configurations work fine.

Non-overscroll lock screen configuration is updated to use the same behavior as
login in https://codereview.chromium.org/320523003

BUG=375666
TEST=LockLayoutManager.*, existing tests

Review URL: https://codereview.chromium.org/254673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275431 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/306233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275429 0039d316-1c4b-4281-b951-d872f2087c98