GitLab

We must pass shell=True on Windows for all subprocess module functions
to get PATH expansion for finding git.

This is commented in the first call to a subprocess function, so don't
duplicate that comment elsewhere.

Review URL: http://codereview.chromium.org/3067015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54072 0039d316-1c4b-4281-b951-d872f2087c98

TEST=register_host.py registers host successfully
BUG=None

Review URL: http://codereview.chromium.org/3048036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54070 0039d316-1c4b-4281-b951-d872f2087c98

This DCHECK sometimes fails on the bots; seeing the failing values may help
us diagnose the problem.

BUG=50556

Review URL: http://codereview.chromium.org/3068010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50579
TEST=none

Review URL: http://codereview.chromium.org/3053022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54068 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3052022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54067 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3047021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54060 0039d316-1c4b-4281-b951-d872f2087c98

This was necessary because the Windows expand utility preserves the modification time from the archive. This lead to the extract_d3dx9 action firing repeatedly because the action output was older than the input.

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/3067008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54058 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3069008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54056 0039d316-1c4b-4281-b951-d872f2087c98

Crash was because of inconsistent state caused by threading issues.
The state of the buffer bar isn't so critical to need to be 100% accurate
at all times, so this is fixed by capping the buffered_bytes_ and
current_bytes to always be at legal values.

BUG=49870
TEST=media_unittests
TBR=hclam

Review URL: http://codereview.chromium.org/3045021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50537
TEST=Should not crash on official builds.
Review URL: http://codereview.chromium.org/3032034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54054 0039d316-1c4b-4281-b951-d872f2087c98

Includes fix for XP Perf by reducing webm library size by 1.6 MB
BUG=48037,50507
TEST=XP Perf and layout tests should pass

Review URL: http://codereview.chromium.org/3030024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54053 0039d316-1c4b-4281-b951-d872f2087c98

billing suggestions.

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3071003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54052 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3033036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3067011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50334,50335,50336,50347,50348,50349
TEST=None

Review URL: http://codereview.chromium.org/3067014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54047 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 50072
TEST= no tips on NTP.
Review URL: http://codereview.chromium.org/3033032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54045 0039d316-1c4b-4281-b951-d872f2087c98

With this change, both preconnection and preresolution are
enabled when the --enable-preconnection flag is turned on.

I'm expecting to enable this feature by default soon, so
as to better tune the parameters.


BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3032014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54044 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r54032, due to compile failure.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54041 0039d316-1c4b-4281-b951-d872f2087c98

(Code moved in r53967. Valgrind error is a false positive.)

http://codereview.chromium.org/2832092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options

Review URL: http://codereview.chromium.org/3038016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54032 0039d316-1c4b-4281-b951-d872f2087c98

Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs.
Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed.

BUG=48713
TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs.

Review URL: http://codereview.chromium.org/3046025

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/3058018

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/3032035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54031 0039d316-1c4b-4281-b951-d872f2087c98

The service will fetch tokens in the background and broadcast notifications after it's done.
Move some common constants out into a new file.
Modify TestNotificationTracker to support subclassing as it doesn't properly make a deep copy of notifications on the stack.
TEST=unit tests included
BUG=47093

Review URL: http://codereview.chromium.org/3024002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54028 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3028029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54025 0039d316-1c4b-4281-b951-d872f2087c98

It may be the case that some tests march onward with the wrong
directory and then do something bad.

Review URL: http://codereview.chromium.org/3033037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54024 0039d316-1c4b-4281-b951-d872f2087c98

In real usage, we won't be exporting public keys to a file, so refactor and update the API to reflect this.  Also, add a method to find a private key, given its associated public key.

BUG=chromium-os:4485
TEST=unit tests

Review URL: http://codereview.chromium.org/3078001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54023 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it compiles
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3026031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54020 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that window.open requests issued by ChromeFrame carry the correct cookies in the outgoing HTTP requests.

To achieve this we no longer issue navigations with the gcf:attach* prefix. We now issue a navigation to the current
page URL with the attach external tab suffix, which indicates that the page is forced into ChromeFrame without making
an actual HTTP request. This ensures that the new IE8 process has access to all HTTP cookies.

We need to patch IInternetProtocol::LockRequest and UnlockRequest to not call the underlying implementations for our
dummy request as this crashes in IE8 in the prebinding code path.

Fixes bug http://b/issue?id=2277519

Added tests for the CanNavigateFullTabMode helper function.

Bug=2277519

Review URL: http://codereview.chromium.org/3051018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54019 0039d316-1c4b-4281-b951-d872f2087c98

Fix memory leaks in the balloon controller unit test by loading the NIB in the correct test-friendly way, which allows the windows to be closed correctly and the cleanup code to run as expected.

BUG=49590
TEST=unittests

Review URL: http://codereview.chromium.org/2825073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54018 0039d316-1c4b-4281-b951-d872f2087c98

Also added a missing OptionsPage.setState call.

BUG=none
TEST=OptionsPage should work as expected when switching tabs and users/network list should be populated properly.

Review URL: http://codereview.chromium.org/3074007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54017 0039d316-1c4b-4281-b951-d872f2087c98

Failure seen on the buildbots.  It would help to know why.

Review URL: http://codereview.chromium.org/3067013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54015 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an assertion failure when trying to use this class on the Mac due to SkBitmap destruction happening during process exit handling.

BUG=None
TEST=Custom startup page list should still show default favicons.

Review URL: http://codereview.chromium.org/3028030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54014 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54013 0039d316-1c4b-4281-b951-d872f2087c98

The python sync server does not support recursive deletion, as a result of which test cases that remove a directory of sync entries end up failing.

This checkin updates the sync server to support recursive deletion of sync entries and all their childen.

BUG=50306
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3051019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54012 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3050018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54010 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2873061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54009 0039d316-1c4b-4281-b951-d872f2087c98

Enhance plugin logging a bit. This adds logging in a few more places, especially for Windows. This also changes the log level to ERROR so that when you opt in to plugin logging, you don't also have to set the log level to be INFO and put up with a low of log spew.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3013039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54008 0039d316-1c4b-4281-b951-d872f2087c98