GitLab

because of the use of an uninitialized value in a function call.
Fortunately, it turns out that call is completely unnecessary anyway, so
this simply removes it.

TBR=danakj@chromium.org,jhawkins@chromium.org

Review URL: https://codereview.chromium.org/911453002

Cr-Commit-Position: refs/heads/master@{#315242}

Rebaselines landed (a couple in progress).

BUG=452219
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/906073002

Cr-Commit-Position: refs/heads/master@{#315241}

The Web UI incorrectly states that the issued and expires dates for
certificates is in UTC, when in fact it's in local time. Additionally,
it appends UTC in a non-internationalized way. This patch fixes both
issues by adding a new time_formatting.h utility function to produce a
formatted time string with the local time zone appended.

BUG=426909

Review URL: https://codereview.chromium.org/827123004

Cr-Commit-Position: refs/heads/master@{#315240}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce6d54c..738bfa1

TBR=

Review URL: https://codereview.chromium.org/909703002

Cr-Commit-Position: refs/heads/master@{#315239}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/067f8ab..b8d4635

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/906053002

Cr-Commit-Position: refs/heads/master@{#315238}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e426ccc..ce6d54c

TBR=

Review URL: https://codereview.chromium.org/906863002

Cr-Commit-Position: refs/heads/master@{#315237}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/772b5df..e426ccc

TBR=

Review URL: https://codereview.chromium.org/893053003

Cr-Commit-Position: refs/heads/master@{#315236}

BUG=436459

Review URL: https://codereview.chromium.org/905763002

Cr-Commit-Position: refs/heads/master@{#315235}

Add KeyedServiceShutdownNotifier for classes that depend on keyed services but can't be keyed services themselves.

BUG=395391

Review URL: https://codereview.chromium.org/905703002

Cr-Commit-Position: refs/heads/master@{#315234}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8698150..772b5df

TBR=

Review URL: https://codereview.chromium.org/903413002

Cr-Commit-Position: refs/heads/master@{#315233}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6262aac..8698150

TBR=

Review URL: https://codereview.chromium.org/902403002

Cr-Commit-Position: refs/heads/master@{#315232}

When the user navigates to a new page, stop sending accessibility
events on the old page.

BUG=421116,450409

Committed: https://crrev.com/6ce40a1e561892849c1f6ac070dda140f6cc0115
Cr-Commit-Position: refs/heads/master@{#314812}

Review URL: https://codereview.chromium.org/830053004

Cr-Commit-Position: refs/heads/master@{#315231}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/01d3319..067f8ab

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/866403010

Cr-Commit-Position: refs/heads/master@{#315230}

Logging revealed the flakiness was in ::AccessibleObjectFromWindow.
Replace that with an alternative method, and remove the logging.

BUG=440579
TBR=dtseng,ananta

Review URL: https://codereview.chromium.org/901183003

Cr-Commit-Position: refs/heads/master@{#315229}

Cr-Commit-Position: refs/heads/master@{#315228}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/873033003

Cr-Commit-Position: refs/heads/master@{#315227}

All arm platforms support V4L2 SVDA by default and use_v4l2_codec also
governs V4L2 VDA/VEA now.
Generates libv4l2 stub in GN file.
This CL is re-landed because CL 828063009 is reverted by 902773003.

BUG=449883,455545
TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks,
and panther_freon
TBR=piman@chromium.org,posciak@chromium.org

Review URL: https://codereview.chromium.org/902143002

Cr-Commit-Position: refs/heads/master@{#315226}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/884fc25..6262aac

TBR=

Review URL: https://codereview.chromium.org/906813002

Cr-Commit-Position: refs/heads/master@{#315225}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/57bdc6e..884fc25

TBR=

Review URL: https://codereview.chromium.org/902373002

Cr-Commit-Position: refs/heads/master@{#315224}

1.)Populate failure strings for GPU info collection when
context_info_state records fatal failure.

2.)The vendorid and deviceid of gpu should give
data on all platforms where context fails to
run.
ex:On mac devices gpu info strings are not
collected (vendor, renderer, driver version),
so populate vendorid and deviceid while collecting
webglinfo which should always be valid.

In case vendor, renderer, driver version are not
populated they will be indicated as "Not Available"
on those platforms.

BUG=412440

Review URL: https://codereview.chromium.org/800483002

Cr-Commit-Position: refs/heads/master@{#315223}

Apparently ~15 months ago I introduced a bug that causes the
'test_report' step to crash on the chromium.webkit WebKit Android Nexus 4
bot to crash if more than 10 tests fail, flake, or pass unexpectedly,
and no one has noticed or at least dealt with it until now :(.

TBR=jbudodrick@chromium.org
BUG=

Review URL: https://codereview.chromium.org/891473007

Cr-Commit-Position: refs/heads/master@{#315222}

WebRTC 8220:8286
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cfe4b49..e898b13

Libjingle 8221:8277
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/18f533d..e361ce8

TBR=magjed@chromium.org

Review URL: https://codereview.chromium.org/905133002

Cr-Commit-Position: refs/heads/master@{#315221}

This reverts commit 4cf59ffa.

This patch appears to break the contentshell_instrumentation_tests on
the chromium.webkit waterfall. I'm not sure what to do about this,
as the .webkit tests appear to be run in a completely different
way than the .linux (main waterfall) tests, but I'm reverting this
for now and we can sort it out later.

TBR=jbudorick@chromium.org, maruel@chromium.org
BUG=400499

> Author: jbudorick <jbudorick@chromium.org>
> Date:   Fri Feb 6 16:43:24 2015 -0800
>
>     [Android] Convert ContentShellTest.apk to isolate.
>
>     We were previously using --test-data to push files from
>     //content/test/data/android/device_files to
>     $EXTERNAL_STORAGE/chrome/test/data/content. Switching to isolate lets
>     us handle all of our instrumentation and gtest data dependencies in the
>     same way. It will also facilitate using isolate to optimize transfers
>     between builders and testers.
>
>     BUG=400499
>     TBR=maruel@chromium.org
>
>     Review URL: https://codereview.chromium.org/878163004
>
>     Cr-Commit-Position: refs/heads/master@{#315148}

Review URL: https://codereview.chromium.org/886993003

Cr-Commit-Position: refs/heads/master@{#315220}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fad7ce8..57bdc6e

TBR=

Review URL: https://codereview.chromium.org/907673002

Cr-Commit-Position: refs/heads/master@{#315219}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5cc0f6c..01d3319

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/907663002

Cr-Commit-Position: refs/heads/master@{#315218}

Revert of Temporary commit to evaluate perf impact of prototype CPU profiler (patchset #10 id:170001 of https://codereview.chromium.org/888923004/)

Reason for revert:
Reverting temporary commit.

Original issue's description:
> Temporary commit to evaluate perf impact of prototype CPU profiler
>
> Design doc: https://docs.google.com/document/d/1Bv-I1yM9AjgY3t27ixdyWHCAW9IpVx02YQ-nSbIqccc
>
> BUG=
>
> Committed: https://crrev.com/47c6093645b62fbc9f68cf50375fc0626e32516c
> Cr-Commit-Position: refs/heads/master@{#315196}

TBR=cpu@chromium.org,wfh@chromium.org,vadimt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/904233002

Cr-Commit-Position: refs/heads/master@{#315217}

Since top controls height can now be changed, storing top controls
offset as an absolute value causes problems.  Normalizing its format to
(0, 1) means we we don't need to adjust it when the height changes.  It
also improves readability and means TopControlsManager will compute
correctly even when the height is currently 0.

This patch also switches top controls to use SyncedProperty.

See also Blink-side patch: https://codereview.chromium.org/882683003

BUG=430635

Review URL: https://codereview.chromium.org/901813002

Cr-Commit-Position: refs/heads/master@{#315216}

Follow-up to http://crrev.com/870053006 (which added the methods that accept user-supplied timestamps) and http://crrev.com/892463004 (which modified Blink to use the user-supplied timestamps).

BUG=345845

Review URL: https://codereview.chromium.org/894913006

Cr-Commit-Position: refs/heads/master@{#315215}

BUG=452592

Review URL: https://codereview.chromium.org/909633002

Cr-Commit-Position: refs/heads/master@{#315214}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/907643002

Cr-Commit-Position: refs/heads/master@{#315213}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5f27c14..fad7ce8

TBR=

Review URL: https://codereview.chromium.org/903763005

Cr-Commit-Position: refs/heads/master@{#315212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1c71d0a..5f27c14

TBR=

Review URL: https://codereview.chromium.org/906763002

Cr-Commit-Position: refs/heads/master@{#315211}

The current crash handler prints a message on logcat of the form
"### WebView crash. Version ..." whenever a crash is detected in an
Android app which happens to have a WebView.
Due to the in-process nature of the WebView, the crash handler is
triggered regardless of the actual cause of the crash, which might be
totally unrelated with the WebView or the chromium codebase at all.
The current wording is misleading as it erroneously suggests that the
crash is always due to the WebView.

BUG=456485
TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/903363003

Cr-Commit-Position: refs/heads/master@{#315210}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f087214..1c71d0a

TBR=

Review URL: https://codereview.chromium.org/906713003

Cr-Commit-Position: refs/heads/master@{#315209}

Revert of Added MockPresentationClient to use in layout tests. (patchset #1 id:1 of https://codereview.chromium.org/905823004/)

Reason for revert:
This is causing layout failures on the blink bots. They're crashing with the following assertion:

STDERR: [17800:1287:0207/062834:4514258387182:FATAL:mock_presentation_client.cc(34)] Check failed: controller_ != controller && (!controller || !controller_).

Original issue's description:
> Added MockPresentationClient to use in layout tests.
>
> Blink change with the test follows: https://codereview.chromium.org/906673002/
>
> BUG=412331
>
> Committed: https://crrev.com/49a225f6ecb52b805a99d55e9e37ed7e21ef7c1b
> Cr-Commit-Position: refs/heads/master@{#315204}

TBR=mkwst@chromium.org,peter@chromium.org,avayvod@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331

Review URL: https://codereview.chromium.org/906753002

Cr-Commit-Position: refs/heads/master@{#315208}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0692c5f..5cc0f6c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/905463008

Cr-Commit-Position: refs/heads/master@{#315207}

Cr-Commit-Position: refs/heads/master@{#315206}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9c87e95..f087214

TBR=

Review URL: https://codereview.chromium.org/905073002

Cr-Commit-Position: refs/heads/master@{#315205}

Blink change with the test follows: https://codereview.chromium.org/906673002/

BUG=412331

Review URL: https://codereview.chromium.org/905823004

Cr-Commit-Position: refs/heads/master@{#315204}

Revert of Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptu… (patchset #13 id:240001 of https://codereview.chromium.org/897483002/)

Reason for revert:
This breaks the WebRTC real webcam tests on Windows. See for instance http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester/builds/13860. The error is

[2292:2232:0206/211958:997267:FATAL:video_capture_controller.cc(474)] Check failed: static_cast<size_t>(length) >= frame_format.ImageAllocationSize() (0 vs. 614400)

The Win bots are equipped with C920 webcams. I logged into the bot to make sure the webcam was working right - it is as far I can see.

Original issue's description:
> Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().
>
> BUG=
>
> TEST=VideoCaptureDeviceTest.* in media_unittests pass.
>
> Committed: https://crrev.com/79288ba0b63021e8731e0401b8a4a9055d33fa10
> Cr-Commit-Position: refs/heads/master@{#315175}

TBR=mcasas@chromium.org,perkj@chromium.org,emircan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/898803004

Cr-Commit-Position: refs/heads/master@{#315203}