- 02 Dec, 2019 40 commits
-
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGPathElement> and DynamicTo<SVGPathElement> as new downcast helper 2. Use IsA<SVGPathElement>(element) in place of IsSVGPathElement(element) Bug: 891908 Change-Id: Ibbfb1dec739672a3c7a1bf9fc48b4478a4eea604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936613 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720442}
-
Jérôme Lebel authored
TBR: stkhapugin Bug: 1029709 Change-Id: Ic8d7021777e1977e9071d05853958646b74efc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944472Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720441}
-
Guido Urdaneta authored
Mark http/tests/devtools/network/oopif-content.js as Flaky on Linux. It has flaked a lot recently and even caused CQ false rejections. Bug: 1029528 Change-Id: I682559b28e741b956bf413ebc139da6b8e7556ca No-Try: True TBR: caseq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946330Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720440}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d050e5a75e36..d523ce04e70a git log d050e5a75e36..d523ce04e70a --date=short --first-parent --format='%ad %ae %s' 2019-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c8e3617e..8a450048 (272 commits) 2019-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bc82fb14aab4..ea0dcd4bda18 (7 commits) Created with: gclient setdep -r src/third_party/skia@d523ce04e70a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: bsalomon@google.com Change-Id: I2e90b8489e2db535f5614b900a4c3d6194c56084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720439}
-
Adam Rice authored
TransformStream and TransformStreamNative were separated to support having multiple implementation. Now that the V8 extras implementation has been removed, this division is no longer necessary. The initialisation of TransformStream has changed somewhat because it is no longer delegated. Modify users of TransformStreamDefaultControllerInterface to use TransformStreamDefaultController directly, and remove it. BUG=1029408 Change-Id: Ifd9fc0e71a52174eb33c60d08e93f5e74303eca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942893 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720438}
-
Guido Urdaneta authored
Mark external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.html as flaky. It has been flaking on all platforms and sometimes causing CQ false rejections. Bug: 1029713 Change-Id: I6069378774bc801902d50e65de8a00fb77ca8faf TBR: jsbell@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944672Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df12488bf4f8..3af1ae4c5509 Created with: gclient setdep -r src-internal@3af1ae4c5509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I6134f99682d19dedd9820bc4e49f0405f9adf456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946410Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720436}
-
Mikel Astiz authored
Crashes have been reported on Beta and and the implementation has been refactored since (base::Value refactoring) so it's safest to just disable the garbage-collection for one milestone. Bug: 1029673,989340 Change-Id: Id2e062ba302a7ffea970964170c492b513a52b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945812 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720435}
-
Juan Antonio Navarro Perez authored
Test is flaky. Bug: 971998 Change-Id: I357c5bf76ca34584c5a97cfd979272d52d88ee94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946369Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#720434}
-
Jan Wilken Dörrie authored
This change contains a small fix to the leak detection toggle when users navigate to the sync settings page from another settings page. Bug: 1029515 Change-Id: I3fbd63ea1e4d65cda43b45f9a1bbcc3639aceee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944174 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720433}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGMaskElement> as new downcast helper 2. Use IsA<SVGMaskElement>(element) in place of IsSVGMaskElement(element) Bug: 891908 Change-Id: I2781f717a10afb6187228647581b99a864ad851e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936612Reviewed-by: -
David Roger authored
This fixes a crash introduced by CL https://chromium-review.googlesource.com/c/chromium/src/+/1944387 Sync promos can be shown in incognito, and they used to be non-Dice promos. Dice promos are now used. To match the previous behavior, they use an empty list of accounts. Fixed: 1029634 Change-Id: I5761681517d4cc3af052e9835b347439e528106b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946328Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#720431}
-
Andy Paicu authored
This CL adds a checkbox that will display the current state of the notifications prompt quiet UI, which the user can then enable/disable at will. The quiet UI can be automatically-enabled by embargo-logic. Bug: 1014874 Change-Id: Ia5e68877acf4b4dce82fe4eb1679706c62c7f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930820Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720430}
-
Hugo Holgersson authored
When a fragmented (line broken) link has focus, we use one of its fragments (not their union) as search origin. Going Left: Start at the beginning of the link (the first fragment). Going Right: Start at the end of the link (the last fragment). This feels more intuitive and is probably a better UX for most users since most texts are written left-to-right. Discussed in: crrev.com/c/1912661 Bug: 1029269 Change-Id: I2ba214a3208ce82d3b6cb6a85b6840b3d9c33961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944169 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#720429}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 891670 Change-Id: I123507e4d4145ab7717729ddb122c6eb990f1827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944669 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720428}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f1017f0c7bd2..8adeb1cc5a26 git log f1017f0c7bd2..8adeb1cc5a26 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 fancl@chromium.org Vendorize pinpoint ui dependencies from dashboard Created with: gclient setdep -r src/third_party/catapult@8adeb1cc5a26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: I40be2e37218bd1e2b4ff74f781d69c5c90ea1805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946250Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=hjd@chromium.org Bug: 891670 Change-Id: I989334bbb928f8261e42608f1d6cf115db324a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944852 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#720426}
-
Rakina Zata Amni authored
We should check each ICU match to make sure they are valid (aren't empty or start/end in non-offset-in-anchor positions). Bug: 1028152 Change-Id: I1e99075a65e474cb7bf7fc14b08730f801df6541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939159 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#720425}
-
Greg Thompson authored
This reverts commit c3c37466. Reason for revert: canary top crasher; see https://crbug.com/1029631. Original change's description: > Collect user opt-in before enabling account-storage for passwords > > This CL adds a pref that stores which accounts have opted in to use the > Google account storage for passwords. While this pref is false, > passwords can not be saved to the account, and passwords in the account > are not downloaded. > It also adds an entry to the password autofill dropdown that lets the > user set the opt-in. > > Bug: 1024332 > Change-Id: Iac552c310d0e9f19ee2bb1893e217e60b1114d31 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645294 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720206} TBR=sdefresne@chromium.org,treib@chromium.org,dvadym@chromium.org,jzw@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024332,1029631 Change-Id: Ib859957d27a898652e001515652cde25a30ed1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944497Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720424}
-
Takashi Toyoshima authored
To match with the security origin of the test content, the target URL for the XHR should be 127.0.0.1 rather than localhost. Due to this mismatch, the test fails with OOR-CORS in the fyi bots. Even with this change, the test can verify if an isolated world can have an isolated CSP for running Chrome Translation. Bug: 1020471 Change-Id: I018ddccc2bc460947720bf3b114bf96c81ff1370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941535 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Yuki Shiino authored
The bindings generator needs to know whether a member is defined in a partial and/or mixin IDL fragment in order to make a Blink API call. Thus, records such information in CodeGeneratorInfo. Bug: 839389 Change-Id: I997e518c842e93d392846bf63480a9b8e0f7e1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942894 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#720422}
-
Yuki Shiino authored
Bug: 839389 Change-Id: If04ceea51b0e709fb8da91f6947140f754889ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943077 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=mkwst@chromium.org Bug: 891670 Change-Id: I3745d4df316f3acc29bc576d884f4e41dd6de273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944851 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#720420}
-
Alexander Timin authored
If navigation is reusing RenderFrameHost, we won't use BackForwardCache that case. This patch adds "RenderFrameHost reused" as a reason to the bfcache metrics and also records BrowsingInstanceNotSwappedReason for these cases as well. R=kouhei@chromium.org,hajimehoshi@chromium.org,falken@chromium.org CC=arthursonzogni@chromium.org BUG=1004676 Change-Id: I2a03a2144d4ed8d8e24136a981542cc97facee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942906 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#720419}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGEllipseElement>(element) in place of IsSVGEllipseElement(element) Bug: 891908 Change-Id: I94acafea6e7b5fbf87731859474c9915070a7407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936573Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I637e89b10e9b770a36fc3f007cc0ce71bc710aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943078 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I1837515ed902100be67c0dc74440f50d25002420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942594 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Adam Rice authored
Remove the WritableStream base class and rename WritableStreamNative to WritableStream. Remove WritableStreamDefaultControllerInterface and use WritableStreamDefaultController directly instead. Also, remove RaisesException from WritableStream locked accessor and change getWriter() signature to return WritableStreamDefaultWriter instead of "any". Bug: 1029408 Change-Id: I5c9aed0c4c1ca992eec9460a3bd41ca6900d0c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943652Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b334829a91d6..47f3eb42641b git log b334829a91d6..47f3eb42641b --date=short --first-parent --format='%ad %ae %s' 2019-11-29 afdx@google.com spirv-fuzz: Fix invalid tests (#3079) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@47f3eb42641b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: If927524a876ca9ce18a2a26f92b7e13075b214bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946102Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/frame as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes UserActivation::CreateLive() and CSPViolationReportBody::Create() factory functions. Bug: 939691 Change-Id: Ia299ca53a77076f86cbb124e7c1e3ab33272c1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943778Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/fileapi as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes some of File::Create() and Blob::Create() factory functions. Bug: 939691 Change-Id: Ifd8a6471f4c0fb3cc834efe82577803d59ba4441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943086Reviewed-by:
-
Gyuyoung Kim authored
As a step to remove Create() factory functions, this CL converts <{{cpp_class}}>::Create() to MakeGarbageCollected<{{cpp_class}}>. As this CL modifies the template file, dependent tests are modified by the change. Bug: 939691 Change-Id: I9546faf3e5c43b583d2f4694a75f5cbd70e4d10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946048Reviewed-by: -
Hugo Holgersson authored
When a fragmented (line broken) link has focus, we use one of its fragments (not their union) as search origin. Going Down: Start at the first fragment. Going Up: Start at the last fragment. This avoid an endless scroll loop when trying to scroll a page downwards: aaaaa FFFFFF FFFFFFFF When F is focused after a SCROLL, we now search below its first fragment, instead of going back to #a. This avoids a SCROLL-F-a-SCROLL-F-a loop. Bug: 1015965, 1029269 Change-Id: I4703c28d59f16db4f36f2524943ee4ed067b2dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912661 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 891670 Change-Id: I3cc1d3025d141b3d6bc7617c5982b6fe6a038dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944850 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Yuki Shiino authored
Supports copy construction of WithXxxx and improves ease-of-use. This technique will be used in https://crrev.com/c/1942594 . Bug: 839389 Change-Id: I0a59aaf7412b557481a81b4bb91f4c3d992b2949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943076 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Removes NamedConstructor that has not been used yet and that is not a constructor at all and may not be appropriate to be defined in constructor.py. Will introduce it once it turns out where and why we will need it. Bug: 839389 Change-Id: Ib27240e733d92e82e82a8a01f7b05fda1e231ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946168Reviewed-by:
-
Yuzu Saijo authored
This CL removes ServiceWorkerOnUI depenedency for the bfcache to work. Now, when ServiceWorkerOnUI feature is not enabled, tasks are posted on the UI thread from ServiceWorkerCoreThread. If it is enabled, tasks are run immediately on the UI thread. This way, bfcache would be enabled for both cases. Change-Id: I1a27ffddbe61d70c197408fdd098a6f9ee5d366e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939081 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Dominic Farolino authored
There are no immediate plans to tamper with this aspect of Priority Hints. If there is in future experimentation, we will make the necessary changes, but for now, this TODO is not actionable. R=yhirano@chromium.org Bug: 821464 Change-Id: I787e7db3967f618000d391b87576f1312879fe94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945939 Auto-Submit: Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL removes ServiceWorkerContextCore::GetProviderHost() used only in tests to reduce dependencies on ServiceWorkerContextCore::providers_. Bug: 931087 Change-Id: I3ddc6affac40556d626798b9bf21745c2b014e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946049Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#720404}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGAnimateMotionElement> as new downcast helper 2. Use IsA<SVGAnimateMotionElement>(element) in place of IsSVGAnimateMotionElement(element) Bug: 891908 Change-Id: Idd892a19c8b958253fd0fa7296f1cc803f8cf9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936569Reviewed-by:
-
