- 24 Oct, 2020 40 commits
-
-
Lindsay Pasricha authored
Bug: 1141723 Change-Id: Ia4795156483d4ec32b8670682718c7f5db4088c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493689 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#820535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b7cead9f979..2942ff0e4f55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If792aad36d48a3af3dde44e830ed96e6d7eba98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495426Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820534}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: Ia56240117b3138a8a774ebf799b843f2215ed6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494820 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#820533}
-
Michael Irani authored
- Mismatch introduced in 2487866 Bug: 1029954 Test: Manual Change-Id: I422bc73c0f04232f011e6f29835b3ae304348ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496037Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Irani <michaelirani@chromium.org> Auto-Submit: Michael Irani <michaelirani@chromium.org> Cr-Commit-Position: refs/heads/master@{#820532}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: Ic12afd68af4bb6b1eec07c66918db951eb08aab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494281 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#820531}
-
Jesse Schettler authored
A private property of SelectBehavior is referenced outside the behavior, so change it from private to public. Bug: 1059779 Change-Id: I5ef3dbf338393540ab0c4905f2f3122e7e758150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495407 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#820530}
-
David Van Cleve authored
This CL defines an interface with which //content embedders can satisfy requests for "local" issuance of trust tokens (https://github.com/wicg/trust-token-api), which are normally obtained by querying a token issuer's HTTP server but may in some instances be able to be provided by on-device entities, like system services or other trusted applications. Like the comment in trust_tokens.mojom discusses, we're adding this to //content/public because the implementations will likely, at least in part, vary by operating system and by specific browser brand or app. Design doc for one implementation: http://go/clank-device-integrity (internal only, sorry). Fixed: 1130276 Change-Id: I577050aaae103288576e04e9f75330a16bce718b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493520 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820529}
-
Harvey Yang authored
This commit adds frequently used constants, such as device attributes and channels, so that sensor clients can reference and use them directly. BUG=chromium:1006141 TEST=builds Change-Id: I5cd0b9c17067bb051dd9860270fed1b9fdab7f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477113Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Auto-Submit: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820528}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/58a26a83628c..375e1f6a6486 2020-10-23 robertphillips@google.com Add unit tests for vertexData in the thread-safe cache 2020-10-23 bungeman@google.com Remove code guarded by SK_LEGACY_SURFACE_PROPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: egdaniel@google.com Change-Id: I202d9c91d2a586a716ff5e3ca76fa15f79bbc907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495993Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820527}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/9ab6e8b9eb0e..f81c1081ea7d 2020-10-23 dneto@google.com wgsl-reader: treat function formal params as const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I227c5ab99ae126ae49ffce96f07a5b32a53b23da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820526}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c572b425..73fe59b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I57dfd47b5d04cdee34e15d9b8cae3ec8e4d5f779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495803Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820525}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ie7536bf111b251764626b9597af13a1eccad67e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488604Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#820524}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: Ib7d17a8327079194f0223558f4d3cc6eac330f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494420 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820523}
-
David Grogan authored
When deriving the content size suggestion we need to account for the aspect ratio and any definite cross axis size. In the code that does this we were using the flex basis instead of the cross axis size. This fixes two tests that were marked as failing. Change-Id: Ifcdd57434944f884a5c6b1c0dae68efa7e1bba6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490227Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820522}
-
Jimmy Gong authored
Was previously calculating notification timestamp from a Unix epoch time source. This patch fixes this by properly converting the timestamp to Windows FILETIME epoch. Bug: 1106937 Fixed: 1141587 Change-Id: I6d085a2b6449f8a8424a8c3e203939659d8bb32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493429 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820521}
-
Jeffrey Young authored
Clickable photo albums have role="checkbox" for accessibility and tast tests. BUG=b:169579102 Change-Id: I2520ecf4baed3dfad3dc7aa9e1176dc4f9b3b239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492420Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820520}
-
Eric Lawrence [MSFT] authored
The full email address must be specified when it does not end with the domain @chromium.org. Change-Id: I7614c2114b83a6cecc269a16279b88650bfd52d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495852 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820519}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: I12e6a89c1e06b7223f37e9d916e1c101d1f8b8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494405Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820518}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: I01eff901f3af62ba8800caca679afcb7d0a005e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494261Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820517}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: Idc61e2ce84b7e5971d523debd177ffdf4991fdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494186Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820516}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I72e54269ebabf0fc4fe1f21909d0b56c5d9ac682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495274Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820515}
-
Dana Fried authored
Badge displays forever until removed in code. Future enhancements could show the badge conditionally. Bug: 1055150 Change-Id: I112190c7be5c609994dce3d94db81032f744c1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487911 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#820514}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: Idc47df64e7f13e6b56d01628e21bd1a907ec7174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494443Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820513}
-
Liquan (Max) Gu authored
Context: Currently, some payment UI's colors, dimens, styles live in //chrome/android/java/res/values, and they are depended by //components. In order for //weblayer to depend on //components, these resources need to be moved into //components. Change: * Moved the payment's (and some autofill's - as they are used by payment UIs) colors, dimens, styles from //chrome to //components * Replaced color #B2B2B2 with @color/black_alpha_30 in the color files because they are equivalent according to go/clankcolors. Bug: 1141076 Change-Id: I2b40ed364e70f2e5cb243ad158b7af647c855de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490269Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820512}
-
Khushal authored
A platform bug can result in transaction acks getting dropped which stalls all rendering. A fix for this will be released in an R update soon so this changes disables using this API in Q. This also reverts an earlier workaround which was added for samsung dex mode since its not necessary after this change. TBR=skyostil@chromium.org Bug: 1131081 Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#820511}
-
Lei Zhang authored
Convert remaining callers. Bug: 646113 Change-Id: I66cf237f210ffb70bb03adfcb13c6de604f28525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482247Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f28949d69964..6f9b1bfd4849 2020-10-23 jessemckenna@google.com setup_color: Disable colorama on pre-Windows-10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114548 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id1d16eb7187d62364e6f03c2c81621ad4bc436ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820509}
-
John Lee authored
Bug: 1141573 Change-Id: I2ac4c7156e7b7e997bcadb0e187a53d8adfd3a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496024Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#820508}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3691164b7e2c..0b7cead9f979 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134167 Tbr: sky@google.com Change-Id: Ic8d20b510c8b4565668c787157ba4fe2f5e42909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495547Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820507}
-
David Grogan authored
Some hand calculations in the reference didn't age well. I replaced the -ref.html with checkLayout. The test failed in Firefox in an identical fashion. New test passes in both browsers. Just a test, no behavior change. Fixed: 1111708 Change-Id: I7fc82e5d990c57db6c0d205e30aacaed88990418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490251 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#820506}
-
Phillis Tang authored
Pass OsIntegrationManager to AppRegistrar, AppRegistryController and InstallFinalizer during |SetSubsystems| to avoid accessing it from WebAppProvider. Also update TestWebAppRegistryController to create a TestOsIntegrationManager during |SetUp|. Bug: None Change-Id: Icb8a73aed0fcd4cf127eabd4af4251cbf462864d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495821 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820505}
-
Weiliang Chen authored
Adding more data structures into the class that is shared between output surface and overlay processor. Following this CL, each viz::Display would have a DisplayCompositorMemoryAndTaskController, which is on the viz compositor thread. It will own a DisplayCompositorMemoryAndTaskControllerOnGpu, which is on the gpu thread. In this CL, we would have singular place for memory tracking and command buffer id. This is CL 2/? of sharing gpu data structure between output surface and overlay processor. R=rjkroege Bug: 1093440 Change-Id: I3f22a4fd56b082dd24115dd6e3e973bb188bed4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373395 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#820504}
-
Muyao Xu authored
This CL adds logs every time |has_local_display_route_|'s value changes. When its value is true, the cast toolbar icon should be blue, unless there are FATL or WARNING issues. Bug: b/165366974, 1117673 Change-Id: I082fadb913cdad4527020f2f10f06051d610deee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472531 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#820503}
-
wutao authored
Bug: b/170903277 Test: New test Change-Id: I76e8ad06a2307c1bb1bae1441b75f20efee189f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487884 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820502}
-
Piotr Bialecki authored
Yet another CL to unblock WebXR in WebView / WebLayer work. Changes: - ArCoreJavaUtils, ArImmersiveOverlay & ArDelegatenow no longer need to live in //chrome - moved them to //components/webxr - native ArCoreJavaUtils are also moved to //components/webxr - ArDelegate needs to be consumable by ChromeActivity - added required DEPS entries and created a target that is present independently of enable_arcore build flag - adjusted the location of linter suppression entries - converted them from entries in lint-baseline.xml into @SuppressLint attributes Bug: 843374 Change-Id: I8fa8a7594f69fd4bb6cb65326ef626300b5ab55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490235Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#820501}
-
Anders Hartvoll Ruud authored
Bug: 568705 Change-Id: I60d908398869162c664760da5d638d7bac2dae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489891Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#820500}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I01fd3e306d81c281f847496fb8795f38ce58b32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820499}
-
Roman Arora authored
Leverage content-visibility property to optimize render time. https://web.dev/content-visibility/ Screenshots from Dev Tools: Performance: original: https://drive.google.com/file/d/1bb_KeUWn1C0TDmUuhZO2zE0qcqqDlq3O/view?usp=sharing optimized: https://drive.google.com/file/d/1yHm19aq3ri7YnI9xUpPbfmVQCycuESXF/view?usp=sharing 6x-slow screenshots: original: https://drive.google.com/file/d/13ymyxUmpPWHNh0z-I_s_wUN2osGFwJW_/view?usp=sharing optimized: https://drive.google.com/file/d/1y7MPjiU9px2S0BlfRlCizKG9b9kj9tHi/view?usp=sharing Bug: 1099917 Change-Id: I2206817422cbaeb4a59ed1707a2e39dd354cc7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493092Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#820498}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42a741a2145c..58a26a83628c 2020-10-23 csmartdalton@google.com Fix the formula for fNumRadialSegmentsPerRadian in GrStrokePatchBuilder 2020-10-23 johnstiles@google.com Add unit test for nested function calls in FP files. 2020-10-23 reed@google.com Show cubic made up of 2 quads 2020-10-23 johnstiles@google.com Revive SkSLFPTestbed for basic verification of CPP/H codegen. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Id7e6b89b0915cb939688a4b63c53bddd6c3a7bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820497}
-
Darin Fisher authored
Bug: 1141261 Change-Id: I9f877ac89f9435193f04c87a6a3f3d51593f202d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495516Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820496}
-