- 10 Dec, 2020 40 commits
-
-
Harry Cutts authored
This CL adds a new setting for the pointing stick's primary button, with a corresponding dropdown on the pointers subpage. The setting carries over to the login screen, too. If the flag is disabled, changes to the equivalent mouse setting are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. login screen) Bug: 1114828 Test: Check the dropdown changes the primary button (including on the Change-Id: I3f078767bfe703a2f451eac807969e68e5273902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573389 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835852}
-
Jiaqi Han authored
The classpaths written by build/android/gyp/create_java_binary_script.py are relative paths to the current working directory, this CL removes the duplication part for the concatenation of source root and the relative paths. Merge-With: eureka-internal/494461 Bug: None Test: CQ Change-Id: I434e2807c86909c86dad9c5ebd528b8fbe56b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582411 Commit-Queue: Jiaqi Han <jiaqih@google.com> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#835851}
-
Amr Aboelkher authored
Hash dance timer usually starts off whenever the AutoEnrollmentCientImpl is going to start i.e. AutoEnrollmentCientImpl::Start(). However, as PSM is being executed in the beginning, before Hash dance sequentially, that will make the resulting Hash timer record Hash dance duration + PSM duration. This CL is starting the timer of Hash dance only when preparing and sending off the Hash dance request. Also, it adds its required regression tests. BUG=chromium:1157317 Change-Id: Ie4aa0b8a3bd6cf296e3804995cacc45c23833c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582121 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#835850}
-
Yue Li authored
This is a reland of 8144dae3 Original change's description: > Quick Answers: Add page size options for Search request > > Since we only use the first result from search request, set the page > size to 1 to reduce the delay. > > Bug: b/173239982 > Test: None > Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yue Li <updowndota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833940} Bug: b/173239982 Change-Id: I357edef540563fdbc8b5ba93bbb78ac127d827b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578262Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#835849}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/35f077086ef3..0a64a9747555 2020-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d94a77b3 2020-12-10 nicolascapens@google.com Update dEQP/Cherry setup documentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b3163a44bdbfe146dcfdcd142059394452f6a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835848}
-
Peter Qiu authored
Bug: internal b/174649142 Test: manual on device Change-Id: I737054f7aa7fbfed193dc7cd5dba29cd4ba3902c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582824 Commit-Queue: Peter Qiu <zqiu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#835847}
-
Joel Riley authored
Also update floating panel UI to match visual spec: go/enhanced-sts-spec AX-Relnotes: N/A Bug: 1143825 Change-Id: I0d5cf4b5c026e7eb7b5ccc6944a77d9247cab41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577882 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835846}
-
Kramer Ge authored
This reverts commit 500376ce. Reason for revert: crbug.com/1144179 has been fixed, we no longer make consecutive subsurface commits with fences. Original change's description: > [LaCrOS]Disable usage of linux_explicit_synchronization for now > > linux_explicit_synchronization can cause crash due to a bug in earlier > exo version. Underlying issue can be fixed from lacros side. Re-enable > once fix is landed. > > Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 > Bug: 1151012 > > TBR=rjkroege@chromium.org > > Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552854 > Reviewed-by: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829874} TBR=rjkroege@chromium.org,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1151012 Change-Id: I932daf018ac1e48898221f849652b50d65f1b0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580280Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#835845}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/108b759ef91b..f6df8692023c 2020-12-10 jmadill@chromium.org Vulkan: Support XFB in non-Vertex stages. 2020-12-10 kaiyili@google.com Add an option to copy the artifact to vendor partition 2020-12-10 jmadill@chromium.org Increase internal max uniform blocks limit to 60. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: run roll_aosp.sh --copy-to-vendor-partion, build the Android image Change-Id: I5e8d8661db84048c39452fedc8181aff7885a9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585724Reviewed-by:
-
Fritz Koenig authored
This is a short clip. If the hardware can decode the clip in it's entirety before sending a reset then there will be 2 flushes, not 1. BUG=b:174428494 TEST=tast.video.DecodeAccelVD.vp9_show_existing_frame Change-Id: Ia22aed2397d25567f019edb5f43740c8efeb0898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578381 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#835843}
-
Thomas Guilbert authored
This CL fixes a race condition in which a MediaLog could be created in a context that is already destroyed. See the attached bug for more details. Bug: 1154468 Change-Id: I26ae0c621d9a4557d224ca77f696ad3ce53b41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580478Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#835842}
-
Michael Bai authored
Make server and computed field types available for Java when the autofill starts, this patch doesn't work for prediction that arrives after the autofill start. Add the integration test. Change-Id: I2eb23f0244ce4b745eaa15bcaee57e10f41acd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581146 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#835841}
-
bttk authored
SitePerProcessAutoplayBrowserTest.PropagateUserGestureFlag is flaky. TBR=alexmos@chromium.org Bug: 1014175 Change-Id: I4547aaefd7337900f20883e0768a0bda418a923c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586207Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#835840}
-
Hans Wennborg authored
Otherwise the script doesn't run on Windows; relying on the shebang doesn't work there. Bug: 877722 Change-Id: Id7665fb1d03bece0d015eb6a9f2f7fbf96325d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582078Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bob Haarman <inglorion@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#835839}
-
Leonid Baraz authored
Bug: b:170054326 Change-Id: Id1948ddad64e6bec3ed960a83b910073b18bb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582863 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#835838}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9f89587dc4fc..6def748c92e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3d1a42b4aa0d2a14445637453b81ce2a30499c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585548Reviewed-by:
-
Boris Sazonov authored
Adds chrome/browser/lacros/account_manager_facade_lacros_unittest.cc and a couple of basic tests for AccountManagerFacadeLacros. To make that class testable, the mojo::Remote is now passed explicitly to the ctor. Bug: 1117472 Change-Id: I59826ff3c7c0d6561b8fd4cb94a164884eb91a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545923Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#835836}
-
Yue Zhang authored
SimplePlayPause and MultiplePlayersPlayPause are flaky on multiple Android bots. TBR: mlamouri@google.com Bug: 1157319 Change-Id: Ic1944c2281f10ba3dca8298e22d0a784d533919e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585668Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835835}
-
Austin Sullivan authored
- Allows for file picker prompt to start in a well-known directory (Desktop, Documents, Downloads, etc.) - If specified, this field takes precedence over LastPickedDirectory https://crrev.com/c/2478901 - Adds RuntimeEnabled feature flag for all in-development FSA APIs Bug: 1019287 Change-Id: I1f6278d2407e756e4a0e24ed043a93dc088e7905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555998 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Frank Liberato authored
Previously, we would elide any config change that arrived before the first frame was decoded, since the accelerated decoder sends one even if it matches the container config. Unfortunately, some streams actually do change config before the first frame (e.g., some RTC streams). Eliding it leaves the D3D11 decoder configured for the container config. This CL causes D3D11VideoDecoder to elide the config change, and prevent re-allocating the D3D11 decoder, only if the config matches what the container told us. Bug: 1109397 Change-Id: Ib9c5ec77897b24666118077935f91c541cbdabe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585666 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835833}
-
Garrett Beaty authored
This adds support for providing multiple console_view_entry values in ci.builder. Change-Id: Ia936e903a139e855fbdb14ca452a176225c56317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585446 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#835832}
-
Rachel Carpenter authored
Targeted for M89, launch bug crbug/1104668 Bug: b/174514210 Change-Id: Ica81eef4d720142a1725b105da5159ce46873e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583586Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835831}
-
edchin authored
This CL creates a base class that will hold cross-platform code. The derived class PasswordProtectionService (in /content) will have content-specific code. This CL keeps the base class in the same file to make the review easier. A followup CL will move the base class (and unittest) into separate files. * moves navigation throttle code to derived class. * moves some content-specific functions to derived class. Bug: 1147967 Change-Id: I1fa606f241225680bd33b7828fdfc6b588ad415d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576079Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835830}
-
Andrew Xu authored
This CL shows the delete button's inkdrop highlight when the button is under pseudo focus and protects the feature by a browser test case. Bug: 1151493 Change-Id: I3b42cb001e63002b658b84c662338e773efe5c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583208Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835829}
-
Robbie Gibson authored
Bug: 1056781 Change-Id: Ie7c1421b4e6767d6f9714f75f2317555045ff951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581920 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835828}
-
Trevor Perrier authored
Change-Id: Ib664751e624c8211035d6b00ff8e9ebc669f05a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585550Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Josh Simmons <jds@google.com> Auto-Submit: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#835827}
-
Jimmy Gong authored
Previously, the connected Phone Hub UI would display before the phone model is initialized. This resulted in the UI flashing the uninitialized status model before the actual phone model status. This fix delays the connected view from displaying until the model is initialized. Fixed: 1155636 Change-Id: Iadbbefbc3e5cee70316cfe02ef9d466888a2e6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581221 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Proposal: go/phishguard-referring-app-android. Add SafeBrowsingReferringAppBridge to obtain referring app information from java side. This class is not added under safe_browsing/ module, because it depends on IntentHandler, which is not modularized yet. Bug: 1154860 Change-Id: I75307e232a63d4f09016db7bb712186f266896d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568643 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835825}
-
Hiroshige Hayashizaki authored
As the non-bare keys and resolution results of specifier maps are normalized (i.e. serialized URLs), raw and percent-encoded non-ASCII strings are considered equal (as both of them are percent-encoded after serialization). This CL tests that raw and percent-encoded versions of non-ASCII characters are: - Considered equal in non-bare specifier keys, - Considered equal in checking backtracking, and - Not considered equal in bare specifier keys. For consistency, this CL also adds some backtracking tests that don't involve non-ASCII characters but use the same patterns of added non-ASCII tests. Bug: 848607, https://github.com/WICG/import-maps/issues/207 Change-Id: I6c8ae478da2fcbe0f6df03a608dabdad60644ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573422 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835824}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4a4586c0442385d383e3722d95d83053856e1ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585266Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607590477-d35f449faec99b40815e9d2dc99b7b8e79c372c4.profdata to chrome-win64-master-1607612331-9abd6632cfb32a4e513da1b46025c0e77c15ae02.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5a64d3d36c6532f12069f84961f02f981b749936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585104Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/73cdeec6..0937070d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic5199154a6b9052e516e9158a6d411909e1ca5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835821}
-
Luke Zielinski authored
This rolls up to SHA 0fb69997a8b5154bf39ba3ffa586c2aa25442da8 Change-Id: I04ceba8cf7238ff660f3aa3aad70041656ce26be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585624 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#835820}
-
Henrique Nakashima authored
TabModelSelectorImpl does not create or destroy TabPersistentStore anymore. Instead, TabModelOrchestrators manage the lifetime of TabModelSelectorImpl and TabPersistentStore. Give TabModelSelectorImpl a Supplier<TabPersistentStore> instead of passing TabPersistentStore directly. This is a step to break the two-way dependency between TabModelSelectorImpl and TabPersistentStore. Bug: 1138561 Change-Id: Ie2fa4a2735e509ff816b3e2cf5f8f6fffda7999c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572639 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#835819}
-
Kyle Williams authored
Minor fix to prevent prematurely starting the service. BUG=chromium:1105567 TEST='autoninja -C out/Default/ chrome/test:unit_tests && xvfb-run ./out/Default/unit_tests --gtest_filter=CfmLoggerServiceTest.*' Change-Id: Ifea6b11b79a1076c88310de84c87fa1c43e92ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585625Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/145deff4ccea..b5da31f17214 2020-12-10 chrche@microsoft.com [Loc] Migrate cookie_table to Localization V2 2020-12-10 andoli@chromium.org [module.json extensions] Migrate network views 2020-12-10 leese@chromium.org Fix test flakes in multi-workers and issues tab tests 2020-12-10 morlovich@chromium.org Add a utility for structured header handling (2/3) 2020-12-10 andoli@chromium.org [module.json extensions] sources views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073406,chromium:1073909,chromium:1134103,chromium:1136655,chromium:1157427,chromium:1157455 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I309a4dd4b55d5c6254ed4ecbdd2bb12c8f0ef070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585265Reviewed-by:
-
Nina Satragno authored
We show a generic error sheet when the authenticator is missing a capability or is locked. For any of these cases, the user might have tapped the wrong authenticator, or they may unplug and replug their authenticator. We should show a "try again" button like we do for other errors. Fixed: 1144183 Change-Id: I0bcd658becf18b50cc04737179764f7db77b38aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579826Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#835816}
-
Edward Lesmes authored
Bug: 1113033 Change-Id: I4739a56b308d818b65c29c5f60a7a2af57ac52c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582829 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#835815}
-
Scott Violet authored
The issue is the LocalMainFrame interface is registered on the renderer side once the LocalFrame is created. This means that if LocalMainFrame is requested before the renderer is created, any calls sent along the interface are effectively dropped. I tried adding a DCHECK in GetAssociatedLocalMainFrame() that it's only called if IsRenderFrameCreated() is true, but that hits in tests. BUG=1154852 TEST=comment change only Change-Id: Id602b1883c7b554f07fc50ecc78c7fa8e041602b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585306Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#835814}
-
Xianzhu Wang authored
In paint properties, if both mask and mask-based clip-path exist, we make the ClipPathMask effect node as a child of Mask node, which requires us to paint mask before clip-path mask. The latter applies on the former to create an intersection of the masks, then the intersection will be applied to the masked content. Previously the clip-path mask was painted before the mask, and the former applies to a transparent backdrop which had no effect. Bug: 1155384 Change-Id: Ic40c8254193c141a286c4b323515fabf8a76e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583154 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#835813}
-
