GitLab

The logic to calculate where the SDK should be is already done by
envsetup and made available to gyp as a variable, so just have gyp pass
this as a command line argument to ant. The behaviour is identical.

This change is to move toward making it possible to build the Android
port without having envsetup.sh sourced at build time (only at
gyp-generation time), making it more like other platforms. It also
simplifies the ant buildfiles.


Review URL: https://chromiumcodereview.appspot.com/10821105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:139126
TEST=Still compiles and passes tests, no functional changes.
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149399 0039d316-1c4b-4281-b951-d872f2087c98

Leak in V8/WebKit bindings, leak in Mesa; extend a suppression for null deref
BUG=138510,139998,139996
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10829120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137864

TEST=StringPrintfTest


Review URL: https://chromiumcodereview.appspot.com/10800078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139581

Review URL: https://chromiumcodereview.appspot.com/10824089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149396 0039d316-1c4b-4281-b951-d872f2087c98

- The GTK login prompt dialog is used for HTTP auth. Some websites need HTTP
  basic access authentication, then the login prompt dialog is required.

BUG=90445
TEST=HTTP authentication websites tested
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149395 0039d316-1c4b-4281-b951-d872f2087c98

Instead, let it be reset during the destruction of BrowserMainLoop, which
happens after the IO thread has been shutdown.

This prevents a race condition between ShutdownThreadsAndCleanUp() and the
destructor of InputTagSpeechDispatcherHost. The latter runs on the IO thread,
and could sometimes end up trying to use the SpeechRecognitionManager
at the same time as it was being destructed.

Tested by running WorkerTest.QueuedSharedWorkerShutdown a couple of hundred
times under ASan, as well as running existing speech tests.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10836007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149394 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149393 0039d316-1c4b-4281-b951-d872f2087c98

BUGF=none
TEST=none
TBR=apavlov
Review URL: https://chromiumcodereview.appspot.com/10843025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149392 0039d316-1c4b-4281-b951-d872f2087c98

If GData search done on the server contained entries that are not in the local
snapshot of the file system, it typically indicates there exists a newly added
entry on the server (but not notified to the local client). This CL requests a
delta feed in such a case. Arrival of the delta feed is notified to the file
manager, and the search result is re-queried.

BUG=138786
TEST=manual (see the bug for repro steps).

Review URL: https://chromiumcodereview.appspot.com/10835031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10821124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:138667
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10818019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149388 0039d316-1c4b-4281-b951-d872f2087c98

But, SpdyStream and StreamSocket use IOBuffer in their interfaces.
To reduce memory copies, we should use IOBuffer to hold data.

BUG=none
TEST=net_unittests


Review URL: https://chromiumcodereview.appspot.com/10796107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137319
TEST=Hover over the Extension Commands link and make sure the hand appears. Also make sure the link works as before.
Review URL: https://chromiumcodereview.appspot.com/10821102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149386 0039d316-1c4b-4281-b951-d872f2087c98

This will help with changing the icon's appearance when it's in
request-to-act mode.

To deal with the fact that ExtensionAction can't load files, the
platform-specific code now explicitly caches icons into the
ExtensionAction.

I also noticed that several users were converting the returned icons
into another format, and caching the most recent such conversion.
Since gfx::Image does that automatically, I switched to storing that
instead of SkBitmap.

BUG=133142


Review URL: https://chromiumcodereview.appspot.com/10806058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149385 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149384 0039d316-1c4b-4281-b951-d872f2087c98

This change pulls hunspell to merge r147911 <http://crrev.com/147911>.

TBR=palmer,jschuh
BUG=14721
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10829115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127493
TEST=manually checked on lumpy


Review URL: https://chromiumcodereview.appspot.com/10817028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149382 0039d316-1c4b-4281-b951-d872f2087c98

We unify seccomp-bpf and seccomp-legacy initialization in the same
file.

TBR=jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149381 0039d316-1c4b-4281-b951-d872f2087c98

- In case of crbug.com/139441, End() should close the window but it also schedules OnColorChooserDialogClosed() and this has been released already.  That call isn't necessary in this case, so set_listener to NULL.
- tab is expected to call DidEndColorChooser() everytime it ends, thus it should be called in End() too. the callback to prevent the calling


BUG=139441


Review URL: https://chromiumcodereview.appspot.com/10821087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149380 0039d316-1c4b-4281-b951-d872f2087c98

When media elements got deleted, stream_texture_factory_ will get deleted before video_frame_.
This causes the callback function to execute with a null pointer.
Move the DestroyStreamTexture call in to WMPA dtor.

BUG=138827

Review URL: https://chromiumcodereview.appspot.com/10828079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139964
TODO=run DriveAPIParserTest.FileListParser

Review URL: https://chromiumcodereview.appspot.com/10843023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149378 0039d316-1c4b-4281-b951-d872f2087c98

Still multiple list (uses next_link and token), parent
folder handling etc. are missing, but minimal information
is captured.

BUG=chromium:127728
TEST=unit_tests --gtest_filter="DriveApiParserTest.*"

Review URL: https://chromiumcodereview.appspot.com/10829056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149377 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=build success


Review URL: https://chromiumcodereview.appspot.com/10827067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149376 0039d316-1c4b-4281-b951-d872f2087c98

Most of them are replaced with WeakPtrFactory to avoid exposing AsWeakPtr()

BUG=None
TEST=build success


Review URL: https://chromiumcodereview.appspot.com/10824061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149375 0039d316-1c4b-4281-b951-d872f2087c98

- change the implementation of web auth flow window to use browwer popups
- Use notifications instead of being a WebContentsDelegate for navigation events and window close events.
- Change tests accordingly.

BUG=130204

Review URL: https://chromiumcodereview.appspot.com/10826078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149374 0039d316-1c4b-4281-b951-d872f2087c98

This class is introduced to separate code related to WAPI
(codename of Documents List API) feed processing.

To minimize diffs, the the class is defined in gdata_file_system.cc
The code will be moved to a set of new files in a separate patch.

BUG=130669
TEST=out/Release/unit_tests --gtest_filter=GData* && out/Release/browser_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10825120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149373 0039d316-1c4b-4281-b951-d872f2087c98

Also add --experimental flag to build_sdk.py so we can test a library without
it being included in the archived SDK.

BUG=122229
TEST=none
R=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10829027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149372 0039d316-1c4b-4281-b951-d872f2087c98

The update notifications were sent at every download progress and flooded the
file manager UI. This patch inserts a check on frequency so that the event
keeps the interval of certain (currently 1000) milliseconds.

BUG=138838
TEST=manually tested copying large files.

Review URL: https://chromiumcodereview.appspot.com/10834027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139849

Review URL: https://chromiumcodereview.appspot.com/10828105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149370 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a svn:executable flag to a python script.

TBR=eatnumber
BUG=none
TEST=check_perms
Review URL: https://chromiumcodereview.appspot.com/10823116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149369 0039d316-1c4b-4281-b951-d872f2087c98

Our counts of non-useless updates are wrong in part because of the way
we track deletions.  When an item is deleted, we flip the IS_DEL bit.
On restart, we purge all fully synced IS_DEL items from our directory.
However, we might still receive some re-deliveries of the tombstone for
that item.  The old algorithm would consider tombstones of non-existent
items to be "useful", despite the fact that they're often just
reflections of updates we've already received.

The updated algorithm isn't perfect.  There's no easy way to distinguish
between a tombstone created by another client where this client never
saw the original (which one could argue is useful, and definitely not a
reflection) and the re-delivery of a tombstone created by another client
which this client has already received and processed long ago (which is
definitely not useful).  Both scenarios look the same, and both will be
counted as 'reflections' under the new algorithm.

A similar issue arises with UNIQUE_CLIENT_TAG items.  When we delete
them we force their version to 0 locally.  This makes our regular
reflection detection algorithm ineffective.  This change updates the
algorithm to consider tombstones to items that have UNIQUE_CLIENT_TAG
and are locally deleted to be reflections.  It's not perfect, but it
should be good enough for our purposes.

BUG=139684

Review URL: https://chromiumcodereview.appspot.com/10834095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149368 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10825117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=hshi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149366 0039d316-1c4b-4281-b951-d872f2087c98

It will be used in WebKit for the color suggestion picker popup.

BUG=139288
TEST=LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

Review URL: https://chromiumcodereview.appspot.com/10824058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133088
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10830059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135546

Review URL: https://chromiumcodereview.appspot.com/10843020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149362 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149361 0039d316-1c4b-4281-b951-d872f2087c98

Remove hashes from DEPS file and instead use the ones specified in the NaCl
repo for the version of NativeClient specified in the DEPS file.

BUG=http://code.google.com/p/chromium/issues/detail?id=138285
TBR= bradnelson@google.com

Review URL: https://chromiumcodereview.appspot.com/10821118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149360 0039d316-1c4b-4281-b951-d872f2087c98