- 28 Dec, 2019 33 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5bce433bdae6..6ee4206ee994 Created with: gclient setdep -r src-internal@6ee4206ee994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3876986aca3895b560a9370b88f2dd6cdbe86c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983581Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727685}
-
Etienne Bergeron authored
Add unittests for getCursorBounds to avoid breaking it with coming code refactorings. R=pkasting@chromium.org Bug: 1025561 Change-Id: I358623e9be67627b104ca6729b3b688a4e221a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981854 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#727684}
-
Dan Beam authored
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1034836#c2 R=rbpotter@chromium.org Fixed: 1034836 Change-Id: Ica1e595263de2e5b34499352435d4d99ff866133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983551 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727683}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=355446 Change-Id: I58db2de0c366c427bfa86595004bc3815576be5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983548 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b015b7d12040..139deb3609b0 git log b015b7d12040..139deb3609b0 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@139deb3609b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I970b6d4a4bf484bba698f128cb930a3adabee301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727681}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I2dfffc7094d4a5d2eb105aef876ce8ab7ede3a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981855Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727680}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic245e3f8cdb39de63301e98b206e928d000f7d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983507Reviewed-by:
-
Caleb Rouleau authored
All Telemetry tests are currently run as part of One Buildbot Step (OBBS): performance_test_suite. However, gtest perf tests are run separately. This causes problems since these tests have to finish before we can start the Telemetry tests. So even thought these tests are fast, they block a bunch of other tests. This changelist adds these test to the shard maps so that they can be run alongside the Telemetry tests as part of the same shards. This allows us to distribute load across all the shards evenly. As a first test, this changelist only does the switch for Nexus 5. If this works, I will follow it up with changes for all the other builders. Please note that this changelist should not be cleanly reverted because it changes which shard the various telemetry tests run on. This change can cause false-positive improvements and regressions as a result of the bot that the stories are running on changing. If this change is reverted, then that will cause another set of these false positives as the stories change back to running on an earlier bot. Bug: 921353 Change-Id: I0dabb053ba21b05cc9e97f540e23e59829e3e44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983326Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab693fffbdba..5bce433bdae6 Created with: gclient setdep -r src-internal@5bce433bdae6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0788d434c83efbd20d741b43e2f42246d0f1a86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983503Reviewed-by:
-
Etienne Bergeron authored
The lifted function is similar to the ExpandRangeToWordBoundary(...). It allows to get the enclosing range at grapheme boundaries. R=pkasting@chromium.org Bug: 1025561 Change-Id: I4f439b81ac0c1c7e540f67b98c9e3e7f9757b36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982714 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
rbpotter authored
- Delete code paths from browser settings people pagethat are behind showOSSettings = true - Move sections of UI that are always hidden when showOSSettings = false to chromeos/os_people_page. Bug: 990132 Change-Id: I162bef622cda7e60254b301106aa3628b20de3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978254 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727675}
-
rbpotter authored
Moving CUPS printers files from c/b/r/settings/printing_page to c/b/r/settings/chromeos/os_printing_page, and deleting CUPS printers link row from browser settings printing page, since it is only shown when showing the OS settings. Also fixing the getEulaUrlGetsCalledOnModelChange test, as it always fails for optimize_webui=false before this CL. This appears to have never been detected due to https://crbug.com/1003483, which disabled all OS settings browser tests on debug builds. Bug: 990132 Change-Id: Iba9d153c69accd53396132d21046e055e6e3556c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982669 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
rbpotter authored
The test was only flaky for Linux CFI and Mac 10.10 but was disabled on all platforms. Re-enable it for builds that aren't Linux CFI or Mac. Bug: 1008122 Change-Id: I5e442736fa80a3b1e8afc727696c3964f0dd205f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983457Reviewed-by:
-
Matt Reynolds authored
Microsoft released an updated "Series 2" version of the Xbox Elite Wireless Controller in 2019. The updated version uses Bluetooth for wireless connectivity instead of the proprietary wireless protocol used by earlier Xbox One gamepads. This CL adds mappings for Xbox Elite Series 2 on Linux when connected over USB and Bluetooth, and on macOS when connected over Bluetooth. The device does not provide inputs on macOS when connected over USB. BUG=1022220 Change-Id: Id323c0536ed01645030c5f73287add3b8c28e780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983354 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#727672}
-
Regan Hsu authored
Currently, there is an unnecessary blink of enabled 'Backspace' button. This regression occured because a transition time was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1898479 to iron-icon, causing a momentary blink. This CL removes the transition time to the fill so there is no blink in the beginning on the backspace button. Doing so does not cause any blatant changes to other actions applied on backspace button (i.e deleting a pin number when the button is enabled). Fixed: 1036266 Change-Id: I539ec8b2f775c868d560f8fa2df76299bf8a7a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983344 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/726986fab08b..f77838c9ed9f git log 726986fab08b..f77838c9ed9f --date=short --first-parent --format='%ad %ae %s' 2019-12-28 hypan@google.com Add reference binaries for android app bundles Created with: gclient setdep -r src/third_party/catapult@f77838c9ed9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986990 Tbr: skyostil@google.com Change-Id: I536a8a085c5cb69acfbcff3cf0e5621c2bda1c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983500Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I62a36fc558389e61047f263d02477a71a74b70ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982935Reviewed-by:
-
Tarun Bansal authored
Bug: 1037033 Change-Id: I29827fadfdb4fbdfc5e2ca6b252cacc043119d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983351Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727668}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2dc05978f1d..8ac79125c052 git log f2dc05978f1d..8ac79125c052 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d814fc7e..9986f224 (727531:727633) Created with: gclient setdep -r src/third_party/webrtc@8ac79125c052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I33121717c0b0a3d52be03182e2464f36975e3bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982937Reviewed-by:
-
Peng Huang authored
GLSurface clients expect GLImages used by previous frame can be reused after a new frame is swapped, so the client may start issuing GL commands against the GLImage in the SwapBuffers callback. So GLSurfaceEGLSurfaceControl should set read fence of GLImage first, and then run the SwapBuffers callback. Bug: 1036566 Change-Id: I38b3d14b68bb8dc93fb8a042782faaf9a54cb4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979629Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727666}
-
Andrey Kosyakov authored
This fixes more tests that became flaky due to asynchronous destruction of HeadlessWindowTreeHost (https://crrev.com/c/1977741) TBR=kvitekp@chromium.org, kylechar@chromium.org Bug: 1037652, 1034954, 1036627 Change-Id: I29b2490d9f1f49157dd1207c4b0bae0507b0c405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983540Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727665}
-
Emily Stark authored
(This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1978898, with a different test that relies on a slow HTTP response instead of a long one, to avoid OOMing some trybots.) With HTTP auth committed interstitials enabled, extensions were getting notified of each auth request twice: once when LoginHandler is first called to cancel the auth request and show a blank error page, and again when LoginHandler is called after committing the error page to show a login prompt on top of it. In common operation, the second extension dispatch was a no-op, because the request had been destroyed already by the second entry into LoginHandler. But, there was a race ticked by long response bodies. That is, it was possible that the second onAuthRequired event would be dispatched to an extension before the request was destroyed. The request was destroyed between the second dispatch and the extension's reply. When the extension replied,the WebRequestAPI would simply drop the reply for the now non-existent request, never returning control to LoginHandler so that it can proceed to show the login prompt. The fix is to ensure that auth requests are dispatched to extensions only once, on the first time LoginHandler is called, before the request is cancelled. Bug: 1034468 Change-Id: I735f9c76bce5788c5362d7d04e6f81fdcd9535d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978898Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#727041} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980766 Cr-Commit-Position: refs/heads/master@{#727664}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I685d7e499684c3bc4515a983f6a224dc2690eb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983447Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#727663}
-
Xiaocheng Hu authored
Bug: 1024767 Change-Id: I824e98765b2869ca9d674a17ef3e738ec9a01a1f NoTry: True Tbr: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983501Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/588c373aced1..ab693fffbdba Created with: gclient setdep -r src-internal@ab693fffbdba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I103e376cb84636225f4a6482b228fad5d8447a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983445Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/263d57d37615..726986fab08b git log 263d57d37615..726986fab08b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 khokhlov@google.com Revert "Reland "[Telemetry] Make proto trace format the default"" 2019-12-27 chonggu@google.com Reland "[Telemetry] Add Fuchsia device support." 2019-12-27 khokhlov@google.com Reland "[Telemetry] Make proto trace format the default" Created with: gclient setdep -r src/third_party/catapult@726986fab08b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642,chromium:1028612,chromium:1036638 Tbr: skyostil@google.com Change-Id: I6ee9250507587d0d469a492d05abb77b233ad053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983439Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1038128 Change-Id: I2cb8c6575adea53ec8ae0b44949647fec7db8707 NoTry: True Tbr: mek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982938Reviewed-by:
-
Xiaocheng Hu authored
Test is flaky. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/85451 Bug: 1038156 Change-Id: Ice9b10b2acaedcba0ecf3463475d94962af27514 NoTry: True Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982936Reviewed-by:
-
Bailey Berro authored
- This CL delays the rendering of the arrangement section until |displays| is truthy to avoid the arrangement section flashing. Bug: 1022315 Change-Id: I36da215142ed8bafb739dbbdedaf9bfa4f2baf24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979115Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#727657}
-
Brandon Wylie authored
TBR= mlamouri@chromium.org Bug: 1038151 Change-Id: I46a30236c75694c7682cbadedce36c649ad064fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983448Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727656}
-
Xiaocheng Hu authored
[Sheriff] Disable GooglePasswordManagerNavigationThrottleTestWithPasswordManager.PasswordsWithGPMAndSyncUserClickedLink Bug: 1029034 Change-Id: I4a3729f7435b1002b36d53140b5b3f5d31fec6b0 Tbr: vasilii@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982934Reviewed-by:
-
Andrew Xu authored
Enable the hotseat feature as default. Besides that, this CL does the following things: In annotation_feature_enabled_test.js and zcr_remote_shell_unittests .cc, the current tests assume that the shelf icon's size is 56x56 which is not always true under hotseat. So those tests are fixed by hard code. TBR=tbarzic@chromium.org,oshima@chromium.org tbarzic: chromeos_features.cc oshima: zcr_remote_shell_unittest.cc Bug: 1032702 Change-Id: I3b51893d4724e6f085fea8ca7c0b9b415e6cea4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974861Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727654}
-
Avery Musbach authored
Bug: None Change-Id: Iedec344fda56e80c083b31d968729cfc51b32d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983357Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#727653}
-
- 27 Dec, 2019 7 commits
-
-
Avery Musbach authored
Bug: None Change-Id: If9551bcc5b7d23affb1799adf821efa100df40ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983190Reviewed-by:
-
Avery Musbach authored
OverviewWindowDragController::DragResult values are only ever checked against kSuccessfulDragToSnap. Distinctions among the other values are for readability only. See the code review comment at [1]. So the present CL cleans it up with semantic meaning in mind, and not much concern about functionality. OverviewWindowDragController::CompleteNormalDrag is significantly simplified near the end. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1570218/3/ash/wm/overview/overview_window_drag_controller.h Bug: None Change-Id: I0ae77c4b7d8d4dfa5f01dfbcbd6990c8bd27a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983349 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6a291685941..588c373aced1 Created with: gclient setdep -r src-internal@588c373aced1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1036426 Tbr: jbudorick@google.com Change-Id: I4708c5b71bcef8b32b9fe1b5c1b8f676999920b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982929Reviewed-by:
-
Tricia Crichton authored
When Timeout occurs running a command, return status 500 to client instead of 408. This cl restores compliance to the WebDriver spec. Bug: chromedriver:3291 Change-Id: Id48d08cace4dc6faf36270e130b859b179faa326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983340Reviewed-by:
-
Xiaocheng Hu authored
Test is flaky: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36522 Bug: 997786 Change-Id: I97f2e400e829b13859033767a257402325646cf3 NoTry: True Tbr: treib@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983441Reviewed-by:
-
John Abd-El-Malek authored
This allows production code to get to ProfileImpl from a BrowserContext, and tests to interact with it directly in future cls. Change-Id: I5f3c9899a661a3b05c67e1287467b3dbabf7f75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983255Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727647}
-
Tarun Bansal authored
These are no longer needed. Bug: 1037176,1037172 Change-Id: I894a8ae7a0e8a467ac1786f934daef58bc1dcc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983348 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727646}
-
