- 10 Mar, 2020 40 commits
-
-
Ionel Popescu authored
Per the comment in [1], this CL updates the focus ring color when increased contrast is enabled on Mac to #101010. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1054813#c22 Bug: 1054813 Change-Id: Iac10ec3a21bf920bd16744f7752d7a24a4aa1906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094345Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748483}
-
Tim Song authored
BUG=1040648 Change-Id: I911c466951ea2a1691c9ee5539bc5c7573d948fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095781 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748482}
-
Tomasz Wiszkowski authored
This change introduces Adaptive suggestions count, where the number of offered suggestions is driven by the available screen space. The mechanism needs to decide whether a suggestion is eligible ahead of Layout call, and is therefore unable to reliably identify the height of a suggestion, therefore we use minimum suggestion height instead. Bug: 1050813 Change-Id: I1fc440f6e86fc0ca764b79e8c835be174bf31da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071139 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#748481}
-
Archana Simha authored
Previously if the extension was in split mode both the incognito and the non incognito processes would receive the onAlarm event even if the alarm was created in a different browser context. Now alarms.onAlarm is restricted to the browser context the alarm was created. Bug: 1011374 Change-Id: I1c5ed9273da1ec7d4e8b211b04591c8ae839ad1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067542Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#748480}
-
Jinsuk Kim authored
It is possible that the preview tab is requested to open, while it is already the current bottom sheet content just hidden in the controller. This CL makes sure it will be visible by moving it to the appropriate peek/open state. Bug: 1057966 Change-Id: Id3dca309738d22cca5086325272a4aa0dff67724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087307Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748479}
-
Hongchan Choi authored
Some AudioNodes require an access to the execution context (mainly because of the task runner) and this might not work (null-deref) if the associated frame/document of a BaseAudioContext is already detached. This change adds a check against ExecutionContext in the factory methods of problematic cases. Test: Ran submitted reprocases on ASAN and they do not crash anymore. Bug: 1057735, 1058693, 1058648, 1058687, 1058668 Change-Id: I4c6b994087f8f9561edd4fe8eaa74961fa3bebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095141 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748478}
-
Alex Danilo authored
Icons for the action bar buttons are controlled using -webkit-mask-image applied to a child of the buttons. The clear button in the search box had the mask applied directly to the button which caused any border applied by focussing to be masked out. Add a child <div> to the clear button to be consistent with all the other action bar buttons. Applies the mask to the child div instead of the containing clear button. Tbr: noel Bug: 1059012 Change-Id: Ie0273eb97b06fb4b588ce523a06673d5606fe056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094427 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#748477}
-
Chih-Yu Huang authored
Currently, we used base::Feature "ChromeosVideoDecoder" to control VD enabling. For those unsupported boards, we add the cmdline argument "--disable-feature=ChromeosVideoDecoder" to disable the feature. However, this argument doesn't affect at guest mode. So when we enable the feature by default, those boards cannot play video at guest mode. In this CL, we add a new cmdline flag "kForceDisableNewAcceleratedVideoDecoder". We pass this flag to GPU process, and this flag forces to disable the ChromeosVideoDecoder feature. Bug: b:149797442 Test: Add/Remove "--force-disable-new-accelerated-video-decoder" at /etc/chrome_dev.conf then run `tast run $(DUT) video.Play.h264_guest`. Check VDA or VD is created as expected Test: ./gpu_unittests --gtest_filter="GpuPreferencesTest.*" Change-Id: I1257947fee388e0edbe52e258fbf3f6e5afca795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063511Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748476}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23899c64e3db..ea3ddc9aefde git log 23899c64e3db..ea3ddc9aefde --date=short --first-parent --format='%ad %ae %s' 2020-03-09 fmalita@chromium.org [skottie] KeyframeAnimator builders 2020-03-09 scroggo@google.com Update SkWebpEncoder.cpp's copyright notice 2020-03-09 kjlubick@google.com [canvaskit] Update dash example link to use new API. 2020-03-09 nifong@google.com Fix deprecated names Created with: gclient setdep -r src/third_party/skia@ea3ddc9aefde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ib5bd141971411b8c436d8977e7c2c2d105387d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748475}
-
Mustafa Emre Acer authored
The current implementation checks the URL too early. If the URL is non-HTTP(S) (e.g. a data URL), url.GetWithEmptyPath() returns an invalid GURL and causes a DCHECK. Bug: 1056755 Change-Id: I9923d5f28dae10382ac6701ca5cc25342c24a0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095778Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748474}
-
Tibor Goldschwendt authored
Previously, NewTabPageHandler was a content::WebContentsObserver. However, we never associated it with a web contents. As a result, all usages of web contents in the NTP handler were in fact a nullptr. This CL fixes this by passing the correct web contents when creating the NTP handler. Additionally, it removes content::WebContentsObserver as one of the handler's interfaces as we are not observing any changes. Change-Id: I4d79b726dbc7377f29b6f0630680bb13082a3c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095785 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#748473}
-
Carlos IL authored
This histogram is expiring soon. Since it was launched to check usefulness of chrome://connection-help, which has since launched, it is not required anymore. Results have been fairly stable at around 20% of "Learn More" clicks resulting in a redirect to chrome://connection-help (due to the navigation triggering another SSL interstitial). Bug: 1059826 Change-Id: I99b87138e0a7776bd89ec9d3785380c725e0f176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095209Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#748472}
-
Wenyu Fu authored
In the original implementation, screen reader cannot read out the content for RadioButtonWithEditText. This change makes the EditText as the label of the widget, so that the content description for EditText can be read out as part of the RadioButtonWithEditText. Before the change, RadioButtonWithEditText read out as "Checked/Unchecked radio button"; after the change, the widget read out as "Checked/Unchecked radio button for <read out for EditText>", which will contains: 1. The Radio button is for a EditText 2. The text & hint for EditText Bug: 1057269 Change-Id: I23cabe4b7bc8313bbc8c055a95f5a9e26e876b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090620 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#748471}
-
Nico Weber authored
http://gn.googlesource.com/gn/+log/4166e9fbc1f..fd3d768bcfd4 fd3d768 msvc writer: Don't die on generated_file() and create_bundle() targets. f871e54 Fix Rust dependency propagation c2d0ace Fix crash in "gn gen --ide=xcode" when project is malformed 5e43d01 Fix gn format --stdin newlines on Windows d422999 WIP: Fix (cross)compile with MinGW c89bc82 Write input files to json project Bug: 1059666 Change-Id: I2a7de94702f8e5d3611e175aa096c82a8d39a689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095467Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#748470}
-
Hiroki Sato authored
Nodes in WebView is already sorted by the order to be traversed. Sorting based on bounding rectangles makes the navigation order broken. Bug: 827352 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: Open Gmail app or ChromeBrowser app, and confirm that navigation order is correct. Change-Id: Icbf1f10ab8762c038e763c80a75e2d17340be7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089540Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748469}
-
Xinghui Lu authored
In order to control real time URL lookup via high-end and low-end groups, add a memory upper threshold control. This change will make it easier for finch configuration, see: go/wmpfd Bug: 1014202 Change-Id: I639153c9baac73cd8bfcdaff3a82c020237a6c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092697 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748468}
-
nancy authored
The pause app dialog and block app dialog are system type window, which means once the dialog is opened, the user must click the OK to accept it, and the user can't move to other windows or do another other things on the Chromebook before he/she clicks the OK button. Based on the discussion in 1056466, this CL is used to implement: For app block: 1. When the app is blocked, no matter the app is running or not, we won't show dialog, because it is Android controls the app running, and AppService can't know whether the app is running or not, due to the schedule issue. When AppService is notified about the app status changed, the app has been stopped. So rollback the dialog show in arc apps when the app status is changed. 2. After the app is blocked, when the app is clicked to launch, show the app block dialog. For app pause: 1. When Family link notifies AppService to pause app, AppService will show the pause app based on the family link's parameter. If the parameter is yes, then show the dialog, otherwise, don't show the dialog. This has been implemented, so no change for this CL. 2. After the app is paused, when the app is clicked to launch, get the latest time limit setting from family link, and show the app pause dialog. BUG=1056466 Change-Id: I2e9c5445f13820b63cca81954724bfed95c614be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084033 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#748467}
-
wutao authored
When showing Assistant UI, we used to request the screenshot. This will significantly reduce the smoothness of Launcher animation. This cl defers the screenshot request to the time when users click the "What's on my screen?" suggestion chip. We still request and cache the Assistant structure of current active window before showing the Launcher, which has not shown noticeable effect on the smoothness. Bug: b/145218971 Test: Added new AssistantScreenContextControllerTest Change-Id: I1bb6c7597414d4a981cf0ce8df50eb5e5b981427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013498Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#748466}
-
Nick Burris authored
Add a document policy that lets pages opt out of scrolling that automatically happens on page load. This provides an opt-out to the Scroll To Text feature (see bug and [1]), but also applies to fragment scrolls and scroll restoration. With the DocumentPolicy feature[2] enabled, pages can opt out of these types of scrolling by adding the HTTP header: Document-Policy: force-load-at-top [1] https://github.com/WICG/ScrollToTextFragment/issues/80 [2] https://github.com/w3c/webappsec-feature-policy/blob/master/document-policy-explainer.md Bug: 1047900 Change-Id: Iebba7fd24fa2e362bfa4a8f77903763b5d95b787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073138 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748465}
-
Donn Denman authored
This reverts commit a5ef8671. Reason for revert: Still flaking a lot. Original change's description: > [TTS] Reenable CSMTest suite with longer timeout. > > Speculatively re-enables the ContextualSearchManagerTest suite with > the hope that the mysterious underlying flakiness issue has gone > away, or that the longer timeout in this version of the code will > help. > > Original disabling CL: https://crrev.com/c/2088007 > > TBR=twellington@chromium.org > > BUG=1058362 > > Change-Id: I02ea4f209b86b730cc6f40622839ffb12f3753c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094245 > Commit-Queue: Donn Denman <donnd@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748287} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: Ibb00c69f96bf4bbc54776540c813e68f86598fc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095963Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#748464}
-
Kent Tamura authored
and remove three redundant web tests. - Adopt autofocus-only-once.html to WPT - Remove autofocus-opera-001.html and autofocus-opera-006.html. They are covered by html/interaction/focus/the-autofocus-attribute/first.html in WPT. - Remove autofocus-opera-008.html. It's covered by |html/interaction/ focus/the-autofocus-attribute/focusable-area-in-top-document.html| in WPT Bug: 1058203, 1059322 Change-Id: I0fec1af7821ad596c522f6df56aba66504db295a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094058 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#748463}
-
Artem Bolgar authored
Bug 1057571 (broken stencil buffer functionality in WebXR) was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2084067. This commit adds a test for the issue. Bug: 1057571 Change-Id: I9390aa47a3eabc1d8cf2d0717fb020b70e455ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093391 Commit-Queue: Artem Bolgar <artyom@fb.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#748462}
-
John Williams authored
The native MRP was assuming mirroring sessions don't send messages to the client, which is incorrect. Fixing that assumption involved moving quite a bit of functionality from CastActivityRecord to its base class, ActivityRecord. Bug: 1047834 Change-Id: Ie35b5d518af78a01451fc6e7b0f13be7024d115c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064813Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#748461}
-
Sajjad Mirza authored
Bug: 1059102 Change-Id: Ie92e9bbec7584f21e1b6408168be9c558b89003b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092206Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748460}
-
Noel Gordon authored
Change caret image RTL transform CSS rotate(-180deg) to scaleX(-1) for the same visual result. Bug: 1035691 Change-Id: I3140cc2356118b27cced786fbad335bab2d6ea6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094903Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748459}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1cd52d2cfe4c..c2d817317046 git log 1cd52d2cfe4c..c2d817317046 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 geofflang@google.com Allow referencing buganizer issues with ANGLE CLs. 2020-03-09 geofflang@google.com Generate arch-specific defines in Android.bp 2020-03-09 geofflang@google.com Improve GN args for generating Android rolls. Created with: gclient setdep -r src/third_party/angle@c2d817317046 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I5550fb5c96d793c55d4162f3d594d76d23ff5d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748458}
-
Jeff Yoon authored
Some test targets for iOS are shared (for example, basic_unittests). As all iOS test targets are wrapped with the generate_wrapper template, we need a mechanism to execute these shared targets without changing the test type in gn_isolate_map.pyl. Thus, for iOS, we force tests that are not "generated_script" type to behave as such by mimicking its behaviour in the GetIsolateCommand. Change-Id: I67f9fea82f8ac3cfe765441a3cb0e6f4ab61bd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035052 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#748457}
-
Deepanjan Roy authored
This is a reland of c401a7d6, which should be fine to land now that we have merged https://chromium-review.googlesource.com/c/chromium/src/+/2089827 Original change's description: > [tbmv3] Add an integration test for run_tbmv3_metric > > Adding a simple smoke test to make sure run_tbmv3_metric does not break > silently. > > Change-Id: I54f4d525e221eef403678034efde505ee19cbc1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078736 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Deep Roy <dproy@chromium.org> > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Deep Roy <dproy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747385} Change-Id: I6fbaa19940658ad17ec805c0b29cca7dd5d9690c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091588Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748456}
-
rbpotter authored
For now, ignoring importHref() line. Once lazy loading is added for Polymer 3 settings, this will be updated to be replaced by dynamic import() instead. Bug: 1026426 Change-Id: Ib8e6585b7ad8f4b1585635eae3a09a2259c7fdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091657Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#748455}
-
Yuchen Liu authored
Add an optional API to check whether the platform can play video with requested profile/size/framerate smoothly. Merge-With: eureka-internal/373033 Bug: internal b/150214233 Test: dev console Change-Id: Ib0886b51a46e3e33a3b9a4dd413b8dd32185b603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094576Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748454}
-
Adam Langley authored
This change adds a hidden-by-default entry in the passwords settings UI on Android that triggers the Phone as a Security Key prototype code. The most important thing to verify about this change is that it doesn't have any effect unless the user manually sets the flag: the UI is intended for experimentation and for UX-team to consider at this point. BUG: 1002262 Change-Id: I17d1077002b53198bc1d2422e28d13c6611dfc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079614 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#748453}
-
Mohsen Izadi authored
Bug: 993895 Change-Id: Id1d68e92f06f00bb6f6b1ea632df34c8f5f76624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095408Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748452}
-
Caroline Rising authored
By default bubbles attempt to mirror when off screen, this change lets LocationBarBubbleDelegateViews that are anchored to icons within the ToolbarAccountIconContainerView to offset instead of mirror. This change makes this the behavior on all desktop platforms, usually Mac and Linux do not adjust bubbles. Bug: 1056305 Change-Id: Iff14e308ba76673b2269c7bcdece1ba443dc3874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094483 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#748451}
-
Alex Danilo authored
Clicking anywhere on the action bar causes the search box to collapse unless it contains text input. Change the search box collapse logic to respond to clicks anywhere in the Files App rather than just the action bar area. Bug: 1058547, 1002413 Change-Id: I5e09ad4eb7ec3e5bf0b732d45665dbbc6af7bb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094377Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748450}
-
Jenny Zhang authored
The problem is SearchResult kept its own property of is_recommendation_, instead of using metadata_'s is_recommendation attribute.Therefore, it is out of sync of ArcAppReinstallAppResult for its is_recommendation setting. Bug: 1050761 Change-Id: Id5d503b0541626ccfdde7b7a9b8dbc3784cfe655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090835Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748449}
-
Josh Horwich authored
--enable-arc-oobe-optin-no-skip commandline switch is no longer needed as all Chrome OS devices enable it. This change removes the switch and makes its behavior the default so we can remove it from the Chrome OS builds. Bug: 1059048 Test: OOBE flow on Chromebook Change-Id: Idf85a61afa34077691edf5d7f261f96c4e81e4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091652 Auto-Submit: Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#748448}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e1d6ce38422..a1ac244222a5 git log 4e1d6ce38422..a1ac244222a5 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b57f55e2..5a78076c (748149:748288) 2020-03-09 aluebs@webrtc.org Remove RTC_NOTREACHED from audio_send_stream when ANA didn't work 2020-03-09 minyue@webrtc.org Add NtpTimeMs as a method in EncodedImage. Created with: gclient setdep -r src/third_party/webrtc@a1ac244222a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I944da2630307a1868a3b961e36246cd3f192a9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748447}
-
Eric Willigers authored
The BubbleDialogDelegateView constructor set margins based on provider GetDialogInsetsForContentType(TEXT, TEXT). ExtensionUninstallDialogDelegateView then adjusted these margins. The WebAppUninstallDialogDelegateView logic is based on ExtensionUninstallDialogDelegateView, but it doesn't have the same base class, so it was previously adjusting from 0 margins instead of adjusting layout provider insets. We now have consistent margin behavior between ExtensionUninstallDialogDelegateView and WebAppUninstallDialogDelegateView. Bug: 1059166 Change-Id: I97ad4cacdf346b4686c6d76ab38ef84d34a6e871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094917 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#748446}
-
llin@chromium.org authored
Bug: b/150783279 Test: manual Change-Id: I9c9e37ff8ec2be5ec5f47af54a751019401d53b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092932 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748445}
-
Matthew Denton authored
And also add services/service_manager/sandbox/linux/ to the "linux_sandbox" watchlist definition. Bug: None Change-Id: Id66946cd60ecb415a540d77fa6be35de0a71948f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093393 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748444}
-