- 14 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0f7984519b7..3b8d1780b324 git log b0f7984519b7..3b8d1780b324 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 jalyn@microsoft.com Fix mac-only enter key regression Created with: gclient setdep -r src/third_party/devtools-frontend/src@3b8d1780b324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib5aa722f3941cac8cfda9874bfcbb1fb33a66955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758691}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32457326e052..dee4d7a54e44 git log 32457326e052..dee4d7a54e44 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 cclao@google.com Vulkan: Early fragment tests optimization Created with: gclient setdep -r src/third_party/angle@dee4d7a54e44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9175c3eb2f6749ce8a01b0c16ac2b68bbd22ae53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148203Reviewed-by:
-
Katie D authored
Bug: 1055150 Change-Id: I74fdfd76923d58e3133c80f88de59efb86daaa78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144869 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#758689}
-
Zain Afzal authored
cl/303855538 will add a save copy function to the clientAPI delegate, this CL adds the chromium side code to implement this function. The save copy delegate function simply prompts the user to pick a file location, dumps a provided blob into the file specified, then relaunches the media app with this new file. Bug: 996088, b/141587270 Change-Id: I97b253fbffa9e1efb75448c98d41c3cee893bf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134028 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#758688}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e03aa465. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 2f3bb77d "[device-orientation] Upstream web tests to WPT" 9e22b2c7 "[css-flexbox] Move negative-flex-rounding-assert.html to WPT" 67963d34 "[css-flexbox] Move negative-margins-assert.html to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 5ec29e3e "[css-grid] Migrate grid-tracks-stretched-with-different-flex-factors-sum.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" f064e48f "Make will-change: backdrop-filter a containing block for fixed and abs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I222651efc5dd98fc5f88404fcdc013bf8689fc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147956Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758687}
-
Sergey Poromov authored
The check is redundant because it's checked previously that the user is affiliated that implies that they are managed. Also chromeos::ProfileHelper::Get()->GetProfileByUser() doesn't return the Profile if it's not finalized and as SafeBrowsingPrivateEventRouter is now created during Profile initialization it doesn't work. Bug: 1069588 Change-Id: Ia4edd715a223688852f643ee2b28b9b9a4d4e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144178Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#758686}
-
Kenichi Ishibashi authored
These methods are wrappers of corresponding methods defined in ServiceWorkerStorage. Added test patterns come from ServiceWorkerStorageTest.StoreUserData with minor modifications. Bug: 1055677 Change-Id: I6615ff14d10cb7302db7d388363672839998f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142879 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#758685}
-
Yuki Yamada authored
Adds ResetWithReason() and set_disconnect_handler_with_reason() to HeapMojoRemote so that it can handle custom reason of connection error. Bug: 1049056 Change-Id: I6ee8bfb5e0620f4598270ce9c0dde3effb9dba1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145388 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#758684}
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to position-relative-with-scrollable-with-abspos-crash.html. Bug: 1063749 Change-Id: I138ff2b27b90fbbdbf84c2292c469b757a9350cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145416Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#758683}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4034bbc78ebeb68fe7f19fc1883a0c64453ce268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148207Reviewed-by:
-
My Nguyen authored
window_shell_id is added in candidate_window_view in https://crrev.com/c/685497. Its usage is removed in https://crrev.com/c/1600630, however the attribute is left there. suggestion_window_view is copied from candidate_window_view so it has the same extra code. No_Bug: Cleanup Change-Id: I761a4bb7c137e1778604d31cc31b59d7e934d6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143014Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758681}
-
David Munro authored
See comment and https://bugs.chromium.org/p/chromium/issues/detail?id=1068914 for details, this seems necessary for sliders within and without cr-dialog to work correctly with touchscreens. Test: Use a WebUI slider, os settings slider and os settings inside a dialog slider, check all work. Bug: chromium:1068905 Change-Id: I07497b81857725b6eef907fda6f936ed3b89c606 Change-Id: Ib12f13bdb8e93e7f1fbe847e24a6c3159413c3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141993Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#758680}
-
Taylor Brandstetter authored
Bug: chromium:1069962 Change-Id: Ib86fde34b8b9d9e0065ef153ae2807533321ed79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146139Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#758679}
-
Gyuyoung Kim authored
This CL moves stretch-table-child.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this CL sets a background color to 'first' selector for the manual test. Bug: 1063749 Change-Id: I20655a51cc6fc6462bf4f0aba361e8f9a05d095b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132899Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL adds a prefetch image API to image loader. Must be called in reduced mode. In reduced mode, currently it can't start utility process to decode image, so we need to use the correct image fetcher api to do prefetch. Bug: 1058534 Change-Id: Iaed251b2cf2760fbca154b14db6f6c8e4840e52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146304 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758677}
-
bttk authored
RecordHistogram now works when native is not loaded. Bug: 1069507 Change-Id: I856d509c8b217eea5149adccfb0c28603249a920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148119Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758676}
-
My Nguyen authored
It wasn't working properly because I forgot to add handling of SuggestionStatus::kBrowsing enum. Bug: 1068855 Change-Id: I0e96f0ab4ab587a80d26d022c1a1e415ea1b6c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141479Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b8b3f5ffc0ea..e6e9fec904b8 git log b8b3f5ffc0ea..e6e9fec904b8 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 asweintraub@google.com Add new FPDF_LoadMemDocument64 API for PDFium. 2020-04-13 tsepez@chromium.org Allow modifiers for keycode events in .evt files. 2020-04-13 tsepez@chromium.org Make UnownedPtr<> interoperate more transparently with raw pointers. Created with: gclient setdep -r src/third_party/pdfium@e6e9fec904b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I35630ba61bf49fa84c1ae1886eea8c7ba7adc721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148192Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/449545fd382b..6bed80858d3b Created with: gclient setdep -r src-internal@6bed80858d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I0e8936171c471fbfd2b6d3d78593c3514833fd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148196Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758673}
-
David Tseng authored
This change: - makes both CommandHandler.onCommand and ChromeVoxBackground.setPref do the same thing when changing sticky mode. This is with the one exception of CommandHandler calling through to SmartStickyMode (since it is a user command vs other call sites that simply update the pref). - Makes one small fix in SmartStickyMode; not all trees mark an editable root (e.g. Android, views). RELNOTES: n/a Change-Id: I5d0a4bc9626c0a885b350df8515aa42f3553a69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148121 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#758672}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac2a401164e1..297fffa4987b git log ac2a401164e1..297fffa4987b --date=short --first-parent --format='%ad %ae %s' 2020-04-13 dproy@chromium.org Add origin trial token for tests Created with: gclient setdep -r src/third_party/catapult@297fffa4987b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1021137 Tbr: sadrul@google.com Change-Id: I5f5ac3a206c0b043847f93ee0de38c0aa4560a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148197Reviewed-by:
-
Nate Fischer authored
WebView team is still monitoring URL scheme metrics to understand WebView usage. We intend to do so indefinitely (until we decide there's a better way to understand WebView usage), so this extends the metrics a year into the future, per guidance. Fixed: 1063899, 1063898 Test: N/A Change-Id: I01c86904cbb0dea9363d7c0546b2419df557ae28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148157 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758670}
-
John Lee authored
This CL is the first CL of many to replace the settings-box class with a cr-row class, which will allow the removal of settings-box and the use of the --cr-section mixin. This CL proposes examples of a few changes: - Replace .settings-box-text with .cr-padded-text. The name is clearer of what it does and the class may be used with other .cr-row instances. This also allowed us to remove .two-line/.three-line classes unless explicitly used to make one-line rows appear taller. - Replace .start with .flex. It looked like .start was used primary to make a child of .settings-box stretch. .flex achieves the same goal and does not have any position-related info in its name, so it is more flexible in that it can be used in other positions (like a child in the middle). - Replace .middle with .flex or .cr-row-gap, for the same reasons as above. Bug: 973674, 686905 Change-Id: I0532bef08769f9fe2e1aec1d034d0f94b29f8ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144429 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758669}
-
Timothy Loh authored
This CL adds support for outputting the current progress of a view progress bar by ChromeVox, which currently says "progress indicator" without indicating the actual progress. The logic here is mostly copied from views::Slider. Bug: 1021414 Change-Id: I9a31708d34b9823ed72a5b9f44b9b08de4df95a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129367Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#758668}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9378b8016c60..4f17b60208fa git log 9378b8016c60..4f17b60208fa --date=short --first-parent --format='%ad %ae %s' 2020-04-13 zmo@chromium.org Use Dawn's BUILD.gn instead of defining another one for Skia. 2020-04-13 reed@google.com [skvm] approx_atan2 Created with: gclient setdep -r src/third_party/skia@4f17b60208fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064305 Tbr: kjlubick@google.com Change-Id: Id015a8ce1118a8ec6099d4bafaff190d179e6101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148202Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/871651d9993b..8c8d16a1c53f git log 871651d9993b..8c8d16a1c53f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 cwallez@chromium.org BUILD.gn: Move dawn_end2end_tests to its final location 2020-04-13 yunchao.he@intel.com Support none visibility binding in bind group Created with: gclient setdep -r src/third_party/dawn@8c8d16a1c53f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I20b81088d1b9fedf70d2484f2254caffc41ed136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148206Reviewed-by:
-
Wan-Teh Chang authored
Also change the format_info_ data member into a local variable in YUVAToRGBA(). Bug: 960620 Change-Id: I4fb220d02aa726517dbe8a2d26d379974f62616e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146234 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758665}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/533a31d92b64..39fd800d2c43 git log 533a31d92b64..39fd800d2c43 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 btolsch@chromium.org Fix typo in LUCI scheduler for ARM64 bot Created with: gclient setdep -r src/third_party/openscreen/src@39fd800d2c43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ifd3c083aa67c672d0143ca1932675d02d5abedca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148201Reviewed-by:
-
Findit authored
This reverts commit f7789d6a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 758653 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y3Nzg5ZDZhODBlODkxOTljMDczY2M5YzkwNTA3YmRmNWQyNDMyZGQM Sample Failed Build: https://ci.chromium.org/b/8883087602376633360 Sample Failed Step: compile Original change's description: > Roll src/third_party/nasm/ 21eb59531..c74336e4a (3 commits) > > https://chromium.googlesource.com/chromium/deps/nasm.git/+log/21eb59531974..c74336e4a093 > > $ git log 21eb59531..c74336e4a --date=short --no-merges --format='%ad %ae %s' > 2020-04-13 dalecurtis Disable sanitizers for nasm in all build types. > 2020-04-13 dalecurtis Disable sanitizers for nasm like we do for yasm. > 2019-10-07 efoo Add "# COMPONENT" to nasm OWNERS file > > Created with: > roll-dep src/third_party/nasm > > Bug: 766721 > Change-Id: I938feca69acaac56b8e6860486b374e8d208dd62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148062 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758653} Change-Id: I882d300299f70b66ae55114092becb2e070366aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148225 Cr-Commit-Position: refs/heads/master@{#758663}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/adc4da30f420..0574822f9f69 git log adc4da30f420..0574822f9f69 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 94450aa9..edcfd61b (758458:758565) 2020-04-13 mbonadei@webrtc.org Remove std::vector<BandwidthEstimationInfo> template instantiation. 2020-04-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 318b9b3c..94450aa9 (758358:758458) Created with: gclient setdep -r src/third_party/webrtc@0574822f9f69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7595218fef5773e26713062153c9a97991424334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148194Reviewed-by:
-
Becca Hughes authored
Handles DB errors a bit better by trying to recover the DB. We also make sure we close the DB when we shutdown. BUG=1069626 Change-Id: Id3cf87341362d1ee6c13e798cbb651f8cf991df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147370 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758661}
-
Xiaohan Wang authored
The plan to support hardware CDM modules has been changed and CdmProxy is not needed any more. Remove CdmProxy related code to clean up the code base. Bug: 785563, 1067786 Change-Id: I3c6decae6b3397dcff74cf7c072b901f6e511a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136468Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758660}
-
Kurt Horimoto authored
This reverts commit e8e69e97. Reason for revert: causing crbug.com/1070440 Original change's description: > [iOS] Add WebAppInterface. > > This interface returns the additional standard and secure schemes added > by web::RegisterWebSchemes() so that these schemes can be used in the > test process for EG2 tests. > > Bug: none > Change-Id: Id02340bc11bc725ecc2c9b802455b8d669ec2b5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144840 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758601} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: Id05ff8c9b893b48b4e73d3245938d64bbdea8c7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148162Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758659}
-
Gyuyoung Kim authored
This CL migrates fecomposite-non-zero-inoffset[-expected].html tests from css3/filters to external/wpt/css/filter-effects with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to fecomposite-non-zero-inoffset-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: I88b74ff2e6575f376c51bc1e4b615db3a39f373b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141558Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758658}
-
chrome://interstitialsKurt Horimoto authored
This reverts commit 2bd6fe9a. Reason for revert: crrev.com/c/2144840 needs to be reverted because it caused crbug.com/1070440 Original change's description: > [iOS] Hook up chrome://interstitials page. > > This CL adds support for the chrome://interstitials WebUI, which > contains links for dummy interstitials. Currently only a subset of the > available links are implemented for iOS. > > Bug: 1064803 > Change-Id: Ie8fed45623f18319ff1c8a9de5108108a796b2bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145154 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758619} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: Ibccc6934d4330f32a24ddb763b1447f67517b09c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147919Reviewed-by:
-
Nate Fischer authored
Android recently launched a public version of Android Flash Tool. This updates our device setup instructions to refer external contributors to use the public tool. Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4956ee9633242e6c727f9dfd7ccf378a2c44fb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147691 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#758656}
-
Kurt Horimoto authored
This reverts commit e03aa465. Reason for revert: Needed to revert crrev.com/c/2144840, which is causing crbug.com/1070440 Original change's description: > [iOS] Clean up ChromeTestCase class methods. > > Calling [self class] from class selectors is unnecessary since |self| > is already a class. > > Bug: none > Change-Id: I76f72c489a48ae1f17dda7eac7b67ecbba8f3e9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148061 > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758639} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I19840c79ff6ea6dc1f554efa88f50f88eb0352d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148279Reviewed-by:
-
Toby Huang authored
The pref kSupervisedUserApprovedExtensions contains extension ids that the parent has approved for the supervised user. We want these approvals to sync across ChromeOS devices. As a SYNCABLE_OS_PREF, kSupervisedUserApprovedExtensions does not sync from M83 to M84 due to the SplitSettingsSync feature in M84. Changing this pref to a SYNCABLE_PREF fixes this syncing issue from M83->M84. Moreover, this pref should be a browser pref instead of an OS pref to be more consistent with the rest of extensions. Bug: 1068794 Change-Id: I8ae34dbd1e12d312ff72f062c9e5026bb8e6a525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147853Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758654}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/21eb59531974..c74336e4a093 $ git log 21eb59531..c74336e4a --date=short --no-merges --format='%ad %ae %s' 2020-04-13 dalecurtis Disable sanitizers for nasm in all build types. 2020-04-13 dalecurtis Disable sanitizers for nasm like we do for yasm. 2019-10-07 efoo Add "# COMPONENT" to nasm OWNERS file Created with: roll-dep src/third_party/nasm Bug: 766721 Change-Id: I938feca69acaac56b8e6860486b374e8d208dd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148062 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#758653}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/925cedba7bad..a01816b0bae9 git log 925cedba7bad..a01816b0bae9 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 sokcevic@google.com Set git low speed detection on bot_update Created with: gclient setdep -r src/third_party/depot_tools@a01816b0bae9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie46f0a48dd2d68ac5dc304fc784a6b2605093565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148195Reviewed-by:
-
