- 10 Aug, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change adds conversion functions between base::StringPiece and absl::string_view. This is to aid the adoption of other Abseil features, that make use of the otherwise banned absl::string_view in their public API. Fixed: 1113880 Change-Id: Ib038a4e71fb0ce6470304e4151474a5d92809d22 Bug: 1113880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345306 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796501}
-
Yuwei Huang authored
This CL makes the iOS app use the newer Google account management library instead of the deprecated one, i.e. we no longer use the side menu and will use the circular profile button on the top-right corner of the screen. Code changes in this CL include: * Introduce an AccountManager as an abstraction layer to Google-internal account management UI components, also with an AccountManagerChromium implementation for the public build. * Deprecate AppViewController and remove AppViewControllerChromium as the new UI component doesn't act as the root view controller of the app. * Remove ToS and Privacy Policy from the side menu items, as the new UI already comes with these links in the footer. Internal change: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3202666 Demo: https://screencast.googleplex.com/cast/NDYyMzk5MDAzNzQxMzg4OHxkODBmNGI4OC01YQ Bug: 810097 Change-Id: I660e2aeef7337050e827f3a32b524deac7b0e462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343637 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#796500}
-
Matt Jones authored
This patch converts the toolbar's composited texture and logic into its own MVC component. The ToolbarSceneLayer has become the "view" of the new component and is now TopToolbarSceneLayer. All classes related to the component live in .../browser/compositor/overlays/toolbar. This patch also adds a small suite of unit tests. Bug: 1100332 Change-Id: If34fef9378a7b64524e6eb31e381c48b636a94aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302853 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#796499}
-
Caitlin Fischer authored
Also, make wychen the owner of this histogram. Bug: 1110301, 1110961, b/162309838 Change-Id: I8d0471a4a9fbb52b3f778a612bd617146cc175a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323501 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796498}
-
Himanshu Jaju authored
- Parses incoming advertisement and creates ShareTarget from it. - Inject CertificateManager from factory for mocking in tests. Bug: 1085068 Change-Id: I1b1ed2252baa59e68f4daa1e772a51e9cf32eff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332725 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#796497}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12bc13e26d28..7b17f160f76a 2020-08-10 aerotwist@chromium.org [global] Stage second impl of ThemeSupport If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I489f3af5dd80232574296ca89c1ae900ab790d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796496}
-
Livvie Lin authored
Change-Id: Ia12de00773aca815151b4475e37152b524b21bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347045Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796495}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu uses kInProcessCommandBufferClientId as it's client id. Tell GrShaderCache to cache shaders from kInProcessCommandBufferClientId to disk. Bug: 1114763 Change-Id: I71d66b007abf76358b28937eae505198e7f882d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346986Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796494}
-
Ella Ge authored
Tbr: katie@chromium.org Tbr: ellyjones@chromium.org No-try: true Bug: 1054641 Change-Id: I0d5896afccb2012beea0edb9505ee620f263c318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346055Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796493}
-
Xing Liu authored
This CL adds a flag to enable Chime push notification channel on canary. Bug: 1105693 Change-Id: I647a64743399f07c65652728345bdb7d96b0e153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346832Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796492}
-
Elly Fong-Jones authored
The way it's implemented is very non-obvious and hard to find via code search, so add a comment explaining it and an explicit xref to the involved PlatformStyle constant. Bug: None Change-Id: Ia1756752d403cffac434d6249897b2d5d35eeba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342572 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#796491}
-
Joshua Bell authored
A follow-on to a previous fix[1] to handle the recursive case. A limit was imposed on key length to prevent OOMs as JS arrays are converted to IDB keys. Array keys were handled, but not nested arrays. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2304445 Bug: 1113505 Change-Id: I6eb184cf75e5b39eecfdb79f1d10536d68251452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346839 Commit-Queue: Joshua Bell <jsbell@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796490}
-
Steven Bennetts authored
This addresses some inconsistencies with the 'Other' APN UI encountered when switching between carrier networks within a Cellular Service. It also adds support for 'Other' entries with accessPointName values matching an existing entry but with different username or password values. Additionally it fixes some instability in the UI while scanning (when the device properties become unavailable). This fixes that by postponing Cellular property updates until scanning completes. Bug: 986921 Change-Id: If5a012e38e5af32ffe4832c553396b94361b86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333536Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796489}
-
Jonah Chin authored
This CL splits GetRasterSkImage() into two explicit functions: GetSwSkImage() will always do a readback for texture backed images. GetAcceleratedSkImage() will return a texture backed SkImage and is limited to specific callers. PaintImage::readPixels() handles callers who previously used PaintImage::GetSkImage()->readPixels(). This is necessary for GetSkImage()'s deprecation. In the OOPR case, this new API is routed through the readback on RasterInterface via TextureBacking. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: Icdbb4941ba199e04bfc163f8638d8293131480c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316413Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796488}
-
Becca Hughes authored
Change-Id: Ib25fc8454cac9db5c17e0fd4c1952bbe7a2a4c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342388Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796487}
-
Sebastien Lalancette authored
Adding a new SharingCoordinator initializer and updating ActivityServiceCoordinator's initializers to enable triggering a URL sharing flow for URLs that aren't necessarily associated with a WebState. Some activities that depended on a WebState have been disabled for that flow (e.g. Print, Find in Page). Also, this CL makes ThumbnailGenerator optional for ChromeActivityURLSource, as no thumbnail can be generated without a WebState. This CL also modifies the initialization of ActivityServiceCoordinator to use a new ActivityParams object which will contain the properties used to configure the various sharing flows. Bug: 1102892 Change-Id: I0b28d5fcc7bae78e669dbfac33ba252165ce86bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319793 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796486}
-
adamta authored
When feed reloads and goes back to being one page (10 articles long), infinite feed would stop working because saved height was higher. We should only check if the saved height is different instead. Bug: 1085419 Change-Id: I89fe5a5c854bdf1b3b46c0b78aa012088bd0011f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342582Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/039f681a841a..ea8be2120ee6 2020-08-10 johnstiles@google.com Update ProcessorClone test to re-verify problems without using clone(). 2020-08-10 egdaniel@google.com Add plumbing for dst read render passes into GrVkRenderPass. 2020-08-10 johnstiles@google.com Add style guidance for `k` prefix on constants. 2020-08-10 robertphillips@google.com Move more atlas functionality from GrSmallPathRenderer to GrSmallPathAtlasMgr 2020-08-10 tdenniston@google.com Lower cubic stroke recursion limit to 24 2020-08-10 jmbetancourt@google.com add terminating file on complete of CorrectnessActivity 2020-08-10 brianosman@google.com Reland "Untangle dependency cycle in sksl dehydration" 2020-08-10 mtklein@google.com simplify skvm blitter main logic 2020-08-10 nifong@google.com Add more perf tests and other minor improvemnts 2020-08-10 mtklein@google.com make skvm lerp() a little smarter 2020-08-10 borenet@google.com [recipes] Dump debugging information before running tests on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I37bfe928af41da62d4de800289e6aeecb3c7017b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346871Reviewed-by:
-
Tommy Martino authored
Bug: 1099268 Change-Id: I1e279858e48f65d1b842caa9943777f50aadc9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332840Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796483}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1662e97f324e..ccf01e74ec70 2020-08-10 brandon1.jones@intel.com Re-add heap usage tracking for textures in a pass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If423f0624633cd32acb65051f5fa2dd347b5a859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346948Reviewed-by:
-
Gayane Petrosyan authored
As url is not set in ShareParams when text is shared, url should be passed from tab. If url is passed through ShareParams, it will add first party options for sharing url and will share text+url. Bug: 1102382 Change-Id: I83d5e883b6e1f1f05cd9768d7618ceb61396185c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343295 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#796481}
-
John Smith authored
The issue was that previously, the tabs/toolbar area used the NativeThemeDarkAura for colors, which was not OS accent aware. This was replaced by a forced-to-dark version of the platform's native theme. On Mac, I added a check to maintain the old behavior that skipped the accent colors because there was an issue with how the light/dark theme was applied on Mac. This was since fixed, so we can remove this check and use the accent colors in incognito. This also makes the color behavior more consistent between regular dark mode and incognito. Bug: 1049360 Change-Id: If9a40955391b3c6d9603c66d4eedb99afb0af752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337575Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Joan Barnett <johnsm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796480}
-
Khushal Sagar authored
R=backer@chromium.org Bug: 757605 Change-Id: I39872742a535ad7d632c374332d36b949a0c0558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341945 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796479}
-
Avi Drissman authored
Do not try to derive one weight of font from another. Use the API to directly generate them. PlatformFontMacTest.FontWeightAPIConsistency tested that our understanding of shifting weights up and down was correct. The code no longer shifts weights up and down as that is unreliable and version-specific, so there is no need to test weight shifting and it is removed. This also fixes Big Sur issues. This re-lands c2e39ede. It turns out that DCHECKs do evaluate everything in them so wrap it with DCHECK_IS_ON(). Bug: 1101426 Change-Id: I1194b4aa127223456b432d12c47d248264d87c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342387Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.48-1596451266-benchmark-86.0.4221.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id2ef8c1d1300cd08e8df855ff9a4ea48afa1b9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346876Reviewed-by:
-
Ilia Samsonov authored
This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina. blink web tests for these versions has been removed from waterfall. Bug: 1077312, 1107003, 1114680 Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796476}
-
Orin Jaworski authored
To aid in smoke testing Pedal concept matching data for all the new languages, a unit test is added that ensures each locale's data set can be loaded and used. Bug: 893183 Change-Id: Ic4686e5cf85dd0f1734fa1a2129f9b4ac3c72da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337107 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796475}
-
Lei Zhang authored
The The is a band, but the the is not. Change-Id: I8c0dc1d4984cf90fe6d83449415e0799f0ec8024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345713Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796474}
-
Liquan (Max) Gu authored
Change: * Move JourneyLogger into ComponentPRImpl to facilitate the moving of PRImpl#close() into ComponentPRImpl. * Move the PRImpl.Delegate.isOffTheRecord interface method into PRFactory. The value of isOffTheRecord will be set according to the merchant page's state at PRFactory#createImpl(). Bug: 1102522 Change-Id: I46de04bdde95e48d8ecdf1c31cf2685fef213001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341948 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796473}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.48-1596448621-benchmark-86.0.4221.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1104aeba79d1853d9318c7c1df33df9329dc78c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346880Reviewed-by:
-
Patrick Noland authored
This starts the process of hiding the MenuButton view behind the coordinator. Primarily, ToolbarAppMenuManager (renamed to MenuButtonCoordinator) now directly manipulates the MenuButton instead of doing so through TopToolbarCoordinator. MenuButton related functionality is removed from the Toolbar interface, with a few mechanical adjustments to match. Bug: 1086676 Change-Id: I9d8e63e320feec671df5cbd82aed9e330b543865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327315Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#796471}
-
Yicheng Li authored
This enables reusing LoginPasswordView and LoginPinView with custom colors, e.g. for in-session auth dialog and dark mode in the future. Bug: b:156258540 Test: deploy to Nami device, looks the same as without the change. Change-Id: Ic7ec4be3327fa4a94571543d41ba5030807389b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333823Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796470}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.39-1596449559-benchmark-86.0.4221.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iac91130f7397a64d750169081560d49e33ec3e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346879Reviewed-by:
-
James Zern authored
-O2 is ~11-17% faster than -Os on a pixel 3a using a ndk build of the decoder (r21d) Bug: 1047051 Change-Id: Ifa67bcd7352f535a71f726c32320d6c0353263d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340497Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#796468}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsCrPolicyNetworkIndicatorMojoTestV3.All Change-Id: I6cabdf0cda77044e2a2e77c07ef174531d6f1852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345520Reviewed-by:
-
liberato@chromium.org authored
Change-Id: I151f491c0e3729cff3a20c4b8ec9fd628ce5898b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343630 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Koji Ishii authored
|NGLineBreaker::RewindOverflow| assumes that |Rewind| rewinds the current |item_index_| to the specified value. However, at some point |Rewind| was changed to not to rewind positioned floats. The DCHECK was to ensure the assumption. This sometimes hits when the line width saturates |LayoutUnit|, and it was considered not too harmful. But crbug.com/1114324 suggested that it may create unexpected internal states which can lead to crashes. This patch removes the assumption from |RewindOverflow|. Bug: 1114324, 1020101, 1029599 Change-Id: I221e87d4ed089ae97aa21a99c2be73dc555f6d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344431Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796465}
-
Adam Ettenberger authored
This CL addresses a bug where Role::kButton, and possibly other roles that derive their name from descendant contents, were not firing Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. ax_object_cache_impl.cc : - When firing a text changed event, also fire a text changed event for the first ancestor that derives its name from descendant contents. This ensures the nodes are invalidated, send appropriate text changed events, and the changes are serialized to the browser process AXTree. browser_accessibility_manager_win.cc : - FireUiaTextContainerEvent made it possible to fire text events more than once for a given text provider so it has been removed. - Instead, populate a set |text_changed_events_| which contains the text providers via |GetUiaTextPatternProvider| and fire the UIA text events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents - |text_selection_changed_events_| could also potentially end up with the same double-event problem, so it uses GetUiaTextPatternProvider now as well. - Removing usage of std::unordered_set based on the guidance in base/containers/README.md. In general these sets shouldn't grow large enough to benefit from being unordered. AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. Bug: 1105262 Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#796464}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/db0253c93b9b..13ebfa60c3f2 $ git log db0253c93..13ebfa60c --date=short --no-merges --format='%ad %ae %s' 2020-08-10 wub Deprecate --gfe2_reloadable_flag_quic_save_user_agent_in_quic_session. 2020-08-07 nharper Expose ProofSource::Details on QuicCryptoServerStream 2020-08-07 renjietang Add version DCHECKS in GOAWAY handling. 2020-08-07 nharper Tighten content-length header parsing in shared spdy code, not flag protected Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src remove deprecated flag R=dschinazi@chromium.org Change-Id: Ia065ee167b59261845f652258cbeb47584cd8a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346909 Auto-Submit: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796463}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/IVemt3pOQOKoaDEDMgqmUBfRju4WJsHWYff7SymNScAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159394333,b/159394534,b/159964708,b/160646592,b/160930327,b/161170553,b/161179660,b/162901119,b/163099117 Tbr: help-app@grotations.appspotmail.com Change-Id: I6879e2d711d88064544f2f94459621a93305a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796462}
-
