- 30 Jul, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It removes ClearCache from PO2TS since it's only used by PO2TS and it could call ClearCache through |token_manager_| instead of having a helper method and it moves UpdateClearsCache from ProfileOAuth2TokenServiceTest to OAuth2AccessTokenManagerTest. It removes GetTokenCacheCountForTesting from PO2TS because UpdateClearsCache which needs a cache size is moved to OAuth2AccessTokenManagerTest and it gets the size from |token_manager_| directly. The test name, 'UpdateClearsCache', is also renamed to 'ClearCache' in OAuth2AccessTokenManagerTest. Bug: 967598 Change-Id: Icf700cd3709a3749df13e556bd6ca9107d615900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719112 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682131}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/gfx. *_struct_traits.* => *_mojom_traits.* ui/gfx/mojo => ui/gfx/mojom Bug: 806965 Change-Id: I26ddff47ccb37edafde1fe15d66214afb84b3537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722465 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682130}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ff7e2ebc5e4d..7c54fa2d4559 git log ff7e2ebc5e4d..7c54fa2d4559 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 crouleau@chromium.org [Telemetry] CreateResults in only one place. Created with: gclient setdep -r src/third_party/catapult@7c54fa2d4559 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:985103 Change-Id: I6141bc29472de7ae7620928498110f3a6e96d9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682129}
-
Rakina Zata Amni authored
TBR=achuith@chromium.org No-try: true No-presubmit: true No-Tree-Checks: true Bug: 988918 Change-Id: I1a0bf6d7f99cc3ccc97d5111fa10bdacd8a105e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724561Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682128}
-
Koji Ishii authored
This patch changes ResourceResponse::HttpContentType() to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII should be sufficient for most web platform usages. For MIME type, [parse a MIME type] uses [ASCII lowercase]. Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. [ASCII lowercase]: https://infra.spec.whatwg.org/#ascii-lowercase [parse a MIME type]: https://mimesniff.spec.whatwg.org/#parse-a-mime-type Bug: 627682 Change-Id: I9f44fbe1583618c3f1250af8e417dedf6cd41563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720994 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#682127}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Ia613dc3366287bce6313ec8405a0c459adeb0fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725255 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia504baed1d1a613fb58b06c2655093beb3115c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724836Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#682125}
-
Noel Gordon authored
This test is a consistent [ Pass Timeout ] flake on the MSAN bots. Tbr: rakina@ No-try: true No-presubmit: true Bug: 856601 Change-Id: If4d75e81bb8075e3a314e429f24a84dfc7157cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725242 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682124}
-
rajendrant authored
This CL adds tests for base URL, referrer-policy and crossorigin state at parse time are retained when the deferred frame is loaded-in. Bug: 984983 Change-Id: Ifab76a15a4addf750251cbfd0e6849c535b95531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719445 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#682123}
-
liberato@chromium.org authored
This CL introduces the feature flag kUseOutputLatencyFromHAL, which causes OpenSLES audio output to query the Android AudioManager for its output latency, and include that in the computed latency. Note that AudioManager.getOutputLatency is hidden in the SDK; it should not be used normally. It's only used here as a hack to fix some AndroidTV audio synchronization issues on some devices. In the future, OBOE support will switch us to AAudio, which uses the correct latency from HAL automatically. Change-Id: If6a1d46ef2f4eab98a99e53080a6b96a70d749ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722971Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#682122}
-
Mei Liang authored
Change-Id: I20e36b47a4e4111269e660142819a9e22bc2f544 Bug: 987206, 970266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719614 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682121}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/385f490b054e..84cf6f97b5e9 Created with: gclient setdep -r src-internal@84cf6f97b5e9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I27eb0f753cc0fb06cf7edb49a9e96c2cee95d666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725569Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682120}
-
Jinsuk Kim authored
The reverted CL had a regression caught by assertion in BottomSheet.getSheetState. This CL attempts to address the issue while still ensuring the animation from hidden to peek state works as expected. This reverts commit 9ae8477c. Bug: 937946 Change-Id: Iecec38cceafd2228ac7e6bebc51b3d12c5cedf1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715168 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#682119}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d31c667503bc..e858d1fb244d git log d31c667503bc..e858d1fb244d --date=short --no-merges --format='%ad %ae %s' 2019-07-29 thestig@chromium.org Rename XFA version of CPDFSDK_Widget::ResetAppearance(). 2019-07-29 thestig@chromium.org Remove a parameter to CPDFSDK_InteractiveForm::ResetFieldAppearance(). 2019-07-29 thestig@chromium.org Remove parameter to CPDFSDK_Widget::ResetFieldAppearance(). Created with: gclient setdep -r src/third_party/pdfium@e858d1fb244d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I59d9f758c508a47379d7089edade9faaa93e1e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725237Reviewed-by:
-
Ahmed Mehfooz authored
We do not currently flip the canvas for focus rings when RTL is enabled. This can cause certain focus rings to be drawn incorrectly for their corresponding buttons. Some views change their canvas flipping on RTL behavior after installing focus rings. This can cause a recently added DCHECK to fail. Bug: 986571, 960284 Change-Id: Ic24db27c1faee1c62bafbb0de1db3426bf5c23e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719673 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#682117}
-
Gayane Petrosyan authored
Bug: 988880 Change-Id: I7107fb8c3399ae1ce561d8971e40e42e112371e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725006 Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682116}
-
Akihiro Ota authored
Implement AutofillPopupViewNativeViews::GetAccessibleNodeData to set the role of the autofill suggestions container to kMenu. This method was previously unimplemented, which was causing issues with PosInSet and SetSize calculations of the enclosed AutofillPopupItemViews. This change also adds robustness to the accessibility posinset and setsize calculation code by continuing over nodes with role of kUnknown. This way, containers do not have to be immediate parents of their items, which is common on the web. Lastly, this change adds a test in accessibility code to verify the new behavior. Bug: 985987 Change-Id: I3078ff4ddfcb31224af07523da8b385267644bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709660 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682115}
-
Fabrice de Gans-Riberi authored
* Add the host chromedriver binary as part of the Fuchsia build. * Add a CIPD package to upload a stripped chromedriver binary. Bug: IN-1321 (Fuchsia internal) Change-Id: Ia414914304ede7a54ff097365bb72cba6674e5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719377 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#682114}
-
Cliff Smolinsky authored
Add wtsapi32 to delayloads list and remove it from the allowed list for chrome_child.dll. This dll is used in the browser process and with the remoting feature, neither of which requires immediate loading in chrome_child.dll. Bug: 987672 Change-Id: Ib3ddbb27578f76d854e1966a12eb1fc6cd30e9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719304Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff3f2082..bd0b0262 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d219f23380b788615a877510beb8a61f80280cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725130Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682112}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c73c7e11dbb..0395e7c66a5f git log 6c73c7e11dbb..0395e7c66a5f --date=short --no-merges --format='%ad %ae %s' 2019-07-29 moragues@google.com Atlas: Remove deprecated firmware-atlas-11827.12.B from build config Created with: gclient setdep -r src/third_party/chromite@0395e7c66a5f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1c8eaefc22db8e05f207e2e64944a736ae91a2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725293Reviewed-by:
-
Mohsen Izadi authored
When underlying cc::Layer of a ui::Layer is changed via ui::Layer::SwitchToLayer(), a bunch of properties are transferred from the old cc::Layer to the new one. masks_to_bounds() value should also be transferred. BUG=988819 TEST=LayerWithRealCompositorTest.SwitchCCLayerTrilinearFiltering/* in compositor_unittests Change-Id: I36d245a91975f0e3e6a6cd51119d973b0452ae68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725095Reviewed-by:enne <enne@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682110}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It removes CancelAllRequests and CancelRequestsForAccount from PO2TS since these are only used by PO2TS and it could call these methods through |token_manager_| instead of having helper methods. It moves CancelAllRequests and CancelRequestsForAccount from ProfileOAuth2TokenServiceTest to OAuth2AccessTokenManagerTest since OAuth2AccessTokenManager manages requests. It adds AddAccount to FakeOAuth2AccessTokenManagerDelegate to handle multiple accounts. Bug: 967598 Change-Id: I550a241a632a84f431c8eb348b544b81f1b8eac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715174 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Collin Baker authored
FloodFillInkDropRipple uses different durations for flood-fill and fade-out animations for different target states. This changes InstallableInkDrop to use the same times. Bug: 933384 Change-Id: I84520a7c8b919223a71df979cebcbdb070dfdf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716099 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#682108}
-
Hesen Zhang authored
- In support of loading/adding/deleting a vector of icons with callbacks. - Change Add API, removing key argument. - Will follow-up unit test in next cl. Bug: 963290 Change-Id: Ie0fddeea5a1dc74103fb5765a976bb3ad933e156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722407 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682107}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2386ffedf334..ff7e2ebc5e4d git log 2386ffedf334..ff7e2ebc5e4d --date=short --no-merges --format='%ad %ae %s' 2019-07-29 rnasri@google.com Add screenshots based speed index metric Created with: gclient setdep -r src/third_party/catapult@ff7e2ebc5e4d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:983638 Change-Id: I67e976206f255ea37092e9a7ef9972d7cec223a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725295Reviewed-by:
-
Vlad Tsyrklevich authored
WaitForMultiprocessTestChildExit on Android currently can't handle child process crashes due to threading requirements for the Android-specific implementation. Hack around it for now. Bug: 973167 Change-Id: I7027dba463150802516ea525f4fc4e2cdfd8d18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725335 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#682105}
-
Koji Ishii authored
This patch changes AXNodeObject::AriaAutoComplete() to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII should be sufficient for most web platform usages. From the spec perspective, the ARIA-HTML spec does not specify case-insensitiveness for "aria-autocomplete" attribute: https://www.w3.org/TR/wai-aria-1.1/#aria-autocomplete but HTML uses ASCII case-insensitive for all its attributes: https://infra.spec.whatwg.org/#ascii-case-insensitive Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. Bug: 627682 Change-Id: I9aa1e89365aee4d795daaea53103049ff5bdfd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720820Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682104}
-
Keith Lee authored
Change-Id: I2e895223f327172b59613302454654b943d7fdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722831 Auto-Submit: Keith Lee <keithlee@google.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Keith Lee <keithlee@google.com> Cr-Commit-Position: refs/heads/master@{#682103}
-
Andrew Grieve authored
It's used only for chrome_apk. Also simplifies resource_blacklist_regex in compile_resources.py so that it is able to remove a resource from all densities. Bug: 988047 Change-Id: Ic47140f9f597dcee7abd0762131a5dbffd08780b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721452Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#682102}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5048a6a756bf..e68b5bd4e6e9 git log 5048a6a756bf..e68b5bd4e6e9 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 csmartdalton@google.com don't try to format includes on windows 2019-07-29 csmartdalton@google.com Rename labrynth.cpp -> labyrinth.cpp Created with: gclient setdep -r src/third_party/skia@e68b5bd4e6e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: If241921fa74997277fb312790fdbb1dafc31be64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725294Reviewed-by:
-
Timothy Loh authored
This CL removes the CrostiniAppLaunchObserver abstraction, which does not actually give us any benefit because where it is used we already know about the derived class, and it also isn't used like a regular observer. I also updated includes to make the dependencies clearer. Change-Id: Id75bac0db683a9800ede6b9993c62dfa927231b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722139 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682100}
-
Oliver Dunk authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ucEUTqoi4Nc/wx3q-B7tAQAJ Bug: chromium:966249 Change-Id: I84c95a54724227815e674b3804119666bf6b0291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702364 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#682099}
-
George Burgess IV authored
Our current profile is one from a release branch, and release branch profiles have caused us headaches in the past. We're fixing the autoroller to no longer roll us to these profiles in https://skia-review.googlesource.com/c/buildbot/+/230302 . That CL requires us to be on a profile that isn't a branch profile. TBR=agrieve@chromium.org Bug: 988452 Change-Id: I6a631e16bb0f40d1613bfdbb5b5a2e50bbaa5a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723025Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#682098}
-
Jeremy Chinsen authored
Currently draw_utils::GetBottomFillRect() returns the gap on the bottom side of a page created by insetting the page. However, in two-up view, the bottom gap for a page has height equal to the difference in height between the current page and its adjacent one. draw_utils::GetBottomGapBetweenRects() takes the bottom component of a page and a rectangle, returning the portion of the rectangle that is below the page. This will be used in PDFiumEngine to compute the bottom empty space for a page in two-up view as mentioned above. Bug: 51472 Change-Id: I436600264106340ca6699799359149f29c797844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721318Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#682097}
-
Jonathan Ross authored
The image diff was approved. Re-enable the test TBR=ynovikov@chromium.org TEST=Pixel_CSS3DBlueBox Bug: 976370 Change-Id: I99d457c83e72982525f6ef4b9d2ce16d1b1101e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724890Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#682096}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8404419a9f8..385f490b054e Created with: gclient setdep -r src-internal@385f490b054e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ic02267473efe1de63739ff6c149af1a9ba967c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725188Reviewed-by:
-
John Rummell authored
Now that FileStreamReader and FileStreamWriter work with PluginPrivateFileSystem, enable incognito mode for PluginPrivateFileSystem. Also updates FileStreamReader to work with the PluginPrivateFileSystem in incognito mode, as the ObfuscatedFileUtilMemoryDelegate is different. This adds 2 more browser tests that verify that encrypted media can read and write files successfully in incognito mode (as it uses the PluginPrivateFileSystem). Verified using inotifywait that the test does not write anything to disk. Bug: 958294,902021 Test: new browser_tests pass Change-Id: I01914cdd866ff96867e7bebfeaea6ef827a5a9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718985Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682094}
-
Mustafa Emre Acer authored
When the lookalike URL interstitial stops a redirect, reloading it navigates to the end of the redirect chain which hides the interstitial. In order to prevent this, this CL stores the parameters of the interstitial (URL, redirect chain and referrer) as WebContentsUserData. On page reload, the throttle retrieves the parameters and checks if the currently navigated URL is at the end of the stored redirect chain. If so, it cancels the current navigation (the reload) and navigates back to the original lookalike URL that triggered the interstitial. As a result, a reload will end up with the same interstitial as before. The throttle immediately clears stored interstitial parameters after it retrieves them, so that unrelated navigations (to a different URL, or initiated directly by the user) don't re-trigger the interstitial. Bug: 941886 Change-Id: If37802815f296bf534d7fb3b54fe96813d1659d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715759 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#682093}
-
Jun Mukai authored
Currently state changes are ignored when the app-list is closed, so I think it's better not to clear the search state there. Instead this allows to clear the state on showing (ResetForShow). This works fine with tablet mode so I'm leaving some of the existing conditions as-is. Ideally state change should be accepted after the closing animation finishes -- that wouldn't affect the rendering and animation smoothness. Modifying that requires larger changes, but this CL wants to be small for merging to M77 branch. Bug: 987584 Test: manually Change-Id: Ie577941b662e68768b2ef03490eb6eb7324332d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725190Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#682092}
-
