- 24 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1faae79f67ac..e8d14c45f873 Created with: gclient setdep -r src-internal@e8d14c45f873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43b543a0063cca5e5b0ae69029e2be33f5c31c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708884}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd1b164088d5..e83f334d45d6 git log fd1b164088d5..e83f334d45d6 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e83f334d45d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ie8405f88dfbcaba7e577b0251ec90219da747eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708883}
-
Chris Lu authored
Creates a new BadgeType for the Save Credit Card Infobar. Adds support for the badge in BadgePopupMenuItem and BadgeButtonFactory. Bug: 1014959 Change-Id: I3052c0a17ea4e5f68db3a16ead997605b58aaacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872014 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#708882}
-
Julie Jeongeun Kim authored
This CL converts ActivationDelegate from cellular_setup.mojom to new Mojo types using PendingRemote, ReceiverSet, and Remote. Bug: 955171 Change-Id: I95085ca9a9d9759bf71366be043adb7223a9a32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872093 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708881}
-
Yun Liu authored
Android instrumentation tests and gtests cannot be separated at mb so we pass '--coverage-dir' to both if any coverage turned on and tackle it at runner side for '--coverage-dir'. Also changed 'java_coverage' to 'use_java_coverage' to be consistent. Bug: 985574 Change-Id: Ia3d99f07292b49714196e3c296d3234420bee0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876492 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708880}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e8378a666b73..2b4bcf993ef5 git log e8378a666b73..2b4bcf993ef5 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org wrapper: use importlib if available Created with: gclient setdep -r src/third_party/chromite@2b4bcf993ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I745380dfa4cfea386914b694747647fdbeb89b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877612Reviewed-by:
-
Chris Lu authored
This change implements presenting InfobarBannerViewController when InfobarTranslateCoordinator starts and the button action. Some constants from TranslateInfobarController are moved to a constants so that they can be shared. Screenshot of what it will look like when activated: https://drive.google.com/open?id=11W6HznODlJduMCZgNOSR1b8Gi_crfQl0 Bug: 1014959 Change-Id: I4e5e2859d20e3f04cd477f65e23889d2aa5b37e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872013 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
M77 has reached stable and there have been no major issues with the new names. Bug: 968369 Change-Id: I2de8132b9ac233a982c3e0d01bafd1c53e80d412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816251Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#708877}
-
Julie Jeongeun Kim authored
This CL converts WebContentsNSViewHost and WebContentsNSViewHost from web_contents_ns_view_bridge.mojom to new Mojo types using PendingAssociatedRemote, PendingAssociatedReceiver, AssociatedReceiver, and AssociatedRemote. Bug: 955171 Change-Id: Ib6770e5030ee68c9882f7f5f2d3654e6cda79d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872215Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
kdillon authored
Change-Id: I9236718df91559319cc1e52992713a1ee0112952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822877Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708875}
-
Mohamed Heikal authored
Change-Id: I349a83d51452b4c55480fe079a7e1c732dd10f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876970Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708874}
-
Fergal Daly authored
All of these passed in this run on linux debug shards/0:Task: https://chromium-swarm.appspot.com/task?id=480b070d14519110 shards/1:Task: https://chromium-swarm.appspot.com/task?id=480b07300c6b9710 shards/2:Task: https://chromium-swarm.appspot.com/task?id=480b0756649ce610 shards/3:Task: https://chromium-swarm.appspot.com/task?id=480b0788b3c15e10 shards/4:Task: https://chromium-swarm.appspot.com/task?id=480b07cc5f172610 shards/5:Task: https://chromium-swarm.appspot.com/task?id=480b07d051ded010 shards/6:Task: https://chromium-swarm.appspot.com/task?id=480b0808d3319210 shards/7:Task: https://chromium-swarm.appspot.com/task?id=480b08113378bb10 shards/8:Task: https://chromium-swarm.appspot.com/task?id=480b084685625110 shards/9:Task: https://chromium-swarm.appspot.com/task?id=480b088bbb9ab510 and on android debug android-shards/0:Task: https://chromium-swarm.appspot.com/task?id=480adbf31c911d10 android-shards/1:Task: https://chromium-swarm.appspot.com/task?id=480adbfb629e4110 android-shards/2:Task: https://chromium-swarm.appspot.com/task?id=480addfec56a7110 android-shards/3:Task: https://chromium-swarm.appspot.com/task?id=480adbfe38c2a210 android-shards/4:Task: https://chromium-swarm.appspot.com/task?id=480ade00c0c16c10 android-shards/5:Task: https://chromium-swarm.appspot.com/task?id=480adbf515c64f10 android-shards/6:Task: https://chromium-swarm.appspot.com/task?id=480adbfcd1f37b10 android-shards/7:Task: https://chromium-swarm.appspot.com/task?id=480ade0fee6ffb10 android-shards/8:Task: https://chromium-swarm.appspot.com/task?id=480adbfe8d557810 android-shards/9:Task: https://chromium-swarm.appspot.com/task?id=480ade012ccd8a10 Sadly, I haven't figured out a nice way to aggregate these into friendly test reports. Tests noted as being flaky will be handled in a different CL. Change-Id: I84df1dc4be6efa13b911c2ae3232e76abd35b925 Bug: 1016230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862137Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708873}
-
Aaron Colwell authored
- Create a common function for generating the killed_process_origin_lock crash key value so we get consistent results no matter what causes this key to get logged. - Introduce can_access_data_failure_reason crash key to make it easier to determine the reason for access failures. Citadel enforcement was trying to use the killed_process_origin_lock key to convey this info but that is no longer possible now that values for that key are consistent across all code paths. Bug: 1015882 Change-Id: I892ee47ca50ac1739eeebdbfb91425342df742dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876745 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708872}
-
Jinsuk Kim authored
AssertionError-based tests are not guaranteed to work. This CL changes the assertion exception used in UserDataHost class to runtime exceptions to make it test-friendly. Items tested in the tests now throw IllegalStateException or IllegalArgumentException. Bug: 877918 Change-Id: I0f1d8c7d9b49a7b8c4020bdfaaf3e15479110b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1192484 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708871}
-
Christopher Cameron authored
We are already doing this in the GPU process as the histogram Gpu.Metal.TestShaderCompileSucceeded. That histogram indicates that we fail to compile the shader from the GPU process within 6 seconds 2% of the time. The new histogram Browser.Metal.TestShaderCompileTime histograms the shader compile time, up to 1 minute, whereupon it uses the max bucket (3 minutes). Also add a DumpWithoutCrashing on timeout. This will have to be removed after one promotion to dev (to not drown out real crashers), but will help gather more information about crashing machine profiles. Move the test shader code into the metal_util component so that it can be used by both locations (the previous implementation was in /viz/). Bug: 974219 Change-Id: Ieeac67d7dcbef53d7e3cc257eca6ba9fccf94286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872624 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9988f9da4047..bf69ed0d31f4 git log 9988f9da4047..bf69ed0d31f4 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 sadrul@chromium.org uma-metric: Specify the bins for peak gpu memory usage metric. 2019-10-23 crouleau@chromium.org [Telemetry] Abridging a story set must come before shard indexing Created with: gclient setdep -r src/third_party/catapult@bf69ed0d31f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:908462,chromium:987273,chromium:965158 Change-Id: Ibd00bf8827a0ccae00a0ddfe470e3cc5a2fe8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877608Reviewed-by:
-
Charlene Yan authored
Bug: 901183 Change-Id: Iadae6a197d4e2842b285d4ea7ce7e632a771bd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867179 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708868}
-
Rouslan Solomakhin authored
Before this patch, a compromised renderer could read-write the instrument metadata for any origin. This patch ties the payment manager to the origin of its context. After this patch, cross-origin payment manager access should not be possible. Bug: 1011600 Change-Id: I22142bdca98de9c9334c0f5e62f9f0268cda8f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865770Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708867}
-
Collin Baker authored
Thumbnail sizes will soon be dynamic. WebUITabStripContainerView will need to resize itself when they change, so it needs to know how the tab strip will be layed out. This CL adds layout calculation logic in C++-side code so both the tab strip and the WebUITabStripContainerView can use it. Bug: 1013646 Change-Id: If45238985e304ec42721a96518b7f1afc264f256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872784 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3b63d6f..bbf7cb0e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idcb42373582b82f1baa529432cc60fde453384fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708865}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbaef603dece..fd1b164088d5 git log fbaef603dece..fd1b164088d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-23 herb@google.com Use common path drawing code Created with: gclient setdep -r src/third_party/skia@fd1b164088d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I2a96b727c7fc33eca267b9137e0a666f4aa04ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877428Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88a99e4382c1..b2885bc4a40f git log 88a99e4382c1..b2885bc4a40f --date=short --no-merges --format='%ad %ae %s' 2019-10-23 tobine@google.com Vulkan:Enable UpdateBufferInUse test on AMD 2019-10-23 xinyi.he@arm.com Vulkan: Mipmap is unconditionally enabled in ANGLE Created with: gclient setdep -r src/third_party/angle@b2885bc4a40f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I3b36d0ffca4cd0b0f61614e5ad576cdff1a4a41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877607Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7bf2eba2b5d..1faae79f67ac Created with: gclient setdep -r src-internal@1faae79f67ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia8adbe6e840ebf93accd8e3007c25a6dc80a6948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877391Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia3a734a764a952f565c3785bddf2a381774a96f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877430Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts CarrierPortalHandler to new Mojo types using PendingRemote, ReceiverSet, and Remote. Bug: 955171 Change-Id: I5ac9e2b0c40a7e0020af8cd2265bb64ece4b9c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871878Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactory from //content to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: I106caf8803c9897d6a671042bbc94d3f90a8450a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863933Reviewed-by:
-
tby authored
I made a mistake in our testing config for ramping to beta, this fixes the experiment name. Bug: 959679 Change-Id: If5fa7a17c32185a8276e2f40ffd17c2026f43b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871717Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#708858}
-
Ken Rockot authored
Instead of going through Service Manager to get a Data Decoder instance, this changes the Explore Sites feature to maintain its own lazily spawned Data Decoder instance using the public Content API. This should effectively mirror the old behavior, including the 5-second timeout of the instance used. Bug: 977637 Change-Id: Ic76a472dabffbbce339cde6c3fab21d1f8b9a195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872418 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708857}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4ff1c872045c..c1a8abc0a3e7 git log 4ff1c872045c..c1a8abc0a3e7 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5030084..510c0ca3 (708640:708742) Created with: gclient setdep -r src/third_party/webrtc@c1a8abc0a3e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I800c9f3a2f0262bf6ef2220a5b6342fc3a95369e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877388Reviewed-by:
-
Andrii Shyshkalov authored
Picks up hopeful workarounds for failure to remove virtual env: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1876802 https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1876638 R=bpastene Bug: 869227 Change-Id: I9d46bb7579e747819d7d82cd3ad06968dd28e7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876471Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#708855}
-
Peter Kasting authored
A whole bunch of miscellaneous small changes. Bug: 1015717 Change-Id: Ia769176e993e46e0adba7993378a575445df7a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874705Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708854}
-
Xiaoqian Dai authored
Previously with hotseat feature enabled, the MRU window can only be dragged if hotseat is swiped up to show above the shelf first. However, we want the MRU window to be able to be dragged directly from shelf, no matter the hotseat is hidden below the shelf or shown above the shelf. Besides, the MRU window should dragged up along with the hotseat, that means, the window dragging should be part of shelf dragging logic (i.e., DragStatus::kDragInProgress), not part of home launcher dragging logic (i.e., DragStatus::kDragAppListInProgress). So in this CL, move the window dragging logic to shelf dragging. I'll remove the corresponding wiring code in HomeLauncherGestureHandler and migrate the tests in a following CL. Bug: 997885 Change-Id: Idd333286c1fac27f53899104f43ef2956ff20b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876746 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708853}
-
siashah authored
Currently, when the user clicks on the done button on the keyboard with an empty text box, we attempt to save the card on payments backend. With this change, we will perform no action if the name field is not filled. Bug: 1016877 Change-Id: I399e2a46925d9092f28f01703846a4481da86e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873721Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#708852}
-
Garrett Beaty authored
Split up the lint-luci-milo and generate_buildbot_json checks into separate conditions, update the path to luci-milo.cfg to be in the generated subdirectory and trigger the generate_buildbot_json check on changes to luci-milo-dev.cfg. Change-Id: Ideb1ab426619fb39d1ffe1da4ea8b60ecca4d949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877590 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#708851}
-
Robbie McElrath authored
See the design linked in the bug for descriptions of these metrics. This CL also changes the test logic to wait for more of VariationsSeedLoader to finish before checking results. Bug: 1010625 Change-Id: Id77d7b16f4bb3e0ac02e134f0d5ebee4917eeaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841240Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#708850}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/720447713e24..e8378a666b73 git log 720447713e24..e8378a666b73 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org loas: use encoding=utf-8 for commands 2019-10-23 vapier@chromium.org paygen: replace gspaths._RandomString with cros_build_lib.GetRandomString 2019-10-23 kimjae@chromium.org osutils: CopyDirContent needs to copy symlinks like copytree symlinks 2019-10-23 saklein@chromium.org gen_call_scripts: Add board option. Created with: gclient setdep -r src/third_party/chromite@e8378a666b73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7501664600a8e145ba3cb1fcfdbf4335fc71c431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875659Reviewed-by:
-
Xinghui Lu authored
When performing the full URL lookup, strip out the fragment, username and password components. Fragments are only used for local navigations. Usernames/Passwords are too privacy sensitive. Bug: 1015469 Change-Id: Ib3885a0acc7c479087cb9e5fe55696cd4745b7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872753 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708848}
-
Livvie Lin authored
Renames omnibox_https_invalid.png since the triangle icon will be used for HTTP pages as well as part of crbug.com/1008219. Bug: 1008219 Change-Id: Idca6aec6f38fa393accb64858d87c8c62b8f4543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873958 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708847}
-
Albert Chaulk authored
Cast javascript channels add a window.<foo>.postMessage(message) method to selected RenderFrame instances to allow renderers to push data to the embedder. The usage looks like this: Browser: add interface during init Renderer: bind JsChannelBindingProvider, call Register, provide JsChannelClient Browser: stick the pid/route/channel in a list Embedder: AddJavascriptChannels Browser: lookup current RenderFrame and corresponding channel, call JsChannelClient::CreateChannel, provide JsChannel Renderer: create JS bindings <script>: call function Renderer: JsChannel::PostMessage Browser: send message to embedder Bug: b/141864193 Test: desktop cast_shell build + custom html Change-Id: I1425cb115f679b876a8b9cb75c418b9d2a7a1506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863073Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#708846}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb9a722fb28..e8843ab060ac git log 9fb9a722fb28..e8843ab060ac --date=short --no-merges --format='%ad %ae %s' 2019-10-23 treehugger-gerrit@google.com Merge "Remove the call to std::partition, and replace with a readable for loop." Created with: gclient setdep -r src/third_party/perfetto@e8843ab060ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib719ae291a42ec8619516d8b6f141ab37c1c7a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876882Reviewed-by:
-
