- 05 Jun, 2018 36 commits
-
-
Adithya Srinivasan authored
I think the crash in https://crbug.com/848212 is caused due to Document::focused_element_ being cleared out during the UpdateStyleAndLayoutIgnorePendingStylesheetsForNode call in Document::SetFocusedElement, but I'm unable to reproduce a situtation where this happens. This CL adds a CHECK that crashes when SetFocusedElement is called during UpdateStyleAndLayout, just so I can get some stack traces in the wild and confirm this theory. Bug: 848212 Change-Id: Ia9293ea155e4ae976592166e7ab4f936f25f3f38 Reviewed-on: https://chromium-review.googlesource.com/1085607 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#564337}
-
Devlin Cronin authored
Migrate the tabs API to use UIThreadExtensionFunction instead of ChromeAsyncExtensionFunction. Bug: 634140 Change-Id: If814f2b4040ec5d38d7e61368c3826ad171ea4dd Reviewed-on: https://chromium-review.googlesource.com/1067481 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564336}
-
Devlin Cronin authored
Update all histogram_tester.h includes in //cc to include //base/test/metrics/histogram_tester.h TBR=enne@chromium.org Bug: 846421 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74c3466b6e9986c1263be4b3c8fb79d2fbebf5b0 Reviewed-on: https://chromium-review.googlesource.com/1086243Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564335}
-
Matt Mueller authored
If the primary and trial verifiers build different paths, and the trial verifier succeeded or the primary verifier failed, try verifiying the trial-built path with the primary verifier. This allows us to ignore some cases where the platform verifier built a poor/different chain but can be coaxed into building a better one by giving it the other chain as input. Bug: 649026 Change-Id: I0b0f6bf7c230abceadcfceedfeeacc6b39339292 Reviewed-on: https://chromium-review.googlesource.com/1083845Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#564334}
-
Oystein Eftevaag authored
TBR=primiano@chromium.org CC=brucedawson@chromium.org https://android.googlesource.com/platform/external/perfetto.git/+log/f0161112a8e0..706b28889182 $ git log f0161112a..706b28889 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 oysteine Chrome+Perfetto buildfix: The tracing integration test relies on IPC too. 2018-06-04 lalitm trace_processor: add code for parsing a trace 2018-06-04 primiano Move ftrace_reader code into src/traced/probes/ftrace 2018-06-04 primiano Add ui build to travis 2018-06-04 primiano Fix perfetto_unittests on Mac 2018-06-01 oysteine Ensure no ipc code is built for Chrome 2018-06-01 hjd ui: Fix node_modules symlink and WASM output 2018-06-01 lalitm protozero: add proto decoder class for efficient in-place decoding 2018-06-01 lalitm trace_processor: add base trace loading code 2018-06-01 lalitm trace_processor: initial definition of columnar trace class 2018-05-31 lalitm tools: fix build of ftrace_proto_gen on OSX 2018-05-31 hjd ui: Make source maps work 2018-05-31 hjd ui: Add tools/node and tools/npm 2018-05-31 hjd ui: Switch browserfiy to rollup 2018-05-31 hjd ui: Add worker bundle 2018-05-31 hjd ui: Don't always re-symlink node_modules 2018-05-31 hjd Build js in obj and leave dist for the real build 2018-05-31 primiano Update to node current (v10) 2018-05-25 hjd Add Jest unittesting framework 2018-05-24 hjd ui: Nest typescript src in ui/src/ 2018-05-24 fmayer Truncate traces for all CPUs. 2018-05-23 lalitm perfetto: update init rc file to account for atrace running 2018-05-23 fmayer Run clang-format in protogen. 2018-05-23 hjd Add quickstart instructions for UI Created with: roll-dep src/third_party/perfetto Change-Id: I79027daeb00006313336bb387dd33eda476227c1 Reviewed-on: https://chromium-review.googlesource.com/1085931Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#564333}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/518bb68..23d75d2 git log 518bb68..23d75d2 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 nodir@google.com [git-cl-try] Handle absence of builds 2018-06-04 nodir@google.com Fix buildbucket bug filing instructions Created with: gclient setdep -r src/third_party/depot_tools@23d75d2 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:849361,chromium:849361 TBR=agable@chromium.org Change-Id: Ie899f8051bb2940e4345f825fb0482ac52b489d2 Reviewed-on: https://chromium-review.googlesource.com/1086027Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564332}
-
Gyuyoung Kim authored
Orignal commit: f4544427 This CL was reverted because it caused the timeout test failure on fyi bots. But, it looks like the issue was solved. So now this CL lands original CL without a duplicated function invocation. Bug: 842019 Test: Covered by RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeMemory Change-Id: I52a4bafc1688822a11fa2408ad7422331fa62a46 Reviewed-on: https://chromium-review.googlesource.com/1084369Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#564331}
-
Siddhartha authored
We observe that the intervention does not have any effect on population. Add metrics to see why it fails. BUG=843419 Change-Id: I1e7443a749331135dbbad9c51ff79ba9d1975db7 Reviewed-on: https://chromium-review.googlesource.com/1083594 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564330}
-
Robert Liao authored
BUG= Change-Id: I8db2a8c03430a8289a9d9f81d1170564cccc2df8 Reviewed-on: https://chromium-review.googlesource.com/1086213 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#564329}
-
dpapad authored
- Ensure 'close' event is bubbling. - Change event target for 'transitionend' to be the underlying <dialog> directly, since 'transitionend' no longer bubbles across shadow roots. Bug: 849465 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I66028eca97595df32637adc94fa48dfdb6510cec Reviewed-on: https://chromium-review.googlesource.com/1086267Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564328}
-
Pavel Yatsuk authored
BUG=811909 R=pnoland@chromium.org Change-Id: Ide1a78f0f35270109f135d899e2be901e73f65c4 Reviewed-on: https://chromium-review.googlesource.com/1081155 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#564327}
-
Xing Liu authored
When the SD card is unmounted, we show a snackbar to inform the user about missing files when first time enter download home. Currently it won't show because externally removed flag is set after loading the db. And we shouldn't use externally removed flag since the user may remove files from other apps. Bug: 844218 Change-Id: I9fa55fc7b7ffe02d8e18c2c8bfb28b4e48cb2b4e Reviewed-on: https://chromium-review.googlesource.com/1085697 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#564326}
-
Devlin Cronin authored
Update all histogram_tester.h includes in //ash to include //base/test/metrics/histogram_tester.h TBR=derat@chromium.org Bug: 846421 Change-Id: Ifeaaa1d725e9ad01af40f803aa210ada3ed35cdf Reviewed-on: https://chromium-review.googlesource.com/1086241Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564325}
-
Christopher Cameron authored
Skia will frequently allocate large temporary buffers (1k x 2k), write to a small part of the buffer, and then read from that small part. To ensure that we do not read from uninitialized memory, the GPU process will then clear all except for that small region of the buffer. This clear is, for historical reasons, implemented as a glTexSubImage2D, and we end up throwing ~8MB of data through glTexSubImage2D during tab switch, which can take ~200 msec, and produce noticeable jank. Split the pre-existing code to clear a level using glClear into a ClearLevelUsingGL function, add support for color buffers (it was previously only used for depth/stencil buffers), and use it for any uploads of more than 4k (an arbitrary choice based on my observation that we often do very small clears as well as very large clears). Bug: 848952 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iba6f36c44dae9f3be3fa431ff0e64dbd8e706e8a Reviewed-on: https://chromium-review.googlesource.com/1083782 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#564324}
-
Robert Ogden authored
This flag overrides the ClientConfig used by the data reduction proxy, regardless of any auth error or expiration of the config. This flag will be used for testing and performance analysis. Bug: 724242 Change-Id: I1b3fc36088318e9423f4b71cf59f67f266e28df8 Reviewed-on: https://chromium-review.googlesource.com/1083813Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#564323}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1589154..5034384 git log 1589154..5034384 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 smut@google.com [Isolate] Update clients to hit /_ah/api instead of /api Created with: gclient setdep -r src/third_party/skia@5034384 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:805543 TBR=halcanary@chromium.org Change-Id: Ia2ac715be890368e6cc85ce3048dfe78df28efc5 Reviewed-on: https://chromium-review.googlesource.com/1086327Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564322}
-
Timothy Loh authored
As it may take a several seconds to spin up the Crostini VM, we should show a spinner so the user has some indication something is going on. We also remove the spinner if the app fails to launch for some reason. Bug: 836673 Change-Id: I8f8c15af201abefe5a1717c106842740a2794b09 Reviewed-on: https://chromium-review.googlesource.com/1055170 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564321}
-
Esmael El-Moslimany authored
Bug: 849234 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id0c0ab1e66289429e1cf51d0f9b2bc80cee3adfc Reviewed-on: https://chromium-review.googlesource.com/1086032Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#564320}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 833598 Change-Id: I400b2b07c60a712a516d3322904933ff6bc5ed9f Reviewed-on: https://chromium-review.googlesource.com/1086376Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564319}
-
Esmael El-Moslimany authored
Bug: 849180 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I71a8dbc6a17383f21bd58ff3c9d918444930f715 Reviewed-on: https://chromium-review.googlesource.com/1086040Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#564318}
-
Bret Sepulveda authored
The tab strip's parent Widget doesn't have a NonClientFrameView in unit tests. This patch moves the logic for determining where the new tab button should go to TabController, which has a fake version for tests. Bug: 846410 Change-Id: I572b3b9aa6f4e4213ea9c203198b6f7bb98746c2 Reviewed-on: https://chromium-review.googlesource.com/1081891 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#564317}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/179611c..9665e37 git log 179611c..9665e37 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9665e37 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5b2591e4b8270a7fcc6449dca008a698c80bd60a Reviewed-on: https://chromium-review.googlesource.com/1086307Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564316}
-
Nasko Oskov authored
Session history keeps a SiteInstance associated with each entry to ensure that back/forward navigations and reloads can correctly load in the right process. However, it is possible that the SiteInstance changes between the time the navigation that caused the session history entry to be created and the subsequent history navigation/reload. In such case, a new session history entry should be created with replacement instead of reusing the existing entry. This implies that SiteInstance should never be updated on its own for a FrameNavigationEntry, so this CL is the first step along the way. It is removing its setter for pending entries and enforces that it is never changed once set. The follow up will do the same for updating entries, however it does need to change how NavigationController works, so it will come separately. Bug: 849430 Change-Id: Ia0a21d55d9a81bd94b06fac97de1b04ecdd95fdc Reviewed-on: https://chromium-review.googlesource.com/1083596 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564315}
-
Siddhartha authored
In case the renderer dies before it gets the start detection command, the metrics recorded will be wrong. So, initialize to 0. The 0x will still be recorded in UMA to understand how often this happens. BUG=843419 Change-Id: If00c4cf94376fb137d78bf22dabaab379f144107 Reviewed-on: https://chromium-review.googlesource.com/1086216 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564314}
-
Raymond Toy authored
Check whether we have access to the audio data when the format is set. At this point we have enough information to determine this. The old approach based on when the src was changed was incorrect because at the point, we only know the new src; none of the response headers have been read yet. This new approach also removes the incorrect message reported in 619114. Bug: 826552, 619114 Change-Id: I95119b3a1e399c05d0fbd2da71f87967978efff6 Reviewed-on: https://chromium-review.googlesource.com/1069540 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564313}
-
Ted Meyer authored
Bug: 847686, 796250 Change-Id: Ifc2855c5ec7c6479fdeb405a0cd7f2f3e8c8697a Reviewed-on: https://chromium-review.googlesource.com/1086232Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564312}
-
Andrew Grieve authored
In order to roll GN 0fbf0789..84176d72 (r555198:r564007) and pick up the following changes: ce772faa Remove references to exe_and_shlib_deps in src 8492bbe2 Fix GN bootstrap 6b9b0c9c Remove memory peak detection code. d7ed1f0a Add exe_and_shlib_deps to executable and shared_library configs 8aca6d50 Fix gn bootstrap 524e60fb Fix typo in gn documentation 37097a96 Remove implementation of legacy heap profiler. 3ae94eab Reland "GN: do not make indirect dependency to direct dependency" 3685d341 Fix gn bootstrap 75dfa0ea GN: Handle deps always in create_bundle target 82a5f004 Reland "Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK" 4497a44f Fix gn CHECK()ing on not_needed() when given undefined identifiers 7ad7e759 Revert "Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK" 5a7f3c44 Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK fa3fcf68 Revert "GN: do not make indirect dependency to direct dependency" 443b70db Fix GN doc formatting. e8a3ce91 GN: do not make indirect dependency to direct dependency ea15ea06 Fully move PathService into the base namespace. ae62ba99 GN: Make the linker output file depend on the inputs. 629ba73c [MessageLoop] Fix message_loop.h includes TBR=dpranke@chromium.org Bug: 843470 Change-Id: I6cde57fde9d867da6ae9f7c8039abcdf545b0b1c Reviewed-on: https://chromium-review.googlesource.com/1085699 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#564311}
-
Mark Pilgrim authored
Bug: 844940 Change-Id: I714d4b403345a3d44b82f217c4e3c103f6a7142e Reviewed-on: https://chromium-review.googlesource.com/1082713 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564310}
-
Bruce Dawson authored
TL;DR - these failures are from a bug/limitation in the test, not a bug in the code being tested. Also, I like it when my floating-point math expertise is actually useful. TimeTicks.FromQPCValue uses double math to verify some integer calculations. Unfortunately, the double calculation involves a multiplication and a division - two roundings - which means that the result can end up being slightly more than 1.0 away from the correct results. I used a combination of Wolfram Alpha and a tiny C++ program to figure out the correct result and the double-rounded result and confirm that an error of 1.00048828125 is actually expected given the QPC frequency on this particular machine. Increasing epsilon a tiny bit seems like the safest and simplest fix. The alternative would be to set epsilon to 1.0 plus the machine epsilon at the range of expected_microseconds_since_origin but at some point that solution becomes too complex and error prone to justify its existence. If failures happen with the slightly increased epsilon then we can consider something more sophisticated. Bug: 786046 Change-Id: I8045128747d72fe5df434905afcf043139f3123c Reviewed-on: https://chromium-review.googlesource.com/1085461 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564309}
-
Varun Khaneja authored
R=jialiul Bug: 750327 Change-Id: I688565f5b3436e9787439e0211ec0c5911a28302 Reviewed-on: https://chromium-review.googlesource.com/1086297 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#564308}
-
Ryan Sturm authored
The cached config takes a few thread hops to apply and in the case of opening the browser from an intent, may not be loaded by the time the navigation occurs. There is a quick optimization to check if the config would apply to the navigation URL that will fail if this race is lost. Removing this optimization should not change the result of the preview in the case that lite page should not be applied. Bug: 849375 Change-Id: I5fa1c08710f2e60da5e218a02d2ba3849348ed78 Reviewed-on: https://chromium-review.googlesource.com/1086108Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#564307}
-
Shimi Zhang authored
Trying to fix the NPE in PopupTouchHandleDrawable, mWebContents was probably set to null in destroy(), so onDetachedFromWindow() has no mWebContents, we still need to set handles to invisible if not already set. Bug: 847802 Change-Id: Id92e55205e61334ea2ba89132212012602a99343 Reviewed-on: https://chromium-review.googlesource.com/1086295Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#564306}
-
Timothy Loh authored
For Crostini apps, we'd like to replace the ShelfSpinnerItemController with a controller for Crostini apps, instead of first closing the shelf item and then re-opening it. This allows us to avoid having a shelf item appear and then immediately disappear when the VM is already running and launching an app which launches quickly. This CL makes the ShelfSpinnerItemController a ShelfModelObserver so we can observe ShelfItemDelegateChanged and update the shelf icon one more time so it doesn't get stuck with the last state of the spinner. Bug: 836673 Change-Id: Id6c0aa2055e587d6462fabb3432f7c9f5d2ee8e7 Reviewed-on: https://chromium-review.googlesource.com/1065552 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564305}
-
Sadrul Habib Chowdhury authored
Allow requesting presentation-feedback during swap time, so that a SwapPromise can make the request for the presentation time. This is useful for cases for paint-timing, where the client may want to execute some code after presentation, but it also wants to execute the code if swap did not happen. BUG=811961 TBR=haraken@ for trivial changes in content/renderer/gpu and blink. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03a9d72b8d022926db94f143ff9ec774618bdfd4 Reviewed-on: https://chromium-review.googlesource.com/1076324 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#564304}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d86c2be0..3c891581 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7730cd089644031ab14ea2fe587cf37534ae13d5 Reviewed-on: https://chromium-review.googlesource.com/1086137Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#564303}
-
Johnny(Jianning) Ding authored
Bug: 848086 Change-Id: Icf22bbb2f3c82bdcb6ecdadf55967401630fe5fb Reviewed-on: https://chromium-review.googlesource.com/1085896Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johnny Ding <jnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#564302}
-
- 04 Jun, 2018 4 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bf32270..a9d8c29 git log bf32270..a9d8c29 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 sadrul@chromium.org tabs: Update the measurements. 2018-06-04 sadrul@chromium.org tabs: Fix tabs metric. Created with: gclient setdep -r src/third_party/catapult@a9d8c29 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849182,chromium:842732 TBR=sullivan@chromium.org Change-Id: Ia0082975bc8c135e38b8183ca31a22596f2f78b0 Reviewed-on: https://chromium-review.googlesource.com/1086070Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564301}
-
Bugs Nash authored
Updated the pre-existing script that removes invalid flakes from TestExpectations to also remove invalid failures. Added --type flag to choose functionality. In the default case (no flag) both flakes and failures and checked. Options for the flag are {flake,fail,all}. Renamed script to update_expectations to reflect new functionality. Bug: 730704 Change-Id: Iec23363fce7a8f39413a6fe42a1134ea10c614c4 Reviewed-on: https://chromium-review.googlesource.com/863002 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#564300}
-
Matt Mueller authored
Bug: 649026 Change-Id: If023ec28835f1260e0cb21f4545f41e4a4f8ff88 Reviewed-on: https://chromium-review.googlesource.com/1086029 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564299}
-
Joel Einbinder authored
When a fragment is not wrapped in any element, it should be treated as an element or text node and not an attribute value. Change-Id: Ife39f9e66dcfe27931af0f7bffaddd9a09b9bfcc Reviewed-on: https://chromium-review.googlesource.com/1083837 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564298}
-