- 14 Aug, 2019 40 commits
-
-
Evan Shrubsole authored
This is a reland of ae18b126 The problem with the first CL was that calling FakeAudioInputStream::Stop() calls Stop() on the capture thread. Thread::Stop() triggers a join, which blocks. On Mac, the AudioThread is actually the browser UI thread, and this block is not ok. The fix to mitigate this issue is to have the capture thread owned in a std::unique ptr that deletes the capture thread on the AudioManager worker thread. The capture thread will be stopped on the worker thread when it is deleted. Original change's description: > Use REALTIME_AUDIO thread for Fake Input Stream > > Delays were seen when using the Audio Thread, detailed in the attached > bug. The use of the REALTIME_AUDIO priority fixes these delays. > > Bug: 971265 > Change-Id: Ieaf280b966354e3515f038ab81841572e075f0b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655530 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/master@{#670443} Bug: 971265 Change-Id: I6e794042fe040ad87ffe823789666c5a987ce9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702426 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#686796}
-
David Benjamin authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935 and https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4 for the motivation for this change. Using credential_mode makes it harder to forget LOAD_DO_NOT_SEND_AUTH_DATA along with the two cookie flags. This has two implications: - The request will no longer participate in HTTP auth if the server requests it. HTTP auth credentials identify the user, so private requests should not send them. Note this only affects server auth, not proxy auth. Unless the server your feature speaks to requests HTTP auth, this is a no-op. - The request will be pooled with sockets used for uncredentialed requests, rather than credentialed requests. This is not expected to meaningfully change behavior. If your code requires HTTP authentication, let me know. You may need to allow credentials for your request. Bug: 799935 Change-Id: I1a891c8fe5939ad1a4afca4d94d847a0ee90aa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752627 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#686795}
-
arthursonzogni authored
The test: NavigationControllerBrowserTest.VerifyBlockedErrorPageURL_SessionHistory has been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1742152 TBR=zetamoo@chromium.org Bug=990812 Change-Id: I82eb39b789da9bc4e5beeb7e128e19b1a30c8c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752831Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#686794}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a769ca02..17d26c04 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3cab5b43df7507e06878b1334f3e3eba4685ceb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686793}
-
Peng Huang authored
GPU.SharedImage.ContentConsumed is added with https://crrev.com/1720793. This CL adds it in histograms.xml Bug: 985024 Change-Id: I62136cea240eb9e12048f706ea4e73ac647b6476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751762 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686792}
-
Yang Guo authored
Previously, when running DevTools web tests, integration_test_runner.html and its dependencies are loaded via file:// URL. We are planning to migrate DevTools front-end to ES modules, which require the correct MIME type, which resources loaded from the file system do not have. The test runner serves these files at localhost:8000/inspector-sources, which we can use. Change-Id: Idb981e5fb157966e655b4b98eb5365f3c0798d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752830Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#686791}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/06998d54f818..34aac4b486cd git log 06998d54f818..34aac4b486cd --date=short --no-merges --format='%ad %ae %s' 2019-08-14 ilkos@google.com Merge "Support text protos in diff tests" Created with: gclient setdep -r src/third_party/perfetto@34aac4b486cd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: If3e98c002a3737f1c931ae410937ee35cce1c6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686790}
-
Stephen McGruer authored
Previously CSSTransformNonInterpolableValue assumed that anything that was composited on-top of would be single. However that is not true; in the simple case where there is a replace animation before it, the replace effect will be a pair: target.animate({ transform: [ 'scale(1)', 'scale(2)' ] }, 1000); target.animate({ transform: [ 'rotate(0)', 'rotate(90deg)' ] }, { duration: 1000, composite: 'add' }); In the example above, the scale animation would not yet have been reduced to a single interpolated value, so the DCHECK for is_single_ would fail. This CL fixes the logic to perform an interpolation in that case. Bug: 979952 Change-Id: I36a3221c55aa3d98281a21a4ac93d95d61c5a1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750200Reviewed-by:Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#686789}
-
Benoît Lizé authored
This contains a few cleanups: - Use standard include paths in base/android/linker - Add HANDLE_EINTR() around calls to open() - Cleanup in ScopedFileDescriptor This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1730893 without the memfd parts. The memfd part will be relanded separately. Bug: 979638 Change-Id: Id78ba7cf395d92d102f52823bb2f0d1fb91197c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753963Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686788}
-
Nicolás Peña Moreno authored
The test was disabled because it landed too close to the change which changed the startTime to not be 0. After addressing that change, the test now passes. Bug: 987915 Change-Id: Id19623083aa141f7c3b541ad490db6395add6f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753082 Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686787}
-
Thomas Tangl authored
Bug: 966388 Change-Id: I0dcdc6cf24edbf04b98e15c0e0c5aeb20a98b164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754005Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#686786}
-
Hajime Hoshi authored
When resuming a frame from BFcache, V8 hooks for eviction are unset. This unsetting should happen before dispatching events, or the events can call V8 and cause unnecessary eviction. Bug: 980111 Change-Id: I325400fceb247ea391e05f382628ade7f7704b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752276 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#686785}
-
Ian Kilpatrick authored
All of these were unused! Meaning that they probably weren't helpful :). There should be no behaviour change. Change-Id: I805a66dedbe3e9049c9c60a39ca76ad35b4d398c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752692Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686784}
-
Lei Zhang authored
Bug: 794619 Change-Id: I06d4efe9b60911980315662d7c7d99859dceb34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752694 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#686783}
-
Marian Fechete authored
Summary: The animation crashes on the payment section when switching between billing addresses with and without a postcode. When switching the require_billing_postal_code flag to true, and using a profile with a billing address that does not have a postcode, the Payment Request section will show an error message requiring a billing postcode. If users then edit the payment method and choose a billing address with a postcode, the animation of the payment method section causes the app to crash because the error message TextView is also being hidden (using View.GONE). This is an animation rendering bug. Fix: Disable animation on the payment method section for children of the section choice list. The animation is not required and causes the crash. Also setting the text of the error message to empty string when there is no missing information. Bug: b/139265901 Change-Id: I4b81b3dcbc08690a372748f2bb09d74968b33ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753005Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#686782}
-
Vadym Doroshenko authored
Password Manager shouldn't save any sync password. This CL ensures that the sync password wouldn't saved on any google domain. Change-Id: I8418f94bab362a830ed88c1dbdb42ba884fd334c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754002Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#686781}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/753def53ed73..603ccac0c742 Created with: gclient setdep -r src-internal@603ccac0c742 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3413822b068057593e95e2c49578f0441e0d0d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753713Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686780}
-
Stuart Langley authored
Updates the following FileBrowser metrics to expire after M88, which is at the end of 2020. FileBrowser.Recent.LoadArcMedia FileBrowser.Recent.LoadDrive FileBrowser.Recent.LoadCrostini FileBrowser.Recent.LoadDownloads FileBrowser.Recent.LoadTotal FileBrowser.ImportController.DeviceYanked FileBrowser.ImportController.ImportCancelled FileBrowser.MediaImport.ErrorCount FileBrowser.MediaImport.ImportCount FileBrowser.MediaImport.Duplicates FileBrowser.MediaImport.ImportMB FileBrowser.MediaImport.Cancelled FileBrowser.MediaImport.Started FileBrowser.VolumeType FileBrowser.ViewingTaskType.Offline FileBrowser.ViewingTaskType FileBrowser.ViewingRootType.Offline FileBrowser.ViewingFileType FileBrowser.ViewingRootType FileBrowser.ViewingRootType.Online FileBrowser.ViewingTaskType.Online FileBrowser.ViewingFileType.Online FileBrowser.ViewingFileType.Offline FileBrowser.Load.Total FileBrowser.Load.InitDocuments FileBrowser.Load.BackgroundScript FileBrowser.Load.BackgroundRestart FileBrowser.Load FileBrowser.Load.BackgroundLaunch FileBrowser.Load.Script FileBrowser.Load.InitUI FileBrowser.Load.InitBackgroundPage FileBrowser.Load.ImportElements FileBrowser.Load.InitSettings FileBrowser.Location.OnEntrySelected.NonTopLevel FileBrowser.Location.OnEntrySelected.TopLevel Bug: 988749, 988747, 988746, 988745, 988740, 988739 Change-Id: I4311b63957ae05feeb144441d1f89c93eaf926a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747490Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Stuart Langley <slangley@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#686779}
-
Kush Sinha authored
Chrome OS Account Manager is in the middle of a Finch rollout and needs some more time before it can be enabled on ToT by default. Extend it's expiry to M79. Bug: 993317 Change-Id: Ifdf17d627361e50017d04fdbb11d512de9bad6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752784Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#686778}
-
Dominik Röttsches authored
In order to aid fallback font selection, clarify language tags for a set of CJK tests. Tbr: kojii@ Change-Id: I4af0c6c214752444bae390b6176ad3a1ebf20baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753964Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#686777}
-
Javier Ernesto Flores Robles authored
Bug: 991209 Change-Id: I0c0bf7b43280f151c93792aad5d1ed75bfd01fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749012Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#686776}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ca9f410b731..e7c1b99e635b git log 4ca9f410b731..e7c1b99e635b --date=short --no-merges --format='%ad %ae %s' 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-08-14 csmartdalton@google.com Add GrCaps::msaaResolvesAutomatically Created with: gclient setdep -r src/third_party/skia@e7c1b99e635b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: I12a1396562b09fc7d8b003e9619bef0dbf526c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753726Reviewed-by:
-
Tim Volodine authored
Fix a bug in the not-webview-exposed.txt interfaces file (due to crrev.com/c/1743098). This should fix the failures on Android WebView (dbg) L-O bots on the main waterfall (see crbug.com/993411). BUG=993411 TBR=nator@chromium.org,fserb@chromium.org NOTRY=true Change-Id: Ica8c786878f0cb851cee8e5e0e488d41fba671a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754009 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#686774}
-
Eric Willigers authored
gap is <'row-gap'> <'column-gap'>? https://drafts.csswg.org/css-align-3/#propdef-gap If row-gap and column-gap are the same, we serialize only a single value, consistent with Firefox and the shortest representation principle. https://drafts.csswg.org/cssom/#serializing-css-values Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750521 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#686773}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b08436c..a769ca02 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3817423fac11e1d26768540abd0ec02fce2f8bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752887Reviewed-by:
-
Vladislav Kuzkokov authored
Bug: 968109 Change-Id: I64a9667d62d57715895307adff916f82b6e01491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748696Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#686771}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. Bug: 968047 Change-Id: Ica1e3deb905af158c7197221d6a200e892833586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749013 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Hans Wennborg authored
Newer Clang versions warn: ../../chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc:192:24: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror,-Wdangling] ? cert_db->GetPrivateSlot().get() ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc:193:24: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror,-Wdangling] : cert_db->GetPublicSlot().get(); ^~~~~~~~~~~~~~~~~~~~~~~~ Bug: 992458 Change-Id: Id2ed48bd1b201c9b03f69f24781ca9aff62d2c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753825Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#686769}
-
Alexandre Courbot authored
So far, we used the OUTPUT buffer id as the timestamp for referencing a frame. However, this method is flawed: the input buffer can potentially be reused as soon as the driver returns it, meaning the same reference ID can be reused before the driver is done referencing the previously rendered frame. Doing so results in corruption of the following frames. Fix this by using the CAPTURE buffer id instead: since user-space is responsible for not resubmitting frames until the decoder is done referencing them, this method is safe and ensures a timestamp still in use is never re-submitted. Bug: 993695 Test: VDA Thumbnails test passes on Kukui. Change-Id: I977b1f06f34e1cfa18f6209979cda0394c0c5bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752578 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686768}
-
chrome://flagsdalyk authored
If the chrome://flags setting is explicitly enabled or disabled, the corresponding secure DNS mode will be persisted. The new chrome://flags setting will not be visible until a future cl makes it visible for non-enterprise users. Bug: 985589 Change-Id: I7956e32889ad9dccd1630e360210f2e073c726dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639663 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#686767}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4fcb743. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I09fcd3ef8fd14c7c9cf4032c2bb0f66637c0931b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752747Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686766}
-
Rune Lillesveen authored
Bug: 939811 Change-Id: I88cf0869c62193c3e09b328aa0bc2e8b801181e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742150 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#686765}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/906d0eb7a718..753def53ed73 Created with: gclient setdep -r src-internal@753def53ed73 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I627a333a2d8d7198d1ddc3476ca3ea82c5a5b14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753710Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. TBR=jam@chromium.org Bug: 968047 Change-Id: Ic49a963049e5aebb7ef088161a3174cd7c4812d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748950Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686763}
-
François Beaufort authored
Following spec change at https://github.com/w3c/web-nfc/issues/237, this CL allows web developers to distinguish when NFC is not available and when it's disabled by user preference. Bug: 520391 Change-Id: I3927d855edef1b1cf9b2036a0b4991745b962e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751948 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#686762}
-
sreejakshetty@chromium.org authored
-> Introduce PrioritisationType QueueTrait to handles priority decisions. -> Convert VeryHighPriority and BestEffort task queues to use PrioritisationType queue trait and remove standalone functions. -> Update the queue trait |is_high_priority| and add it to PrioritisationType QueueTrait. Bug=978001 Change-Id: Iea7999e8591035dba936b0537aa5a1dc99344c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741908 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#686761}
-
Balazs Engedy authored
This also necessitated: -- Making JavascriptDialogViews a DialogDelegateView that has its |message_box_view_| as a child views instead of delegating to it. -- Promoting CreateFrontElidingTitleLabel from //c/b/ui/views/permission_bubble/ into //c/b/ui/views/. Bug: 987465, 987715 Change-Id: Ic042288dbb7a71c3c2750255ddda8329eea11c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730901 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Dana Fried <dfried@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#686760}
-
Christian Dullweber authored
In order to correctly apply content settings with secondary patterns, CookieSettings needs to know the TopFrameOrigin of a request. Currently it only has access to SiteForCookies, which can be an empty url for cross-origin iframes. This CL passes TopFrameOrigin from UrlRequests to CookieSettings and uses this value to look up ContentSettings. SiteForOrigin is still used to determine whether the cookie is used in a third-party context. As TopFrameOrigin is not yet always available, this new behavior is behind the ImprovedCookieControls flag. Bug: 988398 Change-Id: Ibb6180b68ae9f4780046be6fb2a9dcbb39f9ccf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698419 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#686759}
-
Vadym Doroshenko authored
As a part of username first flow, single username field needs to be filled (i.e. without a password field). This CL implements this on the renderer side. Bug: 959776 Change-Id: I4900bc0d35de0cef0250715ec1981a4a05dd0747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741922 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
MT8183 only supports H.264 decoding, so only add the checksums for this test. Bug: b:123551776 Test: VDA Thumbnails unittest is successful on Kukui. Change-Id: I4985bcb5595a8e863e35ad56c22bd29482c61eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752579 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
