GitLab

Arguably more importantly, make data pipe producers not writable during
two-phase writes and consumers not readable during two-phase reads. This
allows multiple threads to simultaneously use the two-phase APIs in a
sane way; they can respond to a "busy" error by waiting. (Why not
"should wait" instead of "busy"? Because waiting is only an appropriate
response if you know that someone else is going to end the two-phase
read/write -- e.g., if a two-phase read/write is happening on another
thread.)

Also refactor the waiter-awakening stuff so that it's taken care of by
the DataPipe superclass, rather than the LocalDataPipe implementation
subclass.

Note that a two-phase write will only discard if "all-or-none" is
requested. Otherwise, as usual, it'll provide as much space as
available.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/129163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243920 0039d316-1c4b-4281-b951-d872f2087c98

This makes unwind support consistent on Linux (used by
base::debug::StackTrace). A combination of arch-specific toolchain defaults
and arch-specific cflags made the previous behavior inconsistent.

Unwind tables are useful for development and much cheaper than
debuginfo, so enable them for all non-official builds.

TEST=build for ia32, x64, arm (compared defaults & official)
BUG=180975

Review URL: https://codereview.chromium.org/129283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243918 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243917 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243908 0039d316-1c4b-4281-b951-d872f2087c98

- Remove GetNext* methods.
- Add GetAll* methods, returning a vector of Params/Msg pairs.

BUG=

Review URL: https://codereview.chromium.org/127243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243907 0039d316-1c4b-4281-b951-d872f2087c98

> Android: moves jni_generator samples to use long for JNI.
> 
> BUG=317523
> 
> Review URL: https://codereview.chromium.org/131543003

TBR=bulach@chromium.org

Review URL: https://codereview.chromium.org/131913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243905 0039d316-1c4b-4281-b951-d872f2087c98

The video muting test didn't force iSAC correctly. Also added some
lightweight log statements to make it easier to see how far we get when
the test fails.

BUG=332765
TBR=wjia@chromium.org

Review URL: https://codereview.chromium.org/131613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243904 0039d316-1c4b-4281-b951-d872f2087c98

Missed updating the MockSurfaceFactoryOzone implementation in content_unittests
when I modified the GetVSyncProvider function.

TBR=piman@chromium.org
NOTRY=true

BUG=

Review URL: https://codereview.chromium.org/131893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243903 0039d316-1c4b-4281-b951-d872f2087c98

There can be multiple streams calling OnData() when the users setup multiple getUserMedia with WebAudio and microphone. We have no way to avoid this situation since it is a valid user cases from the JS perspective.
But unfortunately webrtc does not support it since it has one global transmit mixer, and it will crash when more than 1 stream getting into its resampler.

This CL introduces a lock to sequence the calls to avoid the racing, which should fix the crash.


BUG=332126
TEST=https://devpool-13.talkgadget.google.com/hangouts, go to setting page and play the rington, verify no crash and sound good.
Or go to https://x20web.corp.google.com/~xians/multiple_sources.html, start the call, AddWebAUdio, then Playout a clip, verify the audio sounds good and no crash.

Review URL: https://codereview.chromium.org/131213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243902 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/120693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243900 0039d316-1c4b-4281-b951-d872f2087c98

We need to initialize ResourceBundle otherwise we can't call
views::CreateDesktopScreen().

We will also need a gfx::Screen, otherwise we won't have any surface to
show any thing.

BUG=119759,139313,141187
TEST=views_examples_exe runs and does not crash.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/108513015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243896 0039d316-1c4b-4281-b951-d872f2087c98

gfx::PutARGBImage already has code for doing the conversion, so use that.

BUG=332026

Review URL: https://codereview.chromium.org/130773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243895 0039d316-1c4b-4281-b951-d872f2087c98

for using the class in other platforms outside Chrome OS.

BUG=312566

Review URL: https://codereview.chromium.org/130753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243894 0039d316-1c4b-4281-b951-d872f2087c98

Use this pattern to replace existing methods in BrowserPluginGuestManager. This CL is just a refactor, there is no change in functionality.

BUG=330843

Review URL: https://codereview.chromium.org/128563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243893 0039d316-1c4b-4281-b951-d872f2087c98

As described in the bug, on some pages we observe a chain of redirections between the sign-in and the final landing form, during which the "save password" infobar is prematurely destroyed.

This CL overrides the ShouldExpire method for "save password" infobars to survive page transitions which are redirects.

BUG=26186

Review URL: https://codereview.chromium.org/127973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=run ./out/Default/gn, it should reporte the elapsed time without no
regressions.
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/124803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243888 0039d316-1c4b-4281-b951-d872f2087c98

This is only fixing packaged apps, the bug is not affecting hosted apps.

BUG=314803

Review URL: https://codereview.chromium.org/123733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243887 0039d316-1c4b-4281-b951-d872f2087c98

It does not build entirely yet, but get us closer.

../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:
In constructor 'WebCore::OriginAccessEntry::OriginAccessEntry(const
                WTF::String&, const WTF::String&,
                WebCore::OriginAccessEntry::SubdomainSetting,
                WebCore::OriginAccessEntry::IPAddressSetting)':
../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86:
error: no matching function for call to
'blink::WebPublicSuffixList::getPublicSuffixLength(WTF::String&)'
../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86:
note: candidate is:
../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20:
note: virtual size_t
blink::WebPublicSuffixList::getPublicSuffixLength(const
                blink::WebString&)
../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20:
note:   no known conversion for argument 1 from 'WTF::String' to 'const
blink::WebString&'

BUG=328717
TEST=gn, ninja -C out/Default blink_platform
R=brettw@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/119723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243886 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243883 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/131433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243882 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes fullPaths from the file views, by using the volume manager and the getLocationInfo() method instead.

BUG=320967
TEST=Tested manually.

Review URL: https://codereview.chromium.org/130533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243881 0039d316-1c4b-4281-b951-d872f2087c98

code base.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/130003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332301

Review URL: https://codereview.chromium.org/129723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243879 0039d316-1c4b-4281-b951-d872f2087c98

The actual command-line switch was renamed to this in SVN 230100. This
just fixes about:flags so it shows the correct name.

BUG=332323

Review URL: https://codereview.chromium.org/129703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243878 0039d316-1c4b-4281-b951-d872f2087c98

which is extremely slow.

BUG=248032
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/129603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243877 0039d316-1c4b-4281-b951-d872f2087c98

The code is dead and we have no plan to implement RTP recording in the near term.
So removing to avoid confusion.

BUG=

Review URL: https://codereview.chromium.org/129533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243876 0039d316-1c4b-4281-b951-d872f2087c98

in the lock rank checking code in PRRWLock.

Remove the suppression for the memory leak in _PR_SET_THREAD_RWLOCK_RANK.

R=agl@chromium.org,thestig@chromium.org
BUG=124445,331625
TEST=none

Review URL: https://codereview.chromium.org/129413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243875 0039d316-1c4b-4281-b951-d872f2087c98

Change Browser so that entering a with block calls Start(). This better matches the already existing behavior where exiting a with block calls Close().


BUG=None.
TEST=tools/telemetry/examples/list_available_browsers; tools/telemetry/examples/telemetry_perf_test.py --browser=system; tools/perf/run_benchmark tab_switching.top_10; tools/perf/run_tests; tools/telemetry/run_tests

Review URL: https://codereview.chromium.org/128653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243874 0039d316-1c4b-4281-b951-d872f2087c98

Previously the logic of progress center is implemented in ProgressCenter.  But
the logic does not follow the item's animation states so another logic is needed
in the ProgressCenterItemPanel and it is getting more complex.

This CL adds ProgressCenterItemGroup to manage the states of items. This class
responsible for creating the summarized item for the close view of progress
center and controling life time error items.

This CL also adds the test of the group. 
It does not start to use the group actually.

BUG=315438
TEST=file_browser_jstest

Review URL: https://codereview.chromium.org/127763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243873 0039d316-1c4b-4281-b951-d872f2087c98

This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
instead of TokenWebData::FromBrowserContext.

This CL is an unchanged reland of https://codereview.chromium.org/109783003/,
which had been speculatively reverted to see if it was causing ChromeOS build
failures. The speculative revert unfortunately stuck as it happened to land in
the same run as the CL that actually fixed the (unrelated) ChromeOS build
failures: https://codereview.chromium.org/129343003/.

BUG=332107
TBR=noamsml

Review URL: https://codereview.chromium.org/130813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243872 0039d316-1c4b-4281-b951-d872f2087c98

So that we can rely on IPC_MESSAGE_CLASS(msg) check to
determine which messages we want to relay onto another thread.

Mostly just shuffling,
- Separated EmbeddedWorker messages out of service_worker_messages.h into embedded_worker_messages.h
- Added a new message class for that
- Created a new directory content/common/service_worker (and OWNERS file) as now we have multiple header files for SW under common/

BUG=313530

Review URL: https://codereview.chromium.org/127583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332414

This reverts commit d3beaabc.

NOTRY=true

Review URL: https://codereview.chromium.org/128433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243869 0039d316-1c4b-4281-b951-d872f2087c98

This pulls Android-specific targets out of remoting.gyp into a new
gypi file.

Review URL: https://codereview.chromium.org/129943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243868 0039d316-1c4b-4281-b951-d872f2087c98

r243376 Add icu.isolate
r243425 Fix icu link warning on Windows

TBR=jshin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/128403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243867 0039d316-1c4b-4281-b951-d872f2087c98

Their visibility was controlled separately but r242610 changed
this.

This is intentionally false instead of is_auxiliary_text_visible()
of candidate_window_ because that field is not updated at that point.

BUG=332275
R=hsumita@chromium.org, komatsu@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/128863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243866 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the debug info is assumed to include only layout rects.
This is a bummer. This CL allows for blink to return an arbitrary JSON
object that will simply be merged into the base::DictionaryValue
we populate for about::tracing. This will allow us to return
arbitrary debug info for tracing from blink.

BUG=None

Review URL: https://codereview.chromium.org/128303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243865 0039d316-1c4b-4281-b951-d872f2087c98