- 05 Dec, 2017 40 commits
-
-
Erik Luo authored
Rendering console logs with lots of text can stall DevTools. In this CL, very long text will get truncated. A 'Show N more' button reveals the full text and a 'Copy' button copies the full text to clipboard. Screenshot: https://imgur.com/a/0dHJI Bug: 658525 Change-Id: Ic27e4836b8aaf9069f7ff0643b39ded4a83ce91f Reviewed-on: https://chromium-review.googlesource.com/597012 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521869}
-
Justin Novosad authored
This change makes it possible to decouple the actions of capturing an animation frame from a canvas and sending it to the compositor. This is a prerequisite for mergin OffscreenCanvasResourceProdiver with CanvasResourceProvider. Bug: 788439, 776801 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iaf4563069ede53b1bba8bde5ea8b693d4c1a2b73 Reviewed-on: https://chromium-review.googlesource.com/803945 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521868}
-
Ran Ji authored
Replace "WebApk.Permission.ChromePermissionDenied" UMA by "WebApk.Permission.ChromePermissionDenied2" It previously logs all Chrome permission denied. Fix to only include WebApk. Bug: 780934 Change-Id: I32e2d9009423365e1f10ae68dc53ff870e52ea06 Reviewed-on: https://chromium-review.googlesource.com/797431Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521867}
-
Hongchan Choi authored
AudioContextTest.cpp tests the audio latency and is not involved any AudioWorklet operation. Removing AudioWorkletThread addresses the data race found in the bug. Locally confirmed that TSAN with this patch does not crash with the data race any more. Bug: 792140 Change-Id: I297533a176c42fb1af5025fdcd77a1cf4e68ee56 Reviewed-on: https://chromium-review.googlesource.com/809825Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521866}
-
Dmitry Skiba authored
On low-end Android devices in-proc GPU is started on demand, when CompositorImpl::SetVisible(true) is called for the first time. Due to the fact that native / Java messages on Android are not strictly ordered (see crbug.com/788008) sometimes GPU startup is delayed for too long, stalling the renderer (see the bug). We already have code to start GPU early (from BrowserThreadsStarted), but that code includes explicit !UsingInProcessGpu() check. However, the check (which was there from 2012), seems obsolete now. As sievers@ and boliu@ discussed in crbug.com/450396#c4 the check was there to avoid a race setting ChildProcess::current, but became obsolete once ChildProcess::current switched to TLS. This CL removes !UsingInProcessGpu() check, causing in-proc GPU to start early. Bug: 787647 Change-Id: Ifb6764e8b479003412674ce667dd6c3ea08dcb43 Reviewed-on: https://chromium-review.googlesource.com/804144Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#521865}
-
Xiaocheng Hu authored
This is a reland of e62d46f6 The original change was reverted due to failures in the new unit tests, which assume box fragment creation for inline elements <b>, <i> or <u>, which however is not true. This reland ensures box fragment creation by adding border to those elements. Original change's description: > [LayoutNG] Introduce NGInlineFragmentTraversal in place of NGInlineFragmentIterator > > This patch introduces a utility class NGInlineFragmentTraversal, so that we can > conveniently retrieve: > - ancestors of a given physical fragment in a container > - descendants of a given physical fragment > - physical fragments in a container with the given layout object > > The utility class supersedes the existing NGInlineFragmentIterator class. Follow > up patches will convert clients of NGInlineFragmentIterator to use the traversal > class instead. > > Bug: 636993 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I7f3f553df18291df50f60075ab84294dd394d86c > Reviewed-on: https://chromium-review.googlesource.com/807758 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521758} Tbr: eae@chromium.org, kojii@chromium.org, yoichio@chromium.org, yosin@chromium.org Bug: 636993 Change-Id: I616a89ac0ca1360681e47bbc45317ffca5d99d90 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/809302Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521864}
-
Manuel Rego Casasnovas authored
This patch makes that when you select empty lines on a contenteditable element, the selection is painted similar to what happens on a textarea. There are 2 changes to make this happen. On one side, newlines are no longer marked as InlineBox::KnownToHaveNoOverflow(). On the other side, InlineFlowBox::ComputeOverflow() has been modified in order to extend the overflow rect for newlines. With this the behavior of selection in contenteditable elements and textareas is more consistent. BUG=789508 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I55f33e8c688a92e760e3d359c2cf54deacd005af Reviewed-on: https://chromium-review.googlesource.com/793036Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#521863}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b88605f7..7af7216b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If31e6aa7c3984e6be8324f3101055e00206f1958 Reviewed-on: https://chromium-review.googlesource.com/809193Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521862}
-
Daniel Park authored
Records infobar displayed when a survey is accepted. Calls closeInfoBar instead of onCloseButtonClicked when accepting a survey to prevent logging the new action. Bug: 791752 Change-Id: I488720882832ee20946cc1a56937d234c4cce620 Reviewed-on: https://chromium-review.googlesource.com/806367Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#521861}
-
Gregory Chatzinoff authored
Update the New Tab Bubble Promo String to "Add tabs and switch between pages". Bug: 779656 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia42386ecc45e45ccf93105d48ff5bdd898cf4058 Reviewed-on: https://chromium-review.googlesource.com/809844Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521860}
-
Derek Cheng authored
Revert "Reland "Enable video capture service by default on platforms where it is rolling out with M61."" This reverts commit 0fdb7a80. Reason for revert: broke webkit_layout_tests: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/12888 Original change's description: > Reland "Enable video capture service by default on platforms where it is rolling out with M61." > > This is a reland of 1e2e99ef > > The reason for the revert was a Webkit layout test failing with this CL. With > https://chromium-review.googlesource.com/c/chromium/src/+/806442 landed to fix that test, > this CL should now be able to reland without modification. > > Original change's description: > > Enable video capture service by default on platforms where it is rolling > > out with M61. > > > > Bug: 721812 > > Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd > > Reviewed-on: https://chromium-review.googlesource.com/719416 > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#517761} > > TBR=emircan@chromium.org > > Bug: 721812 > Change-Id: If69cdb660b0b97a28084b6bd0610234d5abb232f > Reviewed-on: https://chromium-review.googlesource.com/809530 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521800} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: Iee20ddb4dabf156cd3709151792cc374b0b50194 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721812 Reviewed-on: https://chromium-review.googlesource.com/809770Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521859}
-
Takumi Fujimoto authored
This is a reland of 52dda118 Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277,777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} Bug: 789277, 777650 Change-Id: I0a2edc4af121fa675548f9d545bb6048b05e2f13 Reviewed-on: https://chromium-review.googlesource.com/809333Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#521858}
-
Yuke Liao authored
This CL adds support to filter code coverage results by list of directories or files so that the script can run faster without having to generate a report for every executed file. Bug: 789691 Change-Id: I2e954872b7f1113cd04b8e609ffdabf0578db762 Reviewed-on: https://chromium-review.googlesource.com/809295 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521857}
-
Wez authored
Previously the targets to be compiled (but not run) were specified explicitly, effectively duplicating the logic already present in the GN build configuration files. Bug: 707031 Change-Id: I8c6715f9f862a04a49c81030ba9d0212f0468ec9 Reviewed-on: https://chromium-review.googlesource.com/802189 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521856}
-
Jacob Dufault authored
This is more consistent. Bug: 784495 Change-Id: I39bdff1cf126d6d3abf245620ce3c803d382db34 Reviewed-on: https://chromium-review.googlesource.com/806644 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#521855}
-
Steven Bennetts authored
This change requests focusing of the first item after selecting an item. Generally that should focus the newly connecting item as soon as the list is updated. Bug: 739633 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I728658d1bbc916c56793960c576e47fe5bc91354 Reviewed-on: https://chromium-review.googlesource.com/806440Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521854}
-
Steven Holte authored
Bug: 754889 Change-Id: I60bc810728bed4759dac3a406f0eae36a1e11820 Reviewed-on: https://chromium-review.googlesource.com/794491Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#521853}
-
Sky Malice authored
This avoid hitting a DCHECK that was introduced in https://chromiumcodereview.appspot.com/2401083003 where we tried clean up notifications to the model thread about encryption information. By re-using the existing ApplyUpdates methods (and DCHECKs) we now realize that we sometimes call ApplyUpdates before the initial sync is completed. This is probably wrong and definitely, since the initial sync will call ApplyUpdates and pass encryption information. Sending it before that will just be confusing for the proc. Bug: 789950 Change-Id: Ifc2b01efbc71145574f9106c67ce9aebfc8f6b99 Reviewed-on: https://chromium-review.googlesource.com/807664Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#521852}
-
Chris Bentzel authored
Bug: 167187 Change-Id: If36e8f8eb3667a505818edec7cdff3bb36bd8831 Reviewed-on: https://chromium-review.googlesource.com/804663Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#521851}
-
Sergey Ulanov authored
Added kNoClockless flag in the test. This is expected to fix the flake. Bug: 788387 Change-Id: Ife4a443ef30d4f9b656e52ece3c1025cee5c0a96 Reviewed-on: https://chromium-review.googlesource.com/809507 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521850}
-
Wez authored
This requires fixing NativeValueTraitsImplTest.IDLCallbackFunction to use ASSERT_DEATH_IF_SUPPORTED. The conditional handling for Official vs normal builds is also removed, for simplicity. Bug: 779820, 707031 Change-Id: Ib2563d8b6ca792ce916d7be907956d33329e4ba4 Reviewed-on: https://chromium-review.googlesource.com/802355 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521849}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/12ec6760afd9..c45271e053c8 $ git log 12ec6760a..c45271e05 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 thestig Remove redundant field in struct FXCMAP_CMap. 2017-12-05 thestig Fix CXFA_SimpleParser member destruction order. 2017-12-05 thestig Avoid integer overflows in CPDF_FixedMatrix::Transform(). Created with: roll-dep src/third_party/pdfium BUG=791616,791048 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id9a3a2c72218d95099dc5a350d51e2050758e565 Reviewed-on: https://chromium-review.googlesource.com/809312 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521848}
-
Kenneth Russell authored
These machines were moved to the chromium.android waterfall a while back but their JSON entries were forgotten. Remove the definitions of these bots and the test suite exceptions referring to them. (The presubmit checks caught all of the stray exceptions.) Add cast_junit_test_lists to Cast Android (dbg) on chromium.android, which is presuambly where it should have been placed during this migration. BUG=662541 Change-Id: Iaa0453b17e06e31096ecf4e770557ad6aa7d7fd6 Reviewed-on: https://chromium-review.googlesource.com/809633Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521847}
-
Doug Arnett authored
Bug: 792133 Change-Id: Iaa99ae16b359560f60e23c07cace1241781b6bbd Reviewed-on: https://chromium-review.googlesource.com/809296Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#521846}
-
Henrique Nakashima authored
Bug: 768982 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I030f371dcbc1fbef3bcc01ce1daa110cd5b6ad1f Reviewed-on: https://chromium-review.googlesource.com/807144Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521845}
-
Wez authored
This test appears to timeout 100% of the time under Linux, so adding the Timeout expectation to prevent it from causing try-bot failures until the issue is addressed. No-Try: true Bug: 789533 Change-Id: I384d355689004eadcf16d6357ed164fca05760a4 Reviewed-on: https://chromium-review.googlesource.com/809826Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521844}
-
Lukasz Anforowicz authored
Bug: 792162 Change-Id: I9e7fbe7484e914a3af14f808c4a9eb81d2b98228 Reviewed-on: https://chromium-review.googlesource.com/808754Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#521843}
-
Dirk Pranke authored
We are busily converting over the test configs for the waterfalls to the new `generate_buildbot_json` tooling; until everything is converted, and we have docs written for how to use this, we want only a very small number of people making changes to these files. R=kbr@chromium.org, jbudorick@chromium.org BUG=662541 Change-Id: I45432632c914a721fc2704e1b57a02399c624a2f Reviewed-on: https://chromium-review.googlesource.com/809684Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521842}
-
Xi Han authored
In Chrome: - WebAPK's channel is set under "Sites" notification group and "readable origin" as the channel, the same channel as Webapps. - If the device is Android o+, Chrome will set a channel to the notification. In WebAPK: - WebApkServiceImpl#notifyNotification() is deprecated. Chrome calls notifyNotificationWithChannel() instead. - If on Android O+, WebAPK will ensure the notification channel is created if its notifications have a channel id. To test this change, we need to make sure the following cases all work: - New WebAPK, new Chrome; - New WebAPK, old Chrome; - Old WebAPK, new Chrome. Bug: 700228 Change-Id: I176a8d45f021a33ea441837476b1ca09e973a48b Reviewed-on: https://chromium-review.googlesource.com/786300Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521841}
-
Sandra Sun authored
As the first step of ScrollSnapPoints, this patch implements it on main thread at GestureScrollEnd. It introduces necessary data structures: SnapAreaData and SnapContainerData, updates the data after style change and layout, implements a naive algorithm to select snap points at intended-end-position, adds unit-tests for logic and adds sim-tests for behavior. Bug: 778257 Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47 Reviewed-on: https://chromium-review.googlesource.com/756887Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#521840}
-
Mikel Astiz authored
Regression recently introduced in https://chromium-review.googlesource.com/c/chromium/src/+/782563 without apparent failing tests. Bug: Change-Id: I68dfebce4597234d88428bae7a37d10dd99b93d8 Reviewed-on: https://chromium-review.googlesource.com/808928Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521839}
-
Lukasz Anforowicz authored
The CL tweaks StoragePartitonInterceptor (in isolated_origin_browsertest.cc) so that it can be configured to inject different origins, depending on needs of individual tests. This tweak is supported by changes in base/lazy_instance.h (adding of inequality operator implemented on top of the already existing equality operator), and in render_process_host_impl.cc/.h (to support creating a test-only StoragePartitionService via a base::Callback, rather than via a function pointer). Tweaks of StoragePartitonInterceptor allow forking of IsolatedOriginTest.LocalStorageOriginEnforcement test into 2 separate tests: - LocalStorageOriginEnforcement_IsolatedAccessingNonIsolated - LocalStorageOriginEnforcement_NonIsolatedAccessingIsolated The second test is introduced by this CL and was failing before this CL. Tweaks of ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin disallow requests from non-isolated renderers (in which case CheckOriginLock will return NO_LOCK) if the request is for an isolated origin. This makes the new test pass. Bug: 509125, 764958 Change-Id: Ibfff2c91cb2ac51966e1d89295f10592a3814c08 Reviewed-on: https://chromium-review.googlesource.com/775060 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521838}
-
Pavel Feldman authored
DevTools: roll the inspector_protocol to allows crlf in protocol descriptions, update headless generator. Change-Id: I299a8172b86e0b456f12b245077986ae52f4c594 Reviewed-on: https://chromium-review.googlesource.com/807245Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521837}
-
Xi Han authored
Introduce an optional param "raw_manifest_flags" in shell Apk AndroidManifest.xml. It can be filled with: <uses-feature android:name="android.hardware.ram.low" android:required="true" /> if an unbound WebAPK is targeting low ram devices. Bug: 791080 Change-Id: Ie9968ec477a0dbd0694d37aae72f7454fc797ef2 Reviewed-on: https://chromium-review.googlesource.com/809088Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521836}
-
Jayson Adams authored
In RTL mode a tab transitioning from non-pinned to pinned ends up with no visible favicon. This cl fixes this problem, and also uses the correct tab width to calculate the iconview's position in non-pinned RTL mode. Bug: 789347 Change-Id: I972ef71c47811f9b2a5cf6ca2ac5f2c654d0c2bc Reviewed-on: https://chromium-review.googlesource.com/795151Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#521835}
-
Michael van Ouwerkerk authored
In the scenario provided in the bug, the size is initially small like the video popup. All the lifecycle events happen, and then a fresh layout occurs with the full size, making space for the toolbar. Bug: 789958 Change-Id: I528ae2b94f51dd25bc1d259697d35cfc201b6ed7 Reviewed-on: https://chromium-review.googlesource.com/809016Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521834}
-
gogerald authored
IsPossibleNumberImpl is doing exact the same operations as IsPossibleNumberForString Bug: 736387 Change-Id: I093bb9c10befdac73ae67b4a36ad7857e163813e Reviewed-on: https://chromium-review.googlesource.com/809200Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#521833}
-
Herb Derby authored
Change-Id: I8bcc0d0ff3fec11c2e0dd037a65e025e9c40d607 Reviewed-on: https://chromium-review.googlesource.com/809084Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521832}
-
Dan Sanders authored
This CL defines a new interface, VideoFrameReleaser, and adds a channel in MojoVideoDecoder to use it, in a way that can outlive the VideoDecoder. On the renderer side, MojoVideoFrameReleaser is ref counted, and will live as long as there are outstanding VideoFrames. On the gpu side, VideoFrameHandleReleaserImpl maintains a map of outstanding VideoFrames, and will live until the map is empty. The old path, with special methods on mojom::VideoDecoder, is removed. VideoDecoder implementations can now attach regular mailbox release callbacks to their VideoFrames and expect normal results. Bug: 737220, 733828 Change-Id: I3c26e1e98c61f180246815fcc79f6731d8a26ed4 Reviewed-on: https://chromium-review.googlesource.com/762104 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#521831}
-
Owen Min authored
Metrics to count whether the verification request will be sent when profile is loaded. Metrics to count the amount of time from profile loaded to verification finished. Bug: 791171 Change-Id: I693eb5bd2289fc7ba7c295dbd45309d1b04ffe26 Reviewed-on: https://chromium-review.googlesource.com/804754Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521830}
-