- 12 Feb, 2020 40 commits
-
-
Nick Diego Yamane authored
In X11, TouchEvent::PointerDetails initialization involves allocating a tracking_id/slot entry in TouchFactory internal ID map. Such mapping entry must be cleared when the corresponding touch release/cancel event object is destructed. While this is how it has been working in Aura/X11, in Ozone/X11 such cleanup is not done. This issue has been caught while enabling EventsXTest.* unit tests in Ozone/X11, which is part of this change, in order to increase test coverage in ozone/linux events code. This patch fixes it by slightly extending TouchEvent to override its dtor behavior to do what's needed in a simple way that works for both Aura and Ozone X11, taking advantage of the fact that all XEvent-based ui::Events creation code is now unified at x11_event_translation.{h,cc} (after crrev.com/c/2022280). Also this removes one more platform specific #ifdef from event.cc. R=sadrul@chromium.org, spang@chromium.org Bug: 1049460, 700309 Test: ozone_x11_unittests --gtest_filter='EventsXTest.TouchEventNotRemovingFromNativeMapping' Change-Id: I8aec8aceeec14b7024683df55b9befeb3ba639a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040559 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#740859}
-
Yury Semikhatsky authored
Bug: 1051186 Change-Id: Ib5094ad8617940e70dcb61833c64c89faab76002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051176Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#740858}
-
Rayan Kanso authored
Send the image data for the best shortcut icon to the WebAPK server. Duplicates are not sent, and a per-icon limit of 512KB is enforced. Bug: 1045588 Change-Id: I2557584c32dc872013ecf1da3b3beee19047e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047166 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#740857}
-
Tina Wang authored
The official website and posts on the profile card dialog is clickable and navigable. Adding NavigationDelegate interface in c/b/profile_card and implementing it in c/a/profile_card because Tab's dependency. Bug: 1051210 Change-Id: I5443445ac4c1b9b256eb34e9ba05be6dc2447aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047381 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740856}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7875dfced8a..9fed47ecfb6f git log a7875dfced8a..9fed47ecfb6f --date=short --first-parent --format='%ad %ae %s' 2020-02-12 bsheedy@chromium.org Fix getservbyname assumption Created with: gclient setdep -r src/third_party/catapult@9fed47ecfb6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:869557 Tbr: oysteine@google.com Change-Id: Ibeb86ecaa619e71de0b09e2515eacce334ebaee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052393Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740855}
-
Mike Wittman authored
Provides the ability to apply sample metadata to a range of already collected samples, in addition to applying it as samples are collected. This functionality will be used in a following CL to support applying samples retrospectively based on a time window. Bug: 1034758 Change-Id: Ibae88ba4f0a2bfb42a75360857ae0acbfde003e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018447 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#740854}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d5a2a597ceb4..ac4e1d236088 git log d5a2a597ceb4..ac4e1d236088 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 gmouse@google.com Add missed symbol __aeabi_idivmod for Android. Created with: gclient setdep -r src/third_party/swiftshader@ac4e1d236088 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia7113b01a9e83f9cbfd6aa4d09594d317a5a1207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052199Reviewed-by:
-
Brandon Wylie authored
TBR=yusufo@chromium.org Bug: 1051643 Change-Id: I5b13126fd7e1d65198d66f8d0dd35c0a3f7751a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050755Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740852}
-
En-Shuo Hsu authored
This event and corresponding interface will be used to support battery indicator for headphone supporting Hands-Free Profile (HFP). Design doc: go/cros-bt-bi-hfp BUG=chromium:785758,b:140783217 TEST=build chrome and run chromeos_unittests Change-Id: Ieda4b83f4aa86f21038e7e6a9e9e5aa2b58cba0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041970 Auto-Submit: En-Shuo Hsu <enshuo@chromium.org> Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740851}
-
David Grogan authored
Sufficient refactoring has been done that FlexLayoutAlgorithm exists at the time of the call and we can use its method. Bug: 845235 Change-Id: I1d81924bdaad97ab6d176862ff21c6841b246987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050738 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740850}
-
Sammie Quon authored
Avoids a lot of repaints on the bluetooth feature pod button. Test: manual Fixed: 1049865 Change-Id: I5452809921913d1bce460cc90d6c0819ba9aad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049830 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#740849}
-
Karan Bhatia authored
Currently as part of AhoCorasickNode, we store pointers to other nodes as part of the edge map and failure and output links. On a 64 bit machine, the size of a pointer would be 8 bytes, so replacing it with a 4 byte array index yields decreased memory usage. However doing this also has a drawback. Since we store array indices in an uint32_t, the maximum size of the trie would be limitied by the maximum possible value that an uint32_t can store as opposed to vector<AhoCorasickNode>::max_size(). Also, the current implementation of GetTreeSize ignores any possible overflow in computing the tree size, which can lead to a DCHECK failures as well as incorrect results (It's not clear if it can lead to invalid memory access). Change it to explicitly crash if the computed tree size overflows and can't be stored in an uint32_t. On my local machine, this reduces the amount of memory for the SubstringSetMatcher perf test from ~33 Mb to ~25 Mb. BUG=974391 Change-Id: Ib2541b514b8993e414891b1f678e590f6292dc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050099 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#740848}
-
Hiroshige Hayashizaki authored
Reflects https://github.com/WICG/import-maps/pull/205. This CL updates tests from #205. To match the behavior with the updated spec, this CL turns non-String values into `null` entries (i.e. make whole resolution fail without further fallback), instead of ignoring such entries. Other aspects were already conformant with the updated spec (i.e. weren't matching with the spec before #205). This CL updates (test-only) import maps serialization code so that it matches with the reference implementation, i.e. dump `null` entries as `null` instead of `[]`. This CL also updates spec comments. Bug: 990561, https://github.com/WICG/import-maps/issues/184 Change-Id: Ifa2d04bf20fcef5575c14d135c328730ea09c454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037012 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#740847}
-
Sergey Ulanov authored
After crrev.com/738096 StopTicking() was setting state to kStarting instead of kStoppped. Fix it. Change-Id: Ic1fab2c0cbfcc6636e20e9adb3bd536065dbf843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051389Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740846}
-
Yue Li authored
Bug: b/146869452 Test: Manual Test Change-Id: I1793ff6d403341f9f93377bb03e2a198dec7f25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050682Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#740845}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4ae4cac..33c3ae2b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I68bffe847a8e009011e04992c429fbcc2e64b5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052523Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740844}
-
David Maunder authored
Bug: 1051421 Change-Id: Ia7221f0b2f2f764ec3c9979223db32898ea9a895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051970Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#740843}
-
Jose Dapena Paz authored
Using std::minmax_element on a WTF::Deque iterator with libstdc++ from GCC 5+ fails to compile: /usr/include/c++/9/bits/stl_algo.h:3334:24: error: no matching function for call to ‘WTF::DequeIterator<int, 0, WTF::PartitionAllocator>::DequeIterator(<brace-enclosed initializer list>)’ 3334 | _ForwardIterator __min{}, __max{}; This is because it will try to create an iterator of the DequeIterator type with no parameters (or with an empty list of initializers), but that constructor is not available. So this changeset adds it. Bug: 957519 Change-Id: I95e54a2fd95b19c0d439e9067105b7e388bdea61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051932Reviewed-by: -
Jose Dapena Paz authored
GCC fails to build as unsanitized_atomic.cc is using a Clang only compiler macro: __has_feature: ../../third_party/blink/renderer/platform/heap/unsanitized_atomic.cc:9:18: error: missing binary operator before token "(" 9 | #if __has_feature(address_sanitizer) | ^ Bug: 819294 Change-Id: Id1ef4972e61d82739b115398458fd238736de4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052106Reviewed-by:Anton Bikineev <bikineev@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#740841}
-
Johannes Kron authored
A coming WebRTC CL, https://webrtc-review.googlesource.com/c/src/+/168190 will make one of the tests to pass, temporarily disable the test to unblock WebRTC CL roll. Test should be reenabled with updated expectations once the WebRTC CL is rolled into Chromium. Bug: webrtc:7061 Change-Id: If334429f2aa0ee34f1a478a7072604081199c4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051107Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#740840}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1de518cc2487..35b70cac5639 git log 1de518cc2487..35b70cac5639 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 vapier@chromium.org cros: switch CrOS programs to python3 Created with: gclient setdep -r src/third_party/depot_tools@35b70cac5639 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:997354 Tbr: agable@chromium.org Change-Id: Iba051239d2b7a07054df855a0089df3f2183cc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052194Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/79f336d0743a..66356c20b819 git log 79f336d0743a..66356c20b819 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 bsalomon@google.com Don't go out of our way to do vector calc in GrTextureEffect 2020-02-12 egdaniel@google.com Remove (mostly) getting swizzle from GrSurfaceProxy. 2020-02-12 bungeman@google.com Replace DM:Error with DM::Result. 2020-02-12 ethannicholas@google.com tranform -> transform Created with: gclient setdep -r src/third_party/skia@66356c20b819 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I0b4276bb026066256c3eb7c335bf28f31983f5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052388Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia6626a1a38122c7c89ebc5cdd6eae46bff3f0118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050733Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#740837}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28b3e362d5ed..97f260fb71e6 Created with: gclient setdep -r src-internal@97f260fb71e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1051183 Tbr: jbudorick@google.com Change-Id: Ic808c5251377530ef640af2edacf8798bef2e912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740836}
-
Lan Wei authored
Right now the chromedriver test testActionsMouseDrag is still flaky after we wait 1 second for the page layout loading, we will wait 1 second after performing the actions to check what has been changed on the page to avoid flakiness. Bug: 1033382 Change-Id: Idc9d88326f253723ad619ae46fb6b7b014ecafe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051576Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#740835}
-
Robert Ma authored
This will be the last roll before we have to rewrite WPTManifest in blinkpy or migrate to wptrunner. --ignore-glob has been upstreamed in https://github.com/web-platform-tests/wpt/pull/20242 so the patch is removed. Change-Id: Id9683a351eb7b465dfebc08aa8ae638f5b791754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050731 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740834}
-
Filip Filmar authored
The old code cleared ICU library internal state between test runs, but not the icu_util internal state. This caused the new ICU configurations never to be loaded, since the default behavior of the loader is to make loads lazy and idempotent. Clearing the internal state of icu_util enabled loading new ICU data in each individual test case. This initialization issue may have contributed to arm64 test failures that mysteriously came and went a few days back, possibly related to test run ordering. Bug: fuchsia:45491, 1047475 Change-Id: Ib9290952ea1955b27c752dcaf78a8a6de7fbf77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042057 Commit-Queue: Filip Filmar <fmil@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#740833}
-
Robert Ma authored
The whole third_party/blink is covered by third_party/blink/.style.yapf, but it also has some third-party dependencies in it. Unfortunately, adding ignore patterns to the top-level .yapfignore seems to be the easiest way to skip these directories. Bug: 846432 Change-Id: I02428d30697745fa1424be4faa147a687554bc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052547Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#740832}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I595ed36bbcd53977f750883f4d8322486cffcfaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051772Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740831}
-
Piotr Bialecki authored
Updates the Anchors API to align with changes proposed in the immersive-web CG repository: https://github.com/immersive-web/anchors/pull/29 Change-Id: I1ebc332c1f4b00c8912bf132f924ffa3f383dfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051394Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#740830}
-
Yusuf Sengul authored
Bug: 1048927 Change-Id: I03aa5f9db7b09278581989f53cecb79bd9bac07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036487 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#740829}
-
Sajjad Mirza authored
Bug: 1049421 Change-Id: I3cdcac516547d7e81d30aeb05e280d708d063255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040313 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740828}
-
Danyao Wang authored
PaymentApp::IsValidForCanMakePayment() is only used to compute hasEnrolledInstrument(). Update this name to HasEnrolledInstrument() to more accurately reflect the behavior. Bug: 915907 Change-Id: Ib6281ef0856f1acc6a8d67bbc8ff7b06a69a8684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052190 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740827}
-
Tina Wang authored
Add the component to build file and fix the importing and depending errors that occurred. Remove the inheritance of the TextBubble since we are no longer using a pop-up dialog as a profile card container. Bug: 1051208, 1051537 Change-Id: I23b71bc4f2f5d2fd9e8034cd0d35a1e4da2c6d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047460 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#740826}
-
Tricia Crichton authored
ChromeDriver does not check the status after calling GET_SIZE, this can lead to a crash if the page is modified during the command execution. Bug: chromedriver:3240 Change-Id: I083503fa32e659512e460209d006609b5e4048af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051736Reviewed-by:
-
Xianzhu Wang authored
Previously if a filter has empty content, the bounds of the SaveLayerOp was left unset, causing bad performance in pdf renderer. Now set the bounds to an empty rect. Bug: 918240, 1050694 Change-Id: I7d39336c9525a32af88dac29dc2eb0dc38cd067f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047380Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740824}
-
Becca Hughes authored
Make data table generic so we can reuse it and then adds a playbacks tab. BUG=1024353 Change-Id: I19acb277bb874576e39951d8dda567c2c7e29484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048288Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#740823}
-
Sammie Quon authored
Applies the following to a bunch of buttons: - Change texture ink drop highlight to use solid color layer - Remove masks and use api which takes advantage of clipping Applies to all cros buttons except the ones in: ash/system as those have quite a bit of customization. Test: manual Bug: 1042303 Change-Id: Ibdbf334a397f1b91d5e867ab5d2ca4e96780deb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048040 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#740822}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d9bd62fafb66..0844b9a3b625 git log d9bd62fafb66..0844b9a3b625 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 thestig@chromium.org Prevent destruction of CXFA_FFWidget across FWL events. 2020-02-12 tsepez@chromium.org Add test case for PDF password annotations 2020-02-12 aadhir@microsoft.com Sending focused annotation update to the host Created with: gclient setdep -r src/third_party/pdfium@0844b9a3b625 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003501,chromium:1039629,chromium:989027 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I769609126ada35d6238d4f6d756ea4b5a126c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052095Reviewed-by:
-
Rayan Kanso authored
Bug: 1051209 Change-Id: Id6b15f35f6db717162beb601147bbcf3f5ff35b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051104Reviewed-by:
-
