- 16 May, 2018 40 commits
-
-
Christos Froussios authored
Our current matchers fail the test if they don't match. This is against the formal definition of matchers, which are supposed to be side-effect- free. It also prevents us form setting multiple expectations per test, which will be needed for crbug.com/840384. I've refactored the matchers to not fail the test. I've also split the matchers and added matching result messages, to keep the explanatory value of error messages. Bug: 840384 Change-Id: Ie96af6230e9c165b2ce21d1d6930f3a0b3f3b68b Reviewed-on: https://chromium-review.googlesource.com/1055393 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#559091}
-
Kevin Bailey authored
We were adding padding both in the call to, and within the Omnibox tab switch button class. This CL moves all the padding to the class, which removes the need for the constant in the parent class, Omnibox result view. Bug: 780835 Change-Id: I1c5255752625b08904c356369989073063a3e904 Reviewed-on: https://chromium-review.googlesource.com/1059706Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559090}
-
John Abd-El-Malek authored
The problem, while not specific to these tests, manifested in the download tests sometimes hanging. The cause was that the initial reading of DNS configuration was cancelling in-progress host resolver queries. This showed up in these particular tests because they loaded requests immediately (e.g. without going through the renderer) on startup and were using the (mock) host resolver. Other tests usually spin up a renderer, which would delay requests through the network and this bug would be masked. This was solved previously for Android in http://crbug.com/470897. This change fixes it for all platforms. It also simplifies the previous fix, since later in r391799 the code stopped using time comparisons and just used a boolean to store whether it was the first dns setting or not. Bug: 841557, 470897 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3b0a081098a3e3400881c88e64a7f2ce2797f728 Reviewed-on: https://chromium-review.googlesource.com/1055111Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#559089}
-
Mike Klein authored
This lets us set Chromium-specific defines and cflags directly, as an alternative to the injected chromium_specific_config_for_skcms. (We'd rather skcms not have to think about Chromium if possible.) Change-Id: I9e13df7b5210645b2a77a0f2157b2cbe654f11ea Reviewed-on: https://chromium-review.googlesource.com/1059450Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#559088}
-
Rayan Kanso authored
Bug: 843545 Change-Id: I744c4d15cf9a44846342b9ec23d3406937ebb973 Reviewed-on: https://chromium-review.googlesource.com/1061695Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559087}
-
Max Morin authored
There lines were accidentally readded after being removed, so re-remove them. Change-Id: I2ec3ab7114afd1a563cc5cf43e4611ddb55f01ca Reviewed-on: https://chromium-review.googlesource.com/1061462Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#559086}
-
Quinten Yearsley authored
Bug: 731983 Change-Id: Ic40dc83011157ea7f6d23d7be52c2b8571074334 Reviewed-on: https://chromium-review.googlesource.com/1058310Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#559085}
-
Luke Zielinski authored
We now wait until both cache and redirect collection completes. This fixes an issue where duplicate resource IDs could appear in the report because trimming removed elements and then redirects URLs would overlap with IDs that were not trimmed. Change-Id: I788c515b45f0bb5949d52040c82cd57ee134cc19 Reviewed-on: https://chromium-review.googlesource.com/1060157Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559084}
-
Thomas Tangl authored
When unified-consent is enabled, the syncSetup page title is now "Sync and personalization". Bug: 836034 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6832f4c64f6b30bd17e271cffa35cf85785a3076 Reviewed-on: https://chromium-review.googlesource.com/1027837 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559083}
-
Mathieu Perreault authored
Cleaning up a Feature which has been launched for some time now. Bug: 841772 Test: existing Change-Id: I1edd1bf91d31f89021530f0b70adafb6081e17e2 Reviewed-on: https://chromium-review.googlesource.com/1061477Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559082}
-
Kush Sinha authored
Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I7c32e459c310741fdfb830acfededbda832f5506 Reviewed-on: https://chromium-review.googlesource.com/1057622Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#559081}
-
Noel Gordon authored
Remove FileManagerBrowserTestWithLegacyEventDispatch [1], and re-group the tabindex tests into one test fixture. The old fixtures go away and the Flakiness Dashboard will no longer get data from them. [1] FileManagerBrowserTest handles legacy event dispatch for any tests that contain "tabindex", see ShouldEnableLegacyEventDispatch. Mash: remove old TabIndex test exclusions from the Mash bot filter and add exclusion for the new TabIndex/FileManagerBrowserTest. Bug: 843030 Change-Id: I5aa45996ede4eccdc39ec2ba04d945e7b7f5032f Reviewed-on: https://chromium-review.googlesource.com/1061133 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559080}
-
Fady Samuel authored
Bug: none Change-Id: I5dc0b8be17f8d88fb4650c1c564d7f295dc5c1fe Reviewed-on: https://chromium-review.googlesource.com/1061575Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559079}
-
Fady Samuel authored
We need to always update DelegatedFrameHost and call RenderWidgetHostImpl::SynchronizeVisualProperties when we receive a viz::LocalSurfaceId from the child renderer as auto-resize is no longer the only case for child allocated LocalSurfaceIds. Change-Id: I9fcd6b9b6fe2efcaf8bfb2c9eda988fb9f8cc67c Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1058445Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559078}
-
Max Morin authored
Bug: 843103 Change-Id: I1040b014620079865b1141c52ac8ec90fec26ab7 Reviewed-on: https://chromium-review.googlesource.com/1061293Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559077}
-
Emily Hanley authored
Bug: 840427 Change-Id: I44364a9c3954b14118c77c51cfd454be3919c1f2 Reviewed-on: https://chromium-review.googlesource.com/1055776Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559076}
-
danakj authored
This makes every method in WebLayer match the method name in cc::Layer, with exception of the constructor and the CcLayer() unwrapping methods. It also includes web_layer.h instead of forward delcaring it everywhere so when we change it to an alias, these files will know that, instead of having to change them all to also alias. We'll later change them back to cc::Layer forward declarations. R=pdr@chromium.org TBR=piman, dalecurtis Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0b353da350326d57aeac03191dc88a775442d47f Reviewed-on: https://chromium-review.googlesource.com/1056067 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559075}
-
Justin Cohen authored
This reverts commit 8326d5f3. Reason for revert: Tests are still failing after this rolled in. Original change's description: > [ios] Revert smarter CellWithMatcher change for pre-Refresh > > Speculative fix for pre-Refresh content test failures. > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I743bb7e99a702ea300f0505d6d64a87b906db383 > Reviewed-on: https://chromium-review.googlesource.com/1057460 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558308} TBR=justincohen@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idbbbb285dd8e53e3984b2314cb03775b872c25b6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1060173Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559074}
-
Christian Dullweber authored
All cookie and localstorage tests for BrowsingDataRemover have been moved to StoragePartitionTest in 2013 (https://crrev.com/37843003) and replaced with testing a StoragePartitionMock. This code isn't needed anymore. Change-Id: I7b4278b8a926a2930a69430288c7ab560d162f46 Reviewed-on: https://chromium-review.googlesource.com/1061500Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#559073}
-
W. James MacLean authored
A test that should detect if invoking a tooltip on Android crashes the browser. This test requires that https://chromium-review.googlesource.com/c/chromium/src/+/1057993 is submitted first. Bug: 842410 Change-Id: Ib80b6f76355423b843fbcfa8a51440197b3bc78d Reviewed-on: https://chromium-review.googlesource.com/1059703 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559072}
-
Andrew Grieve authored
Change-Id: Ibf12b63c3651a41e45e80db477bee362b18eb081 Reviewed-on: https://chromium-review.googlesource.com/1060620Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559071}
-
Chris Nardi authored
The upstream version of this test is already imported into Chromium at external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html. Our copy doesn't appear to have diverged from upstream, so remove the outdated duplicate copy of this test. Bug: 723826 Change-Id: I580dbbaa8e88a90b96c5a34eccffa95b62596b21 Reviewed-on: https://chromium-review.googlesource.com/1060283Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559070}
-
Fredrik Söderquist authored
Sink the update of intrinsic_size_ out of the if-else in ComputeIntrinsicSizingInfoForReplacedContent, and then push GetNestedIntrinsicSizingInfo down into subclasses, folding it away to use the "local" constructs of the relevant subclasses. This leaves subclasses to deal with issues such as if whether to apply zoom or not et.c, and will with some additional tweaks allow for more succinct interfaces in the "nested" cases. It also makes LayoutReplaced much simpler. Bug: 722055 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie8493ffa89ffb34d2591d6a7ecdc8ebc20c6264f Reviewed-on: https://chromium-review.googlesource.com/1059776Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#559069}
-
Peter E Conn authored
Bug: 843092 Change-Id: I6e077e6a9db1cc6b36427fdd1238e141c158caeb Reviewed-on: https://chromium-review.googlesource.com/1061314 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559068}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8600ccc2dde..9795ca36af56 $ git log d8600ccc2..9795ca36a --date=short --no-merges --format='%ad %ae %s' 2018-05-16 simonhatch Dashboard - Move logging statement up a bit. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iee1e309d58f9bc821a9f7a7c3f593e10b8a177ea Reviewed-on: https://chromium-review.googlesource.com/1061573Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559067}
-
Chris Harrelson authored
Bug:795549 Change-Id: If7c933158b924800515cd09837ed16537adc8b45 Reviewed-on: https://chromium-review.googlesource.com/1060607 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#559066}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I676ea2ab347f2ff837d5b416ffc2df3a7bff13d4 Reviewed-on: https://chromium-review.googlesource.com/1061237 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559065}
-
David Roger authored
This constant was defined twice: in Profile and in AccountTrackerService. This CL removes the one in Profile and uses the AccountTrackerService one everywhere. TBR=imcheng Change-Id: I094f5e4fb66fb75d7420b664dd13a1d8b98ac0c1 Reviewed-on: https://chromium-review.googlesource.com/1061076 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#559064}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4dc1da47ad18..5f638a1091fb $ git log 4dc1da47a..5f638a109 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 achuith cros_build_lib: Support for stream_log. Created with: roll-dep src/third_party/chromite BUG=chromium:829481 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8fe6389f7a40c78f33c032f752f75b819892d83e Reviewed-on: https://chromium-review.googlesource.com/1061574 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559063}
-
Juan Antonio Navarro Perez authored
Disabling on Android_Go in system_health.memory_mobile. NOTRY=true TBR=nednguyen@google.com Bug: 843547 Change-Id: I5329ffb0dd5605e7c716b8bac290e336b4c6b8a7 Reviewed-on: https://chromium-review.googlesource.com/1061754Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#559062}
-
Jonathan Backer authored
Bug: 829469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idc108797849100053d534c014538b602345f26df Reviewed-on: https://chromium-review.googlesource.com/1060028Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559061}
-
Aldo Culquicondor authored
This UI element is used to build the scrollable overflow menu. Bug: 839488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I930b2b13f61e1533d74df6c5a4aab60089987450 Reviewed-on: https://chromium-review.googlesource.com/1055987Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#559060}
-
Simon authored
Landing this for eakuefner@ since he's OOO this week. This CL switches various small (mostly V8 "press") benchmarks to the histogram pipeline. Bug: 744736 Change-Id: I2391ed93f53bd5471498513c9dc6effa8c25dfba Reviewed-on: https://chromium-review.googlesource.com/1059586 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559059}
-
Lucas Furukawa Gadani authored
This CL removes the typemaps for CacheStorage and converts the browser usage of CacheStorage types to mojo types. Bug: 612287 Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 Reviewed-on: https://chromium-review.googlesource.com/1058334Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559058}
-
Marina Ciocea authored
Reset ref factory in destructor to call ref factory's quit closure before other members get destroyed. Change-Id: Idbb7e22c60c309a2d72aa69af098a33f4b966fe2 Reviewed-on: https://chromium-review.googlesource.com/1060059 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559057}
-
Colin Blundell authored
Sylvain is ramping up to full co-ownership of the Identity Service. Add him as an OWNER now to allow him to make straightforward changes when the two existing OWNERS are both OOO. He will of course defer to the existing OWNERS for complex changes (either making or reviewing) while ramping up. Change-Id: I287b712c402c04dcbf384e3d78b6842f90b3fafc Reviewed-on: https://chromium-review.googlesource.com/1061459Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#559056}
-
Peter E Conn authored
My last attempt at solving this [1] didn't work. I suspect it may be to do with rounding errors, but have no data to back this up. Since the bug is a release block stable, I'll catch the error so we stop crashing. After merging this to branch, I'll commit another change to trunk causing this to throw, but with extra diagnosis information. [1] https://chromium-review.googlesource.com/c/chromium/src/+/908557 Bug: 842897 Change-Id: Iacbb4011cdb0acd92f6c2e0cca3ff5fe8ccc19d1 Reviewed-on: https://chromium-review.googlesource.com/1061313Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#559055}
-
W. James MacLean authored
Tooltips aren't used on Android, and neither are CursorManagers. This CL removes a CursorManager null-dereference in RenderWidgetHostViewChildFrame that occurs on Android. Bug: 842410 Change-Id: I737d7c4ab6a5befda660a9df5598469ac2802fe6 Reviewed-on: https://chromium-review.googlesource.com/1057993Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#559054}
-
Bruno Kim Medeiros Cesar authored
The "usm" service flag is not sent in IdToken. After USM support is launched, we'll want to delete this setting entirely. Bug: 836246 Change-Id: I4981132619ff1bd580bd10a6a47d7aa088394825 Reviewed-on: https://chromium-review.googlesource.com/1059457Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559053}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: Iee4f0a51ee32cc66d4a56620d181d2f090486041 Reviewed-on: https://chromium-review.googlesource.com/1061235Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559052}
-