- 17 Dec, 2019 40 commits
-
-
Fergus Dall authored
memlog_browsertest.cc includes //chrome/common/chrome_switches.h which depends on a generated //chrome/common/buildflags.h, but does not specify this dependency in its BUILD.gn. Because of this, the build will sometimes fail, depending on the order objects are built in. TBR=ajwong@chromium.org TBR=alph@chromium.org TBR=erikchen@chromium.org Bug: 952918 Change-Id: I3d9e80b9e32fe32f008299b047f5ada815d51f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971183Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#725435}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_party/blink/renderer/core/layout only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - CustomScrollbar::CreateCustomScrollbar Bug: 939691 Change-Id: I8d36d02e45569591cf40aaa90b8206090b704b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971032Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#725434}
-
Fergus Dall authored
TBR=layout-dev@chromium.org Bug: 1034839 Change-Id: I4213c437d76e9868f50b1525a6d2ac7b6d1d6456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971176Reviewed-by:
-
Timothy Loh authored
Change-Id: I951eec1d645a17278742386e58a24bd4883daf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971182Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#725432}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I8e40c2f97ac725ff1db8e3ee50e0ca62a3877d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970143 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#725431}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 6606 Change-Id: I023f300ac8055bd5e9c37efbb7a10fef5dcf1f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970071 Commit-Queue: Rob Buis <rbuis@igalia.com> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#725430}
-
Maggie Chen authored
This is ported from V1 for Linux only. Don't crash the GPU processor if Chrome is not on the TTY of our host X11 server. It's expected to be slow. Bug: 949839 Change-Id: I497582c48e8b0d1d9f648ed4abd04882170738d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969775 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#725429}
-
Ted Meyer authored
Change-Id: I8452be4bc6ab0fe28246cd4dd3560491f017dd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971070 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#725428}
-
Kent Tamura authored
This is a reland of 982f6f23 The difference from the original CL: - xml/BUILD.gn: Fix gcc build Original change's description: > xpath_grammar.y: Switch to C++ parser > > We used non-standard alloca() in Bison-generated C parser because the > semantic union object contains raw pointers of Oilpan objects and they > need to be on stack. > > We'd like to avoid non-standard alloca(), and would like to manage > lifetime of union member objects correctly. So, we switch to > Bison-generated C++ parser with 'variant' semantic object. It allocates > the stack of semantic objects in the normal heap, and correctly > construct and destruct each member objects. We can use WTF::String and > blink::Persistent as members without any hacks. > > * rule_bison.py > Replace xpath_grammar_generated.hh with xpath_grammar_generated.h on > preprocessor directives such as #include and #line. > > * xml/BUILD.gn > Move xpath_grammar_generated.* and xpath_parser.cc to a separated > target, and it disables chromium-style clang plugin. > chromium-style plugin produces errors on xpath_grammar_generated.h. > > * xml/xpath_grammar.y > Switch to C++ parser. > Switch to 'variant' from 'union'. > Add missing |$$ = $1|. > Remove unnecessary DeleteString() calls. > > * xml/xpath_parser.cc > Adopt to the Bison-generated C++ parser. > Remove unused |strings_| code. > > * audit_non_blink_usage.py > Allow xpathyy:: namespace in core/xml/. > > > Change-Id: I1b4f3a224dca058bee83518573d1482259f221bf > Bug: 1032320 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961464 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725348} Tbr: dcheng@chromium.org Bug: 1032320 Change-Id: Id0e4983308b78bce1e8ba597460df2fc9d4bc869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971171Reviewed-by:
-
Fergus Dall authored
TBR=xr-dev@chromium.org Bug: 1034841 Change-Id: I2c9f3af01bb2bf7a58710dc25a6cd819cc3a8fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971180Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d78a9b45b9e5..6153165d78f2 git log d78a9b45b9e5..6153165d78f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b1568f29..98b390c9 (401 commits) Created with: gclient setdep -r src/third_party/skia@6153165d78f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ibd1655ceb9228d39f029792bdb0d5ab2a1e0cf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725425}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e45b256a. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 0f40bb89 "Enable the CSS image-orientation always" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1eb01132cd58b23cd8810ecd60fa7e552a1aa450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970147Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725424}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/75d4d0376360..45a70dc772a6 git log 75d4d0376360..45a70dc772a6 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 dberris@chromium.org Always provide an array of result_values Created with: gclient setdep -r src/third_party/catapult@45a70dc772a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034786 Tbr: rmhasan@google.com Change-Id: I5b49451c7352bffa7a6b8f044ca095837111087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971211Reviewed-by:
-
Navid Zolghadr authored
Make NGLayoutResult to use passkey pattern and move the private constructors to public and remove friend keywords. Change-Id: I206aa5889481e05355bf81bc965449294b0de475 Bug: 1030176, 939691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971036Reviewed-by:
-
Jon Mann authored
This is a more robust method of re-applying focus to an iron-list after the underlying data changes. The current method breaks during oobe and updates the list more often than needed. Bug: 1031994, 1032265 Change-Id: Ibc115fa099f80c1da0fd872f00a84472b9ff8c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966581 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#725421}
-
Jon Mann authored
Previously, focus would jump to the first element when the underlying data was updated. Bug: 1030825 Change-Id: I78ae75f3230e3b09c0d286677cbfbbbf6ed8bab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954273 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
-
Ana Salazar authored
Add metrics for hotseat transitions in the in-app shelf, i.e. hiding or extending the hotseat. We only had metrics for transitions from the in-app shelf to the show launcher, so we extended the TransitionAnimationMetricsRocorder to also include the transitions within the in-app shelf as a separate category. Bug: 10221769 Change-Id: Ib55692f412410b59ce9f626ce2424ece003184d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963102Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#725419}
-
Ricky Liang authored
Move switches::kVideoCaptureUseGpuMemoryBuffer from //media/base:base to a simple component //media/capture:capture_switches. The switch is needed by multiple components and //media/base:base causes dependency loop. Bug: 982201 Change-Id: I5351f3e30f6672f53268366e67c640a0e05094f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967094 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#725418}
-
Victor Costan authored
The enum's values are persisted to disk. Make the values explicit, and add a comment warning against deleting / renumbering values. Change-Id: I10761ecd987e23f38302e201ad0345dccb05866e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969246 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#725417}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_party/blink/renderer/modules/webusb only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - USBDevice::Create - USB::Create - USBDevice::Create Bug: 939691 Change-Id: I3a1965c3d108422f1d09a9c5c80e93476e71bad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965746 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#725416}
-
Abhijeet Kandalkar authored
The goal of this CL is to use new downcast helper and remove DEFINE_TYPE_CASTS to adopt new downcast helpers. This CL removes DEFINE_TYPE_CASTS for below element. - ChildNodeList, - ClassCollection, - LiveNodeList, - TagCollection, - TagCollectionNS Bug: 891908 Change-Id: I97faab9ef623ee5bcfff6f39eb70c8ebb048605d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969294Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#725415}
-
Regan Hsu authored
This CL cleans up "settings-localized-link" (formally "localized-string- with-link") a little more, following comments made after the landing of https://chromium-review.googlesource.com/c/chromium/src/+/1941198. Bug: 1015924d Change-Id: Ie1dfb24273fcd32c5386a9710d6d2a6ceb3485bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969773 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#725414}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b119e4e2dca9..75d4d0376360 git log b119e4e2dca9..75d4d0376360 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 dberris@chromium.org Fix run_test data serialization Created with: gclient setdep -r src/third_party/catapult@75d4d0376360 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034786 Tbr: rmhasan@google.com Change-Id: I8cbae3b6d39dcf5c0ca74efe04adb56aca08aefb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970378Reviewed-by:
-
Manu Cornet authored
Change-Id: Ic376b2ad2bf4cb85deaafd2ef7f9b8117caaabf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969281 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
James Cook authored
Child users used to have sync for apps and extensions forced on. This was removed in: https://chromium-review.googlesource.com/c/chromium/src/+/1959795 Remove similar references from the new OS sync settings being built behind the kSplitSettingsSync flag. Bug: 1032047, 1013466 Test: existing browser_tests Change-Id: I5cac6929dc3a0d483cb675531f4a06494eb66a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968971 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/088b831b71b7..f3163cf2ed39 git log 088b831b71b7..f3163cf2ed39 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 thestig@chromium.org Initialize members in the header for CPDF_Object sub-classes. 2019-12-17 thestig@chromium.org Make sure encrypted PDFs save properly when modified. 2019-12-17 thestig@chromium.org Avoid regenerating revision 5 and 6 encryption dictionaries. 2019-12-16 tsepez@chromium.org Break direct dependence between fpdfapi/edit and fxge. 2019-12-16 tsepez@chromium.org CPDF_Document no longer requires fx_font.h. Created with: gclient setdep -r src/third_party/pdfium@f3163cf2ed39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2f6071b52f2af00a41c322ce854c058e44faf577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970640Reviewed-by:
-
Yuzu Saijo authored
This CL removes the ServiceWorkerOnUI dependency from BackForward Cache feature. Bug:1034831 Change-Id: Ic39b1dd317c86b06bfed0ee663b4c76cf9b1bfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969195 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#725409}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Iea137d655e42822b778d95bdd796d6e10394ce39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970263Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725408}
-
Koji Ishii authored
Following bot results are included. 638 640 641 642 644 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I056089ea09e2a2a121887d99cdaf2bfe71435205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969121Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#725407}
-
Jiawei Shao authored
This patch refactors the structures defined in webgpu_cmd_format.cc to make them have the same style as DawnReturnRequestDeviceInfo. This patch also removes all the unused included header files in webgpu_cmd_format.h. BUG=chromium:996713 Change-Id: I888a4a32b7ef515a617d00f7afed0f55f0a980e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967033 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
-
David Grogan authored
Also cache a bit that is recalculated a few times in Layout() -- is_cross_size_definite_ No behavior change intended. Bug: 845235 Change-Id: Id715b3d6903e04b29dace86b5432a29305015fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970070Reviewed-by:
-
Ryan Hamilton authored
QuicStreamFactory to MockCryptoClientStream. This was originally introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1566714 Change-Id: I6c5692b156e784b41d788c967c0ecef44ea99015 Bug: 1034745 Change-Id: I6c5692b156e784b41d788c967c0ecef44ea99015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970586 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#725404}
-
Hirokazu Honda authored
This reverts commit aefeeed1. Reason for revert: the original CL needs to be reverted. CQ should be ready to revert this CL. Original change's description: > Reland "Reland "media: Introduce VideoEncoderInfo"" > > This reverts commit 20420513. > > Reason for revert: Broke the build, see https://ci.chromium.org/p/chromium/builders/ci/GPU%20Win%20x64%20Builder/6779 > > Original change's description: > > Revert "Reland "media: Introduce VideoEncoderInfo"" > > > > This reverts commit ada5790f. > > > > Reason for revert: crbug.com/1034686 > > broke tast.webrtc.DecodePerf.h264_hw > > bisector pointed to it in https://crosperf.googleplex.com/b/c6dec559-71e4-496d-a022-59217f3eaab5 > > > > Bug: 1034686 > > > > Original change's description: > > > Reland "media: Introduce VideoEncoderInfo" > > > > > > This reverts commit 628be97d. > > > > > > Reason for revert: This is not a culprit on crbug.com/1033567 > > > > > > Original change's description: > > > > Revert "media: Introduce VideoEncoderInfo" > > > > > > > > This reverts commit 1b808723. > > > > > > > > Reason for revert: Looks like it broke webrtc.RTCPeerConnectionAccelUsed.(dec|enc)_vp8 tests (see https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome) > > > > > > > > Original change's description: > > > > > media: Introduce VideoEncoderInfo > > > > > > > > > > libwebrtc can know the information about encoders that are not > > > > > contained in the library, by webrtc::EncoderInfo. In the current > > > > > chrome implementation, the structure stops in RtcVideoEncoder and > > > > > thus the filled information doesn't respect the hw encoders. > > > > > > > > > > This Cl introduces VideoEncoderInfo. It is similar to > > > > > webrtc::EncoderInfo. The information is filled in and dealt with > > > > > the structure in chrome code. > > > > > > > > > > Bug: 1031965 > > > > > Test: VaapiVideoEncoder is shown in chrome://webrtc-internals > > > > > Change-Id: I7d2f5b0be6655620baf9007e984fc459287e988a > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949841 > > > > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > > > > Reviewed-by: Dan Sanders <sandersd@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#724174} > > > > > > > > TBR=dalecurtis@chromium.org,sandersd@chromium.org,sprang@chromium.org,hiroh@chromium.org > > > > > > > > Change-Id: I603da2ea22cdf3337adb0cab0d5f98023b2fa1cd > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 1031965 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964271 > > > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > > > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#724191} > > > > > > TBR=dalecurtis@chromium.org,rsorokin@chromium.org,sandersd@chromium.org,sprang@chromium.org,hiroh@chromium.org > > > > > > Change-Id: I30f6d3cfdb061edd4cdd985d65a32c2c4c9304a0 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1031965 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965774 > > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#724413} > > > > TBR=dalecurtis@chromium.org,rsorokin@chromium.org,sandersd@chromium.org,sprang@chromium.org,hiroh@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1031965 > > Change-Id: I27ba45d3c91716ec500fa4e3c1a605cc0cffb248 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971071 > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#725384} > > TBR=dalecurtis@chromium.org,rsorokin@chromium.org,mcasas@chromium.org,sandersd@chromium.org,sprang@chromium.org,hiroh@chromium.org > > Change-Id: If06e7f918670f9f57ac11670da34fe2e5d034648 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1034686, 1031965 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971038 > Reviewed-by: Fergus Dall <sidereal@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#725389} TBR=dalecurtis@chromium.org,rsorokin@chromium.org,mcasas@chromium.org,sandersd@chromium.org,sprang@chromium.org,hiroh@chromium.org,sidereal@google.com Change-Id: Ia511fc5f15fdd9e55afaa8363c8bd6bc5eec020a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034686, 1031965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971045Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#725403}
-
Sajjad Mirza authored
Bug: 1033753 Change-Id: If2b84d6c5708c29ed6b18ef0397b5a93cf04def1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966699 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#725402}
-
Manu Cornet authored
Change-Id: Iaba4924a63e401c8b30f7d1a1afbd1145cd0d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969197Reviewed-by:
-
Ken Rockot authored
Fixed: 1007750 Change-Id: I3d670b6cb5619a89c8ad9b6c37f78d4110a384e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970542Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#725400}
-
Fergus Dall authored
Bug: 1034802 TBR=tbansal@chromium.org TBR=mcrouse@chromium.org Change-Id: Iaf1a11275199ff009605043f3794135c4eb6af4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971035Reviewed-by:
-
Jared Saul authored
Fixed: 1029844 Change-Id: I837685077f5f5781b2290cd63272f3351329fd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967953Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Rakib Hasan authored
This reverts commit 7dc7ddb0. Reason for revert: webrtc.pause_play_peerconnections and webrtc.anvas_capture_peer_connection benchmarks are failing on almost all Android Perf Builders. https://ci.chromium.org/p/chrome/builders/ci/Android%20Nexus5X%20WebView%20Perf/8596 Original change's description: > media/mojo: Enable to pass VideoEncoderInfo via mojo > > crrev.com/c/1949841 introduces VideoEncoderInfo. The info may be > useful for libwebrtc. The goal is to acquire VideoEncoderInfo of > hw encoders running in GPU process. > This CL is the second step, which enables to pass VideoEncoderInfo > via mojo. > > Bug: 1031965 > Test: VaapiVideoEncoder is shown in chrome://webrtc-internals > Change-Id: I2fe4e83888d06c2f49200ddcf4930884e4e499b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959231 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724936} TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031965 Bug: 1034158 Bug: 1034771 Change-Id: I1a57ecba9101812a204aa48115804f7381884555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970915 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#725397}
-
Fergus Dall authored
This reverts commit 004dba18. Reason for revert: Browser tests introduced in this CL fail on linux-chromeos-chrome. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/329 for first failing build. Original change's description: > Add Assistant integration tests using a fake S3 server. > > These tests run as browser tests, use the real libassistant code and use a fake > s3 server to replay previously recorded conversations. > > This allows the Assistant to run CQ tests that verify the basic interactions > are not broken. > > More specifically, this uses a FakeS3Server library that was previously > created by the LibAssistant team. On the ChromeOS side I added hooks to > tell LibAssistant to use the FakeS3Server, and a test-fixture to start/stop > the fake S3 server during the browsertests. > > BUG: b/141264108 > TESTS: in target |browser_tests| with names |AssistantBrowserTest.*| > > Change-Id: I89985c9e34eaa21a17eef69fa5b472fa39486d30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894296 > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#725214} TBR=xiyuan@chromium.org,sammc@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,jeroendh@google.com Change-Id: I2c865a07000513d7f2ed9fe79fb2a19dfaa74e4c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971041Reviewed-by:
-
