- 09 Jun, 2020 40 commits
-
-
Bartek Nowierski authored
Bug: 1086388 Change-Id: Ic73b32ee9b49cbb6fd1901e5340af1ce4274b2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215538 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776502}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0a79bee135cd..83faf15d21b6 2020-06-09 cwallez@chromium.org infra: Migrate builders to Goma RBE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:950413 Tbr: cwallez@google.com Change-Id: Ib5b437a7fc1e4cdc14cfbb3494f3e66681225196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776501}
-
Dave Tapuska authored
In order to move some of the input handling into blink from content we need these additional helper classes inside blink. BUG=1073560 Change-Id: I9cf5bebc0a37d39d93d371d6c97bcccb9d957bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235936Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#776500}
-
Boris Sazonov authored
Extends mobile-identity-consitency flag and updates the list of owners. Bug: None Change-Id: I315eb17cf9a23f11221329e0ec2339b42cb58fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237466 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776499}
-
Monica Basta authored
This CL creates |SigninManager| for desktop platforms. The signin manager will be responsbile for managing the primary account for desktop platforms.This CL also moves all the logic of computing the unconsented primary account to the sign in manager. Bug: 1046746 Change-Id: I8e9e55234e2b5bbc13f0e3d497eaf5389921172d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090428 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#776498}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b137479bdc69..e5fef85222ed 2020-06-09 jacktfranklin@chromium.org Add global TypeScript type support to ts_library 2020-06-09 alexrudenko@chromium.org Ignore internal css keywords If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1092826 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I946a4c7955afa6618dabe555895d640774dc567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237413Reviewed-by:
-
Liviu Tinta authored
Split the test into two subtests. testdriver cannot click on an element in another iframe for Firefox. Remove pointerevent_pointermove_in_pointerlock test from expectation files. Add expectation file for infrastructure testdriver. Bug: 1086154 Change-Id: I3d3cd9c020c9c3d17d53dfa06175e01ea549a740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233579Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776496}
-
Juanmi Huertas authored
Removing as well all the msaa_sample_count infrastructure to remove this flag completely from Chrome. This CL also removes the |resource_dispatcher| parameter from the CanvasResourceProviderSharedImage, as it was not used. Bug: 1078518, 1054797 Change-Id: I32e19323c4f4fe4f8adda662cd656c6e57ed5ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225528Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#776495}
-
Jose Magana authored
Follow adapted version of: crbug/1051776 and https://chromium-review.googlesource.com/c/chromium/src/+/2182702 as migration plan: Step 1: (This CL) - add .gitignore entry for new path - add entry to src/DEPS for MediaApp - point references to app to the new entry Step 2: (CL internal: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3089141) - remove entry for app in src-internal/DEPS Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Bug: 1080473 Change-Id: I942c3f24382b6c1c9ad0688364e932090ea3e5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230559 Auto-Submit: Jose Magana <jomag@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776494}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37e562110fa5..a2e91dbb6195 2020-06-09 tikuta@chromium.org apply yapf for ninjalog*.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:992282 Tbr: agable@chromium.org Change-Id: I1f73ad81bc4c0ab022d1b6e250990bc60c8ce871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237408Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1084759 Change-Id: I14f2a85ee6e880313f74f2933887a5ad54c558da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235872Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#776492}
-
Marc Treib authored
This reverts commit bb3eba33. Reason for revert: New tests are failing on Mac, see e.g.: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/51174 All failing bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests Original change's description: > Add browser test for permission prompt. > > Bug: 1019129 > Change-Id: I08a2c1d038f353b0f84264d0a3ddf26f601347a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214536 > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776457} TBR=bsep@chromium.org,olesiamarukhno@google.com Change-Id: I071939c3e57947489513b14ef49f9ff1037c5617 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235847Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineItemsBuilder| to hold |LayoutBlockFlow| to allow member functions to use |LayoutBlockFlow| during collecting inline items for preparation of the CL[1], e.g. - Use LayutBlockFlow in CollectInlinesInternal() - Use LayutBlockFlow::HasLineIfEmpty() in ExitBlock()[1] [1] http://crrev.com/c/2139612 EditingNG All-In-One Bug: 707656 Change-Id: Ie5a43f97e8ee7f2aa18e7024841fe9f4f48dfe54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237426 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776490}
-
Patrick Noland authored
Failing to do this leaves behind a native observer of bookmark events that can hold onto a profile that subsequently gets deleted. When the observer is triggered, accessing the deleted profile causes a crash. Bug: 1092391 Change-Id: I7864d2c63ae4952aee64cb28574c0404cb868dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236092Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#776489}
-
Side Yilmaz authored
This CL lands fix for wrong usages of profile at PrefetchConfiguration class. Currently, PrefetchConfiguration always consumes regular profile, however the caller classes should pass the current profile (i.e., regular or incognito profile). By this CL; - DownloadSettings always passes regular profile, since settings only runs with regular profile. - Test classes (PrefetchFeedFlowTest and PrefetchConfigurationTest) uses regular profile, since offline pages only available for regular mode, it is sufficient to run tests with regular mode. - PrefetchEnabledSupplier passes the profile key that is hold on instance variable. Bug: 1067314 Change-Id: I2563f9301c8ea9191dbc36b380e96b48142310fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184392 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
-
Stephen Nusko authored
Currently we can flip flop back and forth between TouchMoves being sent async or sync which can cause some pretty noticeable cases of jank. This ensures that we are always consistently scrolling after deciding TouchMoves can be async. Bug: 1072364 Change-Id: I3ef1ed6715d4b1fd2d3e1377ebd6b0c8bcc02872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182426 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776487}
-
Marc Treib authored
According to webkit_lint, "virtual/gpu/"-prefixed expectations are redundant with the non-prefixed versions, so remove them. TBR=juanmihd@chromium.org Bug: 1092835 Change-Id: I2687bd8463870b21be03951b3c55c47f117da7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237141Reviewed-by:
-
Mason Freed authored
Prior to this CL, a "failed" <template shadowroot> element would be left marked as a declarative shadow root, even though it was just an ordinary template. One example of this is: <video> <template shadowroot=open></template> </video> Here, since the video element does not support shadow roots, the template would be left in, but still marked as a declarative shadow root. This would cause problems later if, for example, template.innerHTML was called, because the content property is protected for declarative shadow roots. Additionally, it was previously impossible to access innerHTML on *valid* declarative shadow root <template> elements. Both of these have now been fixed, and tests written. Fixed: 1087457 Change-Id: Ia14c868e9e918e24c756b24ace69b8bb944d0b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236890 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#776485}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3a1df10d3d7..b137479bdc69 2020-06-09 spctstr@gmail.com Fix score function for filenames with dots or whitespaces 2020-06-09 alexrudenko@chromium.org DevTools: fix variable resolution If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084494 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91762a712d668a53f33db168db68156be5a74d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237407Reviewed-by:
-
Marc Treib authored
When the sign-in cookies are cleared, all account storage opt-ins should also be cleared. However, currently this doesn't always work reliably (see crbug.com/1078762). So this CL adds an explicit call to clear the opt-ins to the Clear Browsing Data logic. Bug: 1052005 Change-Id: Ib7fd96cf2de86f3636efa8c1a32061fc31b925c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232346 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#776483}
-
Victor Hugo Vianna Silva authored
This CL uses the new MergeExceptionsStoreCopiesBehavior to display deduplicated exceptions in the new page (exceptions are websites where passwords are never saved). The page now has two new subsections, one for device-only exceptions and one for device-and-account ones, similar to what was done for passwords in crrev.com/c/2228159. We also use the occasion to simplify the code a bit: a) The properties hasDevice*Passwords_ are now just inlined calls of the isNotEmpty_() function. b) Since exceptions and passwords share a common class, the code to filter device-only/device-and-account entries can be shared, cf the getDevice*Entries_() functions. c) Remove unnecessary ids in the HTML file. Screenshot after CL: https://screenshot.googleplex.com/mGDT0DPj3X6 Screenshot before CL: https://screenshot.googleplex.com/Smq5nxgAt07 Bug: 1049141 Change-Id: I27cf33848188801ef2aa3ce1c01ee0e04e105f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236392 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#776482}
-
Finnur Thorarinsson authored
We've already established that external process creation can take a bit of time on Android, as per: https://chromium-review.googlesource.com/c/chromium/src/+/2124377 However, DecoderServiceHostTest also uses the same decoder and should have had a matching increase. This also increases the timeout for waiting for responses from the external process, which hopefully takes care of lingering flakiness in the test, as described in the bug. Bug: 1091852 Change-Id: I015f8fc6764ed3cdd7a308c4eefd3247028ea7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235993Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#776481}
-
Yoshifumi Inoue authored
This patch implements move-caret-to-boundary behavior for hit test to LayoutNG for preparation of enabling EditingNG. Bug: 971414 Change-Id: I3e4b60ced919b5cb383de69736838ce07b5a1627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235133 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776480}
-
Tommi authored
Change-Id: I446fe74fb77875e06a406d3b765818e027d733e5 Bug: 1092787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230494Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776479}
-
Oleg Davydov authored
Policy-based extensions can be normal-installed, when user can disable then and enable back, but may not uninstall these extensions. But on the chrome://extensions page there was a aconfusing "Remove" button for normal-installed extension also, which did nothing. This CL uses more appropriate flag from ExtensionInfo structure to detect whether he "Remove" button should appear or not, therefore for normal-installed extensions this button would not appear anymore. Bug: 1048118 Change-Id: I9fff69b861095962f8cf765bedc525516031c465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219893Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#776478}
-
Wez authored
This reverts commit d6d5f4b8. Reason for revert: Newer SDK appears to still have the pkgfs serve failure issue. Original change's description: > Roll Fuchsia SDK from 0.20200604.3.1 to 0.20200608.3.3 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: I2dae0bc2cc21c19b6aae40ca81301aeec23add66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236327 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#776396} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: Ia7e28c98427e00efd671024db43c468da3614cef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092054 Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235721 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Sreeja Kamishetty authored
This CL adds a new method WebContentsImpl:: RenderFrameHostStateChanged. This is called whenever the RenderFrameHostImpl::LifecycleState changes. One pager doc explaining RenderFrameHostStateChanged usage: https://docs.google.com/document/d/1vH_41CU61disTGWB2aFcP8-weHwfzHjEH7fbqdf3Ff8/edit?usp=sharing This is useful to make sure all the UI elements like popups/dialogs are closed when the RenderFrameHostImpl leave the kActive state. One of the reasons why we want to use RenderFrameHostStateChanged instead of WebContentsObserver::DidFinishNavigation is because a committed navigation changes state of not just the navigating frame but all of its subframes as well. So, determining whether a particular frame's UI element needs to be closed would require listening to DidFinishNavigation in that frame as well as all of its ancestor frames. This CL closes the color chooser popup which rely on a signal coming from the renderer triggered by the document destruction which don't happen in the case of BackForwardCache and would be problematic, instead we close it when the LifecycleState changes from kActive state. Bug: 1073144 Change-Id: I44eab243d5581e6e639406054d79da9efc444b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159444 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776476}
-
Nigel Tao authored
Bug: 1086733 Change-Id: I81b16524a1a38e71c891774814cb668ec265c8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235573Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776475}
-
Anders Hartvoll Ruud authored
Bug: 1091415, 1074052 Change-Id: Ife168acada6aa37502b1bf2ff891700896531610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232341Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#776474}
-
Harald Alvestrand authored
Likely these are bots without H.264 support. No-Try: true Bug: 1092721 Change-Id: Ie0a8e17998217fe8caadc5cd509afb9d15439b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236439 Auto-Submit: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
Koji Ishii authored
The test was using |EndOfReusableItems| to find the first dirty item. However, the function may return earlier items than the first dirty item, because sometiems non-dirty items are not reusable. This patch fixes the test to check |IsDirty| flag instead. Bug: 982194 Change-Id: Ica5ad86af7f2d756bd2f2510e0f074865af7acac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237286 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776472}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibf55c83bbe0968bfe5d09b34a48e460b029fab8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236111Reviewed-by:
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 0044f2fd ("PartitionAlloc reserves address space and AddressPool manages the space"). Bug: 957519 Change-Id: I22d8920883683993befdc38c8924a91db48215fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236434 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Michael Ershov authored
Bug: 1045895 Change-Id: Ib84cc3a4397066ef9c0e1dc204fe2ee27eb6ea2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231118Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#776469}
-
Nigel Tao authored
Bug: 1086733 Change-Id: Id5928c06fa5caa8fe4ddb4a087fdf310056844be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235138Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776468}
-
Joel Hockey authored
Bug: 1057591 Change-Id: Id87a4effa9f19aa9838a315d699ade4cd3e78444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234674 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776467}
-
Ovidio Henriquez authored
This change fixes an issue with the icons that are displayed for chosen object permissions. When the single website settings screen is accessed via the Page Info Site settings button, the icons were not tinted, so they would be inconsistent with the other settings icons. This was especially prevalent using the dark theme as the icons would remain black or grey. Bug: 1081967 Change-Id: Ia164d91c436c33c2cbcc8497d0fcebb3d5dda01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199552 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#776466}
-
Yifan Luo authored
Bug: 1075597 Change-Id: I0b6ef0a751394b307dd09393a972da569fadfa40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213523 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776465}
-
Marc Treib authored
TBR=drott@chromium.org Bug: 1092813 Change-Id: I61acc3136691f7f7cf022b7638d995128be0f651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235823Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec3e870dba2a..d3a1df10d3d7 2020-06-09 alexrudenko@chromium.org Update CDP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:946975 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4cd961d45cf8a9f99b84bc2feb0c7f97df1b8b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237239Reviewed-by:
-
