GitLab

Cr-Commit-Position: refs/heads/master@{#294767}

BUG=
TBR= dpranke@chromium.org

Review URL: https://codereview.chromium.org/572533002

Cr-Commit-Position: refs/heads/master@{#294766}

Revert of Fix some more for= usage. (patchset #7 id:120001 of https://codereview.chromium.org/539383003/)

Reason for revert:
breaks linux_chromeos on try runs here and on buildbot

Original issue's description:
> Fix some more for= usage.
>
> Also fix some controlled settings indicators.
>
> BUG=409938
> R=dbeam@chromium.org
>
> Committed: https://crrev.com/ce80b519af00bb6259e8c63f91fee5263d818124
> Cr-Commit-Position: refs/heads/master@{#294681}

TBR=dbeam@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409938

Review URL: https://codereview.chromium.org/562023003

Cr-Commit-Position: refs/heads/master@{#294765}

This reverts commit 711d923e.

flaky a bunch of times. as an example, see
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/22538/steps/content_browsertests/logs/AccessibilityFrameset
DumpAccessibilityTreeTest.AccessibilityFrameset (run #1):
[ RUN      ] DumpAccessibilityTreeTest.AccessibilityFrameset
Testing: E:\b\build\slave\Win7_Tests__dbg__2_\build\src\content\test\data\accessibility\frameset.html
c:\b\build\slave\win_builder__dbg_\build\src\content\browser\accessibility\dump_accessibility_tree_browsertest.cc(252): error: Value of: is_different
  Actual: true
Expected: false
[3080:2208:0913/171203:4867433:WARNING:channel.cc(211)] WriteMessage() while shutting down
* Line Expected
- ---- --------
     1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
     2     ROLE_SYSTEM_CLIENT FOCUSABLE
     3         IA2_ROLE_SCROLL_PANE
     4             ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
     5                 IA2_ROLE_PARAGRAPH
     6                     ROLE_SYSTEM_STATICTEXT name='My favorite browser is '
     7                     ROLE_SYSTEM_STATICTEXT name='ABC'
     8                     ROLE_SYSTEM_STATICTEXT name='Chrome'
     9                     ROLE_SYSTEM_STATICTEXT name='!'
    10     ROLE_SYSTEM_CLIENT FOCUSABLE
    11         IA2_ROLE_SCROLL_PANE
    12             ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
*   13                 IA2_ROLE_PARAGRAPH
    14                     ROLE_SYSTEM_STATICTEXT name='This test is to check '
    15                     ROLE_SYSTEM_STATICTEXT name='mark tag'
    16                     ROLE_SYSTEM_STATICTEXT name='.'
    17 \u003C-- End-of-file -->

Actual
------
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
    ROLE_SYSTEM_CLIENT FOCUSABLE
        IA2_ROLE_SCROLL_PANE
            ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
                IA2_ROLE_PARAGRAPH
                    ROLE_SYSTEM_STATICTEXT name='My favorite browser is '
                    ROLE_SYSTEM_STATICTEXT name='ABC'
                    ROLE_SYSTEM_STATICTEXT name='Chrome'
                    ROLE_SYSTEM_STATICTEXT name='!'
    ROLE_SYSTEM_CLIENT FOCUSABLE
        IA2_ROLE_SCROLL_PANE
            ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE

[  FAILED  ] DumpAccessibilityTreeTest.AccessibilityFrameset, where TypeParam =  and GetParam() =  (1903 ms)

BUG=

Review URL: https://codereview.chromium.org/567223002

Cr-Commit-Position: refs/heads/master@{#294764}

BUG=412086
TBR=lfg@chromium.org

Review URL: https://codereview.chromium.org/569083003

Cr-Commit-Position: refs/heads/master@{#294763}

BUG=none
TEST=none
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/569663002

Cr-Commit-Position: refs/heads/master@{#294762}

BUG=413006
TEST=manually tested

Review URL: https://codereview.chromium.org/563253002

Cr-Commit-Position: refs/heads/master@{#294761}

In one of the GestureEventDetails' constructors, the arguments
delta_x, delta_y sometime are not used, so we should make a new
constructor which only takes one argument EventType.

BUG=350942

Review URL: https://codereview.chromium.org/565583005

Cr-Commit-Position: refs/heads/master@{#294760}

Restoring the previous behavior of nacl_io regarding utime,
such that it pretends to succeed when a mount doesn't implement utime.

BUG=https://code.google.com/p/chromium/issues/detail?id=414058
TEST=trybots
TBR=binji@chromium.org

Review URL: https://codereview.chromium.org/571773002

Cr-Commit-Position: refs/heads/master@{#294759}

Adds a new API function, chrome.usb.getConfiguration, that returns all
the data from the device's configuration descriptor instead of just the
interfaces as chrome.usb.listInterfaces does. Each level of the
descriptor hierarchy also gets an "extra_data" field which contains all
of the miscellaneous descriptors assocated with a configuration,
interface or endpoint.

BUG=382908

Review URL: https://codereview.chromium.org/558373002

Cr-Commit-Position: refs/heads/master@{#294758}

Previously, if exact_matches was True but there were no exact matches,
it would return fuzzy matches instead. This is not what the caller asked
for.

GPU test names are changed to match the buildbot config, since they were
previously relying on fuzzy matching.

SHERIFFS: May cause errors like:

  No test named "some_test_name".

  Available tests are:
    ...

If so, this CL can be safely reverted.

BUG=413334,413442

Review URL: https://codereview.chromium.org/560153004

Cr-Commit-Position: refs/heads/master@{#294757}

We already have the same msvs_disabled_warnings declared at line 172. No
need to have it twice.

BUG=331829
TEST=gfx_unittests
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/555543003

Cr-Commit-Position: refs/heads/master@{#294756}

Revert of Cleanup: Remove base/file_util.h. Convert remaining references. (patchset #1 id:1 of https://codereview.chromium.org/568873004/)

Reason for revert:
Broke some internal builds. Need to give them a chance to fix their builds.

Original issue's description:
> Cleanup: Remove base/file_util.h. Convert remaining references.
>
> TBR=brettw@chromium.org
>
> Committed: https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18
> Cr-Commit-Position: refs/heads/master@{#294729}

TBR=brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/565803006

Cr-Commit-Position: refs/heads/master@{#294755}

This is needed for the work to drop GCM sign-in enforcement. Since
we no longer wipe out the GCM data when the user signs out, we need
to give user a chance to clear the data if he or she wants.

BUG=384041
TEST=Manual test by selecting "Cookies and other site and plugin data"

Review URL: https://codereview.chromium.org/562423002

Cr-Commit-Position: refs/heads/master@{#294754}

https://chromium.googlesource.com/chromium/blink/+log/9cb8a59cf2f63b817c4c4929dd0ba33b4c2ee7e1..1c10331d9ed2cb8073d44563b1c6e243971b7557
TBR=

Review URL: https://codereview.chromium.org/573533002

Cr-Commit-Position: refs/heads/master@{#294753}

All current versions of host and client support capabilities, we
no longer need to keep support for older versions.

Review URL: https://codereview.chromium.org/565263006

Cr-Commit-Position: refs/heads/master@{#294752}

In the baseline policy, we restrict the |clk_id| parameter allowed in
clock_gettime(). This applies to all sandboxed process types.

In the renderer policy, we similarly restrict the |clk_id| parameter for
clock_getres().

BUG=413469, 413855

Review URL: https://codereview.chromium.org/566083002

Cr-Commit-Position: refs/heads/master@{#294751}

[MIPS64] Add build support for MIPS64 in libjpeg_turbo
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+log/3963fbcd6c16..034e9a9747e0

TBR=rmcilroy@chromium.org
BUG=400684

Review URL: https://codereview.chromium.org/559963004

Cr-Commit-Position: refs/heads/master@{#294750}

These functions should set needs commit, but didn't. This lead to stale
pointers in the impl tree.

BUG=413743,403866

Review URL: https://codereview.chromium.org/572483002

Cr-Commit-Position: refs/heads/master@{#294749}

BUG=
TBR= jianli@chromium.org

Review URL: https://codereview.chromium.org/571553004

Cr-Commit-Position: refs/heads/master@{#294748}

BUG=78512
TEST=no change

Review URL: https://codereview.chromium.org/568163004

Cr-Commit-Position: refs/heads/master@{#294747}

Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

It's a follow up patch to https://codereview.chromium.org/414423002/. We already restructured WebContents
functionalities from ContentViewCore. In this patch we are removing unwanted ContentViewCore methods,
so that ContentViewCore stake holders can directly call these methods.

BUG=398263

Review URL: https://codereview.chromium.org/481803004

Cr-Commit-Position: refs/heads/master@{#294746}

Cr-Commit-Position: refs/heads/master@{#294745}

This is implemented on top of ResourceFetcher.

BUG=410414

Review URL: https://codereview.chromium.org/532773002

Cr-Commit-Position: refs/heads/master@{#294744}

Changing in the intialization order of WeakPtrFactory in src/extensions module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/573513002

Cr-Commit-Position: refs/heads/master@{#294743}

Picks up android.mk generator changes and emacs mode update.

Summary of changes available at:
https://chromium.googlesource.com/external/gyp/+log/94b57d39a88c..46282cedf40f

BUG=

Review URL: https://codereview.chromium.org/568833002

Cr-Commit-Position: refs/heads/master@{#294742}

Changing in the intialization order of WeakPtrFactory in "src/base" module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/565123002

Cr-Commit-Position: refs/heads/master@{#294741}

Since Chrome 38, this policy is also forcing Safety Mode for YouTube.

BUG=344815

Review URL: https://codereview.chromium.org/559033002

Cr-Commit-Position: refs/heads/master@{#294740}

HTML Tags: object, ins, mark, i, legend, frameset, caption, body, th
Aria role: row, spinbutton
Aria state/property: aria-atomic

BUG=170580

Review URL: https://codereview.chromium.org/543953003

Cr-Commit-Position: refs/heads/master@{#294739}

Cr-Commit-Position: refs/heads/master@{#294738}

BUG=None

Review URL: https://codereview.chromium.org/506943003

Cr-Commit-Position: refs/heads/master@{#294737}

PrintWebViewHelperTest.PrintWithIframe document.write()s into
a loaded iframe without a document.close(). This blocks the load event in the parent frame and will soon block load completion notifications.

BlockScriptInitiatedPrinting operates on an initial empty document, which can have strange effects. Load one of the html strings provided in that file, just so we have a real document to work with.

BUG=

Review URL: https://codereview.chromium.org/568933002

Cr-Commit-Position: refs/heads/master@{#294736}

The IOHIDManager object manages the IOHIDDevice instances that it
creates. Calling IOHIDDeviceOpen on such an instance is a no-op and
calling IOHIDDeviceClose prevents the IOHIDManager from tracking the
lifetime of the device. The solution is to never open nor close these
devices.

BUG=413976

Review URL: https://codereview.chromium.org/568873003

Cr-Commit-Position: refs/heads/master@{#294735}

These classes do not need to be classes and expecially don't need to be
abstract classes as this leads to a complicated implementation and
complicated tests. All USB devices no matter the platform will have the
same descriptor data.

This change follows the model of device::HidDeviceInfo.

Relanding this patch (reverted in crrev.com/294640) after restoring the
call to libusb_free_config_descriptor that was removed during
refactoring and caused failures in the Linux ASan LSan tests.

BUG=

Review URL: https://codereview.chromium.org/568943002

Cr-Commit-Position: refs/heads/master@{#294734}

https://skia.googlesource.com/skia/+log/c34b0d4e9ad5806c1f882a1f85191f2ea8ddcdba..abaef86f2b37d8a939506a2076da07f6db456951

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/569843003

Cr-Commit-Position: refs/heads/master@{#294733}

This is a cleanup patch.

ServiceWorkerProviderHost owns ServiceWorkerRegistration and the registration
owns ServiceWorkerVersions, so the provider host doesn't need to hold them.

BUG=n/a
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/563923005

Cr-Commit-Position: refs/heads/master@{#294732}

- add 'No matches were found.' hint
- adjust search bubble content when text option content changes
- fix extra padding

BUG=413520,413522

Review URL: https://codereview.chromium.org/568973002

Cr-Commit-Position: refs/heads/master@{#294731}

We are still passing it around and scaling a rect by it but it is
always 1 so just make that explicit.

R=vmpstr

Review URL: https://codereview.chromium.org/566023004

Cr-Commit-Position: refs/heads/master@{#294730}

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/568873004

Cr-Commit-Position: refs/heads/master@{#294729}

These traces were really helpful in tracking out why things were getting
prioritized wrong.

BUG=410625

Review URL: https://codereview.chromium.org/568183002

Cr-Commit-Position: refs/heads/master@{#294728}