GitLab

There is no need to keep the file descriptor open in net_internals_ui.cc as libdbus duplicates the FD when appropriate.

Use base::File instead of PlatformFile.
Use blocking pool instead of WorkerPool.

BUG=369183
TEST=Can save debug logs in "Chrome OS" section of chrome://net-internals on a Chromebook.

Review URL: https://codereview.chromium.org/270853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269540 0039d316-1c4b-4281-b951-d872f2087c98

These were writing to the current user's downloads directory instead of
a unique temporary directory.

BUG=372017
R=asargent@chromium.org, jamescook@chromium.org
TBR=asargent

Review URL: https://codereview.chromium.org/276133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269538 0039d316-1c4b-4281-b951-d872f2087c98

These browser_tests were writing to the current user's downloads
directory. While this is bad in itself, it is also suspected as the
cause of test failures on the waterfall.

BUG=372017
R=jamescook@chromium.org
TBR=jam

Review URL: https://codereview.chromium.org/274273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269536 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Linux Asan is failing with this patch: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2483/steps/unit_tests/logs/stdio

Original issue's description:
> Resubmit: Add real file for AdNetworks DB
>
> This is a resubmit of https://codereview.chromium.org/268063004/.
>
> The previous version was reverted because it caused a memory leak. This was a
> problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
> has been fixed.
>
> Details:
> Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
> (which according to the class comment, "the ref counting does not matter" [1]),
> the ref-counting _does_ matter. The fix for this went in as part of a refactor
> in https://codereview.chromium.org/263953003/.
>
> [1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44
>
> BUG=357204
>
> TBR=jhawkins@chromium.org (previously approved)
> TBR=felt@chromium.org (very minor changes)
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269494

TBR=jhawkins@chromium.org,felt@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357204

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269512

Review URL: https://codereview.chromium.org/277133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269535 0039d316-1c4b-4281-b951-d872f2087c98

Surface/buffer lifetimes are no longer bound by the controller. In addition,
it is possible for multiple controllers to be linked against the same surface,
making it impossible for a controller to know if the framebuffers need to be
unregistered. Thus move framebuffer initialization into the buffer object.

NOTRY=true

Review URL: https://codereview.chromium.org/276753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269531 0039d316-1c4b-4281-b951-d872f2087c98

Now that we use RecvMsgWithPid to find the PIDs for zygote children,
we no longer need to plumb the chrome-sandbox path down into and
through the renderer host code.

BUG=357670
NOTRY=true

Review URL: https://codereview.chromium.org/276763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269530 0039d316-1c4b-4281-b951-d872f2087c98

GetCurrentConnectionType (in NetworkChangeNotifier.java) gets actual connection type if the value is CONNECTION_UNKNOWN.

BUG=370292

Review URL: https://codereview.chromium.org/264973019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269529 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns at:
Error: Call requires API level 18 (current min is 14):
    android.hardware.usb.UsbDeviceConnection#bulkTransfer [NewApi]

So we need to add @TargetApi to suppress this lint error.

BUG=327768

Review URL: https://codereview.chromium.org/276943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manually
R=asvitkine@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/269343008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269527 0039d316-1c4b-4281-b951-d872f2087c98

R=xiyuan@chromium.org
BUG=368004

Review URL: https://codereview.chromium.org/270973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269525 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a crash in the app list where a NULL AppListItemView
wasn't checked.

BUG=371309

Review URL: https://codereview.chromium.org/271753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046

Review URL: https://codereview.chromium.org/270703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269523 0039d316-1c4b-4281-b951-d872f2087c98

The inner loop in MergePacketEvent should be using j to access the
BasePacketEvents.

Also improved merging logic in MergeFrameEvent a bit.

Review URL: https://codereview.chromium.org/263293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269522 0039d316-1c4b-4281-b951-d872f2087c98

To be landed after: https://codereview.chromium.org/247883002/ and https://codereview.chromium.org/259603002/

BUG=353857

Review URL: https://codereview.chromium.org/255823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269521 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269520 0039d316-1c4b-4281-b951-d872f2087c98

This roll introduces new DBus APIs for Bluetooth connection properties.

BUG=365966

Review URL: https://codereview.chromium.org/275003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269519 0039d316-1c4b-4281-b951-d872f2087c98

A URLRequest can signal the end of a stream by calling OnReadCompleted()
with a byte count of zero. No further reads should be issued after this.
However, ResourceLoader could issue a second Read() if the
ResourceHandler::OnReadCompleted() handler sets defer to true. I.e.

When a read completes:
  URLRequest calls
    -> ResourceLoader::OnReadCompleted(request, 0)
    -> ResourceHandler::OnReadCompleted(id, 0, &defer)
       (ResourceHandler sets defer to true)

Prior to this CL, the behavior on resumption was:

  ResourceHandler calls
    -> ResourceLoader::Resume()
    -> ResourceLoader::ResumeReading()
    -> ResourceLoader::StartReading()
    -> ResourceLoader::ReadMore()
    -> URLRequest::Read()

The new behavior is:

  ResourceHandler calls
    -> ResourceLoader::Resume()
    -> ResourceLoader::ResponseCompleted()

The new behavior is parallel to what happens if the ResourceHandler
didn't defer.

BUG=320394

Review URL: https://codereview.chromium.org/267563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269518 0039d316-1c4b-4281-b951-d872f2087c98

This is required for some internal update generation.

R=grt@chromium.org

Review URL: https://codereview.chromium.org/271823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269517 0039d316-1c4b-4281-b951-d872f2087c98

This backs out r296483, r269492, r269501, and r269511. The iOS bots hated it.
They don't like mach_vm_* and must use vm_* instead, and they can't #include
<mach/mach_vm.h> at all. The above patches dealt with that, but then when it
turned out that the iOS bots also weren't even building ScopedMachVM or
MACH_LOG at all, I decided to call it quits.

http://build.chromium.org/p/chromium.mac/builders/iOS%20Device%20%28ninja%29/builds/919/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.mac/builders/iOS%20Device%20%28ninja%29/builds/921/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16185/steps/compile/logs/stdio

TBR=rsesek

Review URL: https://codereview.chromium.org/274193007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269516 0039d316-1c4b-4281-b951-d872f2087c98

This CL prevents the dragging of app list folders to the Windows taskbar
by disabling synchronous drags for folders.

BUG=371665

Review URL: https://codereview.chromium.org/279673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/270803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269514 0039d316-1c4b-4281-b951-d872f2087c98

Previously we set the packet size in BasePacketEvent proto during
construction and never overwrite it. The problem is that the proto is
most often created as a result of seeing a receiver packet event first,
which does not contain packet size information and thus the size field
is set to 0. We'd need to overwrite the size field when we see a sender
packet event, which contains packet size information.

Most of the time we see receiver event first because they often arrive
sooner (via RTCP packets) than sender events (via IPC every second).

Review URL: https://codereview.chromium.org/272873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269513 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Linux Asan is failing with this patch: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2483/steps/unit_tests/logs/stdio

Original issue's description:
> Resubmit: Add real file for AdNetworks DB
> 
> This is a resubmit of https://codereview.chromium.org/268063004/.
> 
> The previous version was reverted because it caused a memory leak. This was a
> problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
> has been fixed.
> 
> Details:
> Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
> (which according to the class comment, "the ref counting does not matter" [1]),
> the ref-counting _does_ matter. The fix for this went in as part of a refactor
> in https://codereview.chromium.org/263953003/.
> 
> [1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44
> 
> BUG=357204
> 
> TBR=jhawkins@chromium.org (previously approved)
> TBR=felt@chromium.org (very minor changes)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269494

TBR=jhawkins@chromium.org,felt@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357204

Review URL: https://codereview.chromium.org/277133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269512 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/273183003/


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363840

Review URL: https://codereview.chromium.org/267573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269510 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the writeCharacteristicValue function of the
bluetoothLowEnergy API.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Review URL: https://codereview.chromium.org/263333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269509 0039d316-1c4b-4281-b951-d872f2087c98

Tapping the back button, cancel button, or outside the dialog should not set the value.
DatePickerDialog has a bug since JellyBean where the onDateSet callback is called every time the dialog is dismissed.

BUG=325841

Review URL: https://codereview.chromium.org/260903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366947

Review URL: https://codereview.chromium.org/269813012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269506 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269503 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsesek

Review URL: https://codereview.chromium.org/273183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269501 0039d316-1c4b-4281-b951-d872f2087c98

    
Add AUD, SEI and reserved NALU types to the set of NALUs that
trigger the end of current frame, i.e. NALUs that indicate
that we have already got all the slices belonging to the
current frame.

BUG=370758
TEST=vdatest, stream with AUDs

Review URL: https://codereview.chromium.org/268363018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269500 0039d316-1c4b-4281-b951-d872f2087c98

On mac/linux the debug stub port is allocated chrome side and provided to
Native Client. On Windows (where socket handles cannot be passed between
processes), the debug port must be allocated by the nacl process (which can
only happen when the outer sandbox is disable).

Propagate the debug port selected by the nacl side to the task manager to make
it available to the user and debugging extensions.

Depends on this nacl side change:
https://codereview.chromium.org/206493005

BUG=328714
TEST=None
R=mseaborn@chromium.org,jschuh@chromium.org

Review URL: https://codereview.chromium.org/198083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=b/12492817

Add the internal Aw API to enable/disable DRP.

NOTRY=true

notry due to irrelevant failures in windows rel tests.

Review URL: https://codereview.chromium.org/271523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269498 0039d316-1c4b-4281-b951-d872f2087c98

Refactor clients using equivalent non-deprecated methods.

R=reed@google.com,enne@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/271653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269497 0039d316-1c4b-4281-b951-d872f2087c98

Aura's current slop region is boundary exclusive, whereas Android's is boundary
inclusive.  With the unified GR, both platforms will use a boundary inclusive
slop region, but until such time the TouchEventQueue should support either
model.  Allow this distinction via a configurable TouchEventQueue::Config
parameter.

BUG=354763

Review URL: https://codereview.chromium.org/273933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025

Review URL: https://codereview.chromium.org/274943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269495 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of https://codereview.chromium.org/268063004/.

The previous version was reverted because it caused a memory leak. This was a
problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
has been fixed.

Details:
Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
(which according to the class comment, "the ref counting does not matter" [1]),
the ref-counting _does_ matter. The fix for this went in as part of a refactor
in https://codereview.chromium.org/263953003/.

[1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44

BUG=357204

TBR=jhawkins@chromium.org (previously approved)
TBR=felt@chromium.org (very minor changes)

Review URL: https://codereview.chromium.org/274563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269494 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerConnection is deriving from a non exported interface IViewManager.

Attempt 2 at fixing this. The previous approach of using NON_EXPORTED_BASE does not work in
the template base derivation used in this class.

Proposed fix is to explicitly disable this warning for Windows.

BUG=none
R=cpu@chromium.org, cpu
TBR=darin

Review URL: https://codereview.chromium.org/271363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269493 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsesek

Review URL: https://codereview.chromium.org/271353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269492 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/270833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269488 0039d316-1c4b-4281-b951-d872f2087c98