GitLab

This swaps the deprecated 'arraysize' macro for base::size in the GPU
command buffer generator scripts and generated files. No change to
logic.

Bug: 837308
Change-Id: I229a7f9ad9a25f0a7e40690aae5ff167a75aa804
Reviewed-on: https://chromium-review.googlesource.com/c/1313835Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604989}

See: go/chromerulesetservicemerge

This change removes references to ContentRulesetService in our codebase
preferring RulesetService.  It changes the direction of ownership of
these classes, having the RulesetService own the ContentRulesetService.
The publishing/distribution functionality is now called via the
RulesetService itself, which makes calls to the virtual
RulesetServiceDelegate implemented by the ContentRulesetService.

Bug: 900292
Change-Id: I30420f0b36107e65d59d1911b506242c58886ecd
Reviewed-on: https://chromium-review.googlesource.com/c/1294299Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604988}

Enable personal readout to support personal features after we changed to use libassistant device ID.

Bug: b/118782806
Change-Id: I9b3d08eb700f6f352f88c59c11bfbf3813f15c4f
Reviewed-on: https://chromium-review.googlesource.com/c/1312293Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604987}

This reverts commit dcb738f9.

Reason for revert: Broke mac-dbg compile https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-dbg/1596

Original change's description:
> Reimplement GetAppOutput and friends on Mac with posix_spawn.
> 
> Mac no longer uses launch_posix.cc and all process creation goes through
> posix_spawn now.
> 
> Bug: 179923
> Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd
> Reviewed-on: https://chromium-review.googlesource.com/c/1313334
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604982}

TBR=rsesek@chromium.org,mark@chromium.org

Change-Id: I9fd7e4c80f66de9acd35c7626cc65fdd5007d474
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 179923
Reviewed-on: https://chromium-review.googlesource.com/c/1315708Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604986}

https://chromium.googlesource.com/catapult.git/+log/a6ef719b69f4..a8f088180a1c


git log a6ef719b69f4..a8f088180a1c --date=short --no-merges --format='%ad %ae %s'
2018-11-02 chiniforooshan@chromium.org Telemetry: migrate thread_*_cpu_time_per_frame
2018-11-02 erikchen@chromium.org [Reland 1]  ADB commands should only retry errors, not exceptions.


Created with:
  gclient setdep -r src/third_party/catapult@a8f088180a1c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:890757,chromium:895027
TBR=sullivan@chromium.org

Change-Id: I070af3f6172541300ce6dc4d5ac183f117dd1db6
Reviewed-on: https://chromium-review.googlesource.com/c/1315408Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604985}

Its bots will be everything in:
https://chromium-swarm-dev.appspot.com/botlist?c=id&c=os&c=task&c=status&f=os%3AChromeOS&l=100&q=os%3AChr&s=id%3Aasc

Bug: 901205
Change-Id: I0266b1c75deacdd0b287bcd9cc7f8b247a4792af
Reviewed-on: https://chromium-review.googlesource.com/c/1313836Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604984}

This patch moves the responsibility of updating the scrim for the
toolbar over to the ToolbarManager. This allows for the removal of
a fair amount of plumbing for the scrim and some questionable casting.

Change-Id: I3ee397c2444d96da9e9a32bb7652134989ffedad
Reviewed-on: https://chromium-review.googlesource.com/c/1313115
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604983}

Mac no longer uses launch_posix.cc and all process creation goes through
posix_spawn now.

Bug: 179923
Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd
Reviewed-on: https://chromium-review.googlesource.com/c/1313334Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604982}

In normal profile, the small icon uses different default icons based
on download state. Incognito mode should do the same since download
state is not privacy information. Other systems try to use download
notification currently don't plumb the small icon into
DownloadNotificationFactory.

Bug: 901141
Change-Id: I3f813adab15484b1e97e8d1592979f8f381ad8d0
Reviewed-on: https://chromium-review.googlesource.com/c/1313928Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604981}

It's important to cap delays at one day or bad things can happen
on certain platforms.

Also removes a redundant call to ScheduleDelayedWork.

Bug: 863341, 850450
Change-Id: Idfb95a5e5d800255caff74d0718db600b9348335
Reviewed-on: https://chromium-review.googlesource.com/c/1314489Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604980}

https://aomedia.googlesource.com/aom.git/+log/8f2210a2e54a..35171107616f

$ git log 8f2210a2e..351711076 --date=short --no-merges --format='%ad %ae %s'
2018-10-31 johann.koenig INTERNAL_STATS: move ssim_opt_x86_64
2018-10-29 yunqingwang Use 8-tap interp filter in temporal filtering
2018-10-29 wtc Re-enable the NotEnoughBuffers and NoRelease tests.
2018-10-31 urvang av1_highbd_dr_prediction_z2_c: Add an assertion.
2018-10-30 sarahparker Solve a 2x2 system for optical flow computation
2018-10-31 sachin.kumargarg Fix issue in AV1HighBDJNTCOMPAVGUPSAMPLEDTest
2018-10-30 sarahparker Add function to compute matrices for DISflow system
2018-10-22 sarahparker Add x and y gradients to image pyramid
2018-10-30 bruno.berthier Fix build with -DCONFIG_WEBM_IO=0 -DCONFIG_LOWBITDEPTH=0
2018-10-29 david.turner Remove CONFIG_INTEGERIZE_SGR build flag
2018-10-29 david.turner Fix issues with SIMD horver_correlation_full
2018-10-22 debargha Enhance selective_ref_frame for use in speed 0
2018-10-23 wenyao.liu reduce memory usage in PICK__MODE_CONTEXT
2018-10-26 sarahparker Add macro to determine type of global motion computation
2018-10-24 ravi.chaudhary Fix issues in ARNR filtering
2018-10-26 wtc Propagate img->fb_priv when film grain enabled.
2018-10-27 wtc Fix the ExtFBMD5Match test.
2018-10-26 yunqingwang Remove rst_end_stripe in struct AV1Common
2018-10-26 johannkoenig change CONFIG_SHARP_SETTINGS description
2018-10-26 debargha Revert horver calculation to C version temporarily
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org

Bug: aomedia:1255
Bug: 867613
Change-Id: I1dd800038d5ec8e80b4eefc851173d1ca8427e1c
Reviewed-on: https://chromium-review.googlesource.com/c/1313765Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#604979}

This patch converts some layout tests with testharness to reduce usage
of deprecated js-test.js.

It's also a preparation for using Element.innerText as layout test text
dump to avoid confusiong text dumps. These tests contain <option> with
text like "failure", which doesn't appear in old text dump but appears in
innerText. By converting with testharness, we don't have such confusing
text dumps.

Bug: 887148
Change-Id: I38cc38cb395318bb9ddd38d655c99bd4f47bb846
Reviewed-on: https://chromium-review.googlesource.com/c/1314131Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604978}

In function QuicSocketAddressImpl::generic_address(), zero-initialize the returned sockaddr_storage. This is how Google's internal implementation behaves.

Change-Id: I99e3ded71060027c9cd01ffb58330597a12aa880
Reviewed-on: https://chromium-review.googlesource.com/c/1313676
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604977}

The flexbox ones were likely fixed by crrev.com/c/1310475, which
now sets constraint_space.IsNewFormattingContext() correctly for
flex items with ng flex.

The other two were fixed by crrev.com/c/1306968, I believe.

TBR=dgrogan@chromium.org

Change-Id: If44d1d34f416078d3768a9a518390a3fd3072d06
Reviewed-on: https://chromium-review.googlesource.com/c/1315169
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604976}

We have to remove the square brackets if presented otherwise the
array variable will be passed as variable[] and that will cause a build
failure:

gen/modules/desktop_capture/linux/pipewire_stubs.cc:85:26: error: expected expression
  pw_init_ptr(argc, argv[]);
                         ^

Change-Id: I60595a0ce4a4f618fcb904cc3654ce4304fd1ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1312950Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604975}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20f38b3d064b..b49154954d1d


Created with:
  gclient setdep -r src-internal@b49154954d1d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic10f92d3d57c4ed21c851c51f7fbe4a5172c4930
Reviewed-on: https://chromium-review.googlesource.com/c/1315328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604974}

Also splitted the metrics into 2 (MainFrame, Subframe), so that the
subframe metrics can be constructed using bitwise operations.

Bug: 881345
Change-Id: I9e0e9aeb3d518e3fa5afbc3ff101705e04d87232
Reviewed-on: https://chromium-review.googlesource.com/c/1309096Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604973}

This is used to test asynchronous behaviors of touch in interactive
ui tests for ChromeOS, which also fits with the design of Mash.

See https://docs.google.com/document/d/1h6-dBGUUF2Us4C8ELzqlNyZx1VzcGlenLPDeOBJDJJw/edit?usp=sharing
for the details of the failure reason.

BUG=890071
TEST=tab_drag_controller_intearctive_uitest

Change-Id: I07a292e8f8cd69afa4212f90a52400d612cf6f63
Reviewed-on: https://chromium-review.googlesource.com/c/1309093Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604972}

Changes:
Extract logic triggered by app list shelf button into common function
which is also used by search key.

Bug: 896895
Change-Id: Ie81ef2aee94cc56270842887c7554297b1a94575
Reviewed-on: https://chromium-review.googlesource.com/c/1313057Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604971}

The crash may occur when dragging an item for reparant in root level
while we need to add a page break item between two items in root level.
The two items happened to have the same position which triggers a
position fix causing a LoadFromMetadata() call during SaveToMetadata().

Changes:
Remove observer when add page break item.

Bug: 900427
Change-Id: Ie416eeb81de47cd531a6c25a16761ce1d141847f
Reviewed-on: https://chromium-review.googlesource.com/c/1313054Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604970}

This relands commit aa60c219. The original CL
(https://crrev.com/c/1113802) got reverted becuase FeatureList and field
trials are not setup properly in early startup in Android WebView, but
ServiceMangerContext has checked features. See crbug.com/899376. The fix is
in a separate CL: https://crrev.com/c/1305876. Another related precursor CL
is: https://crrev.com/c/1308096.

This CL is an exact copy of the original CL.

The original cl description is:
This CL instantiates the ServiceManagerContext before creating
the BrowserMainRunner. It splits the startup path into two,
with/without starting the full browser. The changes are implemented
behind a flag "allow-start-service-manager-only".

Bug: 846846,729596
TBR: jam@chromium.org
Change-Id: I5214af850d4ef256c9d223db059ed009a42de714
Reviewed-on: https://chromium-review.googlesource.com/c/1305822
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604969}

Each pending request in a socket pool group now keeps track of which
ConnectJob is assigned to it, through a pointer to the corresponding
ConnectJob. If there are more ConnectJobs than pending requests in a
group, pointers to the excess jobs are kept in a list of unassigned
jobs. Associating requests with jobs will make it easier to keep job
priorities in sync with request priorities when reprioritizing
requests.

Bug: 166689
Change-Id: I6bb4adb3d8504d55ae58204398f783f9fa0d62cb
Reviewed-on: https://chromium-review.googlesource.com/c/1305393
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604968}

Bug: 724543
Change-Id: If4da5b51ad6886063801b6e224a0acedd57995cc
Reviewed-on: https://chromium-review.googlesource.com/c/1314612Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604967}

When GuestViewCrossProcessFrames is enabled, we overwrite certain
methods in the guest view js implementation. It appears that the
intended naming convention is to have the methods that are overwritten
end with a "$". However, this was not done consistently.

Bug: None
Change-Id: Iac035cd43264d20e46036581bcaa070d2edd6bb7
Reviewed-on: https://chromium-review.googlesource.com/c/1311076
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604966}

https://webrtc.googlesource.com/src.git/+log/56ef305b6767..42e7d9c929ef


git log 56ef305b6767..42e7d9c929ef --date=short --no-merges --format='%ad %ae %s'
2018-11-02 ilnik@webrtc.org Enable rtc event log in *_loopback tools running with renderers
2018-11-02 asapersson@webrtc.org Add field trial for vp8 cpu speed configuration for arm.


Created with:
  gclient setdep -r src/third_party/webrtc@42e7d9c929ef

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3fa1831a097c3edd152002d40c041e5cbef67750
Reviewed-on: https://chromium-review.googlesource.com/c/1315407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604965}

TEST=clang-cl on Linux works again.

Change-Id: Ie18d17418bf517dd231b5dd68b2a8d9c39d221ed
Reviewed-on: https://chromium-review.googlesource.com/c/1313871Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604964}

https://skia.googlesource.com/skia.git/+log/30edaaac1da4..d029c0e83734


git log 30edaaac1da4..d029c0e83734 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 caryclark@skia.org remove color 16 implementation out of public
2018-11-02 mtklein@google.com move SkICC::WriteToICC out of line
2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 42e8e54e3049..155f802a6be3 (2 commits)


Created with:
  gclient setdep -r src/third_party/skia@d029c0e83734

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@chromium.org

Change-Id: Ibde90606404db52e9227ac6f86653230a681eba1
Reviewed-on: https://chromium-review.googlesource.com/c/1315409Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604963}

The changes to snav-testharness.js lets us assert navigations
in and out of iframes:

 1) To be able to test focus movements in and out of iframes,
    we need to listen for 'keyup'-events on the document where
    focus is _about_to_go_.

    'keyup' targets the currently focused document. When 'keyup'
    comes, 'keydown' has already changed focus to the new document.

 2) Previously each movement had its own async_test(). Now we use
    one async_test() with many "test steps": one for each movement.
    This helps us avoid tricky (mis)usage of testharness.js's
    fetch_tests_from_window().

The changes to the HTML files are mostly mechanical except that
I gave some elements new or renamed ids so they become easier
to distinguish when debugging.

Once we've fixed Issue 801162, the tests' expectations will change:
We want spatnav to first _focus_ the iframe (before scrolling it
or searching inside of it).

Bug: 803086, 891658, 801162
Change-Id: Ib53bb224398510b5744927a5d892381870fa4690
Reviewed-on: https://chromium-review.googlesource.com/c/1314469
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#604962}

Track the undrawn surfaces after aggregating all the surfaces for
display. This will be used to throttle begin-frames to undrawn
surfaces.

BUG=884876

Change-Id: I30fca08d4a8b5c773bc8f29111aad272032e14f9
Reviewed-on: https://chromium-review.googlesource.com/c/1315527Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604961}

https://chromium.googlesource.com/angle/angle.git/+log/a6e8a0c5fee5..99d0463cd940


git log a6e8a0c5fee5..99d0463cd940 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 james.clarke@microsoft.com Windows: add support for SpriteVisuals as a native window type.


Created with:
  gclient setdep -r src/third_party/angle@99d0463cd940

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I3fef239aa1b3ed3b36ea890e6520d97f9aecdb39
Reviewed-on: https://chromium-review.googlesource.com/c/1315410Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604960}

Use the size from the Quad, instead of always hardcoding to 5x5.

Bug: none
Change-Id: Ic6c552f3a780da002c194918226cc8b3a32c8ab3
Reviewed-on: https://chromium-review.googlesource.com/c/1314142Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604959}

This CL adds an experimental GN arg, use_uncompressed_dex, which will
force .dex files to be stored uncompressed in APKs. Currently,
monochrome_public_apk and trichrome_chrome_apk are affected. The
corresponding bundle targets are not affected.

Bug: 777858
Change-Id: Ib8e0922328da02a45f5c5e71675d4d76e907d087
Reviewed-on: https://chromium-review.googlesource.com/c/1311661
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604958}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/879aea82..b5f94ce7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I068297268d9c5a04b50724048370b5a788c3aaaa
Reviewed-on: https://chromium-review.googlesource.com/c/1315387Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604957}

Bug: 900718
Change-Id: Iade6c516120ced7c64991cecc5c1bfef7740d036
Reviewed-on: https://chromium-review.googlesource.com/c/1311694Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604956}

Summary
=======

This CL makes layout tests use the default site isolation from the
platform they are run on (instead of opting out of strict site isolation
via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
Additionally, on platforms where strict site isolation is enabled,
layout tests opt into slightly stricter isolation by enabling isolation
of same-site origins used by Web Platform Tests - this ensures that
features covered by WPT also get sufficient coverage of out-of-process
iframes (OOPIFs).

After this CL, expectations for tests that differ in behavior with and
without OOPIFs are being moved from
LayoutTests/FlagExpectations/site-per-process to:
- LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
- LayoutTests/virtual/not-site-per-process/README.md
- LayoutTests/TestExpectations and LayoutTests/NeverFixTests
  ("Site Isolation failures" section)


Desirability
============

The CL helps with the following:

- Focusing on testing the mode that is actually shipped to end users
- Helping ensure that newly developed features get site-per-process
  coverage without having to set up a separate step (i.e. it is
  sufficient to set-up a bot that runs layout tests with
  --enable-features=NewFeature without also having to have a separate
  test step for runing layout tests with *both*
  --enable-features=NewFeature *and* --site-per-process

This CL does *not* help with reducing requirements for CQ capacity,
because we need to maintain a separate
not_site_per_process_webkit_layout_tests step to make sure that tests
pass without isolation (which is the mode Chrome ships on Android).
Also note that layout test coverage on Android is very sparse - see
https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion


Preserving test coverage
========================

Most tests
----------

The CL preserves covering most layout tests with and without OOPIFs, by
relying on the fact that CQ/waterfall run layout tests on both kinds of
platforms - ones that default to strict site isolation (desktop
platforms) and ones that default to no site isolation (Android).


Tests that used to be excluded FlagExpectations/site-per-process
----------------------------------------------------------------

Around 40 tests fail when run in presence of OOPIFs.  Such tests are
disabled by this CL by moving test expectations from
FlagExpectations/site-per-process into the main TestExpectations file.
The CL preserves non-OOPIF test coverage provided by the disabled tests
by introducing virtual/not-site-per-process directory which runs all
such tests with site isolation disabled.  Using a virtual test suites
for preserving the test coverage relies on the ability to have separate
test expectations for these tests (i.e. relying on the fact that
disabling these tests in TestExpectations doesn't disable their
virtual/not-site-per-process equivalents).

Note that the CL keeps isolating "oopif.test" site even in
virtual/not-site-per-process suite.  This site should only be used by
tests that require an OOPIF.


Preserving site-per-process-specific test expectations
------------------------------------------------------

Some tests have site-per-process-specific expectations:
- http/tests/inspector-protocol/network/security-info-on-response.js
- http/tests/inspector-protocol/network/raw-headers-for-protected-document.js

The tests above highlight that cross-origin cookies are not displayed in
site-per-process mode (a known regression tracked by
https://crbug.com/849483).  This CL preserves expectations and coverage
by shuffling things around:
- old, main expectation -> android expectation
- old, site-per-process expectation -> main expectation


There is one additional test with site-per-process-specific
expectations:
- external/wpt/dom/events/EventListener-addEventListener.sub.window.js

Unlike the other 2 tests, it seems less important to preserve exact test
expectations for the case when the test fails with Site Isolation.
Therefore this test is covered by virtual/not-site-per-process test
suite and an expectation for this test is added to the main
TestExpectations.


Lost test coverage
------------------

Even with extra caution described above, some test coverage may be lost:

- Features covered by tests only on one kind of platform (e.g. disabled
  on Android) are at risk of losing OOPIF or non-OOPIF coverage.

- Before this CL, site-per-process was also applied to all other
  `virtual/...` test suites.  After this CL,
  `virtual/not-site-per-process` will not provide such coverage.


Cleaned up test expectations
----------------------------

Some additional test expectations clean-up is done, while preserving
test coverage:

- The http/tests/perf/large-inlined-script.html test has been already
  present in `SlowTests` and therefore I didn't include this test in the
  new `virtual/not-site-per-process` suite.

- The http/tests/devtools/network/network-datareceived.js test was
  already marked as expecting a `[Failure]` in TestExpectations and
  therefore I didn't include this test in the new
  `virtual/not-site-per-process` suite.

- The http/tests/devtools/console-cross-origin-iframe-logging.js test
  was already marked as `[Timeout]` in the old TestExpectations but for
  Win only.  Since I can repro a timeout on Linux (with and without site
  isolation), I just extended the old expectation to all platforms and I
  didn't include this test in the new `virtual/not-site-per-process`
  suite.  I also removed the test from SlowTests (since timeouts in the
  test are not expected everywhere).


Bug: 870761
Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64
Reviewed-on: https://chromium-review.googlesource.com/c/1302662
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604955}

Change-Id: Id2d3a40f75221b4bdae33ac5558d9b323e149c40
Reviewed-on: https://chromium-review.googlesource.com/c/1311915Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604954}

This lets concierge choose the appropriate disk image type for the
kernel and filesystem.

Bug: 893380
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Change-Id: I2b8d9ae847e5d2a87949a2e7b9ef965d038e11f2
Reviewed-on: https://chromium-review.googlesource.com/c/1312568Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604953}

This CL takes the experimental hrefTranslate attribute on <a> tags
and carries it to the creation of NavigationHandle. This allows
Translate browser code to be aware of its value in
ContentTranslateDriver::DidFinishNavigation.

BUG:900586,872777

Change-Id: Ie7c633aca8a91f1137862898c992c5f63cc1fcca
Reviewed-on: https://chromium-review.googlesource.com/c/1308434Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604952}

Line numbers will change with a V8 change, will rebaseline after that rolls.

BUG=V8:8405

Change-Id: I3003667ea7f8581dfe4de1fb7252888fb45dcd7d
Reviewed-on: https://chromium-review.googlesource.com/c/1313933
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604951}

This is more common and easier to see.

BUG=none
TEST=none

Change-Id: Ieae5f48274430123dbae4dfee4c5b79e1f901b63
Reviewed-on: https://chromium-review.googlesource.com/c/1313829Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604950}