- 23 Sep, 2020 40 commits
-
-
Michael Thiessen authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/2424986/ Bug: 783819 Change-Id: Ic89fc2d6f330c471bfcc18696fafa1f077b901fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427063 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#809902}
-
Tim Van Patten authored
The various .def files used in Windows builds are generated using llvm-nm and only support being used with the clang compiler. These .def files can't be used with MSVC, though we are unsure if that's related to how they are generated by generate_def_files.py or how MSVC consumes them (i.e. the format it expects for the symbols). The issue is primarly about the custom libcxx and MSVC's inability to work correctly with it. //build/config/c++/c++.gni handles this automatically by disabling the custom libcxx for non-clang (MSVC) builds by setting use_custom_libcxx = false. However, this causes the .def symbols to be generated differently (incorrectly), causing link failures related to too many symbols being exported. This change helps support using Abseil in ANGLE, particularly standalone component builds built with MSVC. This is a workaround until: 1.) EXPORT macros are used (preferred). OR 2.) generate_def_files.py can generate .def files for both clang and MSVC, either manually or as part of the build (unpreferred, since the script itself is a workaround). Abseil: Only use Windows .def files with clang The various .def files used in Windows builds are generated using llvm-nm and only support being used with the clang compiler. These .def files can't be used with MSVC, though we are unsure if that's related to how they are generated by generate_def_files.py or how MSVC consumes them (i.e. the format it expects for the symbols). The issue is primarly about the custom libcxx and MSVC's inability to work correctly with it. //build/config/c++/c++.gni handles this automatically by disabling the custom libcxx for non-clang (MSVC) builds by setting use_custom_libcxx = false. However, this causes the .def symbols to be generated differently (incorrectly), causing link failures related to too many symbols being exported. This change helps support using Abseil in ANGLE, particularly standalone component builds built with MSVC. This is a workaround until: 1.) EXPORT macros are used (preferred). OR 2.) generate_def_files.py can generate .def files for both clang and MSVC, either manually or as part of the build (unpreferred, since the script itself is a workaround). Bug: 1126524 Test: Manual verification with standalone ANGLE build Change-Id: Icf071635938f83818b8345b38074c21f362b897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419155 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#809901}
-
Garrett Beaty authored
This reverts commit 229a7c61. Reason for revert: Breaks mojo builders, forgot to update testing/buildbot and mb_config. Original change's description: > Switch the builder group for mojo builders. > > The recipe-side config for the mojo builders has already been copied to > the new builder group. > > Bug: 1131163 > Change-Id: Id1d01ccdac7f242e347db02586b04bb6927b9e0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427123 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#809869} TBR=dpranke@google.com,gbeaty@chromium.org Change-Id: Ib70aa384011d8b1aace921e08683048f9a9aa32b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427285Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#809900}
-
Michael Moss authored
Retry bringing in symupload native symbols support on Mac (with fix from previous roll attempt in https://crrev.com/c/2380139). 9c4671f Change JSON serialization error check. bdac77a file_id_unittest: avoid system() 5640e57 CopyFile: add a C++ API c6d49c4 linux: Fix leak when the offset of memory_mapped_file is greater than 0 039c4c9 Add a .clang-format file to give us local control over Chromium style. 9c38ab7 Add native symbol uploads to Mac OS symupload tool. 62d9272 linux: Fix segfault when there is no section header in ELF file 087795c processor: subtract 1 from return pointers while scanning 014e842 Escape more characters in Mac OS sym-upload-v2 debug_file strings. BUG=1021742 R=mark@chromium.org, nbilling@google.com Change-Id: If54fbc92bf1253c25cb8ca0ef15494a506a9d793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426729Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#809899}
-
Tomasz Wiszkowski authored
This change introduces a set of classes and properties enabling the TileView to become a MVC component. The change collapses the TileView and TileWithTextView classes into one to avoid awkward naming. The TileView base class is never used as a stand-alone component and MVC allows the class to control the visibility of the TextView with ease. The MVC component features all UI specific features used by TileView, TileWithTextView, SuggestionsTileView and TopSitesTileView. Bug: 1106109 Change-Id: I3dde36e767ae876759089bd3580ac5d9ac61e66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424490 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#809898}
-
ckitagawa authored
This test was disabled due to an M85 bot on failing. However, the tests were drastically refactored for M86. I don't think this is still an issue with the refactored tests as the crash location no longer exists. See comments on bug for more details on why I think a simple enable should suffice. Will monitor for new flakes over the next few days. Bug: 1117264 Change-Id: Ifffbca7f9612b4577ca7884c78c8f73695d6fdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426365Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#809897}
-
Patrick Noland authored
This adds the familiar MVC pieces, in addition to the existing Coordinator and View: a Mediator, a ViewBinder, and a Properties class. Logic is moved out of the MenuButton and MenuButtonCoordinator to the Mediator. Of note, there are two compound properties for combinations of properties that need to be set together: * show/hide badge and shouldAnimate * useLight and ColorStateList Bug: 1086676 Change-Id: I12fb7aa1e21b78b0cddf6b72c322e3c030fae78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406378 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809896}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009230800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uJOBjWHF-V8jOwZMkbWeP1rWi_kNv9l_Fsc2gObjg3wC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/166042882 Tbr: help-app@grotations.appspotmail.com Change-Id: Ia47749e95cecdf61c4882a147bf9c7fd17078a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426297Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809895}
-
Peter Kasting authored
Bug: 772945 Change-Id: I1f347bc404e5b347159c64cdb9ff0e45f3903590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425153 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#809894}
-
Elly Fong-Jones authored
This test is quite flaky. Bug: 1131541 Change-Id: I6cd6660221b570a1e10343fa108308b3cd1a6e18 Tbr: msarda@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425401Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809893}
-
Shubham Aggarwal authored
The result of the IPC call GetContentSettingsManager::AllowStorageAccess was cached to prevent further redundant IPC calls. But this was only done for local and session storage permissions (via the AllowStorage() method). This change consolidates the caching logic to be used for all storage types. We also remove the AllowStorage() method and integrate it into the general purpose AllowStorageAccess() methods, adding new storage types for local and session storage. IDBFactory::CachedAllowIndexedDB() is also removed as it is now redundant. Change-Id: I518cf05bc1e12feec25c96aa5c1cd2cefebd1a29 Bug: 1122633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401847Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809892}
-
Jeff Yoon authored
This reverts commit 0d501f4f. Reason for revert: Added it to wrong MB config Original change's description: > [pgo/mac] disable widevine signing for Mac PGO bots > > enable_widevine_cdm_host_verification = false was missing from > GN args for PGO Mac bots, which is causing build failures. > > Bug: 1128810 > Change-Id: I2ccd1db80e80fd983e5f4ef0bd63908281557a04 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425846 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809877} TBR=liaoyuke@chromium.org,jeffyoon@chromium.org Change-Id: I5f4beb446367d5110d267b527df39eae12812a35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427343Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809891}
-
Maksim Sadym authored
* Add `GetComputedRole` to Element in ChromeDriver Bug: chromedriver:3507 Change-Id: Id3e3dc2fa99ca05286d17323c9c03cbf4f36ece7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416381Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#809890}
-
Gauthier Ambard authored
This CL enable the new position of the TabSwitcher. Bug: None Change-Id: I4652f332177f6a5268f33edfb13cca0a52c10fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424185 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#809889}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/18f4b1c7e31a..647a9bd7c253 2020-09-23 johnstiles@google.com Convert the remaining FP tests to golden outputs. 2020-09-23 nifong@google.com Fixes for canvaskit karma tests in google3 2020-09-23 johnstiles@google.com Revert "Calculate texture clamping X/Y coordinates in parallel." 2020-09-23 robertphillips@google.com Add time-based purging to the GrThreadSafeUniquelyKeyedProxyViewCache 2020-09-23 michaelludwig@google.com Allow non-AA clip rects to be scissor only even on MSAA targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: I69962dcd3e5d3b2dea9a7ba75bbce093db484ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809888}
-
Ben Kelly authored
This CL also removes an extraneous std::move() that was requested to be removed in the previous CL review. Bug: 1127008 Change-Id: Iec2f160aa4d5acb68c645c3ccd7bd86ab913f794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419335 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#809887}
-
Domenic Denicola authored
This illustrates the issue in https://crbug.com/1099718. Bug: 1099718 Change-Id: Ie27df0a2cd5f62370332b318726bc10f965efe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270626Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#809886}
-
Brandon Wylie authored
Bug: 1131545 Change-Id: I9617e2d26f7acd50b44a9151927aff6713cdab28 TBR=wychen@chromium.org Change-Id: I9617e2d26f7acd50b44a9151927aff6713cdab28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426489 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809885}
-
Gabriel Marin authored
Precise attribution at instruction level helps to better understand hostspots in assembly view. Updated a few unit tests to check for the right UMA metric being incremented. BUG=b:168312716 Change-Id: I537395d5ec6714c75b4224765ebc247a6ba00ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424517Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#809884}
-
Aaron Leventhal authored
Bug: 1131380 Change-Id: I04477396fa11afb24a89c1447e799880c857b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426248 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809883}
-
Eugene But authored
I learned what I want from this histogram Bug: 1117138 Change-Id: Iae2d2a95b55103f91fed2dead8c7a5bd5401af12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425011 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Bug: 1131437 Change-Id: Idf5017d82261bad5ff933b45acb54309c2eb7771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426764 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
cfredric authored
These lines were generated by running the following script, then running tools/metrics/histograms/update_use_counter_feature_enum.py: import sys startingValue = int(sys.argv[1]) numEntries = int(sys.argv[2]) for i in range(startingValue, startingValue + numEntries): print(' kIdentifiabilityStudyReserved%d = %d,' % (i, i)) Bug: 973801 Change-Id: I99144faf9ff05a731d08813472aab8aa8f23c008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425338Reviewed-by:Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#809880}
-
Elly Fong-Jones authored
They are too slow to run reliably in that config. Bug: 1131570 Change-Id: Id1c94616cd982d66c5c5970d08d24e47db6f2c1e Tbr: yunkez@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426491Reviewed-by:
-
Bence Béky authored
Change-Id: I7e9d87f3f88a3d38ee5b99c85fa3e64b06682e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425844 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#809878}
-
Jeff Yoon authored
enable_widevine_cdm_host_verification = false was missing from GN args for PGO Mac bots, which is causing build failures. Bug: 1128810 Change-Id: I2ccd1db80e80fd983e5f4ef0bd63908281557a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425846 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
-
Kevin Marshall authored
This is a reland of 54ad18ef Removes the Vulkan validation library from the exclusion list, since it is not reliably present across all build configurations. Original change's description: > [fuchsia] Exclude SwiftShader and Vulkan libs from CastRunner. > > Removes large libraries that were pulled in as a result of an indirect > but necessary dep on Blink. > > The exclusions can be removed along with the Blink MessagePort > dependency, once a fix for crbug.com/1126571 lands and is > integrated with NamedMessagePortConnector. > > Bug: 1131102 > Bug: 1126571 > Change-Id: I7b25d50470d667f44424b925d3982efa268c24ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424512 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809544} Bug: 1131102 Bug: 1126571 Change-Id: I3a464a21cd8b9f2c958d4243a01785ac39f7eaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424990Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#809876}
-
Kent Tamura authored
This CL ports a logic in LayoutFlexibleBox::BaselinePosition() to LayoutNG. This CL has no behavior changes because input[type=range] still uses the legacy layout. Bug: 1040826 Change-Id: If40a81d75b9fecd02c3b924501258da94b2d2369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423679 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809875}
-
Mugdha Lakhani authored
Introduces a new component for BackgroundSync so code can be shared with WebLayer. Migrates BackgroundSyncPermissionContext and its unittest. Bug: 1087486 Change-Id: Ib2968305dfa674eec81985f4ae19780ca5d6d9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421491Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#809874}
-
Oleg Davydov authored
DeviceOffHours policy operates with a "real" clock: it has to know the exact time (day, hours, minutes) to make a decision. One of things which affect real clock is suspend: from software's perspective it's a jump into future. Therefore DeviceOffHoursController caught OnSuspendDone event from the power manager to reschedule its timer. WallClockTimer is the class which automatically reschedules after suspend, therefore instead of duplicating this logic in DeviceOffHoursController we can just reuse WallClockTimer. Also this CL makes a number of changes in tests: * An access method for fake power manager client is removed from DeviceSettingsTestBase, as tests for DeviceOffHoursController were the ones which used it. * DeviceSettingsTestBase now has an additional constructor to override time source (mocked or system) for task environment it creates. This is needed because we have to mock time to test suspend, but not all other tests support mocked time. More on that in https://crbug.com/1129894. * CheckSendSuspendDone test for DeviceOffHoursController is renamed to CheckUnderSuspend, since it simulates suspend, not only checks that sending OnSuspentEvent to DeviceOffHoursController may trigger the update. Bug: b:160682243 Change-Id: I403964452e5eeb7470fd731e6760b7b0dec27456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418816Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809873}
-
Peng Huang authored
For remote desktop environment, when Vulkan is used, VANGLE is only used for WebGL. It is not responsible for rendering to the native windows (we will not create GLSurfaceEGL for native windows). We will use Vulkan swapchain to render on native windows. However some Vulkan drivers (NVIDIA) cannot be initialized successfully, if the $DISPLAY env variable is set, but the Xserver(remote desktop Xserver) doesn't have necessary extensions (NV-CONTROL, NV-GLX). To workaround this issue, this CL unsets the $DISPLAY env variable before initializing VANGLE and sets it back after it, if the Xserver doesn't support vulkan swapchain. Change-Id: I528a6f7d2f618123ea519f0ab4f15e788c4dd607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424519Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809872}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I98fc3ffa4818417fc02a92407dbf35eff8c8f601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424715 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809871}
-
Thomas Lukaszewicz authored
Add a FlexLayoutView with the various setters and getters for the FlexLayout exposed as View properties. Bug: None Change-Id: Id4380e9353c7f47774ac35a074559dc31492ab77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419135Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809870}
-
Garrett Beaty authored
The recipe-side config for the mojo builders has already been copied to the new builder group. Bug: 1131163 Change-Id: Id1d01ccdac7f242e347db02586b04bb6927b9e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427123 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#809869}
-
Kent Tamura authored
The crash is similar to crrev.com/806062. In this case, both of |line_width| and |item.InlineOffset()| are saturated to LayoutUnit::Max(), then later width computation didn't work well. This CL fixes the crash by checking the saturation, and also adds vector index checking to prevent similar issues. Bug: 1129570 Change-Id: I7b019fb09dda68b24a70cc6f4865dfa22a70ded1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423759 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Chris Thompson authored
This implements sending new SCT audit reports to the Safe Browsing servers for opted-in users. The SCTAuditingCache now sends reports using a SimpleURLLoader when new reports are sampled for sending to Safe Browsing. This reporting is configured by the SCTReportingService via a new NetworkService::ConfigureSCTAuditing() API. This redesign eliminates the round-trips between the network service and the browser process entirely by having the SCTReportingService configure which network context (and URLLoaderFactory) the SCTAuditingCache should use to send reports (in this case, we use the system network context). This also: - Removes the OnSCTReportReady Mojo API. - Moves the feature flag for opt-in SCT auditing from services/network/ into chrome/ now. - Adds the network traffic annotation for opt-in SCT auditing. - Extends the existing SCTReportingService browser tests to track whether reports sent their results to the reporting server. - Adds unittests covering reports being sent. - Adds an optimization where empty reports are stored for reports that we do not sample (and thus will never be sent to the server), rather than storing the full report object. Bug: 1082860 Change-Id: I29fd0ee1cb9c2d5c850601e0b54203363d4f8282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331755Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#809867}
-
Yulun Wu authored
ZergoQuerySearchBoxColor should be deprecated and kSearchBoxBackgroundDefault should not be used outside of the SearchBoxViewBase constructor. Bug: 1131223 Change-Id: I1f2497618d3c3bfd0fdb93c6b0f162873a2b2111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425623Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809866}
-
Elly Fong-Jones authored
Bug: 1131551 Change-Id: Ia0b99ed3a98680c7add4afe2b4f8e104d5689fda Tbr: enne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425847Reviewed-by:
-
Dave Tapuska authored
This reverts commit 5aca1315. Reason for revert: TabSearch On Mac was fixed separately not needing this revert. Original change's description: > Revert "Remove a few conversion methods on WebWidgetClient." > > This reverts commit 08741021. > > Reason for revert: Breaks TabSearch on Mac. See http://crbug.com/1131162 . > > Original change's description: > > Remove a few conversion methods on WebWidgetClient. > > > > Use the WidgetBase implementations instead of going via the > > WebWidgetClient. > > > > BUG=1097816 > > > > Change-Id: Ib08b5748806fe3862ac291d354043326d3172282 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419129 > > Reviewed-by: danakj <danakj@chromium.org> > > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#809421} > > TBR=danakj@chromium.org,dtapuska@chromium.org > > Change-Id: I4a5f560c73177acfa6d01464bc37eade2a87af62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1097816, 1131162 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424494 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809488} TBR=danakj@chromium.org,robliao@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097816 Bug: 1131162 Change-Id: I6cd02e4003b5f1dfccf3750a601704627e2f2cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425398Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#809864}
-
sandromaggi authored
The definition states that the icon to activate is its index, not index +1. Bug: b/168611883 Change-Id: I83349198e0ca4b555e01e7d0a713d5ce580ef41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424138 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#809863}
-
