- 13 Aug, 2018 40 commits
-
-
Tarun Bansal authored
The plan is to keep a close eye on bots, and disable the tests back if we see flakiness. This CL will help us understand which of the tests are failing, and also get a stack trace (which is now lost). Bug: 866212 Change-Id: I94ff8ffb7278eff1ad3533d7872c1781e1e38b67 Reviewed-on: https://chromium-review.googlesource.com/1173443Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582730}
-
Sujie Zhu authored
To simplify the logic of triggering from settings page, we need to refactor the current local_card_migration_manager: 1. Move the isServerCard to the personal_data_manager. To determine a card is whether a server card or has server dup only depends on the personal_data_manager. So later we can use this function directly without create local_card_migration_manager when we create new attribute for each credit card entry for the settings page. Add unittests in the personal_data_manager. 2. Extract the prepare migratable credit cards to a helper function. Later, when we implement checking migration requirements in the settings page, we do not need to check the migration requirement twice after we bridge back. So we can directly call PrepareMigratableCreditCard() and AttemptToOfferLocalCardMigration() for the settings page. Bug: 852904 Change-Id: I12b90054e96a9cafb6905c39608c7a5c1cbc2f8c Reviewed-on: https://chromium-review.googlesource.com/1167796Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#582729}
-
Ramya Nagarajan authored
Metrics that are logged in client code must be replicated on the remote NTP. Moved many of these to appropriate locations in Chromium code, or to most_visited_single.js, which is iframed by the remote NTP. Items captured by user interaction cannot be moved, and must be captured by the remote NTP. Opened up access to the required APIs from the remote NTP. See go/ntp-metrics-doc for more details. Bug: 855935 Change-Id: Icb0142e34cac122e6326429f8b1525a708084d09 Reviewed-on: https://chromium-review.googlesource.com/1171824Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Stephan Stross authored
Change-Id: I650d6df01f471f5f896a4fdfd48b6f3db939231e Reviewed-on: https://chromium-review.googlesource.com/1170314 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582727}
-
Tessa Nijssen authored
This is a reland of http://crrev/c/1169597 with @available checks added to TextSuggestionsTouchBarControllerTest.Offset in browser tests. When the text surrounding the current selection gets too long, only part of it is received by TextSuggestionsTouchBarController. The location of the received text within the total block of text is denoted by an offset. Previously, TextSuggestionsTouchBarController did not take this offset into account, causing crashes when the selection range was past the end of the received text. The offset is passed along with the text and selection range. The selection range within the received text is calculated using the offset and received selection range. The editing word range is stored both as the range within the received text and the range within the total text for checking when to ignore text selection updates. RenderWidgetHostView::GetOffsetForSurroundingText() was added to retrieve the offset on WebContents update. Browser tests were modified to account for the new offset parameter. A new browser test, TextSuggestionsTouchBarController.Offset, was added to test that the controller properly handles offsets. Bug: 717553 Change-Id: I83f7b3f381086118212106dff3b0b34ed8be2237 Reviewed-on: https://chromium-review.googlesource.com/1173052 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582726}
-
Weilun Shi authored
This commit fix the text highlighted problem both on cancel/done button and the custom background dialog title. Bug: 869086 Change-Id: I6e67f241409ed5498f703ec48966da0105ee5925 Reviewed-on: https://chromium-review.googlesource.com/1171792Reviewed-by:
-
Etienne Pierre-doray authored
This CL adds TaskScheduler.NumWorkers histogram to measure number of threads created in each WorkerPool every hour. Bug: 847501 Change-Id: I5e69f60320231c6ab60d62adb986eecacb15778e Reviewed-on: https://chromium-review.googlesource.com/1164242 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#582724}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: Ied2b63aaf8256033ada85c7d3367db0c4082b454 Reviewed-on: https://chromium-review.googlesource.com/1161084Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#582723}
-
Tatiana Buldina authored
Change-Id: I723ce59e3c6ee5c05bdf58ebf6d56351848a26d4 Reviewed-on: https://chromium-review.googlesource.com/1171849Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#582722}
-
Katie D authored
This reverts commit e5fb6b85, without removing the histograms from histograms.xml. These histograms were initially added to get a sense of how frequently gender was used by TTS and TTS Engine extensions, and are obsolete. TBR=dtseng@chromium.org,rockot@chromium.org Bug: 855203,871506,871511 Change-Id: Ic2625a7277d0bf277dd2f85e3460c417a64cea9c Reviewed-on: https://chromium-review.googlesource.com/1173313Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582721}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8d8a9d7701bd..8405a1536d36 git log 8d8a9d7701bd..8405a1536d36 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 dgarrett@google.com chromeos_config: Leave push_overlays enabled on tryjobs. Created with: gclient setdep -r src/third_party/chromite@8405a1536d36 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I02538ea23f3417ee7929c8dd87ba79c2215d7f6e Reviewed-on: https://chromium-review.googlesource.com/1173131Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582720}
-
Zhongyi Shi authored
Change-Id: I6abffaf9c76d1df6cd1075e446c9e739b3c91f27 Reviewed-on: https://chromium-review.googlesource.com/1168991Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582719}
-
Majid Valipour authored
This reverts commit a08572dc. Reason for revert: the original revert was a mistake. The test is flaky regardless of this CL. Original change's description: > Revert "[animation-worklet] Rename layout tests" > > This reverts commit 46b03fcf. > > Reason for revert: > > Seems to break fast/events/middleClickAutoscroll-nested-divs.html on several platforms. Example here: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34202 > > > Original change's description: > > [animation-worklet] Rename layout tests > > > > Remove "animation-worklet-' prefix from layout tests. The tests are inside AW > > directory so the prefix is just visual clutter. I kept it for tests that check > > something about the worklet itself. > > > > Note: There was a legacy unused animationworklet/visual-update-expected.html > > file that this patch replaces now. > > > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I67a36d7d5913b1394108b8a1731cc660d74f99ad > > Reviewed-on: https://chromium-review.googlesource.com/1165271 > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Reviewed-by: Yi Gu <yigu@chromium.org> > > Commit-Queue: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581552} > > TBR=majidvp@chromium.org,yigu@chromium.org > > Change-Id: If81712c7089784772b5a106159c70bdd7cbce9c8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1167766 > Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> > Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581653} TBR=hubbe@chromium.org,majidvp@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icc031d3f40d537316005f0ba7b79a6d8858c9720 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1173071 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582718}
-
John Z Wu authored
//ios/web_view will implement sync for autofill and passwords in the near future. This is one of many CLs needed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I378520039e2be7b4c5827554bad93322ad0b743d Bug: 865558 Reviewed-on: https://chromium-review.googlesource.com/1141093 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#582717}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 11484015 ("[Extensions] Add a static factory to create VerifiedContents"). Bug: 819294 Change-Id: I5fea2d0b22a0a0b70d0a8e5cd5499cb3c0735385 Reviewed-on: https://chromium-review.googlesource.com/1172786Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#582716}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db7ea8c45f39..b336c2784f5e git log db7ea8c45f39..b336c2784f5e --date=short --no-merges --format='%ad %ae %s' 2018-08-13 zstein@webrtc.org Implement serialization for ICE candidates with hostname addresses. 2018-08-13 yvesg@webrtc.org Don't depend on X11 when rtc_use_x11=false. 2018-08-13 mbonadei@webrtc.org Remove public_deps from rtc_base:protobuf_utils. Created with: gclient setdep -r src/third_party/webrtc@b336c2784f5e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d3f7029332b397c8e553ed8fd1f574378c40f3b Reviewed-on: https://chromium-review.googlesource.com/1173271Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582715}
-
sczs authored
HistoryCoordinator owns _browsingHistoryService, which is instantiated on start but its never niled on stop. Since HistoryCoordinator is long lived and never gets deallocated, _browsingHistoryService keeps listening for notifications. When the App is being shutdown _browsingHistoryService gets notified of an Auth change and HistoryTableVC (of which _browsingHistoryDriver holds a reference of) tries to react accordingly. Since the user is no longer logged in this causes a background Crash. This CL nils both pointers so they stop observing once HistoryCoordinator has been stopped. Bug: 867452 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id99b4ab481d90eca3a380d5b090631c263b65ef3 Reviewed-on: https://chromium-review.googlesource.com/1171250Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582714}
-
Scott Haseley authored
Changing the DCHECK that checks for the page scheduler being frozen when the page is visible to DumpWithoutCrashing to collect more crash dump data. Bug: 873214 Change-Id: I0f10ef13b0cf790cb38189273adf1ddc03030fc2 Reviewed-on: https://chromium-review.googlesource.com/1172709 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582713}
-
Lei Zhang authored
It now matches the Chrome-branded message. The messages used to be different because the PDF plugin was proprietary, but we open sourced the PDF plugin in 2014. Change-Id: I1104911e60a1dcf61ef6194c91eecf67730e8c17 Reviewed-on: https://chromium-review.googlesource.com/1168650Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582712}
-
Tarun Bansal authored
Use network quality tracker instead of network quality estimator (NQE) to obtain network quality in data reduction proxy component. Network quality tracker can provide network service when network service is enabled as well as when network service is disabled. data_reduction_proxy_service.h receives network quality estimates on UI thread from network quality tracker. On receiving estimates, it posts them to d_r_p_io_data which lives on IO thread, and consumes the estimates. Bug: 819244 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8a89fae921c15d5e006c9d51cb19cb6116688fb1 Reviewed-on: https://chromium-review.googlesource.com/1171592Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Removal has been postponed to M71. Bug: 800767 Change-Id: I73c3ab4b25ac3856398a639cfb8d5c08fe9aa7cc Reviewed-on: https://chromium-review.googlesource.com/1172283Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582710}
-
Tonko Sabolčec authored
The following metrics are collected: - Return value of LoginDatabase::DeleteUndecryptableLogins. - Number of deleted logins, if there is at least one deleted login. Bug: 791541 Change-Id: I899d372fd14771cbdd43b03e0340b4b473d1de4f Reviewed-on: https://chromium-review.googlesource.com/1165346 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582709}
-
Philip Rogers authored
https://crrev.com/581383 removed a preferred size timer and started synchronously updating preferred sizes in DidUpdateMainFrameLayout. This caused a performance regression because, even though layout is up-to-date, the preferred contents size may need to be re-computed. Script can cause many layouts per frame which was a performance regression because many multiple preferred contents size updates are now occurring per frame. This patch adds a bool for if a layout occurred which may have changed the preferred content size, and defers the update until after the commit. Bug: 872599 Change-Id: Idfe1ba523b1ecfdf8f959bafc2e20ef6a52487bb Reviewed-on: https://chromium-review.googlesource.com/1172059 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Dan Sanders authored
I was unable to find a MF/DXVA API to retrieve this, so the value is extracted by the config change detector. If there is a platform API, it would (probably) be better, since the behavior would be more likely to match decoder quirks. Bug: 869660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6802c682534f91499a27da7135acc74cbc61911f Reviewed-on: https://chromium-review.googlesource.com/1170096 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582707}
-
Moe Ahmadi authored
Takes Autofill Settings strings related to the new address and credit card toggles to components/autofill_strings.grpd to share on all platforms. Bug: 873215 Change-Id: I358455a33734650dceed1196385d5262efa5b90a Reviewed-on: https://chromium-review.googlesource.com/1171560Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582706}
-
Luna Lu authored
When the device pixel ratio is > 1, image with (device_pixel_ratio * container_size * max_downscaling_ratio) pixels should be allowed by max-downscaling-image policy. BUG:858897 Change-Id: Ic85e79e487c77296556c69b5dc5872e85b22d23e Reviewed-on: https://chromium-review.googlesource.com/1170853Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#582705}
-
Robert Liao authored
This is part 2 of 3 for aligning BubbleDialogDelegateView with its filename. BUG=873422 TBR=sky@chromium.org Change-Id: I98721ecb7ad384aa74f9a8129e6f73433b06b856 Reviewed-on: https://chromium-review.googlesource.com/1171918Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582704}
-
Kevin Marshall authored
The "latest" package ref can be used by clients to discover the most recently built package instance. Given that instance, the client can use "cipd describe" to get the package version, which can be used to select the instances of related packages that were built and pushed at the same repo revision. Bug: 869197 Change-Id: I09de4669a93e07f2546f0dfea088f733870ee267 Reviewed-on: https://chromium-review.googlesource.com/1173053Reviewed-by:
James Robinson <jamesr@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582703}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a745cdf1c11f..5059c2eca07a git log a745cdf1c11f..5059c2eca07a --date=short --no-merges --format='%ad %ae %s' 2018-08-13 primiano@google.com Merge "perfetto-ui: Add CanvasRedrawTrigger" Created with: gclient setdep -r src/third_party/perfetto@5059c2eca07a The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8aea7e3adf2c1b2df848cc552c4f5342cb7ce43b Reviewed-on: https://chromium-review.googlesource.com/1172705Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582702}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/6fd9d0244c7d..b8642738c985 $ git log 6fd9d0244..b8642738c --date=short --no-merges --format='%ad %ae %s' 2018-08-11 marpan vp9-svc: Fix to updated SET_SVC_REF_FRAME_CONFIG control 2018-08-09 jianj Refactor: Move code updating ref frames for svc & denoiser. 2018-08-10 jianj Fix frame drop threshold in vp9 datarate test. 2018-08-08 marpan vp9: Allow for overshoot detection for non-screen CBR mode. 2018-08-09 jianj Change target bitrate in vp9 datarate test. 2018-08-08 huisu Use the pred_mv feature for speed 0 2018-08-06 jianj vp9-svc: Update to SET/GET_SVC_REF_FRAME_CONFIG api 2018-08-09 marpan vp9-svc: Fix for scene detection for SVC 2018-08-09 jianj replace video clips used in vp9 datarate CBR tests. 2018-08-07 jzern loop_filter_rows_mt: use sb_rows to limit workers 2018-08-07 jzern test/stress.sh: switch req. for 100 threads to 64 2018-08-06 huisu Add enhanced_full_pixel_motion_search feature 2018-08-07 jzern vpx_highbd_d153_predictor_4x4_sse2: reduce load size 2018-08-03 johannkoenig vp9: address integer sanitizer warning 2018-08-06 jianj vp9 test: Enable aq 3 and error resilient in realtime for layers. 2018-08-03 huisu Remove unnecessary calls to load_pred_mv() 2018-08-03 mbonadei vpxenc: replace uint16 with uint16_t 2018-08-03 wtc Fix typos in the comment for size_group_lookup. 2018-08-02 jianj vp9: new struct BEST_PICKMODE containing search results. 2018-07-24 slavarnway VPX: Improve HBD vpx_hadamard_32x32_sse2() Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=b/112292577 Change-Id: I66aca1cf24164d8aeac1cdc44dfc68dc2cf96c65 Reviewed-on: https://chromium-review.googlesource.com/1172933Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#582701}
-
Scott Violet authored
Env should always be created here, and always have a mode of LOCAL. BUG=847992 TEST=covered by tests Change-Id: I27789a9633eff910b9a950fbd44c4ece967f02c9 Reviewed-on: https://chromium-review.googlesource.com/1173328Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582700}
-
Timothy Gu authored
The "element_document.ExecutingFrame()" check is identical to what the HTML Standard calls "the node's node document has a browsing context," which belongs in step 11. Also per kouhei@'s request, add a TODO for switching to ExecutingWindow rather than ExecutingFrame. Change-Id: I653d303861c0e02e65d7e5de466fecd90a4806d1 Reviewed-on: https://chromium-review.googlesource.com/1171988 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#582699}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates RLZTracker and FinancialPing away from URLFetcher. Bug=773295,844989 Change-Id: I07fc8d09b359727ad8649e38355dd6af2bc60b02 Reviewed-on: https://chromium-review.googlesource.com/1142749 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582698}
-
erikchen authored
The logic is implemented for Windows, macOS and Linux. It may add non-neglible overhead, since it adds calls to base::TimeTicks::Now() to every posted task. It will be turned on behind an experiment so that we can measure the impact. Bug: 859155 Change-Id: I47c2a4629470d892dcb416a3b2121ef37b87ac8c Reviewed-on: https://chromium-review.googlesource.com/1172913Reviewed-by:
-
Fernando Serboncini authored
TBR=behdad Bug: 870379 Change-Id: I369278f36a6896c07fc5d945a76e4d41d30da87a Reviewed-on: https://chromium-review.googlesource.com/1160600Reviewed-by:
Behdad Esfahbod <behdad@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582696}
-
sunxd authored
The test was previously disabled due to being flaky. Now that the fixing patch was landed, we should enable this test again. Bug: 869314 Change-Id: I7faf6103cd1d5232d058494fe3c4e3018fe96db6 Reviewed-on: https://chromium-review.googlesource.com/1173267Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#582695}
-
Mustafa Emre Acer authored
Chrome displays a navigation suggestion for sites that are lookalikes of popular sites (1), or sites that the user has engaged before (2). As an example for (1): if the user visits https://googlé[.]com, Chrome will display "Did you mean to go to https://google.com". This CL prevents showing this UI if the user engaged with the lookalike domain in the past. In the example above, Chrome will not display a "Did you mean to go to https://google.com" if the user has a site engagement score for googlé.com. Bug: 843361 Change-Id: I583da6de071b86026e3f75ea727e33ef635beb6e Reviewed-on: https://chromium-review.googlesource.com/1167981 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582694}
-
Aldo Culquicondor authored
And enabling check for the whole chrome/browser/android directory. Bug: 871623 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If89ad40bfe133451efc0fd27867e4f939404478a Reviewed-on: https://chromium-review.googlesource.com/1165497Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#582693}
-
Ella Ge authored
The scroll amount passed into BrowserViewRenderer::ScrollTo is physical pixel with page_scale_factor applied. Before --use-zoom-for-dsf enabled, the scroll amount was divided by both dip_scale_ and page_scale_factor_ to convert to scroll amount in dip. With the flag enabled, it still need to divide by the page_scale_factor, but it incorrectly passed the original offset without take page_scale_factor into account, causes scroll amount larger than the max_scroll_offset. When --use-zoom-for-dsf is enabled, scroll_offset_dip_ and max_scroll_offset_dip_ are convert from/to physical pixel in every it get used. We shouldn't stored them in dip. So, this cl changes scroll_offset_dip_ to scroll_offset_unscaled_ and max_scroll_offset_dip_ to max_scroll_offset_unscaled_, as they were in physical pixel when zoom-for-dsf enabled, and dip otherwise. Instead of having dip_scale applied every time it was set. TEST: webview_ui_test.test.DropDownListTest#testDropDownScaledViewPortUseWideViewPort Bug: 869995, 873617 Change-Id: I694ca54438620e7afdf8db210704f40fb2c1ba54 Reviewed-on: https://chromium-review.googlesource.com/1162519Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#582692}
-
Shakti Sahu authored
This CL adds a RoundedCornerImageView which programmatically rounds the corners of an image with given radii. The hairline border for the thumbnail is set as part of the background for the parent card layout. Also the rounding is done on the final image to be shown on the canvas after the scale type, margin, padding etc has been applied. Bug: 850578 Change-Id: I9b80e7e9140277061ce1b4d398da5d65950e279a Reviewed-on: https://chromium-review.googlesource.com/1164174Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582691}
-
