- 03 Oct, 2018 40 commits
-
-
Joe Downing authored
We've seen a few bugs filed recently for problems related to capturing key events via the low-level hook on Windows. These have all turned out to be related to the fact that the low-level hook intercepts the key events before the OS can update its internal state. An example problem is that WM_CHAR messages are not generated if the hook captures the alpha keys. Since the goal of the hook is to intercept/prevent system key combos, I have decided to invert the logic for the Windows version of the KeyboardHook. Now the hook will only handle Alt, Ctrl, and Win keys. Shift is not intercepted as I want the OS to process it so the correct chars are produced for WM_CHAR messages. The result is that the hook is a bit less powerful / flexible with respect to what it can be asked to capture, however when lock() is called w/o parameters the API will block system combos and the key events the webpage will receive will be the same whether the hook is active or not. This is not a problem on other platforms as ChromeOS/Linux have a 'passive' hook where the key state is calculated before the events are passed to us. MacOS would use an active hook however it hasn't been implemented yet. BUG=872396 Change-Id: I8dc2416f4ad026a66e766aa3610835612e5bdccc Reviewed-on: https://chromium-review.googlesource.com/c/1162700Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#596106}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Ib32f16feb0b8cabb2fd38fd841b67eac72555c6e Reviewed-on: https://chromium-review.googlesource.com/c/1258288Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#596105}
-
Chris Blume authored
Building Chromium for Android currently does not support Vulkan. However, Vulkan headers were accidentally being included anyway. This was causing a redefinition error when Skia opted to always include Vulkan but only use it when requested. This patch puts the Vulkan includes behind a flag to match existing gating. BUG=891525 Change-Id: I88b759451a6353a762ea65cdbe34a4c467799ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1257651Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#596104}
-
Tetsui Ohkubo authored
In order to prevent mistouch, we should hide some Shelf icons while ARC++ keyboard is open. It's not limited to ARC++ virtual keyboard, and also affects Chrome OS virtual keyboards. However, they are shown above Shelf, so visually they won't change. This CL hides: * App icons on the shelf * Tray buttons e.g. System Tray, overview mode, etc. This CL does not hide: * Back & Launcher buttons * Keyboard tray button See the mock on the design doc for detail: go/androidime-on-cros TEST=manual BUG=882373 Change-Id: I75c07e25dcf16a1b987047093d172f68295ae480 Reviewed-on: https://chromium-review.googlesource.com/c/1250761 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596103}
-
Sunny Sachanandani authored
Record the overlay format chosen at startup, and format used at runtime for every swap chain. Replace existing histograms which don't work correctly, or work well with multiple swap chain formats. Add a histogram for CreateSwapChain... result for each format to see if using NV12 causes more failures than YUY2. Bug: 869677 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie11dcaee6c9be6c6985a98dc01d7d0219b611988 Reviewed-on: https://chromium-review.googlesource.com/c/1258003Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#596102}
-
Gang Wu authored
got a bug about encoding and decoding, basically it is because covert between string and bytes in JAVA will be wrong if there are negative numbers, so covert them in C++ to avoid it. Bug: 889623 Change-Id: If6916ef30860bc1c3017c95447da6d95669fe793 Reviewed-on: https://chromium-review.googlesource.com/c/1253078Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596101}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0c56d6362b95..a1c846c4cf3f git log 0c56d6362b95..a1c846c4cf3f --date=short --no-merges --format='%ad %ae %s' 2018-10-02 thestig@chromium.org Clean up some XFA forward declarations. 2018-10-02 thestig@chromium.org Avoid overloading CFGAS_FontMgr::LoadFont(). Created with: gclient setdep -r src/third_party/pdfium@a1c846c4cf3f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3d70f3fa56add897a127ac1777e9ae3584441e79 Reviewed-on: https://chromium-review.googlesource.com/c/1258408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596100}
-
Eugene Kim authored
This patch simplifies conditions around the code in ui/ It is much easier to write & read: if (base::ContainsValue(my_vector, my_search_value)) than: if (std::find(my_vector.begin(), my_vector.end(), my_search_value) != my_vector.end()) Bug: 561800 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25733c6a308664b8215bd300a7b85baac90acd33 Reviewed-on: https://chromium-review.googlesource.com/c/1218804Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2be958cd896f..9bebca3c7eec Created with: gclient setdep -r src-internal@9bebca3c7eec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: Ib56f92b26397e280f731d282a7b40e2aa464d1b9 Reviewed-on: https://chromium-review.googlesource.com/c/1258253Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596098}
-
Miyoung Shin authored
This CL supports to write/read the multiple file names for dragging on Mac. BUG=878690 Rename the email self in AUTHORS Change-Id: I3bba2912ad5f89de7e8fb106c89c8f4eb6468935 Reviewed-on: https://chromium-review.googlesource.com/c/1256791Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596097}
-
Zhenyao Mo authored
With --underlay, we add a div on top of video to make sure video layer is an underlay. Note that without --underlay, the video could still be an underlay due to controls, ads, logo, etc. At the moment we don't have a way to force overlay mode. BUG=867155 TEST=manual R=kainino@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If86f759b7f8bc13022b5f24a1031d7e0be3aef3a Reviewed-on: https://chromium-review.googlesource.com/c/1258315Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596096}
-
Kouhei Ueno authored
Bug: 890180 Change-Id: I36d8b9b7d133104dc6dae34c465fa4dc08a7a26b Reviewed-on: https://chromium-review.googlesource.com/c/1253162 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Joel Hockey authored
FileNotFound is the correct error that should be thrown in this case, and is consistent with the handling in VolumeInfoImpl.prototype.resolveTeamDrivesRoot_. Bug: 891562 Change-Id: I41e663a47c6f51190bb2344969a8eca6df36b3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1258662Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596094}
-
rbpotter authored
Ensure that all is not reselected when an invalid input is cleared. Similar to scaling, achieve this by not resetting the backing pages value (or its validity) when an invalid input is cleared. This also saves a preview refresh. Also adding tests for some pages behaviors from this and prior CLs. Bug: 890670 Change-Id: I34285b311f7abd0c992557151f90867cd36cb375 Reviewed-on: https://chromium-review.googlesource.com/c/1256624Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596093}
-
Carlos Knippschild authored
The webview tag is supposed to be used as an iframe replacement, with added security restrictions to the web content loaded inside of it. In a previous CL it was introduced in the dino page code incorrectly, as a regular tag just wrapping the security sensitive content. This change reverts that so not to serve a wrong example. TBR=edwardjung@chromium.org Bug: 852872 Change-Id: I06d74b6e648793a90cfebf4db198f004073a2f2c Reviewed-on: https://chromium-review.googlesource.com/c/1258251Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#596092}
-
Adrienne Walker authored
Now that Skia is running GL directly as a part of OOP-R, it means that the keep alive mechanisms for the command buffer are no longer being applied. If any part of Skia runs long, then the watch dog hang detector will kill the gpu process. In particular, the gpu command buffer does this via: * ContextGroup::ReportProgress * GLES2DecoderImpl::ReportProgress * GLES2DecoderImpl::ExitCommandProcessingEarly ...which all wind up eventually in GpuWatchdogThread::ReportProgress. This fixes this by hooking up CreateGrGLInterface to ReportProgress on several "slow" calls. Bug: 884804, 887939 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I84f2dc92670de3f1dd1ca7e0e8aa85c2d08a4858 Reviewed-on: https://chromium-review.googlesource.com/c/1242033 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
chrome://flagsAdam Klein authored
It's been on by default for awhile. And it remains available in V8 (and thus in Chrome via --js-flags) as "--validate-asm". Also move the virtual test suite to a non-virtual location. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib085f4339cf37d686f76f571dae0b45603391d18 Reviewed-on: https://chromium-review.googlesource.com/c/1239433 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596090}
-
Ted Meyer authored
Completes: - D3D11VP9Accelerator::SubmitDecode - D3D11VP9Accelerator::OutputPicture - D3D11VP9Accelerator::CreateVP9Picture Which are the three methods required to successfully implement a VP9Accelerator class. Bug: 881922 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6af7ebb07b53febf4797c1849a976b1ce8424df1 Reviewed-on: https://chromium-review.googlesource.com/c/1244664 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#596089}
-
Jeremy Klein authored
Align the body contents with the dialog title by just removing an unneeded css class. Screenshot: http://screen/ajbr1Bsq4kB Bug: 883906 Change-Id: I54baadb308c54b440f1fbdc99d8bc5572e135cba Reviewed-on: https://chromium-review.googlesource.com/c/1258506 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596088}
-
Victor Vasiliev authored
Update QUIC feature flags to the state as of Tue Oct 2 15:08:15 EDT 2018 https://chromium-review.googlesource.com/c/chromium/src/+/1258028 Replace QuicUrlUtils with GURL. Merge internal change: 214964597 https://chromium-review.googlesource.com/c/1256143/ Implement QPACK encoder stream. The encoder stream is a unidirectional stream, so the two endpoints hold it differently. The endpoint that creates the stream has a QpackEncoderStreamSender instance that its QpackEncoder uses. The other side creates a QpackEncoderStreamReceiver instance when it receives the opening data from its peer and notifies its QpackDecoder. Of course each connection has two separate encoder streams corresponding to two independent compression contexts, so every endpoint will end up having one QpackEncoder, one QpackDecoder, one QpackEncoderStreamSender, and one QpackEncoderStreamReceiver. Merge internal change: 214847161 https://chromium-review.googlesource.com/c/1255664/ Fix hex string in QpackEncoderStreamReceiverTest.InsertWithNameReferenceIndexTooLarge. Hex encoded string had odd length; add one character. Merge internal change: 215318537 https://chromium-review.googlesource.com/c/1255664/ Refactor QpackDecoder States. 1. Split up DoNameString() into two methods: DoReadName(), which continues reading the headename, and DoDecodeName(), which does the optional Huffman decoding. Same with DoValueString(). This makes states more atomic and therefore maybe easier to reason about. 2. Add comments to explain the awkward difference between handling empty names and empty values. (The other option would be to handle empty names the same way, which feels wrong because they should never occur in HTTP, but QPACK does not forbid them.) Merge internal change: 214688919 https://chromium-review.googlesource.com/c/1254583/ Get rid of QuicControlFrame. No functional change, not protected. The only thing QuicControlFrame saves the derived classes from doing is to provide a default value(kInvalidControlFrameId), this can easily be done the derived classes too. Merge internal change: 214649060 https://chromium-review.googlesource.com/c/1254582/ Remove QuicSentPacketManager.HasUnackedPackets(), because it is misleading and should not be used externally. Merge internal change: 214612735 https://chromium-review.googlesource.com/c/1254581/ Fix QUIC's path degrading alarm so it is is not set on the server and uses HasInFlightPackets() instead of HasUnackedPackets(). Protected by FLAGS_quic_reloadable_flag_quic_fix_path_degrading_alarm. Merge internal change: 214705628 https://chromium-review.googlesource.com/c/1254581/ Modify QuicSentPacketManagerTest.GetTransmissionTimeCryptoHandshake to verify the exponential backoff of crypto packet retransmission timeout. For v39+, last_crypto_packet_sent_time_ gets updated each time a crypto packet gets sent. For v39-, last_crypto_packet_sent_time_ does not get updated for retransmitted crypto packets. Merge internal change: 214603426 https://chromium-review.googlesource.com/c/1254472/ Deprecate FLAGS_quic_reloadable_flag_quic_fix_retransmit_lost_data. Merge internal change: 214593916 https://chromium-review.googlesource.com/c/1254422/ Move checks on stream ID limits into common method in QuicStream Flag Protected by FLAGS_quic_use_common_stream_check This CL moves functionality that is common for checking on whether the limit on stream creation has been reached into a common QuicStream method. This work is preparatory to adding Version-99/IETF-QUIC's stream ID limits. Merge internal change: 214588549 https://chromium-review.googlesource.com/c/1254482/ Pull all inlined quic frames out of the anonymous struct within QuicFrame. No functional change, not protected. This is similar to what CL 210144041 did to the QuicStreamFrame. By doing this to all inlined frames, the anonymous struct will not contain anything with custom constructors, this allows the code to compile under GCC. The chromium bug for the compile issue with this code is https://bugs.chromium.org/p/chromium/issues/detail?id=882347#c6. The (more general) GCC bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77314 Merge internal change: 214536295 https://chromium-review.googlesource.com/c/1254469/ Rename EncodeHeaderSet() to EncodeHeaderList(). Because I renamed header set to header list in the QPACK draft at https://github.com/quicwg/base-drafts/pull/1725. (For some reason the argument of EncodeHeaderSet() was already called |header_list|.) n/a (Prototype code not in production yet.) Merge internal change: 214481848 https://chromium-review.googlesource.com/c/1254468/ Do not use std::string in QPACK code. Use QuicString instead. Merge internal change: 214457698 https://chromium-review.googlesource.com/c/1254467/ Enable timestamps in QUIC ack frames in QuaRTC. Merge internal change: 214450843 https://chromium-review.googlesource.com/c/1254481/ Remove unused QuicTestRandom class from QUIC platform. Merge internal change: 214341130 https://chromium-review.googlesource.com/c/1254465/ Change the vector of static streams in QuicWriteBlockedList from std::vector to QuicInlinedVector. Data structure change, not protected. Merge internal change: 214277121 https://chromium-review.googlesource.com/c/1254463/ Remove unused should_process_data from TestStream's constructor. Merge internal change: 214266461 https://chromium-review.googlesource.com/c/1254461/ Add framer support for IETF QUIC NEW_TOKEN frame. This change adds framer support for the NEW_TOKEN frame defined in IETF QUIC. Frames can be parsed and generated for Verion 99/IETF QUIC packets. Higher level code, to request generation of a NEW_TOKEN frame, or handle receipt of one, is not included in this C/L. Merge internal change: 214257180 https://chromium-review.googlesource.com/c/1254421/ R=bnc@chromium.org Change-Id: Ib8c6977043d47472968b0a5ca9653c38fe13c839 Reviewed-on: https://chromium-review.googlesource.com/c/1258029 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596087}
-
Christian Fremerey authored
When shutting down the service after an idle timeout, cached information about supported device formats is lost. Re-querying these from the OS can take several seconds on certain Android devices. To avoid this, this CL keeps the service alive indefinitely on Android. Bug: 878304, 792621 Change-Id: Ia031319d2f471e6359f248ae5c0b76208df77c54 Reviewed-on: https://chromium-review.googlesource.com/c/1231894 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#596086}
-
Kuo-Hsin Yang authored
The protected tabs (tabs that CanDiscard() returns false) have lower discard priority. When system is in low memory and all remaining tabs are protected, some protected tab shall be discarded to avoid OOM. Bug: 885087 Change-Id: I073a4946e82898a7f16c2ef11441e342c58b99e8 Reviewed-on: https://chromium-review.googlesource.com/c/1250823Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596085}
-
David Black authored
Per request, revising the strings for Google Assistant that appear in Chrome Settings and OOBE. See bug for before/after and spec. Bug: b:117154093 Change-Id: I00fcd6e42939462e6b711036d4b0e2630fe1706f Reviewed-on: https://chromium-review.googlesource.com/c/1257152Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#596084}
-
Kent Tamura authored
These tools will be removed later. Bug: 829697 Change-Id: I364447a74a1b88c72bfc161195430fd9d4c36ba8 Reviewed-on: https://chromium-review.googlesource.com/c/1256386Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#596083}
-
Joshua Peraza authored
7786acf0d7a2 win: move string_number_conversion_test asan/dll disabling into the win clause 0ad7e1fbbe29 [fuchsia] disable MinidumpStringWriter.ConvertInvalidUTF8ToUTF16 39d73623dd1e Add jperaza to CONTRIBUTORS 91781418bc4e linux: Add CrashWithoutDump() Change-Id: If1fb0547ef2071100ef016026f65ac99cbd74357 Reviewed-on: https://chromium-review.googlesource.com/c/1258318Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#596082}
-
Brice Tebbs authored
By default, ArCore returns hits for planes which are much larger than the actual area detected by ArCore. This can cause objects to appear to be floating off the edge of a table for example. This CL changes the algorithm to request ArCore to do a more exact check on planar trackables. The code also limits hits to planar trackables only, which removes some spurious hits with Point Clouds. As more trackable types are supported by ArCore we should probably revist this. Adjust the current hitTest code in the following ways: 1) Ignore all hits on trackables other than Planes 2) Walk the hits returned from AR Core in back to front order 3) When we have found at least one hit, then restrict any subsequent hits we return to those that are within the polygon which ArCore detected for the plane. We assume the first hit is the floor and likely to extend beyond the currently detected area. Bug: 872855 Change-Id: I2649bf10d16b09152f077cd8b9fb2c6fe261162c Reviewed-on: https://chromium-review.googlesource.com/c/1173446 Commit-Queue: Brice Tebbs <btebbs@chromium.org> Reviewed-by:David Dorwin <ddorwin@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#596081}
-
CJ DiMeglio authored
When Talkback reads the media controls, it was reading both the name and description of the control. For most of the controls, the name and description were pretty similar, if not the same, so instead of getting useful information, the user just gets the same thing said twice. this change prevents this by return an empty string instead of the help string. Bug: 560566 Change-Id: Id7c0fb95c779898a8bfe05d0d08fd42323098887 Reviewed-on: https://chromium-review.googlesource.com/c/1244583Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#596080}
-
Peter Kotwicz authored
BUG=883301 Change-Id: I846477189f74726f2f3c2cc0f2f7ac78964fd48c Reviewed-on: https://chromium-review.googlesource.com/c/1256003 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596079}
-
Nico Weber authored
The mac implementation was hidden behind `defined(MAC_VIEWS_BROWSER)` instead of `BUILDFLAG(MAC_VIEWS_BROWSER)` and hence was never enabled. Since BUILDFLAG(MAC_VIEWS_BROWSER) is now always true, just remove the check. Bug: 849020 Change-Id: Ib4e9217304363d2d6e5ace4f1d44271ed6de1bfe Reviewed-on: https://chromium-review.googlesource.com/c/1258027Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596078}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 890902 Change-Id: Ie6085e93e6ab5d0a693a726433356f55cf8b53a7 Reviewed-on: https://chromium-review.googlesource.com/c/1257851 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#596077}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /cc. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=ericrk@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I398d6825bee96b0612611c4b530a0ed458fd8e0a Reviewed-on: https://chromium-review.googlesource.com/c/1257850Reviewed-by:
-
Dmitry Gozman authored
This is an implementation of mojom::DevToolsAgent which will be reused for workers in WorkerInspectorController. After switching workers to mojo, we'll merge InspectorSession into DevToolsAgent::Session. Bug: 775132 Change-Id: I180e62df147b6f256e09eeb1a44779151920471a Reviewed-on: https://chromium-review.googlesource.com/c/1258209 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596075}
-
Bence Béky authored
* Update hugely out-of-date comment for SpdySession::GetPushedStream(). * Drop unused |stream_net_log| argument. * Do not reset |*stream| upon error. The only production call site is in SpdyHttpStream::InitializeStream(), where |stream_| is already guaranteed to be nullptr when GetPushedStream() is called, see DCHECK in line 139. Change-Id: I4b7b5738dd171df9f01fc1bfd7ddec8376985e08 Reviewed-on: https://chromium-review.googlesource.com/c/1257442Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596074}
-
Thomas Guilbert authored
This feature will be used in downstream code to exclude certain devices known to have issues with certain, limited casting scenarios. The devices will be filtered based off of their model name. Bug: 109926233 Change-Id: I4c9fee542fb72db532cc0a2563c45142bc84e961 Reviewed-on: https://chromium-review.googlesource.com/c/1258312Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#596073}
-
Dan Sanders authored
VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED must be retained until all reads have been completed. Such frames are produced when software frames are uploaded to GpuMemoryBuffers. The VideoResourceUpdater handles this, but PaintCanvasVideoRenderer implemented only sync tokens. As a result, WebGL reads of software-decoded frames can tear when the storage is reused for later frames. This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to the VideoFrame until it completes. This ensures that the memory is not reused until after the reads complete in the GPU process. TBR=tedchoc@chromium.org,pfeldman@chromium.org Bug: 819914 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Change-Id: Iec05d3bca69e68ae3d3b231db84caa9bed24d777 Reviewed-on: https://chromium-review.googlesource.com/c/1258212 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
Luis Hector Chavez authored
I'm not going going to be watching ARC-related changes going forward. Bug: None Change-Id: I606c46f81e39cf00ce7eb3611fc96c8a628730e2 Reviewed-on: https://chromium-review.googlesource.com/c/1258602Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#596071}
-
Dmitry Gozman authored
We already pass WebFrameLoadType around, which controls whether we should replace the current history item or not. TBR=mmenke@chromium.org Bug: none Change-Id: Ifd0ac92396334dac14bd4822c7a4f702e31b265e Reviewed-on: https://chromium-review.googlesource.com/c/1246419 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64ba5a302bf0..2be958cd896f Created with: gclient setdep -r src-internal@2be958cd896f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:888064,chromium:891313 TBR=mmoss@chromium.org Change-Id: I4d15bfac9610f58b70a294324daec7393d1dac58 Reviewed-on: https://chromium-review.googlesource.com/c/1258403Reviewed-by:
-
Steve Anton authored
This CL implements the RTCQuicTransport createStream method and the corresponding quicstream event hooked up to the QUIC adapters. It also implements RTCQuicStream.reset/finish and statechange event to allow end-to-end testing. Bug: 874296 Change-Id: I331d37f3e21c606697b8768bf9eea59c90487163 Reviewed-on: https://chromium-review.googlesource.com/c/1217846 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596068}
-
Alexey Baskakov authored
This reverts commit dec38a71. Reason for revert: Crashes browser_tests. Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933735011043353616/+/steps/browser_tests/0/stdout Original change's description: > CrOS FilesApp: Share crostini entries before opening > > When a user opens files within Downloads using a crostini app, > show a dialog for the user to give permission to share the > directory that the files are in with crostini. > > * Move handling of 'crostin-files' flag checking into > foreground/js/crostini.js > * Change FileTasks.executeInternal to detect files that > can be shared with crostini and do sharing before execute. > * UI Test verifies share dialog is shown before execute. > * ConvertFileSystemURLToPathInsideCrostini maps > path from within Downloads to '/ChromeOS/Downloads/...' > > Bug: 878324 > Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 > Reviewed-on: https://chromium-review.googlesource.com/c/1243871 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596003} TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org,lucmult@chromium.org Change-Id: I553be4bfe6c0fad8435383c70b44a420237b250b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878324 Reviewed-on: https://chromium-review.googlesource.com/c/1258622Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596067}
-
