GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8888021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113875 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8885018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113874 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8869003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113873 0039d316-1c4b-4281-b951-d872f2087c98

scripts.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8892015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113872 0039d316-1c4b-4281-b951-d872f2087c98

DownloadsTest.testBigZip to be specific

BUG=107050
TEST=tree gets a little bit greener

Review URL: http://codereview.chromium.org/8901001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113871 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8879039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106208

Review URL: http://codereview.chromium.org/8865005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113868 0039d316-1c4b-4281-b951-d872f2087c98

These ones are slightly darker

BUG=100775
TEST=

Review URL: http://codereview.chromium.org/8893011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113867 0039d316-1c4b-4281-b951-d872f2087c98

Giving it more time to bake.

BUG=none
TEST=tests updated


Review URL: http://codereview.chromium.org/8863011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113866 0039d316-1c4b-4281-b951-d872f2087c98

inherited from the base class.

Manual changes only to spdy_protocol.h, the rest of the CL generated by
running and then manually fixing the one 80 col violation:

 perl -pi -e "s/SpdyControlFrame::size\(\)/SpdyControlFrame::kHeaderSize/"  $(git grep -l SpdyControlFrame::size)

This is the same as the google-internal CL 25980588

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8898003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113865 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8487002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113864 0039d316-1c4b-4281-b951-d872f2087c98

out correct button state in mouse moves.

BUG=none
TEST=none
R=oshima@chromium.org


Review URL: http://codereview.chromium.org/8872057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102685
TEST=NONE
R= estade@chromium.org, sail@chromium.org, jeffreyc@chromium.org

Review URL: http://codereview.chromium.org/8822024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113862 0039d316-1c4b-4281-b951-d872f2087c98

This is also removing the UpdateRect ack in the accelerated compositing case,
because it is not needed (and adds scheduling constraints that reduce
throughput).

This also sends a "dummy" message to the browser to unblock the UI thread if it's waiting on an UpdateRect when the transition from non-accelerated to accelerated happens: the GPU process may need to round trip to the browser UI thread before sending the SwapBuffers callback.

BUG=58782
TEST=reduced jankiness on aura builds when resizing.


Review URL: http://codereview.chromium.org/8498036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113861 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nkostylev@chromium.org
BUG=106473
TEST=Lock screen, observe that launcher icons are no longer visible.

Review URL: http://codereview.chromium.org/8899001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104248
TEST=chrome: about:gpu and webgl pages (both aura and gtk), compositor_unittests, views_unittests


Review URL: http://codereview.chromium.org/8890042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=self


Review URL: http://codereview.chromium.org/8873038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23931
TEST=import incorrect and correctly formatted ONC files


Review URL: http://codereview.chromium.org/8879029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113856 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=106897
TEST=cursor appears in a textfield on focus.

Review URL: http://codereview.chromium.org/8879049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113855 0039d316-1c4b-4281-b951-d872f2087c98

- Fix the memory leak in PluginImageData.
- Fix the out-of-bound memory access in mouselock NaCl example.

BUG=106779
TEST=mouselock NaCl example won't crash after a while (~30 seconds).

Review URL: http://codereview.chromium.org/8872045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.

Review URL: http://codereview.chromium.org/8894007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113853 0039d316-1c4b-4281-b951-d872f2087c98

Fix issue where a crash in the cloud print connector on shutdown will prevent the enable pref change from being persisted.
Moves the write of the pref to earlier in the shutdown process so that if a crash occurs the pref will still be recorded.

BUG=106919
TEST=Verify 106919


Review URL: http://codereview.chromium.org/8879040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8888037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113851 0039d316-1c4b-4281-b951-d872f2087c98

When defined USE_XI2_MT, slot id of TouchEvent is maintained
by a map of tracking id to slot id. Because tracking id will
always keep increasing. The item should be released by TouchRelease
to free the slot id for future use.

BUG=106673
TEST=Manually Tested


Review URL: http://codereview.chromium.org/8839004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107024
TEST=sync data

Review URL: http://codereview.chromium.org/8897015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113849 0039d316-1c4b-4281-b951-d872f2087c98

Previously we would reject requests with pinning errors at the URLRequest layer
but, by that time, we would already have sent cookies.

The commenting of the #ifdef is deliberate - it allows the builders to chew the
code over. Once the builders are happy I'll land another change to uncomment
the #ifdefs.

This also happens to start unpicking the DNS certificate provenance stuff.

BUG=none
TEST=Verify that https://pinningtest.appspot.com fails to load in offical builds.

Review URL: http://codereview.chromium.org/8865006

TBR=agl@chromium.org
Review URL: http://codereview.chromium.org/8896012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113846 0039d316-1c4b-4281-b951-d872f2087c98

This suppression is too broad, and I can't reproduce the original stack trace I
saw anyway, so let's remove this for now and see if it comes up on the bots.

TBR=timurrrr@chromium.org
BUG=96010
TEST=drm release bot

Review URL: http://codereview.chromium.org/8895005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113844 0039d316-1c4b-4281-b951-d872f2087c98

Not the final UI yet.
Additional improvements:
- file name is selected in save-as dialog at start;
- new folder moved to context menu, button deleted.

BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549
TEST=Manual

Review URL: http://codereview.chromium.org/8554003

TBR=dgozman@chromium.org

seems to have broken Linux Chromeos bot:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2359/steps/browser_tests/logs/stdio
Review URL: http://codereview.chromium.org/8898009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=run_all_tests

Review URL: http://codereview.chromium.org/8893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113839 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8872046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113837 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106951
TEST=With a fresh Chrome, create a second profile. Ensure that the original shortcut is modified to point to the first profile. If you check the shortcut, the argument to chrome.exe should include something like --profile-directory="Default".

Review URL: http://codereview.chromium.org/8897002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113836 0039d316-1c4b-4281-b951-d872f2087c98

With multiple profiles we would sometimes crash with the following backtrace:
   ProfileImpl::~ProfileImpl
    ProfileDependencyManager::DestroyProfileServices
      ...
       ProfileImp::InitSyncService()
          UpdateProfileUserNameCache
              profile_manager->GetProfileInfoCache(

The problem was that at this point the profile manager and the profile sync service were both already deleted. Our lazy load of the profile sync service was causing us to create the service twice.

In our other lazy load code we have a flag to prevent us from creating something twice. I added the same code to the profile sync service.

BUG=106869
TEST=Reproduced the crash. Applied my fix and verified that the crash no longer reproduced.


Review URL: http://codereview.chromium.org/8879047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113835 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113834 0039d316-1c4b-4281-b951-d872f2087c98

This fixes shared builds.

BUG=NONE
TEST=trybots pass
TBR=crogers

Review URL: http://codereview.chromium.org/8899005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113828 0039d316-1c4b-4281-b951-d872f2087c98

This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users.

BUG=none
TEST=existing.

Review URL: http://codereview.chromium.org/8824006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106987
TBR=avi
Review URL: http://codereview.chromium.org/8894009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113824 0039d316-1c4b-4281-b951-d872f2087c98

Previously we would reject requests with pinning errors at the URLRequest layer
but, by that time, we would already have sent cookies.

The commenting of the #ifdef is deliberate - it allows the builders to chew the
code over. Once the builders are happy I'll land another change to uncomment
the #ifdefs.

This also happens to start unpicking the DNS certificate provenance stuff.

BUG=none
TEST=Verify that https://pinningtest.appspot.com fails to load in offical builds.

Review URL: http://codereview.chromium.org/8865006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113823 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106988
TBR=dtseng@chromium.org

Review URL: http://codereview.chromium.org/8896003

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/8897004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113822 0039d316-1c4b-4281-b951-d872f2087c98

This helps us move closer to being able to do renderer-side mixing, for
improved performance.
See original CL for discussion: http://codereview.chromium.org/8477037/

BUG=none
TEST=audio_renderer_impl_unittest
(also verified that the media layout tests all pass, and did manual
testing with several audio files and YouTube videos)

Review URL: http://codereview.chromium.org/8785008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106988
TBR=dtseng@chromium.org

Review URL: http://codereview.chromium.org/8896003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113820 0039d316-1c4b-4281-b951-d872f2087c98