GitLab

It's going to be very difficult to enable this for production code as any code can leak message pipes. It'll also be hard to implement correctly with multiplexing. This was added for a test, but I just changed the test instead so that it quits after it sends a lot of reply messages.

BUG=556259

Review URL: https://codereview.chromium.org/1492943005

Cr-Commit-Position: refs/heads/master@{#363034}

This patch improves the handling of importer profile creation to remove
reliance on bare pointers. It also wraps created importer objects in a
scoped_refptr which is what the pointer is assigned to in the caller.

BUG=539746

Review URL: https://codereview.chromium.org/1492663006

Cr-Commit-Position: refs/heads/master@{#363033}

According to http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fselection%2Fmove-by-word-visually-mac.html,
it's slow with debug config on all platforms.

It also flakily timed out on try bot linux_chromium_rel_ng.

Mark it slow for all platform all configurations.

BUG=564771
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/1498733004

Cr-Commit-Position: refs/heads/master@{#363032}

The change to the generated code is such that only calls to
URL.createObjectURL(null) and URL.createObjectURL(undefined) are
affected, as those would previously match the nullable Blob argument.

This is very low risk, due to the behavior of other browsers:

Firefox and IE11 throw for both URL.createObjectURL(null) and
URL.createObjectURL(undefined). Edge presumably matches IE11.

Safari throws for URL.createObjectURL(undefined) but returns null for
URL.createObjectURL(null), which was our behavior before this change.

There are no internal calls to DOMURL::createObjectURL, so the ASSERT
will hold.

BUG=561338

Review URL: https://codereview.chromium.org/1492093002

Cr-Commit-Position: refs/heads/master@{#363031}

This CL does the following:

1. It introduces CompositorMusConnection. The connection to
the Mus Window server is now managed on the compositor
thread. RenderWidgetMusConnection is the corresponding main
thread object. CompositorMusConnection deals with
postTasking information RenderWidgetMusConnection wants to
the main thread and passing information from
RenderWidgetMusConnection to the compositor thread.

2. Input events are routed directly to InputHandlerManager
on the compositor thread. Unconsumed input events make
their way to RenderWidgetMusConnection where they're
currently dropped on the floor.

TEST=./out/mandoline_Debug/mojo_runner mojo:example_main --use-mus-in-renderer --use-zero-copy
BUG=551250

Review URL: https://codereview.chromium.org/1484013003

Cr-Commit-Position: refs/heads/master@{#363030}

BUG=546840

Review URL: https://codereview.chromium.org/1490503002

Cr-Commit-Position: refs/heads/master@{#363029}

BUG=560900

Review URL: https://codereview.chromium.org/1473833002

Cr-Commit-Position: refs/heads/master@{#363028}

It checks cleanly, even though //third_party/WebKit/public does not.

Review URL: https://codereview.chromium.org/1491333002

Cr-Commit-Position: refs/heads/master@{#363027}

BUG=561669

Review URL: https://codereview.chromium.org/1478493004

Cr-Commit-Position: refs/heads/master@{#363026}

In OOPIF-enabled modes, each FrameNavigationEntry has a per-frame
PageState object.  The states for each frame in the tree need to be
combined into a single PageState for GetPageState, and a single
PageState needs to be split into individual FrameNavigationEntries for
SetPageState.

Because GetPageState is const and returns a const ref, we need to
cache the combined PageState each time it could change.

BUG=545219
TEST=Close and restore a tab or session with OOPIFs.

Review URL: https://codereview.chromium.org/1496483002

Cr-Commit-Position: refs/heads/master@{#363025}

The ConvolverNode only supports 1, 2 or 4 channels and must throw an
exception for any other number of channels.

BUG=563379
TEST=convolver-channels.html

Review URL: https://codereview.chromium.org/1497803002

Cr-Commit-Position: refs/heads/master@{#363024}

BUG=552040

Review URL: https://codereview.chromium.org/1493893007

Cr-Commit-Position: refs/heads/master@{#363023}

https://chromium.googlesource.com/skia.git/+log/53c5d5fb795f..222b30d3a84b

$ git log 53c5d5fb7..222b30d3a --date=short --no-merges --format='%ad %ae %s'
2015-12-03 kjlubick Make building with clang documentation a bit easier to find
2015-12-03 egdaniel Create GLSLUniformHandler class for gpu backend
2015-12-03 jvanverth Add transfer buffer support.
2015-12-03 fmalita Don't use the Sk4f gradient impl without SIMD

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/1498883002

Cr-Commit-Position: refs/heads/master@{#363022}

TBR=kozyatinskiy
NOTRY=true
BUG=564585

Review URL: https://codereview.chromium.org/1498903002

Cr-Commit-Position: refs/heads/master@{#363021}

Review URL: https://codereview.chromium.org/1454313002

Cr-Commit-Position: refs/heads/master@{#363020}

R=dpapad@chromium.org
BUG=none
TEST=less code

Review URL: https://codereview.chromium.org/1492253002

Cr-Commit-Position: refs/heads/master@{#363019}

BUG=556259

Review URL: https://codereview.chromium.org/1494863002

Cr-Commit-Position: refs/heads/master@{#363018}

Implements new public-key-pinning Java API (see https://tools.ietf.org/html/rfc7469). The API is accessible through CronetEngine.Builder.addPublicKeyPins() method. The method accepts the host, the a collection of pin hashes, the flag that indicates whether the pinning policy should be applied to the host subdomains and the pin expiration date. The pins are not persisted between client restarts.

BUG=522275

Review URL: https://codereview.chromium.org/1407263010

Cr-Commit-Position: refs/heads/master@{#363017}

Cut the max text length to 200 characters.
Use Newton method rather than b-search to find the text length.

Review URL: https://codereview.chromium.org/1493073002

Cr-Commit-Position: refs/heads/master@{#363016}

testharness.js - https://github.com/w3c/testharness.js
commit: 8658d6ca31d086e695b333aef55bb388091c7049
files: testharness.js idlharness.js

webidl2.js - https://github.com/darobin/webidl2.js
commit: bd216bcd5596d60734450adc938155deab1e1a80
files: WebIDLParser.js (orig: webidl2.js)

Related files testharness.css and vendor-prefix.js did not require
updates - see LayoutTests/resources/README.txt

BUG=561708
R=domenic@chromium.org

Review URL: https://codereview.chromium.org/1493473002

Cr-Commit-Position: refs/heads/master@{#363015}

RenderWidgetHostViewMus::CopyFromCompositingSurfaceToVideoFrame had a NOTREACHED()
that we were hitting on navigation. This CL removes that and adds a TODO.

BUG=none

Review URL: https://codereview.chromium.org/1493823002

Cr-Commit-Position: refs/heads/master@{#363014}

Review URL: https://codereview.chromium.org/1493083002

Cr-Commit-Position: refs/heads/master@{#363013}

Blink now implements the same thing in its interest rect code.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1485823005

Cr-Commit-Position: refs/heads/master@{#363012}

Ultimately it will be done for all platforms and text selection changed will be deprecated.
TESTED=manual testing with Jaws and NVDA using textareas, input and content editables
BUG=558710
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1490953002

Cr-Commit-Position: refs/heads/master@{#363011}

Pull in some of the upstream changes made to the Service Worker Cache API tests.

BUG=476814,482241,429832,564245

Review URL: https://codereview.chromium.org/1485283002

Cr-Commit-Position: refs/heads/master@{#363010}

BUG=565438
TEST=GPU FYI bots
TBR=bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1493553008

Cr-Commit-Position: refs/heads/master@{#363009}

Let bindings generate a TypeError, rather than the module code
producing a TypeMismatchError or InvalidModificationError, if null is
passed for non-nullable interface arguments.

This was previously untested, so new tests were added for the async
API and sync API (in worker) cases.

(Some async cases are not modified in this CL, as there is a
behavior change we want to tackle separately.)

BUG=561338
R=philipj@opera.com

Review URL: https://codereview.chromium.org/1480363003

Cr-Commit-Position: refs/heads/master@{#363008}

Under pinch-to-zoom, there's no extra redraw event. However, the old
WindowView.resetGeometry() code was sensitive to dimensions
(window.innerWidth/innerHeight) that change with pinch-to-zoom. So when
page is pinch-to-zoomed in, refreshing or resizing triggers redraw,
causing inconsistent element sizing.

Our fix is to use dimensions that are insensitive to pinch-to-zoom,
i.e., document.documentElement.clientWidth/clientHeight. Under 100%
pinch-to-zoom, these are identical to the old dimensions except when
scroll bars are present.

BUG=481842

Review URL: https://codereview.chromium.org/1494783002

Cr-Commit-Position: refs/heads/master@{#363007}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a2c55ca8..baf869df

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1491853004

Cr-Commit-Position: refs/heads/master@{#363006}

The API now specifies that ContentLayerClient decides its own PaintableRegion().

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1489713004

Cr-Commit-Position: refs/heads/master@{#363005}

This so far can happen in the test. The CL https://codereview.chromium.org/1483083003/ changes the timing of animation completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1484383003

Cr-Commit-Position: refs/heads/master@{#363004}

Looks like everything that is done in ChromeMainDelegate::SandboxInitialized
is not applicable to WebView.

Review URL: https://codereview.chromium.org/1491743007

Cr-Commit-Position: refs/heads/master@{#363003}

Previously MSE GC algorithm didn't take into account properly the
duration of the last appended buffer. As a result GC would fail when the
media_time was beyond the timestamp of the last appended buffer. This CL
fixes that and adds a new unit test case to cover this situation.

BUG=563292

Review URL: https://codereview.chromium.org/1491513002

Cr-Commit-Position: refs/heads/master@{#363002}

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360

Review URL: https://codereview.chromium.org/1497483003

Cr-Commit-Position: refs/heads/master@{#363001}

Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.

BUG=519562
R=solb@chromium.org

Review URL: https://codereview.chromium.org/1472053003

Cr-Commit-Position: refs/heads/master@{#363000}

https://html.spec.whatwg.org/multipage/webstorage.html

The only change to the generated code is the data->value rename.

BUG=460722
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/1498823002

Cr-Commit-Position: refs/heads/master@{#362999}

Currently, functions like (for example) HTMLElement.toString() invoke a callback that obtains HTMLElement.toString's toString function and applies it to HTMLElement.

This leads to some weird behaviour, like:

> HTMLDocument.toString()
  "function HTMLDocument() { [native code] }"
> HTMLHRElement.toString()
  "function HTMLHRElement() { [native code] }"
> HTMLDocument.toString.toString = function() { return "foobar"; }
  function () { return "foobar"; }
> HTMLHRElement.toString()
  "foobar"
> HTMLDivElement
  function "foobar"

If we don't install the custom toString callback, everything works as expected.

BUG=

Review URL: https://codereview.chromium.org/1497503002

Cr-Commit-Position: refs/heads/master@{#362998}

Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)

BUG=134849

Review URL: https://codereview.chromium.org/1395073002

Cr-Commit-Position: refs/heads/master@{#362997}

In general the framebuffer has to be complete to claim
supporting RED on FBO.

If textureId is invalid glFramebufferTexture2DEXT returns
GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT.
So before this patch, IsGL_REDSupportedOnFBOs would have
returned true.

This leads to green frames when playing video.

This CL does fix bug 545904 but it is an indirect consequence.

We still need a new gpu driver bug workaround because this
CL does not avoid the DCHECK(glGetError() == GL_NO_ERROR);
at the end of IsGL_REDSupportedOnFBOs. Indeed the error is
set from the glTexImage2D call and glFramebufferTexture2DEXT
does not reset this gl error.

BUG=545904

R=bajones@chromium.org, hendrikw@chromium.org, kbr@chromium.org, zmo@chromium.org

TEST= --use-gl=egl on Mesa drivers

Review URL: https://codereview.chromium.org/1465223010

Cr-Commit-Position: refs/heads/master@{#362996}

BUG=138542

Review URL: https://codereview.chromium.org/1472083005

Cr-Commit-Position: refs/heads/master@{#362995}