- 08 Nov, 2019 40 commits
-
-
Antonio Gomes authored
The replacement is now possible that all users are in Blink. Essentially, the former is a pure interface for the later. As a follow up step the use of WebString will be replace by TF::String. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7c94b66363f933db7c15ca0e80236e61aac5828c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902443 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#713836}
-
Henrique Nakashima authored
Bug: 1022107 Change-Id: Ie7b1cb7c41bca57e225a8821360dc9db80d87e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903928Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713835}
-
Bence Béky authored
Before this CL, a frame of reserved type was sent out after every HEADERS frame, even if the HEADERS frame had END_STREAM set, which is in violation with https://httpwg.org/specs/rfc7540.html#StreamStates. After this CL, reserved frames are sent before every DATA frame, when the stream is guaranteed to be in open or half-closed (local) state from the receiver's point of view. Reserved frames sent on stream 0 after the SETTINGS frame are not affected by this change. Bug: 1020233 Change-Id: I2ac5273c44486578d1e14920678ca07800278dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903946 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#713834}
-
Joe Mason authored
A lot of the plumbing that passes information from ChromePromptIPC to higher layers uses the PromptAcceptance enum and callback classes generated from chrome_prompt.mojom. This will make it harder to get rid of chrome_prompt.mojom when it's no longer supported. * Use PromptUserResponse::PromptAcceptance from chrome_prompt.proto, which is now the preferred IPC method. * Define callbacks in ChromePromptIPC that have similar signatures to the Mojo callbacks. * Convert to and from these types in MojoChromePromptIPC. The Mojo types are no longer referenced outside this class and its unit test. R=proberge Bug: 969139 Change-Id: Ie4028bc650aa2d155492225c33716cf6eaf69c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904846Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713833}
-
meacer authored
The letter "ə" (U+0259) can be confused with both "e" and "a" when used in domain names. IDN spoof checker currently doesn't have a way of treating a single character as confusable with multiple characters, so the only option is to map this letter to either "e" or "a" but not both. This is obviously not desirable since the Schwa can be used to spoof the non-mapped character. As a result, there is no straightforward solution other than limiting the character to .az domains (The letter is used commonly in Azerbaijani language). This fix affects ~250 registered domains containing the letter "ə". However, only ~40 of these domains serve some sort of content, the rest are either parked or don't serve content. Furthermore, only 1 of these domains appear in usage logs and the domain is not widely used, so this is probably a safe change. Bug: 1017707 Change-Id: Ied699b3b7bd067945d90dd360d2ecf3243912145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904761 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713832}
-
Gauthier Ambard authored
This reverts commit 87d8b793. Reason for revert: This breaks swipe to dismiss. See crbug.com/1022763 Original change's description: > Fix headers on reading list after deleting articles. > > -call |-removeEmptySections| in |-setEditing:animated:| before resetting the property. > > needsSectionCleanupAfterEditing needs to be removed when dropping iOS 12. > > Bug: 998491, 1022763 > Change-Id: I38cef305e1763120b402f1904f21c29c48ce024a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832273 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703237} TBR=kkhorimoto@chromium.org,gambard@chromium.org,ewannpv@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998491 Change-Id: I91e0004d962761c18514f1fa1f2e463c74491eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905849Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713831}
-
Anatoliy Potapchuk authored
Split function OnNetworkRequested(bool requested) into two more logical calls. Bug: 1015383 Change-Id: I3bb5af7fb530e0d3a7a5123069a41dbad44ed997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905709 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713830}
-
Olivier Robin authored
With slim navigation, the tab cannot be restored anymore. Directly add the tab to recently closed without creating a WebState (as the WebState is not used anyway). Bug: 1022298 Change-Id: I4979564e938fd49fb8b622c38561675ccf27a8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903354 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713829}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0663b3d6a615..0db29887459d Created with: gclient setdep -r src-internal@0db29887459d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic7d240e469b38af109f0b464373f4ca62d38c516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905889Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713828}
-
Tommy Steimel authored
This CL sets the focus behavior for the title and artist text in the media dialog to allow screen readers to focus it. This fixes an issue where screen readers could not read the title and artist. Bug: 1022553 Change-Id: I691a0b3ba1ed99b18264f34863943e0f289b9d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904538 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#713827}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c1fb4156d24..2bc811ea07b7 git log 7c1fb4156d24..2bc811ea07b7 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 danilchap@webrtc.org Mark checked_cast, dchecked_cast, and saturated_cast as constexpr 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 63455546..b19a2944 (713670:713775) 2019-11-08 gustaf@webrtc.org Remove legacy EchoControlFactory::Create 2019-11-08 mbonadei@webrtc.org RTC_EXPORT webrtc::GetScreenRect. 2019-11-08 tommi@webrtc.org Fix number of arguments being passed when setting the thread name on Windows. 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b4dd47d..63455546 (713546:713670) 2019-11-07 honghaiz@webrtc.org Revert "Stop using and delete DEPRECATED_SingleThreadedTaskQueueForTesting" 2019-11-07 peah@webrtc.org Further AGC refactoring in preparation for adding multichannel support 2019-11-07 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-07 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-07 minyue@webrtc.org Make Opus PLC always output 10ms audio. 2019-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 93ed153e..3b4dd47d (713404:713546) 2019-11-07 peah@webrtc.org Correcting the AGC saturation detection for multichannel input Created with: gclient setdep -r src/third_party/webrtc@2bc811ea07b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I39c7d0392e222496df1292ca515e2c5108df4f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905886Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713826}
-
Daniele Castagna authored
ParseOverlayStrategies was mispelled to ParseOverlayStategies Test: no Change-Id: Ica6a73f174649756f99d3e772d3fb928380a428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904316 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713825}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c832dcd6c20..5e3eacac1ca1 git log 2c832dcd6c20..5e3eacac1ca1 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 ilkos@google.com Encapsulate the totals on the heap profiles metrics Created with: gclient setdep -r src/third_party/perfetto@5e3eacac1ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I90d2e53782c81faf2f66e9d91673524d3c112f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713824}
-
John Budorick authored
Bug: 1022537 Change-Id: Ic0181f537b130c869c05be2a7ba1e7584e6ba0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904493 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713823}
-
ckitagawa authored
This CL implements the required code to capture paint previews in Blink. The majority of the code is shared with printing; however, new flags are introduced to handle the differences between printing and painting of previews. This CL *does not* introduce support for OOP iframe paint previews and scrolling them (to be handled in a separate CL). Desired Behaviors; - Paint Previews should look exactly like the current webpage and should not reformat in the way printing does. This includes ignoring print display tags and the simplifications used in painting. - Paint Previews should re-layout to be the full contents of the page not just the viewport. This is achieved by printing to a canvas the size of the document (single page). - Paint Previews should print to a single Skia Picture (per frame) rather than a Metafile Skia Document. Design doc: go/fdt-design Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Bug: 1001109 Change-Id: If0e947befea8ecc78b2cbee950e8c1cbd8e1281e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844057Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#713822}
-
kylechar authored
We are hitting DCHECK where two SkSurfaceCharacterizations don't match. It's a rare crash and I'm unable to reproduce it locally. Store both SkSurfaceCharacterizations on the stack and alias them so they are included in minidumps. Bug: 1022304 Change-Id: I8844f0f4483486896e7ecc7ef89fd17f6f88531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904449Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713821}
-
Mihai Sardarescu authored
This reverts commit 2e670a95. Reason for revert: Fixed the compile error. Original change's description: > Revert "Avoid explicit conversion for CoreAccountId on desktop platforms." > > This reverts commit 75be7e87. > > Reason for revert: breaks compilation on fuchsia: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20ARM64/90020 > > Original change's description: > > Avoid explicit conversion for CoreAccountId on desktop platforms. > > > > Bug: 959157 > > Change-Id: I8d6a6c80a4f2aea5a84264f26b4047ca46f6e687 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904173 > > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713817} > > TBR=msarda@chromium.org,triploblastic@chromium.org > > Change-Id: Ic950b9b7b4bd800b0d7c71c4ab46f17f68922137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 959157 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906307 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713819} TBR=msarda@chromium.org,jbudorick@chromium.org,triploblastic@chromium.org Change-Id: I76654053beb414ac2ae9eb8ce28320af23d6d4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 959157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906366Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713820}
-
John Budorick authored
This reverts commit 75be7e87. Reason for revert: breaks compilation on fuchsia: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20ARM64/90020 Original change's description: > Avoid explicit conversion for CoreAccountId on desktop platforms. > > Bug: 959157 > Change-Id: I8d6a6c80a4f2aea5a84264f26b4047ca46f6e687 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904173 > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713817} TBR=msarda@chromium.org,triploblastic@chromium.org Change-Id: Ic950b9b7b4bd800b0d7c71c4ab46f17f68922137 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 959157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906307Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#713819}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6eb91af65c35979841defffc20b5737fbdb1c29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713818}
-
Mihai Sardarescu authored
Bug: 959157 Change-Id: I8d6a6c80a4f2aea5a84264f26b4047ca46f6e687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904173Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713817}
-
Andreas Haas authored
V8 changes the size field of ArrayBuffers to {size_t}. Therefore an ArrayBuffer from V8 can overflow the size field of a blink::ArrayBuffer. With this CL we change the {ByteLength} getter of blink::ArrayBuffer to two new getters: {ByteLengthAsUnsigned} and {ByteLengthAsSizeT}. {ByteLengthAsUnsigned} includes an overflow check and is used for now for most existing accesses to {ByteLength}. Eventually we would like to change all calls to {ByteLengthAsSizeT}, so that eventually we can remove {ByteLengthAsUnsigned} and rename {ByteLengthAsSizeT} to {ByteLength} again. R=haraken@chromium.org Bug: v8:4153 Change-Id: I1af532b8ef525b04e8e7f39147f4ab87f8e29082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888831 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713816}
-
Miyoung Shin authored
This change converts DistillerJavaScriptService mojom interface client in components to use BrowserInterfaceBroker. DomDistillerService instead of DomDistillerViewerSource owns DistillerUIHandle instance and a static helper function is used to register its binder. Bug: 936482 Change-Id: Iebc814be8118a10a756a05c9bb0115ec9add9805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892631Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#713815}
-
Dominique Fauteux-Chapleau authored
Migrates RetrieveDMToken calls to use the new BrowserDMToken class and change the class member from a string to this class. Also add a few includes the linter warns about. Bug: 1020296 Change-Id: I6754c373cc34c1b3ca25da81847793ab199cddb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903952 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713814}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/3ee5ac7b0e..3b14632a5b TBR=aerotwist@chromium.org Change-Id: I59b1377ff48cc0d2aeb3345bf0da79bb93b4e858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905711Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713813}
-
Dominique Fauteux-Chapleau authored
Migrates RetrieveDMToken calls to use the new BrowserDMToken class. Also add an include the linter warns about. Bug: 1020296 Change-Id: If0ffd36bbd6b92079a49be252d0638c7e6918e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903962Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#713812}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c041237..4e6e728c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4b22fb747760e63bfed6b675fe34c4bdb07fe6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905786Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713811}
-
Michael Lippautz authored
Tbr: haraken@chromium.org Change-Id: I34500581c84b960f87c7d71e3e5234f6ec820c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905548Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713810}
-
Rune Lillesveen authored
Made chrome://tracing crash on closing <dialog> element with FlatTreeStyleRecalc enabled. Bug: 972752 Change-Id: Ie152f10d2972a873fb7f1cc00cff745719d90faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905710Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#713809}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0d1100a7149..2c832dcd6c20 git log f0d1100a7149..2c832dcd6c20 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 ilkos@google.com Java heap stats metrics Created with: gclient setdep -r src/third_party/perfetto@2c832dcd6c20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:b/144097821 Change-Id: Iadd3a1ba00da441db82b0300f00372e60d036669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713808}
-
Olivier Li authored
The current behavior of the test contains two problems: 1) It uses a directory path that is never created to to hold the HistoryBackend database. This leads to a consistent sql::INIT_FAILURE status that spams the logs and is ignored. 2) |temp_dir_| that is used by |profile_| is destroyed first which leads to more errors. Problems in this test were found while trying to create some warnings for misuse of HistoryBackend in tests here: https://crrev.com/c/1898109. Bug: 661143 Change-Id: I0181a4d8c50e846469dbd435520086e3b7e35442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900208 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#713807}
-
A Olsen authored
JS tests don't work on ASAN, which is a known bug: https://crbug.com/1010561 Use the existing "include_js_tests" flag to exclude password_change_authenticator_test as it is intended, instead of an ad-hoc solution. Bug: 1022385 Change-Id: Ia81d148dd2c38c17813a2b007be27aa932849679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904197 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713806}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2eeedf46266..0663b3d6a615 Created with: gclient setdep -r src-internal@0663b3d6a615 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I085033b259e32082bb9b74c8a591ca6df5d41fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905649Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713805}
-
Clemens Arbesser authored
This CL improves the user interface for the selection of login options. It adds an optional sublabel and an optional |learn_more| popup that displays additional information to the user when tapped. This CL also adds several missing a11y strings for the edit buttons of user form sections. Example video and screenshots in the bug linked below. Bug: b/143694298 Change-Id: Ibcbc939b03e9d078d5979672ea9ca4677abd55b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893209 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713804}
-
Karolina Soltys authored
Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: If3a7b14a0cb6630c8d5754726bf3a10e6b84eeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852289 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713803}
-
Jit Yao Yap authored
Rearrange imports and add comments for the script. Updated script can be found at team-review.git.corp.google.com/c/chrome-enterprise-muc/+/593459 Change-Id: Ib1760a62a1a7406d62d56f3aca6d95a378081209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903356Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#713802}
-
Austin Tankiang authored
Bug: 1003238 Change-Id: Iad97daff9e2c134f10a491214a7d3298951fb59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892234 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#713801}
-
Yutaka Hirano authored
I'm planning to introduce "crossOriginIsolated" property (https://crbug.com/1018680) which needs both COOP and COEP. We are planning to ship COOP and COEP at the same time, so there is no need to have separate flags. Let's have "CrossOriginIsolation" feature flag which controls both COOP and COEP. Bug: 1018680, 922191, 887967 Change-Id: I59be10017af54f66e1488d1d74f0b52ae526130d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905032Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#713800}
-
Marc Treib authored
SyncStoppedReporter is supposed to tell the Sync server when Sync gets disabled on a device. Reasons for disabling Sync are: User explicitly disabled Sync (and signed out), enterprise policy, unrecoverable errors, and maybe some other error cases. Before this CL, in the case of sign-out/disabling Sync, we'd throw away any cached access token before calling the SyncStoppedReporter, and so it would actually never be able to send a request. This CL fixes the issue by having SyncAuthManager notify its client (in practice, the SyncService) of the signout *before* throwing away the access token. Bug: 1022389 Change-Id: I58ecabb90700ca063c699f574a0ab62d064b6f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903204Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713799}
-
Mohamed Amir Yosef authored
This CL gets rids of couple of booleans inside PasswordFormManager and replaces them with an enum. Change-Id: I37db96a7be143b09b1e43eaf38462b94e453db24 Bug: 1012203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847338 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#713798}
-
Alexander Timin authored
Ensure that we reach DOMContentLoaded in addition to just finishing the navigation to ensure that "Loading" is not one of the reasons why the navigation wasn't cached. R=carlscab@google.com,hajimehoshi@chromium.org BUG=1018206 Change-Id: Id2dd95c030ade83c0a8714150ed190f94b72e81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895341Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713797}
-