GitLab

BUG=461222

Review URL: https://codereview.chromium.org/1348563003

Cr-Commit-Position: refs/heads/master@{#360469}

The condition of one of the DCHECKs to check that the code is running on
the correct thread was wrong.

BUG=554214

Review URL: https://codereview.chromium.org/1452013006

Cr-Commit-Position: refs/heads/master@{#360468}

There are just a few calls and one comparison. No functional changes.

This CL is not dependent on any other pending CLs.

BUG=499321

Review URL: https://codereview.chromium.org/1441443003

Cr-Commit-Position: refs/heads/master@{#360467}

BoringSSL may currently only be initialized by one piece of code, so full
initialization must happen in Chromium code, rather than WebRTC.

Historically, this was because the locking callbacks needed to be configured.
This is gone, but EnsureOpenSSLInit still configures NEON support on Android
and detects a CPU with known broken NEON support. Until that's moved to inside
the library (https://crbug.com/542879), Chromium must initialize some of the
stack ourselves.

BUG=556462

Review URL: https://codereview.chromium.org/1462443003

Cr-Commit-Position: refs/heads/master@{#360466}

Gets rid of SubtreeStyleChange which relies on sibling tree recalcs.

R=tkent@chromium.org,ericwilligers@chromium.org
BUG=557440

Review URL: https://codereview.chromium.org/1459553002

Cr-Commit-Position: refs/heads/master@{#360465}

This patch forces mus+ash Chrome to software composite the ui and content
region into a single bitmap that is uploaded to the mus window server. The
approach here is similar to how Chrome paints to X11 when hardware acceleration
is not available.

BUG=554699
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e482a6010424204e7c8e313c5922acc38506be5c
Cr-Commit-Position: refs/heads/master@{#360289}

Review URL: https://codereview.chromium.org/1438903002

Cr-Commit-Position: refs/heads/master@{#360464}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fa52ce51..8fb1fca2

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1457893002

Cr-Commit-Position: refs/heads/master@{#360463}

This should green the CFI buildbot.

BUG=chromium:557969

Review URL: https://codereview.chromium.org/1461583004

Cr-Commit-Position: refs/heads/master@{#360462}

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

also use std::move() instead of scoped_ptr::Pass().

BUG=554291, 557422

Review URL: https://codereview.chromium.org/1456703004

Cr-Commit-Position: refs/heads/master@{#360461}

Failing tests on Mac OS:
  CastStreamingApiTestWithPixelOutput.EndToEnd
  TabCaptureApiPixelTest.EndToEndThroughWebRTC
  TabCaptureApiPixelTest.EndToEndWithoutRemoting

BUG=557929
TBR=hubbe@chromium.org, miu@chromium.org

Review URL: https://codereview.chromium.org/1456863003

Cr-Commit-Position: refs/heads/master@{#360460}

When Chrome is launched from the gyp-generated Visual Studio solution,
::GetModuleFileNameW returns a value that contains a path traversal
component. This isn't supported by base::File and causes
installer::GetModulePath to fail.

With this CL, we use base::PathService instead of ::GetModuleFileNameW
to get the path to the current executable. base::PathService
removes all path traversal components.

BUG=554514

Review URL: https://codereview.chromium.org/1436103005

Cr-Commit-Position: refs/heads/master@{#360459}

Following histograms are added.
1. Tracking session lifetime from its start to end.
2. How long an old inactive tracking session is maintained in the tab model since it became inactive.
3. How long an expired (active/inactive) tab entry is maintained in the tab model since its latest tracking session.
4. How long an unexpired tab entry is maintained in the tab model.

BUG=557436

Review URL: https://codereview.chromium.org/1444133002

Cr-Commit-Position: refs/heads/master@{#360458}

BUG=548797

Review URL: https://codereview.chromium.org/1434663004

Cr-Commit-Position: refs/heads/master@{#360457}

This is a partial revert of a01f7d9e.

BUG=557930
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/1461583003

Cr-Commit-Position: refs/heads/master@{#360456}

The correct enum value for AVX is 3, not 4. The enum value of 4 implies
/arch:IA32, which means x87 FPU ops only.

R=johannkoenig@google.com,tomfinegan@chromium.org,hans@chromium.org
BUG=557968

Review URL: https://codereview.chromium.org/1460763003

Cr-Commit-Position: refs/heads/master@{#360455}

This CL plumbs four QUIC experimental params (
quic_store_server_configs_in_properties,
quic_delay_tcp_race,
quic_max_number_of_lossy_connections,
quic_packet_loss_threshold) from Cronet's
setExperimentalOptions API to net::HttpNetworkSession.

This CL also adds a unittests target to run the unittests.
A followup CL will enable the unittests on the cronet bots.

BUG=545118

Review URL: https://codereview.chromium.org/1448583003

Cr-Commit-Position: refs/heads/master@{#360454}

Right now, the label for the button that recovers a potentially
malicious download says "Hurt me plenty" in English.

This button label bothers some users (see link below) and, to me,
crosses the line from lighthearted and informal to kind of dark and
a little snarky.

(See https://productforums.google.com/forum/#!topic/chrome/zWJ0Bm06Hf0.)

The translation notes suggest translating "Recover anyway" for other
languages, so let's use that in English as well.

(Alternatively, someone has suggested "Damage my computer" if we want
something scary-sounding but less dark. For reference, Firefox uses
"I'll be careful", but I'm not a huge fan.)

BUG=

Review URL: https://codereview.chromium.org/1412423015

Cr-Commit-Position: refs/heads/master@{#360453}

- Be able to send and receive compositor protos to/from the render
  process and the browser process.  Messages are piped through the
  browser process to/from the network and renderer.  A separate client
  (go/blimp) will render the compositor protos.  This is part of the
  compositor refactor around splitting ThreadProxy into two components.
- Hook the proto sending into the BlimpEngineSession class.
- Set up a RemoteProtoChannel interface on the CC side to be used by the
  ChannelMain class once we start building that from the LayerTreeHost.

BUG=552055
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1442853005

Cr-Commit-Position: refs/heads/master@{#360452}

Provides a simpler, byte-oriented api for getting data out of a multibuffer.
This CL also has the unit tests for the multibuffer itself. (Since those tests
uses the MultiBufferReader class.)

Depends on:
https://codereview.chromium.org/1165903002

Media cache design doc:
https://docs.google.com/document/d/15q6LTG0iDUe30QcoMtj4XNmKCa_7W_Q2uUIPFsJhS1E/edit

BUG=514719, 557589

Committed: https://crrev.com/f8b2532f9f9b4a35f396602bb80dfc34ee102fe4
Cr-Commit-Position: refs/heads/master@{#360244}

Review URL: https://codereview.chromium.org/1420883004

Cr-Commit-Position: refs/heads/master@{#360451}

Exclude ProxyResolverV8TracingWrapperTest.Terminate which fails under
Dr. Memory.

TBR=jkummerow@chromium.org
BUG=557993
NOTRY=true

Review URL: https://codereview.chromium.org/1461803002

Cr-Commit-Position: refs/heads/master@{#360450}

BUG=525756
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1423803004

Cr-Commit-Position: refs/heads/master@{#360449}

InlineLoginDialog removed.

BUG=546731

Review URL: https://codereview.chromium.org/1457683002

Cr-Commit-Position: refs/heads/master@{#360448}

- Lock icon in EV bubble is not supposed to have a background box
- location bar https icon has different colors for incognito

Colors that are hardcoded for inverted color schemes (as they no longer match their native theme values):
- chip border and background colors are white
- selected keyword chip is blue700
These colors could be made part of NativeTheme, but they seem specific to these chips, so I just set them inline.

BUG=501377

Review URL: https://codereview.chromium.org/1448433004

Cr-Commit-Position: refs/heads/master@{#360447}

Revert of Bind Application in renderer (patchset #15 id:280001 of https://codereview.chromium.org/1452823003/ )

Reason for revert:
This change is making hundreds of webkit_tests crash on linux_chromium_rel_ng with:

[1:1:1118/141621:108326049405:FATAL:lock.cc(32)] Check failed: owning_thread_ref_.is_null().
#0 0x00000067e2de base::debug::StackTrace::StackTrace()
#1 0x00000057a71f logging::LogMessage::~LogMessage()
#2 0x0000005eb69b base::Lock::CheckUnheldAndMark()
#3 0x000000518e1c base::Lock::Acquire()
#4 0x000000518b43 base::AutoLock::AutoLock()
#5 0x0000005b4014 base::SequenceCheckerImpl::CalledOnValidSequencedThread()
#6 0x000006f074ae IDMap<>::Lookup()
#7 0x000006f0598c content::RendererBlinkPlatformImpl::SetPlatformEventObserverForTesting()
#8 0x000008459264 content::SetMockGamepadProvider()

Original issue's description:
> Bind Application in renderer.
>
> This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.
>
> I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
>
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
>
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}
>
> Committed: https://crrev.com/2c716f9d5ebff610641f4506c17ec81d4b89b7bb
> Cr-Commit-Position: refs/heads/master@{#360396}

TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1457173002

Cr-Commit-Position: refs/heads/master@{#360446}

This rolls GYP to the latest commit in its repo.

  e113348 Changes analyzer to include test_targets in compile_targets

BUG=557505
TBR=dpranke@chromium.org
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1454023003

Cr-Commit-Position: refs/heads/master@{#360445}

This fixes compilation.

Review URL: https://codereview.chromium.org/1456163002

Cr-Commit-Position: refs/heads/master@{#360444}

This CL removes UpdatePermanentNodeVisibility from bookmarks component code as
it is the embedder's decision to show or not permanent nodes.

BUG=367639,456876
R=noyau@chromium.org,stanisc@chromium.org

Review URL: https://codereview.chromium.org/1454983004

Cr-Commit-Position: refs/heads/master@{#360443}

BUG=514815

Review URL: https://codereview.chromium.org/1450063002

Cr-Commit-Position: refs/heads/master@{#360442}

It's somewhat confusing to have to find it in cc/trees/layer_tree_settings.h.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=dtrainor@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/1462613002

Cr-Commit-Position: refs/heads/master@{#360441}

BUG=535478
TBR=caseq
NOTRY=true

Review URL: https://codereview.chromium.org/1459593003

Cr-Commit-Position: refs/heads/master@{#360440}

Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (patchset #5 id:120001 of https://codereview.chromium.org/1437683004/ )

Reason for revert:
Broken MSAN: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%281%29/builds/40036

Original issue's description:
> [Extensions] Don't count bubble dismissal from focus loss as acknowledgment
>
> Currently, if an extension message bubble is shown, and then it is dismissed
> because it loses focus, we treat it the same as the user clicking the dismiss
> button - which serves as acknowledging the extension.  We could ignore focus
> loss, but this makes for very noisy, awkward bubbles.  Instead, allow the bubble
> to close, but don't treat this as user acknowledgment, and show the bubble again
> on next startup.
>
> This also involves tracking the close reason for a BubbleDelegateView.
>
> BUG=548269
>
> Committed: https://crrev.com/1462f63a60f9c7e1e53a3a42f70afc214d67fa71
> Cr-Commit-Position: refs/heads/master@{#360373}

TBR=finnur@chromium.org,sky@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548269

Review URL: https://codereview.chromium.org/1456213002

Cr-Commit-Position: refs/heads/master@{#360439}

BUG=none
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1459723003

Cr-Commit-Position: refs/heads/master@{#360438}

This CL makes the DataUseAggregator re-use the same callback objects
separately for annotation and amortization calls, as an optimization to
avoid allocating and holding on to a new callback object for every call.
This CL should have no noticible effects other than using less memory.

BUG=

Review URL: https://codereview.chromium.org/1456793003

Cr-Commit-Position: refs/heads/master@{#360437}

The "Divider" colors are intended for use for the hyphens that separate
e.g. the URL and page title. These hyphens actually just match the
DIMMED_TEXT color; I can't find a time in the past where this color was
ever used for anything.

BUG=501377

Review URL: https://codereview.chromium.org/1454983003

Cr-Commit-Position: refs/heads/master@{#360436}

CL explains why most fields of net::CertVerifyResult are being set
to hard-coded values.
PrivetV3ContextGetter::CertVerifier checks only Sha256 fingerprint
of the certificate. So calculation of the most of properties is
unnecessary.

BUG=524788

Review URL: https://codereview.chromium.org/1451573002

Cr-Commit-Position: refs/heads/master@{#360435}

Android didn't like our magic to automatically include a connection to mojo:tracing in ApplicationImpl. This does things the explicit way: including a mojo:TracingImpl in each and every mojo application package.

BUG=534895

Review URL: https://codereview.chromium.org/1459453003

Cr-Commit-Position: refs/heads/master@{#360434}

This code path is now also used by Android. And it may return null. So
add nullity check to avoid crash.

BUG=557285

Review URL: https://codereview.chromium.org/1456053002

Cr-Commit-Position: refs/heads/master@{#360433}

BUG=556772

Review URL: https://codereview.chromium.org/1451933005

Cr-Commit-Position: refs/heads/master@{#360432}

BUG=530624
R=wfh@chromium.org

Review URL: https://codereview.chromium.org/1449273003

Cr-Commit-Position: refs/heads/master@{#360431}

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

This is needed because Aura Android will set use_aura to
true but use_ash to false.

BUG=557285

Review URL: https://codereview.chromium.org/1451973002

Cr-Commit-Position: refs/heads/master@{#360430}