GitLab

The imported 3pp code has been cleaned and translated to C++.
Build targets will be added in a separate CL.

Bug: webrtc:9076
Change-Id: Ia53a042a842db734199271691c7b7c26e09b8ae0
Reviewed-on: https://chromium-review.googlesource.com/983557Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ale Bzk <alessiob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548115}

- GetAccessibleName()
- IsOpeningSettingsSupported()

These two methods represent fields that are already present in
message_center::Notification.

This also gets rid of ArcNotificationContentViewDelegate in favor
of having the ArcNotificationView create and maintain a reference
to the ArcNotificationContentView directly.


Change-Id: Ifcad792f38902b567f71665046c0d9ba02d74305
Bug: 768439
Reviewed-on: https://chromium-review.googlesource.com/969541
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548114}

This reverts commit 0e554b21.

Reason for revert: Two crash reports already on the morning of the new Canary.

Original change's description:
> Add CHECK in Job::SetSpdyHttpStreamOrBidirectionalStreamImpl().
> 
> Bug: 819101
> Change-Id: I6618354362d7454ad4ffa69d383ef739895932d4
> Reviewed-on: https://chromium-review.googlesource.com/990512
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547694}

TBR=rch@chromium.org,bnc@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 828865
Change-Id: If00bd7afc74680126998cecefd67fe21201cdc13
Reviewed-on: https://chromium-review.googlesource.com/995852Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548113}

Typo from https://chromium-review.googlesource.com/959445.

Bug: 802963
Change-Id: Ide52935d3a4b2bdbf2d3f29cf67893bd7b54ce10
Reviewed-on: https://chromium-review.googlesource.com/985131Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548112}

This is a follow up on crrev.com/c/982646

Bug: 796334
Change-Id: I63b04d2f2ab61ef1d9a45f3d360df5f1e1290959
Reviewed-on: https://chromium-review.googlesource.com/988742Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548111}

Change-Id: Ibe413cfc3e46c24a865ea90213125761836de95f
Reviewed-on: https://chromium-review.googlesource.com/991603Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Alex Chu <alexchu@google.com>
Cr-Commit-Position: refs/heads/master@{#548110}

This is a precursor for an upcoming change that will split the public bits
of the MessageLoop class (used through MessageLoop(ForUI|IO)::current())
to another class.

Bug: 825327
Change-Id: I3cda2a0e1b2ff48aaeeaeeb68d99c5dda926350f
Reviewed-on: https://chromium-review.googlesource.com/978776
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548109}

Bug: 827551
Change-Id: I134199ca4538f469fc29d0b315a9e36f72e8df80
Reviewed-on: https://chromium-review.googlesource.com/982611Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548108}

Noticed the script was complaining of unknown sections:
  .gnu.hash
  .note.android.ident
  .note.crashpad.info

Change-Id: I546325135fab4a334ff9a16c635fe86cc6ef4c47
Reviewed-on: https://chromium-review.googlesource.com/995955Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548107}

Modifiers specified as:
{ ctrl: true }
worked, but
{ ctrl: false }

got interpreted as having ctrl down (as the code only checked the presence of the value and not its boolean state).

Change-Id: Icec8959441c193d548fcaf45b163c41fdb351472
Reviewed-on: https://chromium-review.googlesource.com/985967
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548106}

It is now possible to get the same information from the returned buffer.

BUG=788243

Change-Id: I5e76eedb5b5539167f93b1d275007f33f82a1c2b
Reviewed-on: https://chromium-review.googlesource.com/977055Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548105}

When in tablet mode on Chrome OS, webpages should have a
mobile-like behavior such as:
- Shrink viewport contents to fit the window size.
- Mobile viewport style.

This also exposes WebContents::NotifyPreferencesChanged() so
that it's possible to trigger an update of all RVHs associated
with a WebContents including OOPIFs

BUG=822455,828697
TEST=browser_tests --gtest_filter=TabletModePageBehaviorTest.*

Change-Id: Id80316fdb7c504a8a6f40ca9127c13ca58a9eee9
Reviewed-on: https://chromium-review.googlesource.com/978519
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548104}

This replaces external reference of Assistant logo in OOBE OptIn to
internal static icon.

Test: Manually
Bug: 828642
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d0c42acf53095af14c31fc1d64ab5f4731a9509
Reviewed-on: https://chromium-review.googlesource.com/994732Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#548103}

Also migrates //headless from its own unique_ptr<> based ProtocolHandler
map to use content::ProtocolHandlerMap.

Bug: 556939
Change-Id: I4ceea7f048542da1dd7a1f4a68d6ab91f75ff813
Reviewed-on: https://chromium-review.googlesource.com/989397
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548102}

FrameIsScrollableDidChange had a typo and always returned true. This
prevented an early-out in ScrollingCoordinator's
UpdateAfterCompositingChangeIfNeeded from being effective.

This patch should have no web-visible changes and should only improve
performance by making an early-out work.

Bug: 826883
Change-Id: Ic3bbac06b6cf7e6a1097a42ba43d1dfd35dcb0c6
Reviewed-on: https://chromium-review.googlesource.com/994546Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548101}

... mostly by removing the inclusion of redundant header files.

Bug: 734095
Change-Id: Ibed243cbdedba4499a6e62f2b79d31cdbf77b535
Reviewed-on: https://chromium-review.googlesource.com/989396Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548100}

The modern media controls should not show what has been previously
cached on the left hand side of the play head. This pins the segment to
the zero position so it always is filled in.

BUG=827539

Change-Id: I97f5f06b7e349faf163667d2b19ef8930e0b13c7
Reviewed-on: https://chromium-review.googlesource.com/994180Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548099}

Do not migrate proxied connections for connectivity probing packets. Protected by existing flag FLAGS_quic_reloadable_flag_quic_enable_server_proxy.

Merge internal change: 191428948

R=rch@chromium.org

Change-Id: Ide8207871b8a31465cec09439e1f9e67a4366542
Reviewed-on: https://chromium-review.googlesource.com/995613Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bin Wu <wub@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548098}

This is a reland of c6e9dffe

TBR=oshima@chromium.org

Original change's description:
> overview: Fix how multi touch works for overview drag.
>
> Using two fingers was not restricted which brought a bunch of other bugs.
> Only allow one item to be dragged at a time. Still allows switching of
> fingers midway, so we just check the item which requests drag events is
> the same as the current drag item, instead of checking the gesture
> finger id.
>
> Test: ash_unittests WindowSelectorTest.DraggingWithTwoFingers
> Bug: 827435
> Change-Id: I2c897b1b3c483b5df7a98a658f575a6ebd706acd
> Reviewed-on: https://chromium-review.googlesource.com/988294
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547932}

Bug: 827435
Change-Id: I1cda10e4712f79e458f5b977779809a1ed8255d5
Reviewed-on: https://chromium-review.googlesource.com/996052Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548097}

Moved it from platform/win7/ to platform/win/. This doesn't seem to
affect any of the Windows bots when running the tests as normally, but
if the test is part of a virtual test suite, it otherwise fails to find
the PNG in some cases (it happened on win10_blink_rel).

This blocks CL:981138

Change-Id: I94468b94eb53ed9b62911c6e0ca648941e65038a
Reviewed-on: https://chromium-review.googlesource.com/995475Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548096}

When calculating the delta between Windows Epoch and Unix Epoch in
geolocation mock, Date constructor (that interpretes
parameters in terms of *local* time) was used for the Windows
epoch (1601-01-01) and Unix epoch (1970-01-01) assuming that the
timezone offset didn't change between 1601 and 1970. That assumption
does not hold any more when ICU is used to take into account
the historical timezone offset changes. As a result,
geolocation-api/timestamp.html test failed when the fix for v8:3547
was landed. (https://chromium-review.googlesource.com/c/v8/v8/+/572148 ).

This CL uses Date.UTC() to avoid the issue and is a pre-requisite
to relanding the above v8 CL.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: v8:3547, chromium:417640, v8:5714
Test: layout test: geolocation-api/*
Change-Id: Iaf718c2818fa9a5f5c64136a38579a1fcafe7805
Reviewed-on: https://chromium-review.googlesource.com/994343Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548095}

This is a mechanical change. Understanding ownership of various objects such as interceptors
is difficult in the current implementation, and it is prone to memory leaks and
accessing dangling objects.

There is follow-up work to implement support for pausing such interceptors.

Bug: 828600
Change-Id: Ic88e76be4adc45e0f341f13ff888fd1612b157a6
Reviewed-on: https://chromium-review.googlesource.com/991471Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548094}

Bug: 564071
Change-Id: I77b644c49df34ed0beb95e94947fcc5a9e842fd0
Reviewed-on: https://chromium-review.googlesource.com/982539Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548093}

Bug: 819888
Change-Id: I648353f7f4fa6790f63d4d4eca711c1d48d2092e
Reviewed-on: https://chromium-review.googlesource.com/995585
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548092}

Change-Id: I393f7eab3058bec390ad1feff7ba147e60b42d18
Reviewed-on: https://chromium-review.googlesource.com/995580Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#548091}

This CL makes use of the new "immersive" media query to add styling for
the new media controls in VR mode. Due to a bug in how the "immersive"
media query works, the changes here are not visible yet.

Bug: 809021
Change-Id: I3737a3e1f6ca27d5111cf1d7e4b5b2ae221ee97f
Reviewed-on: https://chromium-review.googlesource.com/993396Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548090}

Enable the ExtendedMouseButtons feature. Approved Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MrKpBV26ik4/D_zmoAJrAQAJ

BUG=680741

Change-Id: I146a535b1eb8b502e43681bc1fbb83d595f29ed8
Reviewed-on: https://chromium-review.googlesource.com/994673Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548089}

In https://chromium-review.googlesource.com/c/chromium/src/+/974445 I
failed to notice that the content scheme was only on the intent filter
with mime types. Assuming this was intentionally only on the filter
with mime types, I've added it back to that filter.

Bug: 827796
Change-Id: I6b1f9dc1b01e6b87838215698290d7ac8d894022
Reviewed-on: https://chromium-review.googlesource.com/995957Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548088}

This compression overhead should be a padding-only symbol since it is
purely overhead that is inactionable.

Bug: 826008
Change-Id: I6d2b21676d3cd41efdb738d1c85b4f783dff9286
Reviewed-on: https://chromium-review.googlesource.com/995964Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548087}

WebView was calling WebContents::IsCrashed() to determine if the
crashed overlay view (sad tab) should be shown on top of the web
contents, but on Windows only, IsCrashed() was returning false for
a tab that was killed due to OOM.

It's not clear whether OOM should count as a crash or not or
whether there should be a platform difference. However, this bug
can be fixed safely either way. The real logic determining whether a
sad tab is shown or not happens in SadTabHelper. It's sufficient for
WebView to just check whether the WebContents has any abnormal
termination status, and show the crashed overlay view if so.

Bug: 817124
Change-Id: I7ba5f5f40e8d4499ec509b38471bbc1a1f8b6225
Reviewed-on: https://chromium-review.googlesource.com/993992
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548086}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8e870f6ea5bea91a48f09273d7a4d78e44d553b2
Reviewed-on: https://chromium-review.googlesource.com/992853Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548085}

Wait to create views for the suggested content until after the sheet is
opened. This will reduce memory cost if the sheet is never opened.

BUG=822955

Change-Id: I657f601cc1862227514eb599df205da2c5dee1ad
Reviewed-on: https://chromium-review.googlesource.com/990773
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548084}

https://chromium.googlesource.com/angle/angle.git/+log/6bc264aee686..59c5b897ec70

$ git log 6bc264aee..59c5b897e --date=short --no-merges --format='%ad %ae %s'
2018-04-03 oetuaho Validate gl_FragData and gl_FragColor access after parsing
2018-03-30 jmadill Vulkan: Make RenderTargetVk use ImageHelper.
2018-03-29 lucferron Vulkan: Support for bools and bvec* uniforms
2018-03-30 jmadill Vulkan: Add an Image helper class.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I4f17f987277a23d4c13bb56dbeccf3482839b176
Reviewed-on: https://chromium-review.googlesource.com/995954Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548083}

Disable this test as it's flaky on Linux.

Tbr: yiyix@chromium.org, fsamuel@chromium.org
Bug: 828061
Change-Id: Ia890fb9392d2784e4b2c835665cc7a6427b1c0e4
Reviewed-on: https://chromium-review.googlesource.com/995588Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548082}

Currently, _CheckUniquePtr PRESUBMIT check reports each failing line as
a separate error. This repeats the error explanation and thus clutters
the output necessarily.

This CL makes _CheckUniquePtr collect all occurences of the two issues
it checks for (direct use of unique_ptr constructor and replaceability
with nullptr) and group them under a separate single error, one for each
of the both types of check.

It also adds the failing line into the output, to make it easier to
understand the issue already from the presubmit logs.

This follows what is done for other checks, e.g., _CheckNoPragmaOnce).

Bug: 827961
Change-Id: Ic7d60a05b6f96da741f1401422f4a1690bb6e279
Reviewed-on: https://chromium-review.googlesource.com/990132
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548081}

Bug: 804570
Change-Id: If8461c73deb1938a643bf7a3a3e4d753fe4e7c00
Reviewed-on: https://chromium-review.googlesource.com/991060Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548080}

4 kB is a bit large. Microbenchmarks don't indicate a performance
hit when lowering this, and they may even improve on lower-end
devices.

This decreases the default size to 128 bytes. We can monitor perf
dashboards for the effect.

Also fixes a bug in test code which assumed an allocation wouldn't
resize a message, since that actually happens now.

Bug: None
Change-Id: Ibc7d17fe6f7cc98db7b290862cd4aea0f9be4fe0
Reviewed-on: https://chromium-review.googlesource.com/992553Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548079}

Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
https://github.com/w3c/pointerevents/pull/238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548078}

Bug: None
Change-Id: I964926f9177af1b227e381f59c5140e3389e3f07
Reviewed-on: https://chromium-review.googlesource.com/993774
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548077}

When we have an untrusted offline page, the popup should show the claimed
URL and creation date, and allow the user to copy the claimed URL.
* Trusted offline pages are unchanged
* Untrusted offline pages don't show the scheme.

Mocks at go/offline-pages-p2p-mocks#slide=id.g1d74dc3fd1_0_13

Bug: 826362
Change-Id: I4c33c6b151f1e6f82bccb44122081712648c39c7
Reviewed-on: https://chromium-review.googlesource.com/980925Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548076}