GitLab

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1082323004

Cr-Commit-Position: refs/heads/master@{#325377}

If one of the tools/mb files changes, mb analyze may not produce
correct results (since the configs might change), so we should
just build everything.

Also, fix a dangling target for the android_gn trybot.

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1092523002

Cr-Commit-Position: refs/heads/master@{#325376}

This flag causes unused argument errors when using LTO (or Clang's integrated
assembler), and is not needed to disable executable stacks, as we are already
passing -Wl,-z,noexecstack at link time, which is how executable stacks are
already getting disabled on other platforms.

BUG=407544
R=thakis@chromium.org
TEST=Built libchromeshell.so with default GYP_DEFINES with and without this change, verified that binaries are equivalent

Review URL: https://codereview.chromium.org/1091463002

Cr-Commit-Position: refs/heads/master@{#325375}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4127337..86a890b

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089323002

Cr-Commit-Position: refs/heads/master@{#325374}

This also includes several fixes for the plugin logic on Windows:
- The banned directory check normalizes path separators.
- The banned directory check now returns true for files that are
  considered system headers.
- Diagnostics from the plugin are always reported as warnings.

BUG=467287
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20

Committed: https://chromium.googlesource.com/chromium/src/+/5b5d1269ade9eeb50875b20570ef3e0d8c5d95fb

Review URL: https://codereview.chromium.org/1072203002

Cr-Commit-Position: refs/heads/master@{#325373}

This basically brings back the original implementation of InputMethodGtk long time ago, which covered most of cases that haven't been covered by the current implementation (e.g. generate keypress event for the accent/dead keys).

Due to limitations of Aura framework, it is hard to get the native window (e.g. XWindow). Therefore, gtk_im_context_set_cursor_position cannot be called at the appropriate time. The current InputMethodAuraLinux implementation workarounds it to leverage the key event, which carries the information about native window, and call set_client_window in DispatchKeyEvent(). The basic scenarios work but some special scenario cannot work. For example, iBus Pinyin IME tries to show the status-bar-UI at the cursor position without typing any keys.
This cl keep the current logics for that and won't fix the issue.

And this cl removes the keyup of 229 keycode, which is unnecessary. Therefore, for 229 keycode, the IMF will not try to pair the keydown and keyup.

This cl adds some tests to avoid future regressions on basic scenarios which consider sync/async modes, ibus hacky behaviors, dead keys, multi-commits, etc.
Note that the tests don't cover all possible scenarios as the worldwide IMEs with different IM modules (xim, ibus, etc.).

TBR=sky@chromium.org
BUG=463491,474828,125161,458179
TEST=Verified on local linux workstation.

Review URL: https://codereview.chromium.org/1068093002

Cr-Commit-Position: refs/heads/master@{#325372}

Revert of Build the Clang plugin on Windows. (patchset #7 id:120001 of https://codereview.chromium.org/1072203002/)

Reason for revert:
Rebase went horribly wrong...

Original issue's description:
> Build the Clang plugin on Windows.
>
> This also includes several fixes for the plugin logic on Windows:
> - The banned directory check normalizes path separators.
> - The banned directory check now returns true for files that are
>   considered system headers.
> - Diagnostics from the plugin are always reported as warnings.
>
> BUG=467287
> R=thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5b5d1269ade9eeb50875b20570ef3e0d8c5d95fb

TBR=hans@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467287

Review URL: https://codereview.chromium.org/1087423003

Cr-Commit-Position: refs/heads/master@{#325371}

These test aggregating 20 surfaces with 100 quads and resources each. Opacity < 1 in one test prevents the Surfaces from all being merged into 1 renderpass.

Review URL: https://codereview.chromium.org/1082103003

Cr-Commit-Position: refs/heads/master@{#325370}

This will allow the DisplayScheduler to differentiate between
a frame without any resources and one that should not be drawn.

Some tests use frames without any resources and the DisplayScheduler
was missinterpreting that as the Browser locking resources.

BUG=467750, 476544

Review URL: https://codereview.chromium.org/1084313002

Cr-Commit-Position: refs/heads/master@{#325369}

Convert downloads_page.css to downloads_page_style.html. See http://goo.gl/vIGSCO for more information.

BUG=477154

Review URL: https://codereview.chromium.org/1089703002

Cr-Commit-Position: refs/heads/master@{#325368}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1059753007

Cr-Commit-Position: refs/heads/master@{#325367}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/221360a..639a828

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1085393002

Cr-Commit-Position: refs/heads/master@{#325366}

This also includes several fixes for the plugin logic on Windows:
- The banned directory check normalizes path separators.
- The banned directory check now returns true for files that are
  considered system headers.
- Diagnostics from the plugin are always reported as warnings.

BUG=467287
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20

Review URL: https://codereview.chromium.org/1072203002

Cr-Commit-Position: refs/heads/master@{#325365}

BUG=

Review URL: https://codereview.chromium.org/1091683002

Cr-Commit-Position: refs/heads/master@{#325364}

BUG=468567

Review URL: https://codereview.chromium.org/1070253002

Cr-Commit-Position: refs/heads/master@{#325363}

TimeView should have enough space to show the time, but even if
it doesn't assign enough space, it shouldn't replace a part of
the text by elipsis (...).

BUG=471297
R=stevenjb@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/1088353002

Cr-Commit-Position: refs/heads/master@{#325362}

BUG=

Review URL: https://codereview.chromium.org/1073893005

Cr-Commit-Position: refs/heads/master@{#325361}

These should provide a basic smoke test for real-world regressions from
Slimming Paint phase 1.

BUG=471873

Review URL: https://codereview.chromium.org/1075523002

Cr-Commit-Position: refs/heads/master@{#325360}

This bug was preventing Chrome from registering for GCM invalidations on Android, meaning that sync was never told to download new data.

The bug was introduced by http://crrev.com/1048423005, where the ensureGcmIsInitialized line was removed from the SyncController constructor. The onFirstStart call was supposed to handle it, but from a clean start sync is disabled, so that case is not hit.

This patch moves the ensureGcmIsInitialized call back to the constructor, and the test ensures that the call is made at some point during browser initialization.

BUG=475299

Review URL: https://codereview.chromium.org/1081283003

Cr-Commit-Position: refs/heads/master@{#325359}

This replaces percent-encoding whitespace as a method to combat the use
of crafted URL fragments to inject messages into the page info popup. By
truncating the URL so that at most two lines of the fragment are shown,
we prevent lengthy messages from being injected while minimising the
effect on most URLs.

BUG=466351

Review URL: https://codereview.chromium.org/1077483002

Cr-Commit-Position: refs/heads/master@{#325358}

Remove most of the event specific rendering, and instead use key/value
iteration and output into a table. Special case specific cases to render
certain field types (net_error, bypass_type).

BUG=477188

Review URL: https://codereview.chromium.org/1071393004

Cr-Commit-Position: refs/heads/master@{#325357}

BUG=472269

Review URL: https://codereview.chromium.org/1055263005

Cr-Commit-Position: refs/heads/master@{#325356}

In order to move repaint to use the control code of TBM, we
first need to remove the code that automatically issuing
marker in smoothness_controller & make sure that all the pages that are paired with repaint must issue the markers
themselves in the page.

BUG=444703

Review URL: https://codereview.chromium.org/1083413002

Cr-Commit-Position: refs/heads/master@{#325355}

Convert network_summary.css to network_summary_style.html. See http://goo.gl/vIGSCO for more information.

BUG=477154

Review URL: https://codereview.chromium.org/1073903004

Cr-Commit-Position: refs/heads/master@{#325354}

Convert *.css files to *_style.html files for the following custom elements: date_time_page, settings_drawer, settings_main, settings_menu, settings_page_header, and settings_ui. See http://goo.gl/vIGSCO for more information.

BUG=477154

Review URL: https://codereview.chromium.org/1051763004

Cr-Commit-Position: refs/heads/master@{#325353}

Running modulefinder with just __init__ doesn't include everything, and having
the entry points is more likely to include everything.

BUG=None.
TEST=tools/telemetry/find_dependencies | wc -l  # == 3770, not 3719

Review URL: https://codereview.chromium.org/1089673002

Cr-Commit-Position: refs/heads/master@{#325352}

Recently we started pulling in the arm_trusted 'toolchain'
which is actually a small linux sysroot image so it contains
all kinds of licenses in header files.

This was the cause of a recent revert of NaCl DEPS roll:
https://codereview.chromium.org/1089163003

BUG=none

Review URL: https://codereview.chromium.org/1087283003

Cr-Commit-Position: refs/heads/master@{#325351}

This should not be used by anyone other that ExternalNavigationHandler.

Review URL: https://codereview.chromium.org/1091653002

Cr-Commit-Position: refs/heads/master@{#325350}

Huffington Post websites check that they have permission to pop up
notifications. If we don't have this mock version, we crash.

BUG=none

Review URL: https://codereview.chromium.org/1093433002

Cr-Commit-Position: refs/heads/master@{#325349}

This aligns with SSLClientSocketNSS's behavior (which never checks the ring
buffer) and with TCPClientSocket's behavior (which never checks writes at all).
Because SSLClientSocket::Write may complete before bytes are actually written
to the network, it's possible there is data in transport_bio_ still to be
written to the network.

Normally this wouldn't happen as the peer would read the request before sending
a response. But this breaks POSTing to a URL that requires HTTP Negotiate as
the server may return a response before draining the POST body. Due to the
delayed flush, transport_bio_ may not be clear by the time we check
IsConnectedAndIdle.

This is not the ideal fix to the auth issue, but it's a minimal one and aligns
our OpenSSL behavior with our old NSS one. IsConnectedAndIdle is somewhat
unavoidably weird and racy since the check it makes is inherently not very
sound.

BUG=466147

Review URL: https://codereview.chromium.org/1089123003

Cr-Commit-Position: refs/heads/master@{#325348}

Previously LibjingleTransport was waiting for channel to be become
writable before considering it to be connected. As result it was loosing
all data that's received before the channel is marked as writable.

BUG=477142

Review URL: https://codereview.chromium.org/1080633005

Cr-Commit-Position: refs/heads/master@{#325347}

When we skip shared tiles in raster iterators, we need to ensure
that we consider resolution as a factor, since the twin will not be
returning tiles if they are of non-ideal resolution (so we shouldn't
be skipping the tile if the twin has higher, but non ideal, priority).

BUG=477136
R=sunnyps, vmiura

Review URL: https://codereview.chromium.org/1064743003

Cr-Commit-Position: refs/heads/master@{#325346}

This bug is introduced in r324679. When Initialize/ReleaseHardware was
removed, the call to the factory the kept a count on the number of
compositors with hardware acceleration was dropped. This means the
factory refuses to create a context for video.

Add those callbacks, and emulate the original call by checking if the
memory policy is zero.

Review URL: https://codereview.chromium.org/1073893004

Cr-Commit-Position: refs/heads/master@{#325345}

BUG=434572

Review URL: https://codereview.chromium.org/1072403004

Cr-Commit-Position: refs/heads/master@{#325344}

"Merge apps and tabs" feature promotion is moving to the new tab page
so it is no longer needed in first run.

BUG=467437

Review URL: https://codereview.chromium.org/1071303003

Cr-Commit-Position: refs/heads/master@{#325343}

BUG=NONE
TEST=Building html_viewer from scratch also builds the network service.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1090753002

Cr-Commit-Position: refs/heads/master@{#325342}

The Chrome-Proxy integration tests should not be dependent on the Chrome
404 error page. Use the new chrome.googlezip.net/chrome-proxy-header/c_*
urls, which have their own resources.

BUG=472298

Review URL: https://codereview.chromium.org/1088833006

Cr-Commit-Position: refs/heads/master@{#325341}

Summary of changes available at:
https://chromium.googlesource.com/chromiumos/platform/system_api/+log/b5515b1..beb5547

BUG=345072
R=rkc@chromium.org

Review URL: https://codereview.chromium.org/1073983009

Cr-Commit-Position: refs/heads/master@{#325340}

CrxInstaller currently just guarantees that its ExtensionInstallPrompt
|client_| data member is destroyed on the UI Thread. But this is not
enough -- CrxInstaller is the InstallPrompt's delegate via a weak
reference, so it can't be destroyed first.

This changes CrxInstaller from a RefCountedThreadSafe to a
RefCountedDeleteOnMessageLoop to ensure the whole thing is destroyed on
the UI thread when all references are gone.

Note that CrxInstaller also owns a ChromeRequirementsChecker which is a
WeakReferenceOwner. WeakReferenceOwners must be destroyed on the thread
that created them, so CrxInstaller being destroyed on the FILE thread
also hits a DCHECK at weak_ptr.cc:20.

Since SandboxedUnpackerClient is the base class that "is" the
RefCountedThreadSafe other classes derived from SandboxedUnpackerClient
are affected. To keep things simple and consistent, they all become
RefCountedDeleteOnMessageLoop.

BUG=410415
TEST=At the webstore: {show an install dialog, then cancel it}. Repeat
many times. Chrome should not crash. Previously a race condition could
be triggered causing Chrome to crash (maybe a 1-in-20 chance).

Review URL: https://codereview.chromium.org/1080453002

Cr-Commit-Position: refs/heads/master@{#325339}

When the requester of a host resolution doesn't specify IPv4-only
(i.e. when it's safe to do so) HostResolverImpl should be
successfully resolving IPv6 literals.

BUG=428280

Review URL: https://codereview.chromium.org/1088513004

Cr-Commit-Position: refs/heads/master@{#325338}