GitLab

BUG=636289

Review-Url: https://codereview.chromium.org/2229333002
Cr-Commit-Position: refs/heads/master@{#412764}

1. Distinguish PaintInvalidationNone and PaintInvalidationProbablyNone,
   so that callers of ObjectPaintInvalidator::computePaintInvalidationReasion()
   can treat them differently to avoid unnecessary overriding
   cases that definitely no paint invalidation is needed.

2. Check emptiness of newBounds and oldBounds earlier. This avoids
   unnecessary object and layer paint invalidations when both oldBounds
   and newBounds are empty but we computed a non-none paint invalidation
   reason.

3. Renamed LayoutObject::paintedOutputOfObjectHasNoEffect to
   paintedOutputOfObjectHasNoEffectRegardlessOfSize because it doesn't check
   for empty size. The behavior is required to do correct paint invalidation
   when the size changes to empty. Now the name is better suited to the
   actual behavior.

These changes will help spv1 paint invalidation and GeometryMapper-based
spv2 paint invalidation to produce the same result.

BUG=510908
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2247543003
Cr-Commit-Position: refs/heads/master@{#412763}

Manually revert all of https://codereview.chromium.org/2251583002/. NeedsRebaseline tags were removed by
rebaseline-o-matic - adding them back to reset test expectations to former state.
Replaces
https://codereview.chromium.org/2251393002/ which could not
auto-merge
BUG=638822
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=ericrk@chromium.org,vmpstr@chromium.org

Review-Url: https://codereview.chromium.org/2251863005
Cr-Commit-Position: refs/heads/master@{#412762}

BUG=627697
TEST=opened a file and moved to the next with <Right> and checked chrome://histograms. Confirmed 1 FileBrowser.QuickView.FileTypeOnLaunch is exported and 2 FileBrowser.QuickView.FileType are exported.

Review-Url: https://codereview.chromium.org/2252723005
Cr-Commit-Position: refs/heads/master@{#412761}

Otherwise Chromium claims supporting video/mp4 and fails to play some
YouTube video without falling back to video/webm even if supported by
the server.

BUG=571417

R=jrummell@chromium.org

Review-Url: https://codereview.chromium.org/1569053002
Cr-Commit-Position: refs/heads/master@{#412760}

Mark inspector/editor/text-editor-search-switch-editor.html as skip on Win7, Mac10.11, and Linux debug.
Example failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6954
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8908
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3999

BUG=638618
TBR=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2251373002
Cr-Commit-Position: refs/heads/master@{#412759}

This CL fixes a violation for a DCHECK that states |m_workerLoader| should be
cleared before the MainThreadLoaderHolder's destruction.

BUG=635436

Review-Url: https://codereview.chromium.org/2256103002
Cr-Commit-Position: refs/heads/master@{#412758}

Removed Wrap-Flow and Wrap-Through from ComputedStyle's
StyleRareInheritedData, since they are no longer used. Also removed some
additional unused ComputedStyle initial value methods.

BUG=628043

Review-Url: https://codereview.chromium.org/2223133004
Cr-Commit-Position: refs/heads/master@{#412757}

Before this CL, file names to include were decided with
the path of original IDL files.
This behavior could mislead us as if we included generated
files for partial interface and non-partial interface
in one aggregation file, although we aggregate files for
all partial interfaces into one file.

This change make it obvious in .gn/.gyp files to aggregate
files for (non-)partial interfaces.

BUG=634231

Review-Url: https://codereview.chromium.org/2259463002
Cr-Commit-Position: refs/heads/master@{#412756}

The --csv argument makes find_unmapped_histograms.py report unmapped
histograms in CSV format instead of logging them.

This makes it easier to digest the output in other software.

R=isherman@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2245263004
Cr-Commit-Position: refs/heads/master@{#412755}

This CL:

 - Renames PermissionInfobarDelegate to PermissionInfoBarDelegate
   (this is the only delegate class which doesn't follow the InfoBar
   naming convention).
 - Removes redundant requesting_frame_/requesting_origin_ members
   in PermissionInfoBarDelegate subclasses
 - Moves ShouldShowPersistenceToggle's feature query into
   PermissionUtil in preparation for the desktop and grouped infobar
   implementation
 - Moves ignore count incrementing after ignore action UMA, to be
   consistent with dismiss count UMA in PermissionContextBase.

BUG=638076

Review-Url: https://codereview.chromium.org/2250053002
Cr-Commit-Position: refs/heads/master@{#412754}

Review-Url: https://codereview.chromium.org/2250953004
Cr-Commit-Position: refs/heads/master@{#412753}

Review-Url: https://codereview.chromium.org/2255013002
Cr-Commit-Position: refs/heads/master@{#412752}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8be763db2940..1383b507de4f

$ git log 8be763db2..1383b507d --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2257443003
Cr-Commit-Position: refs/heads/master@{#412751}

When a download is cancelled/failed/removed, it should be removed from
auto resume list.
Otherwise, resumption will be retried over and over as it is never
removed from auto resumption.

BUG=636724

Review-Url: https://codereview.chromium.org/2248963002
Cr-Commit-Position: refs/heads/master@{#412750}

This patch converts "editing/undo/4063751.html" to use w3c test harness
to simplify test script for improving readability.

This patch also renames it to "redo_rebalance_whitespace.html" to provide a
hint what this test script verifies.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2249833003
Cr-Commit-Position: refs/heads/master@{#412749}

This adds a check to make sure that the origin of the service worker is allowed
to run in the context of the "first party for cookies" (i.e. top-level document)
before starting it to handle a foreign fetch event. This makes sure service
workers with foreign fetch can't be used to bypass third-party cookie blocking.

BUG=540509

Review-Url: https://codereview.chromium.org/2255713003
Cr-Commit-Position: refs/heads/master@{#412748}

TBR=asanka@chromium.org
BUG=long OOOs ;)

Review URL: https://codereview.chromium.org/2251383002 .

Cr-Commit-Position: refs/heads/master@{#412747}

webapk_installer.cc sets the scope URL to a default if the Web Manifest scope
URL is empty. This CL sets the scope URL from the fetched Web Manifest to the
default if it is empty prior to comparing the scope URLs

BUG=624834
TEST=ManifestUpgradeDetectorTest.*

Review-Url: https://codereview.chromium.org/2205953006
Cr-Commit-Position: refs/heads/master@{#412746}

BUG=636558,637866

Review-Url: https://codereview.chromium.org/2241413003
Cr-Commit-Position: refs/heads/master@{#412745}

Follow the current Blink style.
This CL doesn't have any behavior changes.

BUG=583200

Review-Url: https://codereview.chromium.org/2257683002
Cr-Commit-Position: refs/heads/master@{#412744}

This patch converts "editing/deleting/delete-3857753-fix.html" to
use w3c test harness to simplify test script for improving readability., and
renames to "delete_keep_style.html" to provide hint about what this test script
verifies.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2255723002
Cr-Commit-Position: refs/heads/master@{#412743}

This patch converts "editing/deleting/delete-4083333-fix.html" to
use w3c test harness to simplify test script for improving readability., and
renames to "delete_link_at_end_of_sentence.html" to provide hint about what this
test script verifies.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2255733002
Cr-Commit-Position: refs/heads/master@{#412742}

Because the value of a certificate profile is sent straight to
cryptohomed, it needs to match what is in CertificateProfile
in the cryptohomed source code.

See CryptohomeClient::AsyncTpmAttestationCreateCertRequest.

BUG=624187
TEST=none

Review-Url: https://codereview.chromium.org/2256643003
Cr-Commit-Position: refs/heads/master@{#412741}

Avoid checkbox AutomationNode issue https://crbug.com/638498

BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2254673003
Cr-Commit-Position: refs/heads/master@{#412740}

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2254543004
Cr-Commit-Position: refs/heads/master@{#412739}

This CL introduces bottom controls to compositor. Once the height of the
bottom controls is specified, a resize signal will be sent to cc and
renderer with a shortened view port height. Upon user scrolling, the
height of the bottom bar is computed by applying the shown ratio of the
top controls to the bottom controls. Since bottom control is less
sensitive, it will react to scrolling even if top controls is
constrained. Also please note that the shrinking and expanding of the
bottom area do not need to be pixel perfect, as such perfection cannot
be observed by human vision.

TODOs:
1. Implement main thread scrolling, like what we did for top controls.
2. Investigate to conduct standalone scrolling animation if the top
controls is totally absent.

BUG=581227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2106753004
Cr-Commit-Position: refs/heads/master@{#412738}

Reason: I can't see any particular reason why the port needs
to be gotten in the wrapper script, and this change simplifies
the wrapper script.

Review-Url: https://codereview.chromium.org/2253163002
Cr-Commit-Position: refs/heads/master@{#412737}

Since r412195, Blink uses a different path to notify that the
initial document was accessed: it no longer relies on the fact
that WindowProxy forced v8 to fallback to canAccess().

BUG=none

Review-Url: https://codereview.chromium.org/2250433005
Cr-Commit-Position: refs/heads/master@{#412736}

This CL destructs base::Thread and its underlying system thread before
WorkerThread::terminateAndWait returns. This is important to make sure that
the main thread calls WTF::shutdown() after ThreadSpecifics of all threads
are destructed. See 345240 for more details.

BUG=345240

Review-Url: https://codereview.chromium.org/2251903002
Cr-Commit-Position: refs/heads/master@{#412735}

They are RefPtr/PassRefPtr versions of std::static_pointer_cast, and
not used any longer in Blink.

This CL also removes unused SVGListPropertyHelper::toDerived(), which used
WTF::static_pointer_cast in pre-Oilpan era.

This CL has no behavior changes.

BUG=583200

Review-Url: https://codereview.chromium.org/2254073002
Cr-Commit-Position: refs/heads/master@{#412734}

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Panel Layout Manager, Ash unit test
BUG=632755

Review-Url: https://codereview.chromium.org/2254603002
Cr-Commit-Position: refs/heads/master@{#412733}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8b2e42bcefdd..8be763db2940

$ git log 8b2e42bce..8be763db2 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2254903003
Cr-Commit-Position: refs/heads/master@{#412732}

When a drive is right-clicked, the focus of fileManager is not set to the drive unless it has been left-clicked once before that.

test=manual test on device using a write-protected SD card and USB drive
BUG=636373

Review-Url: https://codereview.chromium.org/2253873002
Cr-Commit-Position: refs/heads/master@{#412731}

Currently, the CreateNativeWebModalManager() method declared inside the
web_modal component is defined outside of web_modal, which means linking it as a
shared component will fail. This is a layering violation.

This is now fixed for builds using Views, with constrained_window depending on
web_modal and web_modal providing definitions of all the symbols it declares.
Most unused implementations of CreateNativeWebModalManager() have been deleted,
with two remaining: create_native_web_modal_manager_cocoa.mm for Cocoa, and
test_create_native_web_modal_manager_cocoa.cc to prevent errors compiling
components_unittests, which isn't allowed to depend on the former file's
dependencies.

BUG=522654,492442

Review-Url: https://codereview.chromium.org/2087643003
Cr-Commit-Position: refs/heads/master@{#412730}

BUG=635947

Review-Url: https://codereview.chromium.org/2249743006
Cr-Commit-Position: refs/heads/master@{#412729}

The Box Alignment specification defines a new value 'normal' to be
used as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in
the parsing logic and adapts the Self Alignment properties to the new
value.

The 'auto' value is no longer valid for the 'align-items' property and
the Computed Value will be always the specified value. However, it's
still valid for justify-items and both of Self Alignment
properties. We will use the StyleAdjuster to resolve these 'auto'
values.

In order to deal with repaint and relayout whenever some alignment
property changes and resolve again the 'auto' values, current
implementation relies on triggering a Reattach whenever any of these
properties changes. This is a source of many problems for animations,
plugins, ... (See bug 580070 for details). The correct way of
implementing this is using "Inherit" instead so we can run the
StyleAdjuster again only for the nodes affected by the change.

This approach reduces considerably the number of style invalidations
and let us unskip the align-items repaint and relayout related
tests. These, as well as the justify-items related ones, had to be
rebaselined due the different invalidation areas generated.

Because of resolving everything in the StyleAdjuster, we don't need to
duplicate the resolution logic for generating the computed style. We
only have to deal with the 'auto' flag duality, which is not both
'auto' and 'normal' in any post-adjustement logic. This also gives us
the opportunity to get rid of the ShadowDOM and slotted elements
issues, since we don't have to deal with parent's style.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883, 474798,  448371, 582230

Review-Url: https://codereview.chromium.org/1709963002
Cr-Commit-Position: refs/heads/master@{#412728}

This is another CL for refactoring part of LayerTreeHost to LayerTree.

Refactored MutatorHostClient, and also follow Khushal's other CL, to
cache raw pointer of LayerTreeHost in LayerTree, and use unique_ptr to
wrap LayerTree in LayerTreeHost.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2216203002
Cr-Commit-Position: refs/heads/master@{#412727}

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2252963005
Cr-Commit-Position: refs/heads/master@{#412726}

https://chromium.googlesource.com/skia.git/+log/70f5251cc591..36e5adbaaac9

$ git log 70f5251cc..36e5adbaa --date=short --no-merges --format='%ad %ae %s'
2016-08-17 robertphillips Revert of Reduce window rectangles cap to 8 (patchset #1 id:1 of https://codereview.chromium.org/2254013002/ )
2016-08-17 robertphillips Revert of SkPDF:  cache metrics once. (patchset #4 id:60001 of https://codereview.chromium.org/2253993002/ )
2016-08-17 fmalita [SVGDom] Fix <ellipse> positioning

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2250283005
Cr-Commit-Position: refs/heads/master@{#412725}