GitLab

This reverts commit 7c9e1f12.

Reason for revert: Test failures were due to untriaged images, fixed now.

No change from original CL.

Original change's description:
> Revert "Switch RenderTests to use SkiaGold"
> 
> This reverts commit 3ed31ecf.
> 
> Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32796
> 
> Bug:1098417
> Original change's description:
> > Switch RenderTests to use SkiaGold
> > 
> > Switches all uses of RenderTestRule to use the SkiaGoldBuilder method
> > of constructing it, which results in all Android RenderTests being
> > backed by Skia Gold.
> > 
> > Bug: 1057851
> > Change-Id: I63d40faef7863dddb5edaa93aef8559eb4d3696d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248742
> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Reviewed-by: Peter Conn <peconn@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#780931}
> 
> TBR=boliu@chromium.org,twellington@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org
> 
> Change-Id: I58bd6a0289cb496c62ae4b5556374ffcbfa333ce
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1057851
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261178
> Reviewed-by: Gang Wu <gangwu@chromium.org>
> Commit-Queue: Gang Wu <gangwu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781429}

TBR=boliu@chromium.org,twellington@chromium.org,gangwu@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1098417, 1057851
Change-Id: I4762d97220b6b0745c462d220e90ffd8ed1043ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261257Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781515}

Part I to setup logger for TileService.

Logger: The public interface to the log code.  Can be queried for state
and returns base::Value objects.
Logger::Observer: Used to notify external components (e.g. WebUI) about
internal state changes.
LogSink: The internal interface that should be notified by internal
components about potential log-worthy changes.
LogSource: The internal interface that Logger will request state from.

Also Add BlackHoleLogSink and EmptyLogger for test purpose.


Bug: 1066556
Change-Id: Ib8ee202c650cf72de20ab5cb6b9038ea51d5f651
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250891Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781514}

Adding template specialized class VariantUtil which adds Get and Set
methods for the underlying data in a VARIANT specific to a VARTYPE.
This is useful for template methods, since it makes it easier to
templatize VARIANT logic, avoiding macros like V_BOOL, V_UNKNOWN, etc.

The VariantUtil class also has a typedef |type| for the underlying type
associated with a specific VARTYPE.
e.g. VT_BOOL => VARIANT_BOOL, VT_UNKNOWN => IUnknown*.

Moving IsLeakableVarType out of ScopedVariant and into variant_util.h.

Split out from :
https://chromium-review.googlesource.com/c/chromium/src/+/2188057

Bug: 928948
Change-Id: I8f8e4bcbf7620122ec361c4947175271ee5e6be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244454
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781513}

Before this CL, the code was mistakenly adding internal padding to
the menu position. But both the EditableCombobox and the dropdown
draw their borders similarly and hence they should use the same bounds.

Screenshots:
Before: https://screenshot.googleplex.com/RBcFKJ0WqBC.png
After: https://screenshot.googleplex.com/HfCZTOgE8dv.png

Bug: 1044038
Change-Id: Ib6595b9165518886a88e5513653d22f197534545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260879
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781512}

Let's keep monitoring it for health check.

Bug: 1089488
Change-Id: Ieacbd68692b0176bf5500f11b3b76984f24325c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259754
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781511}

Some cases in the KioskAppManagerBrowsertest are flaky because
SimpleURLLoaderImpl::OnReceiveResponse may get non-500 failure response
code. I suspect they are actually 400 error, but don't have enough
evidence.

Add some additional logic to log this information to figure out the root
cause.

Bug: 1090937
Change-Id: Ia343519dbd06311dfde2bccd25d9ebf86bb72566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257857Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781510}

If |chromeos::AccountManager::Initialize| is called twice, it may happen
that the second call may complete before |AccountManager|'s
initialization is actually complete.

Fix this by keeping duplicate initialization callbacks in a queue until
initialization is complete.

Change-Id: Ib44ffaed733fd3a567bdd8d256d04b182b1dbff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255458
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781509}

https://webrtc.googlesource.com/src.git/+log/30a3e787948d..24762f207fa1

2020-06-23 mbonadei@webrtc.org Fix missing dependencies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: If9c3e551678e369a14fa57aadc4b92ea32579a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261055Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781508}

This one case didn't use |InvokeCallbackAndCleanup| and thus didn't call
|Cleanup|.

Change-Id: I6a0dcdb237efe4c1e9be5782151e1295977c1fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255212
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781507}

This change also removes some now-unneeded instance vars.

Bug: 1075649
Change-Id: Ibac05c4b28f6f89f40bb153ba63bd3f46d075b00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252920
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781506}

This also emits a tracing event before calling each listener.

TBRing per https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes

TBR: fdoray@chromium.org
Change-Id: I6d73a0f1796dcb06a01cbf9201116639eab37bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244692
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781505}

Patchset 1 contains the reland without any changes.

This CL adds a callback to the speech recognition client that is called
when all of the mojo pipes are bound, indicating that the speech
recognition service is available.

Bug: 1096632
Change-Id: I0006298c3d3191c84c80d920031abfcbf10e5cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260935Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#781504}

Route feedback from the interest feed to the discover team instead
of the Chrome mobile team for processing.

Bug: 1091058
Change-Id: I186ff9e2078f5f0dea71e3417c5b8186530f7368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261253Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781503}

This bug fixes a problem that may arise when the largest image is
loading and then removed. Before, we'd continue to wait for the paint
time of such image, and hence would only correctly update the
experimental LCP value if we ever painted something at least as large as
that removed image.

Bug: 1045640
Change-Id: I356a58215003871cc15e3bee3ed86423ac612934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255498
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781502}

Also found a bug while writing tests... The shift tab code doesn't take
into account collapsed groups :X

Bug: 1018230
Change-Id: I04fd40de6b24ec892170a9a92a1d4cae51bc444e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261215Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781501}

This change is required for persistent breadcrumbs to identify sessions
boundaries. It would be better to log different events based on launch
type, but this CL is a good tradeoff between complexity and
usefulness.

Implementation fully mirrors how "Shutdown" event is logged.

Bug: 1082892
Change-Id: I28e92353567be0079ab16c6eb73f39230f117e51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253219
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781500}

Sampling out YUV 420 (biplanar) textures will give RGB pixel values.
This is present (e.g, in ResourceFormatToClosestSkColorType). This case
is needed to not crash SkiaRenderer when drawing video on macOS.

Bug: 894929
Change-Id: I8d83b90c0efa8b6400f119492caaa5fe7d136d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261393Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781499}

::PeekMessage can process sent-messages and internal events. It seems
the kernel also uses it as a heuristic to deschedule the main thread when
it thinks it's out of messages. In MessagePumpForUI's design, it's
possible to have application tasks without pending native tasks
(kMsgHaveWork is dropped when running out of native tasks).

This CL uses ::GetQueueStatus() to probe the presence of messages before
invoking ::PeekMessage().

Bug: 1075960
Change-Id: I4a93b22adf225ae2d62aabeb1a7a734232cf7fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258456
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781498}

Remove some code (that had no test coverage), that I initially thought
we'd need, but it's actually incompatible with how an upcoming CL will
deal with float fragmentation.

Bug: 1043787
Change-Id: I9a5cb7c2334c8c17360b6c20e2fb4de078072b79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260612Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781497}

(Test-only change.)

There are a few cases where a test wants to parse the response to an
assertion, and I'll shortly be adding some more. Pull out some common
code for this into a function.

Change-Id: I9a2b53c58d5fe58565e3bc111b67ece28994c3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255211
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781496}

Bug: 1076543
Change-Id: I1286243c1e85a9c7409c5f1f9e326e9ecc337422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250161
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781495}

Used to be a single zip file of all languages which is more inconvenient
format for the further steps of the pipeline that copy this files over
to the public documentation page.

BUG=1082694

Change-Id: I89faec3b5262e443cf768341172b1091bc15596f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256206
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781494}

Roll Chrome Win32 PGO profile from chrome-win32-master-1592917001-0fc7f1d9ca8aa2b3be882f696f21c14836e980c4.profdata to chrome-win32-master-1592920709-d1856a35d8275495ca631105d3b73ea9c8fbb208.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I1c0c0e2e81a8b4d7b93c9cb6b9b8b086ef65ce56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260921Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781493}

Add guidance and documentation regarding upcoming certificate lifetime
changes.

Bug: 1097982
Change-Id: If6073b63774b80e8a01a6940d7c262b603c1ff70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258690Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781492}

It was determined that https://crbug.com/1091423 is caused by multiple
getAuthToken() calls running simultaneously. All getAuthToken() requests
go through IdentityMintRequestQueue that actually manages multiple
queues, one per (ExtensionTokenKey, IdentityMintRequestQueue::MintType)
tuple.

When the remote consent is approved, the request needs to go through
a queue one more time because its ExtensionTokenKey might have changed.
The request, however, needs to update the global cache before any
other request might be run to avoid showing the consent UI again.

There is also the case when a request will be canceled after the
remote consent is approved if the queue already has a
MINT_TYPE_INTERACTIVE request scheduled. This CL makes sure that this
condition is no longer triggered.

Bug: 1091423
Change-Id: I639b7a0bc8274179163c4d19ffc234fafbece791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260658
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781491}

Previously DisableCompositingQueryAsserts triggered DCHECK failure in
CompositeAfterPaint.

Change-Id: I9f341a7fb176d357aa325f2cde9c497cf4536fbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261176
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781490}

Flaky test (conformance/glsl/misc/shader-with-non-reserved-words.html)
is set to RetryOnFailure on Nexus 5.

TBR=kbr@chromium.org

Bug: chromium:1098311
Change-Id: I81ea05c38836d7a248fc36615acdac9a2f40f590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261355Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781489}

1. a fieldtrial param for controlling the time day of the second promo
2. update fieldtrial_testing_config.json

Bug: 1090103
Change-Id: Id9eab63dea1f7534f1078d0ca7c573acbb1b280b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258893Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#781488}

This will let us evaluate the frequency of an issue that leads to the
Trust Tokens database failing to open in an indeterminate number of
cases.

R=csharrison

Bug: 1098019
Change-Id: I7fa18bf3a4477ed02699a9872c13aafb6dce1ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261155
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781487}

This also removes the Connector implementation's dependency on the
legacy features.

Bug: 1069069
Change-Id: Ie6c9365789a0a593f0ff51c6fb8b5edfb52d121b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254448
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781486}

Roll Chrome Mac PGO profile from chrome-mac-master-1592913526-8a6b109b6b3679eaf9b2e9a04d6e6b258b48adc2.profdata to chrome-mac-master-1592935173-d1033b26c7b78c08aca84bf70b5b5eb9d34e3499.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I4a585498ff59d807f2ac9e0d4563337c5a46c386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260928Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781485}

TBR=ryansturm@chromium.org

Bug: 1087736, 1087876
Change-Id: I42837be8d16e6534b97bb3e8fd6154d39411ab26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260397Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781484}

Shelf may have delayed bounds setting via animation using BoundsAnimator.
An ink drop created during this animation can be shifted. This patch
adds an layer transform observer for shelf buttons which uses a new
API in ink drop to set the ink drop root layer transform.

This sounds like ink drop should handle transforming hosts or maybe
views code itself. But this is intended to merge, so this solution is
ideal for now.

Test: added test, manual
Bug: 1097044
Change-Id: I783d86161c8415e5fe419c6e9505bc7b9be77f93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258687
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781483}

Currently, MediaRemotingIntegrationTest.SeekWhilePlaying is flaky, and
has been disabled. After looking at the logs, the primary reason is that
media::PipelineIntegrationTestBase::OnEnded is called multiple times,
resulting in a DCHECK and test failure. The stack for the second
OnEnded call is:

media::PipelineImpl::RendererWrapper::CheckPlaybackEnded
media::AudioRendererImpl::Render

Logs:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890990219267312400/+/steps/media_unittests__with_patch_/0/logs/Flaky_failure:_MediaRemotingIntegrationTest.SeekWhilePlaying__status_CRASH_SUCCESS_/0

Turns out, this is actually a bug in the AudioRendererImpl, where the
old method for determining if the content is ended is flaky, resulting
in multiple calls to OnEnded. This bug has been resolved by a change made on the
AudioRendererImpl, moving to an explicit EndedPlayback signal:

https://chromium-review.googlesource.com/c/chromium/src/+/2021292

Bug: 1043812
Change-Id: I8ca939e5166c3fa3c40f33c7a4e34f3a29d0e06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258342
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781482}

Thread priority should not be modified after a test.
If that is happening, it needs to be fixed in the code.

This CL remove the code that disable the priority checks.

NOTE TO SHERIFF:
 * please paste failure logs when reverting, the goal is
   to remove flaky tests related to thread priority.
 * assigned flaky test to etienneb@

Bug: 1097092
Change-Id: I557727e9ab91ff5bdb4e87e54ba8f56b9313a1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254442Reviewed-by: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781481}

This feature has two problems:

- its name is bad and non-inclusive
- it's no longer needed with inlined typemap definitions

This converts the one remaining dependent typemap to an inlined
typemap configuration in GN.

Fixed: 1097211
Change-Id: I9515ada1bc833f1306f12b2bcae14a59f1257645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255123
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#781480}

Previously we would send the hmac-secret extension to authenticators
that didn't advertise support for it. That's fine because it'll be
ignored but, in the future when we have more support for hmac-secret, it
gets expensive.

This change adds the basic infrastructure for that and stops sending the
extension unless the authenticator advertises support.

Change-Id: I0dc2806c91ab0e032598c1f9ce54899c0b47d269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255210
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781479}

Remove myself from OWNERS in //weblayer

Change-Id: I978fd3c19a58c29542bc37199dd5ed03b2ed6471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261221
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781478}

- Guard the PersistentHistogram init code in WebView.
- The feature is still disabled by default.
- Will use the finch to rollout LocalMemory backed PersistentHistogram.
- The Renderer process metrics will work, but the unsent metrics will
  lost on crash or app being killed.

Tested manually

Bug: 1090682
Change-Id: I3033c853bf2738a2f2dd24efeac6b3913dd79890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259377Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781477}

Adds support for Fast Initiation advertising to NearbySharingService.
When StartAdvertising() is called, the service will acquire a
BluetoothAdapter and use it to create a FastInitiationManager, which
will handle broadcasting the advertisement.

Bug: b:154846208
Change-Id: I5ea0de14901bf14d7f20dd80ef21582c21b10665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211132Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#781476}